From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F9CC4332F for ; Mon, 17 Oct 2022 22:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E4D96B0072; Mon, 17 Oct 2022 18:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 894096B0075; Mon, 17 Oct 2022 18:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75B986B0078; Mon, 17 Oct 2022 18:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 63F416B0072 for ; Mon, 17 Oct 2022 18:46:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3DF02C041B for ; Mon, 17 Oct 2022 22:46:29 +0000 (UTC) X-FDA: 80031926898.11.B2F2C74 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf22.hostedemail.com (Postfix) with ESMTP id AB684C0028 for ; Mon, 17 Oct 2022 22:46:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 231D71F8D1; Mon, 17 Oct 2022 22:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1666046786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KPXn8oCISsFaCnRNyRjpdaEv1QQo5ZLAKB/NsLXVGBs=; b=NfKOqe4gHCl9/Htq5BcTbwrgFymKb4wGV1EoSbTVL1zMWiFBS0wESzuZBCcXi55G/gR0tQ dqkWXoDM2yaNsea3ydA79oc54ZMQO9pSGOy34tkFfc3j8hI+NmtNtlNXbV82hU2h+0y5E3 y7ohEeM0pH8mJna2Hkfzj+XLk/7aVQo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D387413ABE; Mon, 17 Oct 2022 22:46:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7rDvMUHbTWN0YwAAMHmgww (envelope-from ); Mon, 17 Oct 2022 22:46:25 +0000 Date: Tue, 18 Oct 2022 00:46:24 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Tejun Heo Cc: Waiman Long , Michal Hocko , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Chris Down Subject: Re: [PATCH] mm/memcontrol: Don't increase effective low/min if no protection needed Message-ID: References: <20221011143015.1152968-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=NfKOqe4g; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666046787; a=rsa-sha256; cv=none; b=v88NmZyGsytn3NYLtXFUzBJrI/WHaOY9NJSmNrjle+n5KrpmF0V9nvzOJj5PfO3s5YOg4f /CcPRQsfNE02F5Y31KKE3nj96LmuEvxczyCTdALjOUfzkycSkfy71DQlso+MN9dYPqDUoy qePW+7iXBkWwIbcK1D0a030UoFFdDXY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666046787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPXn8oCISsFaCnRNyRjpdaEv1QQo5ZLAKB/NsLXVGBs=; b=MI9lLcsR23/K0kHnPzE/KmkLOuVx7uzUt7jH/Os/Oz6XbjpfnHuRciprSx3ybT0jp2UdqR m4jQgGXG3PEobxC2+MvQmvOwnwz5k54bx1N0UOQExUsJPcSWcqVVs9v0bMdP5aGsqx5hie tvsrN2gwdZzIesJyxq9FtFh45i54PVo= Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=NfKOqe4g; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: a6jsxyit4sajupbom9mfakz3iaorydq9 X-Rspamd-Queue-Id: AB684C0028 X-HE-Tag: 1666046787-550669 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 11, 2022 at 07:04:32AM -1000, Tejun Heo wrote: > Wouldn't it make sense to fix the test? With recursive_prot on, the cgroup > actually is under low protection and it seems like the correct behavior is > to report the low events accordingly. It depends whether the there is a residual protection that the memory.low=0 sibling can use (with memory_recursiveprot). In the discussed LTP test, there should be no residual protection that would justify the apparently misreported memory.low events. I.e. the test is correct, the failure points to a subtle issue with distributing residual protection among siblings. Been there, (haven't) done that: 1) https://bugzilla.suse.com/show_bug.cgi?id=1196298 2) https://lore.kernel.org/r/20220325103118.GC2828@blackbody.suse.cz/ HTH, Michal