From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D718FC636D7 for ; Wed, 15 Feb 2023 15:42:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 383096B0083; Wed, 15 Feb 2023 10:42:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3339E6B0085; Wed, 15 Feb 2023 10:42:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 222176B0087; Wed, 15 Feb 2023 10:42:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 12FA36B0083 for ; Wed, 15 Feb 2023 10:42:12 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BBAB9C0FFB for ; Wed, 15 Feb 2023 15:42:11 +0000 (UTC) X-FDA: 80469942462.24.62668C5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id F0BF8100003 for ; Wed, 15 Feb 2023 15:42:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Tn7w5yBg; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676475730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rDZl/5EEHbOPpxdRh+6glISWcS2OPg5HePgxkDGiegQ=; b=afXUVr8fm0dP4yFk/+f0AGycHT5GS/xTF4Y3AVJd5N1uR21GdGtC5yZZOZWGUU28MfnoJV ZvYDqi8+joS9Zm2SKRE4HLQeUNJTC/5VuOe4gIcvHGHMmXy0LJLpG8OGthtVOH/AcumxDf NMz7q0NdNocJY73j8/6ntBcDwZAOcEQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Tn7w5yBg; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676475730; a=rsa-sha256; cv=none; b=Mm4wF0mgiG3Vsa5rTtEOlxYtz+vnm226O46xas/727T7xQEUMXagQaQqCdif8lPse8OIU5 D3mNSsZv8gvZxbfPl8Z03Y4NGMaBiZbfTflXAoAuYtpiJ7JfDfb2XoZyiZsmvbCZi5g2ah K2t/3VznsmBjECAcjIY/Z1Fq79tfK0I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rDZl/5EEHbOPpxdRh+6glISWcS2OPg5HePgxkDGiegQ=; b=Tn7w5yBgAzqBzJkXZoFI1LG/rg yhJaeStJwyI5ZMuALThvIPfaeRFlm9/DzsDFX5jNKaGaUw3/3nhuDwj0Jv8nIwcdtKvkYU1FO39E1 /u8L/iKTU+OtZncNwkUahyDKyTaYB3+Sd4h9AKw/xwKJjB1M/RIYi7Kps3Teqky7NWc+1pJ6nRdHQ NjiIT0soE9Ek/jdpFhzNrDJYJyEL3OYeMAtB5og4LtYkiCYHPZ3hvaVLtxx7vliCGTEsHhvDRQD0R TXljirgf5gUdnTogAeb9x3WxJ0/yCUuapR3MBByX9SGu398gW0Nbo+hVhNuxkvrUxA9pzbU9XHBtC briV317g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSJub-007aG4-Cf; Wed, 15 Feb 2023 15:41:37 +0000 Date: Wed, 15 Feb 2023 15:41:37 +0000 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] mm: hugetlb: change to return bool for isolate_hugetlb() Message-ID: References: <12a287c5bebc13df304387087bbecc6421510849.1676424378.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12a287c5bebc13df304387087bbecc6421510849.1676424378.git.baolin.wang@linux.alibaba.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F0BF8100003 X-Rspam-User: X-Stat-Signature: irzhdjbo4w4y4uj5cp4degtu1djxctjy X-HE-Tag: 1676475729-796307 X-HE-Meta: U2FsdGVkX1/uSFWCZeSxqOyFOsFGvv1I/9yh8wZgKUjvfqurGPohrJb/J9nDyXTU6j+AdJ/j/iQF+Scoy1BhCoR+iGSEnUHksFYRyocphc4eApyYdK4s7Wy7xnE5pUiZifxGrB5OmhHpfyOQ0GIW1MEBoy/N+5lIf2zWh9fFPhoi6GrQCfwA5iaU7KqaEIf8Vez859z/qUK5Ui0aNy6umK1Wqqu/+SyKBZgs1tLxLWe66swJNhZBXK9Gw3L9+BjWvRieaIRrMxdqrKKnws+x+q9/R+3kuaQWVlb0nOOkIKZNg8GnwCk1b2uYE06u6tjT98yHcLA1I1R7w738ThFJrpFRGbcQA48EKENOY8zpZVJWszdwIW0wVZ4zH7WOgTIbcuynh63v7hvRKyDOHNHJ1xIsnUcldu+R9iTmhwuMSpZvV3A+XLDhB8XJSDyzxqO73s1Buo4XFQEyopRr7bje4sgy5k5SgTMqf6sJ+hDiJONvAzPtZv88gJz6Gjo5YvJK4aGYLPQC5HoBEvLy9dC+FVsLD15uCVLOnL2RLJx3c3dw0BYpRBOn7Ht3+Up/RRu6NF0USFMkQWgDauOS0E7OnvzljtSNDxcnDFzML2HKHpItkYy52E9rZLm7nD5V+CyDAdgyYx97RNpgNs+FEap1GrkQtU0qj+6/2UiyCYhpmL2943pZYsC1LWivrea1ESfY4l38PMojh6GAu4WC3TFfO6IUG5seDFKTRB363uxu+3R9ME7Ym/mmMnf7gO+RiJT9lmiWYaTLJpZFwBkRvbkrQWGSJ2uBu4QJc9rSZEswSw/pK6QX/9MvqsaZjHyiX7xIAuW+aJifqSbn8ENxjaV+XLfsu2PM8xvvziwZ0lcaO4xUhPNhLMAhuYn+MYCLX6hXh8Qd9/VmGECsgxLtDgJkLNsw0bV9qixVER8LjMjGiYW/elscsdfe0b57c3kEaLSzNYjBFhqIzMyk0N8/21g D0VhwBy7 Cg/pyvI0aXf8spvs0LzWsmiwqwtpVUeUyezfPy4d1aEcihuhY7YX9Vo21V96tYdniubChwjISeqy7tNVtcRIBkqMyNQo/S3FNIbSCfO1mH6UsShXB4LOGOOqruh97yO80ZJV7NqAiv2PqXFrNJzIL8N6fbM/wEsFrAR/zoIaDSunquUR9zzRPZwZo7ERgrvlg1SJD8UOIJDwmaXDjKNltFs+vc2xdRsAXuFHY533gZFxomc8eVEvl8SF3TrjXeKSFOl6Qq6KL04CY7CF3BUW8XWYimlNfb7pC7EmisQr8YHn8SneTUwhGtnCUAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 06:39:36PM +0800, Baolin Wang wrote: > Now the isolate_hugetlb() only returns 0 or -EBUSY, and most users did not > care about the negative value, thus we can convert the isolate_hugetlb() > to return a boolean value to make code more clear when checking the > hugetlb isolation state. Moreover converts 2 users which will consider > the negative value returned by isolate_hugetlb(). > > No functional changes intended. > > Signed-off-by: Baolin Wang > Acked-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle)