From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46432C636D4 for ; Wed, 15 Feb 2023 15:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDEE26B0072; Wed, 15 Feb 2023 10:53:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F396B0073; Wed, 15 Feb 2023 10:53:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7DBB6B0074; Wed, 15 Feb 2023 10:53:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 980B86B0072 for ; Wed, 15 Feb 2023 10:53:58 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6BFC7C015E for ; Wed, 15 Feb 2023 15:53:58 +0000 (UTC) X-FDA: 80469972156.15.5B98DC4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id B31A640014 for ; Wed, 15 Feb 2023 15:53:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HNO8pH29; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676476436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rTc8CXcuV5cpdjC3iO0SGA6L8ZyQnZe5ss7R/+Fqmh8=; b=EFlSWy8DPMzyuyVgmXWDXpX/qNTjPE/Hz0bUbx9xRx7sMHjuJIA74hMIfuezE3FjMd4vBV D49tGRQW35aOxrSe1Vt8k/GD33vy4p5x6hOsrSBI7fz9LZpzxwYbUHrA9E9hDyI9zKksRi 0gu4522hPMQYJ0A8WP+RXzGlfCXbLDg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HNO8pH29; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676476436; a=rsa-sha256; cv=none; b=P+b12U+acF2V/WouWI7mLc57em/8TWBPGIccsFwkpUW+FYO4K3uiCuyl8t2CGvhvgLd/qe 7xQpHBUQ6QtJ+3r6XBJKReRsjpmolC53i6pJ/VY1Zew+vdtHDkmE5muqolpZcy94DYMkaO /UwMQNnoAfVFuvs1kWl5HtRBbNebt+A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rTc8CXcuV5cpdjC3iO0SGA6L8ZyQnZe5ss7R/+Fqmh8=; b=HNO8pH29scO5qLGRTFQ9MUd+oG Kwk1WNceb6YmZTaNOYA1oUb2COUwj52M3DhHT6dWzY+nC5Ozl4dhh8M8HYePc/s7CGdvwwwqAIMn/ 2dderB0nxXLQLMxSN2dokF0XHDGStNJ44fotckJ4s3c2hsQvWF2Buf2glU+v/TvHxEM1/jMclEx/k /sicLzkEGmgg9hJ6KzP8agem448nMFXJLleiiauXmTk82LnFnw0ea5/sQkaF1uLadnB4vGgPgkPyK nYU8Fmgei/Ei89UkQrKY0y7TYwfTyuWkObuxhUx+1PBSSl4w+ReAjduCB46UfFr8OqviYT7GcbpGI E0X8rqbg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSK5z-007al5-U4; Wed, 15 Feb 2023 15:53:24 +0000 Date: Wed, 15 Feb 2023 15:53:23 +0000 From: Matthew Wilcox To: Miklos Szeredi Cc: David Howells , Jens Axboe , Al Viro , Christoph Hellwig , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v15 05/17] overlayfs: Implement splice-read Message-ID: References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> <3370085.1676475658@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B31A640014 X-Stat-Signature: j8zezzim76mazj6w1qzqokaasykoke3x X-Rspam-User: X-HE-Tag: 1676476435-222540 X-HE-Meta: U2FsdGVkX1+55uwzyEvZEqz27rbEsW5oJH2h4gGTYWVzVOrARymJQOoW89eCaKwyNY3LCWrkwWymmDPewca4t6bXJ5W39t0/Bd3sx3PCpRcPpEQB8NRvhBH7dEKngfhx5kb2AF/N7jFN/mfCbmI1CvfzXEjNDl1sRRvauozfs4udvnv7m2SCY/00AudHffEieTY8GkqeERhJAyFWD5rBZX230T03Qrdbh17ALjNYS3FmVcJZAvpgF4SCJLS14yfS1AH76Y7Tw+OV6KozO7VOa5GmdNQI4hUZUpcrt9c1mwY1mLeXcEAfxY0MwDaAdGCu9LLnBYXmJtdP8v6A7c6yCL2XtAe7xtbwMwDv4en+zwLH99Nv0kcJjWaPYd16mpUY/FdiX42Yf0AHtLdb4Eml7i/KJVNt4g3AKXhXQdwomxuWLWKATnoFCem/oIMGNtb9kiYARmoN+QFIMje631Poh4BY7wf1XiEk9y3Tp/8HdNdIEXYMCYGuuxSkDyB+5ThGCXj4cM8PyeOpf1KQSibWmvHo1FZ6cpPGkADoCWq/OC4X+487qtCTGkA+YuTtrjKW8rMlCJwCas/L8Ap8vWJxUKt+5Crym2fvs4390Xt6CDGUcoafHXoy+l6iCjJbqqhKhmwH3HGVT7ABx1xaV6Dt2VltdrSohyz6/M5zg4C+tqMLbLX+ya6iKsMd9p+u0sQ6IHgtCKxY7RxUaoS7pOzZbYY6N8nrbL2R5OqfRXVJiULWllYZkvcQttFbXP7wez+8i0gXNmnX7q/ut7ua2TEWTITzt8lDa5zxMo2/Wt/3/Lk2wQoggyRHEnVUuKbuJAIfCG7CPN16D1FRu9MqDsr407r3CTZFFeG3rB+71mLGDoGU2cwTAOrsWpzbtxzOerr2VYfSKfKdZ1pTrwaH5ANWlfFNDJsZiIZ9x6vJzpjv02FPHX+HcIzvb+ZJFy6QdjVpKSbtm791JCnOx7JY0aV GJWKhnOM hfVprlpDaxH+5tVohvY3Sd9i5cENJdPFUaq/o6p4t5lILvQ005NtI7026de2RpI6k4T+ZYVtEBWbJvlMMNaaHFwAw5pUJBfYbP4s4JoWL57HVb6ULNFdWPc4siNQwkXoT+xMP/ELHlzsRo81W94/V76hJ/bsBG8Fvpaff X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 04:50:04PM +0100, Miklos Szeredi wrote: > Looks good. One more suggestion: add a vfs_splice() helper and use > that from do_splice_to() as well. I really hate call_read_iter() etc. Please don't perpetuate that pattern.