From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBE3C05027 for ; Tue, 14 Feb 2023 18:23:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1008A6B0075; Tue, 14 Feb 2023 13:23:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AFBE6B0078; Tue, 14 Feb 2023 13:23:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE0586B007B; Tue, 14 Feb 2023 13:23:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E0AE96B0075 for ; Tue, 14 Feb 2023 13:23:44 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD22C1C6548 for ; Tue, 14 Feb 2023 18:23:44 +0000 (UTC) X-FDA: 80466720768.17.7902F48 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by imf20.hostedemail.com (Postfix) with ESMTP id C93CC1C0020 for ; Tue, 14 Feb 2023 18:23:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=mailo.com header.s=mailo header.b="nHz/10fs"; spf=pass (imf20.hostedemail.com: domain of drv@mailo.com designates 213.182.54.12 as permitted sender) smtp.mailfrom=drv@mailo.com; dmarc=pass (policy=none) header.from=mailo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676399023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=xpw6HlT/j2jxg2Vr7G5/NtNATAiQQgwG4Qj/e0bf88I=; b=skTfwpDTFv3o74MDRhvXmic4L/sOOmL/rt0md2paFlAMgVZ4JLASFhqYKct0WQuVlp7dPT 8RmX1WyDs+RfYgekRjh/G3ipdhRFker91LbD4nbcBAq3pDrB8EGK0eGxXX9+YhexVPqEAK 8FX9Bx+2juhdgDwSG668kZO7FDaYqrI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=mailo.com header.s=mailo header.b="nHz/10fs"; spf=pass (imf20.hostedemail.com: domain of drv@mailo.com designates 213.182.54.12 as permitted sender) smtp.mailfrom=drv@mailo.com; dmarc=pass (policy=none) header.from=mailo.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676399023; a=rsa-sha256; cv=none; b=gYOhfhWch6dp6a6+6AzCgHBNz9YNTEqUK89U866ulJkZ29m9N7E+c794FO4xjNaPEAzDhE 1bB6K+pI4hlgqIWr8hSc80xhGvbvHyWkbVct3W0I7tMOvx13Qc5rhX/DuZh66RjSwDGwPD 88h6RaAW7Y//8zCu2tKipd5JTQWhSVA= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1676399020; bh=WKNP+ZNMgiPRAt20UgQCPKI7q8zlNbwFG0h2qpmMNko=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=nHz/10fsSH6fbCLh3dFj1yMFY0la78TuOH98UXR0DktA3M99NgAkJ9h4KS3e0Qwzh fQU5HqkPcPWgjIe8NAXtspCDV9T83VZZZM6Dz8bc2MDLfRX8PgxDkUfMoEiSCFzSpP EvIgX+ALN98G4czUytMXQEL41x2D94yDnnrBvwpQ= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 14 Feb 2023 19:23:40 +0100 (CET) X-EA-Auth: MmEnkdIFfZXN1qaVwBxVGi/qZ48H/g4c2rx9/UYh24o7WKz8xflKgib4yk86vAWiHUZYnn6nefKyy+epHBzLP4rXbOqcCx+S Date: Tue, 14 Feb 2023 23:53:34 +0530 From: Deepak R Varma To: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: Query on mm/folio-compat: pagecache_get_page Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C93CC1C0020 X-Stat-Signature: cdpnu81n8pp3fjjwg8y9jrocd9fjcp75 X-HE-Tag: 1676399022-323852 X-HE-Meta: U2FsdGVkX18NcM+aGxQqTHME6Ff56PZGqU5UpywhAaM6uRRs6iOCRRsLP2X+s82MtYCJV3zmNI14IAr3xP7xEbi8+UmkiWt2LiJUaSp2EvPoZCJfmHQREIXe4aGAgySVkF5eYm2f7Tc7ohP3xAnkrfyFi4xQjhaZNIqVE2i/xR3MaavplrpwTaTS5SCqPkIz68AYr3tnChIOxesNO/xzRvQALkWuZSFcaTlDaHNIRv1pyjpTyvGPha5j7e5J53mV7MUqhYYkWBS2+lSavCPG3WpUihvIxYFa+QnNeYhwdqK9NqOWBaBXVPDAxUK+aSuJQsCeVK1HgeMft2zU6pBDNiK8pCmjz/lyvfBHBDRJ3gqruDFIplnmMgDBW7iDDTdwYtnQUrzKD3Y2+ZrjIRu+ffF+w+hvyI4e2VuDM+D5/Y8D3mnFEeC/lajq7uVv23b2g910bzunb0MiPRVItda8bYMZxaW3u43A1b+I2rMvH77DAL6t6VQzZKggbnE804UDyoRmAYCcyGh3YIsSkK9N9u4de9G8kz2XjAZzoyQ5YdMFS7PNWUKJkHlT3jROmE/XP0dyDl5nxjd1o6u3C3IN5UTdo0wahzbrnvRnYpcqmixkGx2nWMRSuXZ2Akyiy/+A5AvnrAG2s0wnpablEA6zP7d0aLv1pez/h1j6fpyB9CBEl7aktcoyW2l5hkZP0MGOo6q2o5xaPao5nlPu5KxGI3vOP7vvsRvRgt1BqL7q4Vxk/8vKhWZnrQ34Nz143i3/ibtII8e0Yy5kTZU0PfW6Iy750EAQ4kixhP93WiVt9xUR/Jtt45rF/hjwNuKVgXEpS7wAIUD038cEW/AYTddw5wNdkFs/n76eLdhuJC7KGBfpPpkEMMppwiwUs/i/mYWOW8Gm+EuNuq01FKTCRNwjFqh5SU+LahLag9F1Jcma9ZALQr8K1vQluiE7Kxceu4VycFSV/EFkBu/bckdNCwR jrW8VE/n tBhi661o3HfoPpUihDAaLxF0h0ojri+BRpPoa7S+fvu8s5OxekdEIiyoz6pdHkpYv9OTbFnKisC0mNLmpvXAOTymEEzsVUaT+rNHP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, Could someone comment if it is safe to access the page member variable as written on line #100 when folio is NULL as returned from the __filemap_get_folio() function call? Is this kind of intentional page-fault trigger for the system to handle a new/fresh page allocation? 2 folio = __filemap_get_folio(mapping, index, fgp_flags, gfp); 1 if (!folio || xa_is_value(folio)) 100 return &folio->page; 1 return folio_file_page(folio, index); The code is part of commit ID c5255b421fd04 Thank you, ./drv