From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF3DC636CC for ; Mon, 13 Feb 2023 15:55:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AEF96B0072; Mon, 13 Feb 2023 10:55:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85F6C6B0073; Mon, 13 Feb 2023 10:55:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 727F46B0075; Mon, 13 Feb 2023 10:55:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 631AF6B0072 for ; Mon, 13 Feb 2023 10:55:33 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CD05140811 for ; Mon, 13 Feb 2023 15:55:33 +0000 (UTC) X-FDA: 80462718546.04.96C1C98 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf12.hostedemail.com (Postfix) with ESMTP id 3C41940016 for ; Mon, 13 Feb 2023 15:55:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=K4Iqa4Gh; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf12.hostedemail.com: domain of jens.wiklander@linaro.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676303731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vuapDqdagNGnFpo6uhL7k0neEZp9M4gz2OrukVtMrUk=; b=yUFGamVaW6nlJT4m+sb40+M+UpzuEDF4a2uT9LoYgn8s9zsNkB2P9+zQ6s+KIbX2RWtx+I Ur+3rmOakYd/Aho2TYPBSG/2FszJ58I/W2ZU+yO7zICBoWV20BzzonmU+lhtX4GNg954y3 VGCYkU4/xEE7uSXqQVsLLNnqWaD8fO8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=K4Iqa4Gh; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf12.hostedemail.com: domain of jens.wiklander@linaro.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676303731; a=rsa-sha256; cv=none; b=2jq4aqVL/Ps/yS0ZjKbLm8fT/KnuO5tCyUKlIN507I5hrLrBLl4NqYgqiHN1lIpaZtaF1h AI4Wikm2f/Bkll3WSIDSuXr5nS2dWk+vUZeiLoAV0gyDYYrgZZnQRop2E4sB8o3kT/mG7O Iz7oaqLqfHCcBogvmE4Nm1HUKapuwEQ= Received: by mail-ej1-f47.google.com with SMTP id k16so1464931ejv.10 for ; Mon, 13 Feb 2023 07:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vuapDqdagNGnFpo6uhL7k0neEZp9M4gz2OrukVtMrUk=; b=K4Iqa4GhRfHb+pDFe/SkIa74T/KmapgIhH5krvXfe49NjyMplxwmP1Jsm78gwC7DT3 Sr1nbbEwQiVx8nDHf36NzuQiJt5WZJIA3T3D/7yVgkQ5nP+EeN8WhSFi0HeosPqTQdFH SjYQ5cPJlPdIrHefP4dhusrlHj5hNMS0rg17EY4sSNtXeUhJuPmqrxy9dU80hnPJe/1o ofg2h8s78dWEY60ka1hrYajZj4b4nO4TMCCurU3nLecnJMJv4MV13wd6DcNsUAWi0Ows /DLLWB+3NqnUQ/UE8p9ppHnqVaP2VNK0pTlHJeBZupCquC/HsC0NI13ez846N3V7WJ0E bRSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vuapDqdagNGnFpo6uhL7k0neEZp9M4gz2OrukVtMrUk=; b=cZH7Sk3GzTlS6+9FRhZCvYhRwqkrEugfOAjbAgdaX3yBmgG5RE/Ij40PAUCHQW+tRO BMRoOTT0GO665Nj4frbYPgSVWupYnTtUY1ruKNQfTg9QxU5NHmpSpr9k2u4YOJWARSYz 1lElZrRYw3Y+U28ElMNW7IyztSVNI8aBifX+6E1HdrKgApPfu23Y1eja/Y8GkKVGPnfN /DUttUED3Fw4+nq1ezt3yoGvLgbkdzxmkuNMPb4Dpi7Gev0PKxG2Fz5fk9FTlFIanUFl UnZTwGj2h1GS9Nycv5Y21+pZWdHKDH6kwpFteADuEMzNM2Agn0nkNP9PVGfZDQ1q+IVA 5tSA== X-Gm-Message-State: AO0yUKW08mG/Vz3gpTV1YIA5fKkoMcmO/3aYufFhjEt8zHiemfXkrpZg lCfsowo7sPPCANbZDfMk11IDeA== X-Google-Smtp-Source: AK7set9U1akcHIKuL0+KX0vTYez7hYPW+SEKgxRVoV8Zx2osQnaDonnagZ++a1daYV4ESYRduLdCKQ== X-Received: by 2002:a17:907:168e:b0:8b0:23a6:c491 with SMTP id hc14-20020a170907168e00b008b023a6c491mr11788390ejc.31.1676303730005; Mon, 13 Feb 2023 07:55:30 -0800 (PST) Received: from jade (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id n8-20020a1709065e0800b0087fa83790d8sm7045465eju.13.2023.02.13.07.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 07:55:29 -0800 (PST) Date: Mon, 13 Feb 2023 16:55:27 +0100 From: Jens Wiklander To: Ira Weiny Cc: Sumit Garg , Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, "Fabio M. De Francesco" , John Hubbard , Mel Gorman Subject: Re: [PATCH v2 4/4] mm: Remove get_kernel_pages() Message-ID: References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> <20230203-get_kernel_pages-v2-4-f1dc4af273f1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230203-get_kernel_pages-v2-4-f1dc4af273f1@intel.com> X-Rspamd-Queue-Id: 3C41940016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: y366y9asgk7r3we6o35k1izeowefrnc8 X-HE-Tag: 1676303730-281821 X-HE-Meta: U2FsdGVkX1+CamZMyHOFHhNHFU8A2iGWxwaROGxyjX4LBss/qaCOSUXP4z7UwJyQwN+VvHZO4nBNfLoUyCkdg50iIbmpC9yMpG+K1Rc8W38I9PGPkrdrQhE3hamrNVGw5L9+iDaI8CLteKtosn3EBgSskGCoTkWNysvVCSlfh5nlYlL8/Uj6piFGeHHK0dlfYfbkW1oRDNb865GZE6xJWmOTw9HTsBSQgY7VHVFE+XXaqUG7O18oWGFRU9PPxfBuTcXSkFZaJcQkPntDw+MJKZUMpVXyBhDiu3J5ekkQW4c+a7bVr1R+PG+8Lfbc7nNHoLutUAJ5ZyjQBGfMClrpSpAeKQNaak7e6XI28EHBFDCN5wQrMBmHII0ee+hDDK/l+YuQEk2ukrlc8dAkNU0a2CrO33bHeSKrGKwtigKheR0p5695CFuEZfSQiwhfvtfUHU444AynrSMsjzwiGkg3eOd2qNyxhhV3TeSBTgB2ZatHSpvPwKbltJr/UvW0lVDhdWSz14jrP7mz33VgdDIenBJIivYJlcRwUqOozYNP3w+MM+9El/jk1xYAPvV9klpdCgZUa0Cw0cDGeTEoo5wd7cXufYExtdqa5/c6YH949AXVRwca8CozUHk1jb0agEQVu6DNbc/zZKWUISLEpGwCo7DCTdKhC1E2JBl51rRMyV3y8A4eW6jpZ1DpJe4elyGKHRaTSktK4R+0lFqRDiUFzyMaHT8JTz2afkyySalHc+xhLP6ro6lJEyRmKyCIJaF9eF6T8+GpN2ogj7CH5532Rre9f9cflL7c4KT90wURrjtizQvzKwJnFipBCKyFcqsDsT9AzxUPV3uOg1tOlpHj7SqdMWYMTNtZ0s4dJ69ybhxH2oc2jz75aNlq7+T0p1iY0rom7uwd0Y/2V68xERBVdMjOTI8t+Gi4hgnyKgtYQQW+CSz/YVvVHYEfuxpcw5keOZXNk3vIik9M1jfTdbd ACKHhjBK BcEBPooUb2XL9TmU4rT4CblNryjcB/HJKgXD0Xugjl/kWijiW7rrYsKECMVq418RuGaTCwVaHTUw3SQrVbSRhIx1XHu9T+mMwX6pICI8qmIRgD+Ri0BNpYHqtpgK1XVh5K8le5ru8+YPbXg4jccebQdXV6i/VSi0djyAnz3JEqRG/Gj8jRR0TRFgZlM3U+lOappjNFrtcYBokV0eGuvVPX9gTJr+stSnzKK8eA5OtlM3vg4ZUKjVW92lVvhiC9SMvlcWEpsdzzj3EdIV7dynUR99XdyBKKfdrtk8lMWHTH3GEbjlP3Qky4D5OQ9Cwj/k0q+Fu2TjlIVzBiZOoChpet3iyU2lnmyOx37gAvkqYqBXEwqU9MI1OvdZEgpemPL+F9kHLIvsgSKTaYXqqPu2re7UGhY7RNypUPtewtXfbj7D1INGEbulHkAweaWjopl+Whbg2KvZAyF724UqH+72h5KrmX9nzRZ/3fbF5W4zMmeQ2oFOQLyfdIRHnxjlCV2opg0lrYfBtg1SfB4n8LKPa9kN0IfbQa9EYkGoL2LMEoegsRgBJ0XhmDh4MGw4Sv1+xWTq2r+hcEAfAN112/LBNYXbyMw9lgu8+TPLkaidk2yN8voBRe1aIPY8LqoNp5iSopEKMGKl+utJNayvKjq8IlqMfvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 08:06:35PM -0800, Ira Weiny wrote: > The only caller to get_kernel_pages() [shm_get_kernel_pages()] has been > updated to not need it. > > Remove get_kernel_pages(). > > Cc: Mel Gorman > Cc: Al Viro > Cc: "Fabio M. De Francesco" > Cc: Christoph Hellwig > Cc: Andrew Morton > Acked-by: John Hubbard > Signed-off-by: Ira Weiny > --- > include/linux/mm.h | 2 -- > mm/swap.c | 30 ------------------------------ > 2 files changed, 32 deletions(-) Added to https://git.linaro.org/people/jens.wiklander/linux-tee.git/log/?h=get_kernel_pages-for-v6.4 Thanks, Jens > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8f857163ac89..2041e6d4fa27 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2095,8 +2095,6 @@ int __account_locked_vm(struct mm_struct *mm, unsigned long pages, bool inc, > struct task_struct *task, bool bypass_rlim); > > struct kvec; > -int get_kernel_pages(const struct kvec *iov, int nr_pages, int write, > - struct page **pages); > struct page *get_dump_page(unsigned long addr); > > bool folio_mark_dirty(struct folio *folio); > diff --git a/mm/swap.c b/mm/swap.c > index 70e2063ef43a..4c03ecab698e 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -158,36 +158,6 @@ void put_pages_list(struct list_head *pages) > } > EXPORT_SYMBOL(put_pages_list); > > -/* > - * get_kernel_pages() - pin kernel pages in memory > - * @kiov: An array of struct kvec structures > - * @nr_segs: number of segments to pin > - * @write: pinning for read/write, currently ignored > - * @pages: array that receives pointers to the pages pinned. > - * Should be at least nr_segs long. > - * > - * Returns number of pages pinned. This may be fewer than the number requested. > - * If nr_segs is 0 or negative, returns 0. If no pages were pinned, returns 0. > - * Each page returned must be released with a put_page() call when it is > - * finished with. > - */ > -int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write, > - struct page **pages) > -{ > - int seg; > - > - for (seg = 0; seg < nr_segs; seg++) { > - if (WARN_ON(kiov[seg].iov_len != PAGE_SIZE)) > - return seg; > - > - pages[seg] = kmap_to_page(kiov[seg].iov_base); > - get_page(pages[seg]); > - } > - > - return seg; > -} > -EXPORT_SYMBOL_GPL(get_kernel_pages); > - > typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio); > > static void lru_add_fn(struct lruvec *lruvec, struct folio *folio) > > -- > 2.39.1