From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6590C64ED6 for ; Mon, 13 Feb 2023 15:54:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DAFB6B0072; Mon, 13 Feb 2023 10:54:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68AC86B0075; Mon, 13 Feb 2023 10:54:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5532C6B0078; Mon, 13 Feb 2023 10:54:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 47A9C6B0072 for ; Mon, 13 Feb 2023 10:54:29 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E22864067B for ; Mon, 13 Feb 2023 15:54:28 +0000 (UTC) X-FDA: 80462715816.21.6AA983C Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf16.hostedemail.com (Postfix) with ESMTP id F219B180013 for ; Mon, 13 Feb 2023 15:54:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=AdQ0spNp; spf=pass (imf16.hostedemail.com: domain of jens.wiklander@linaro.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676303667; a=rsa-sha256; cv=none; b=aRcKOAke9jo1CCGpJkcacud35tolkwkiOj66iFyVvh513ORSfl9hN/cLVAIvkM1pHo/WCQ JXuImpSnC9Z4YvmGm0CaobUG2rRIDUrx2wJq7OLkGMmZbkMEAhSGBe6vLD5G+c6JLM+ZtY VU8GFvPNY908kZn8lAuQ56NOHX+oaxA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=AdQ0spNp; spf=pass (imf16.hostedemail.com: domain of jens.wiklander@linaro.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676303667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KfZZZ7pG5QyK89tWcZZMAGkA5IayYu+p3Tr5HuPXiUQ=; b=gx2dhwwdl7wYpS60fFgpWZek8/1kDTsagLevKD7fej4PmmtcTcgg3Zi2GS8brzacBJ2X6L 5nMiIRQ7+mtKDE6ctyMhY38k4KgFbusatEj6BuvZmPv3z51xsx6wrc86pScqvSfQu8odad DMA6h90w1c8jUJKMq+ia9ryhhLeRxaw= Received: by mail-ed1-f46.google.com with SMTP id a10so13510833edu.9 for ; Mon, 13 Feb 2023 07:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KfZZZ7pG5QyK89tWcZZMAGkA5IayYu+p3Tr5HuPXiUQ=; b=AdQ0spNpvZO2a1rdXtFQKQz2a5nIbm1TP0nlRNVEw0a20VQsi4P2TewXf3rcx59UHK JBnJk0T5H9vMttktZQt5rRUgetkcXFJAOSz19WoAM8vq5qge57WOwoka8FiZJrUE1Ja2 GoWqE0CAilTX2E4o4EbrveWM+Z+6PiNYA1pmBDv2EwoB1C50Kqe8TLMM8ZF26zcM8hgS KNa5bJQT5+rg4V6OeKRrl3A8T3Ovdr652BEOONFJJRVMBYpXNInKBRTAODeD6GsbNjNw VzXTm+t87B7XrdydF30bBjZawimeVaBcap2kAM5Ztc5Zq34HK73VQsGIaofC2uzirgpg 6TAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KfZZZ7pG5QyK89tWcZZMAGkA5IayYu+p3Tr5HuPXiUQ=; b=S4tjoG3RSNg6eWBZkv82GORKbJgQKOckOUPwRoyWmV8PBBeocfGL5YevltOFmU3wqg W0Tc2vNNrPJZycGlXJzSr/4Lx9x4ll+IqaHDaW3iYmfjBr6du3SXpkseQeFi6nw80waw 3fF6d7tZsgxf+MiTGxPFqjQ2b9U8KAq4ektjtj+EZnXPoR8T/CREXh76xVTpwuMxNjjA 4Vqb4ejEN9QpqFYilNYYaF1SK3RqHUOTm3yYwjBwwvpWyFI+mtdG8axZc4AbikwPJaX/ zxDwiThxAIiTN+pNLitH0jugrJDtRcmHrhZLcgDkUgQR/eNAM0s31HMsBAuKcACltFU0 BDpQ== X-Gm-Message-State: AO0yUKXIp9pcMvZbZqEm9+dzHsbOwYeTqPfTDib0Smx4lOmWdGeOxlMj oW+U6qEfoA2ieuff8+GIw+TV9g== X-Google-Smtp-Source: AK7set85G84Uc4/3S+BRufNyk4XF+mPrWyiWP+4v7igsCC0787RDUVcRHp/X2rzmloeF4VfNmt983Q== X-Received: by 2002:a50:d64e:0:b0:4ab:4ad1:a381 with SMTP id c14-20020a50d64e000000b004ab4ad1a381mr9872423edj.10.1676303665506; Mon, 13 Feb 2023 07:54:25 -0800 (PST) Received: from jade (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id s6-20020a50d486000000b004aab36ad060sm6803430edi.92.2023.02.13.07.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 07:54:25 -0800 (PST) Date: Mon, 13 Feb 2023 16:54:23 +0100 From: Jens Wiklander To: Ira Weiny Cc: Sumit Garg , Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, "Fabio M. De Francesco" , John Hubbard , Linus Torvalds Subject: Re: [PATCH v2 2/4] tee: Remove vmalloc page support Message-ID: References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> <20230203-get_kernel_pages-v2-2-f1dc4af273f1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230203-get_kernel_pages-v2-2-f1dc4af273f1@intel.com> X-Rspam-User: X-Rspamd-Queue-Id: F219B180013 X-Rspamd-Server: rspam01 X-Stat-Signature: phqtmermzhj48569haop3kqebriuo8jc X-HE-Tag: 1676303666-671906 X-HE-Meta: U2FsdGVkX1+DXTa/L1g1ZzdpiJviqiUTNxHFwYLs28zSY6FOzA24nerSPoqxfFr6k+VADH+z/NXhuxFj7muX7dHQOe3VUfgXxk3QeVpXEyqVpfL/OIMTjrZOTEw+csTwwgK4lCk736bLJ3rOJ20IC03W1s+LrM094XK+t4t6LOPX+YPDajmXBoAPcMoPI3ILcZSbuqSKIl/r1Va8GDXtSGZjemnfGY29xnLlqYiu/UaWDbnhNFi5gE9OF5oracYl/ff0Gf+An0EAnvjwLYEZy+qsWE66LH4usl7DrLGTPxyEXSElZQ5pJfJ0nRyjaD+a07mDZiOdES0CjHW9NAPv+OrHDfDqiO1QNfKogSjg16JIvW4kuodmDDDBdkitDBNB7SaGlHk20W0uuSJNNPqBc1V4WuyzxTQnVuoGtZhcXDVlgXB6tEDJWpDGBj2KO1hyIDFl4cynUr9yn5oWrtUJkwUqrXMKzAZyeW8UATk7U0YYFAejmtlkindNghHypocwbwYBCcR9HLNGqAifzARJNaZcEU0Ih9YQc+Q1fTHKhdVPQRhrblfkG5aVzDq1tq7pSj5K4N/HQQyE9mJuG1K+gei1xi/yAuhgaI63lsKRQYmQNyHoSMfLQ1NZSSPDQaA1PeNizbN7uweMqa84xbYO4L9U3xu0kCT2A6brHob0MXLmT175Ap4V8wIH4FLQ8498OSIo5HNIzy6Xif0QfXtuCBBVSewcGnsIWCx4C9/P7w+Y/oeC81BMUkhg+IJ+eN4MNx3pSeaWnjPb7DQuHz8xZTa8pgFBTxQDIdfkp5n7tPsGhCo+ePVMz/4cCfd1XcD1NFWbYsALz+bFaeMNF8rvIBs2LQckZYUMLzlT9RjJCRY/NBZrOEE9RQlyG5uta9zuQPcIL6ouLlcrt8lwNSbq5m+WMCgwww2ZmiXUiB8+uVzCKoEUFifeGYiTvuMrI9uT4zLkTpdPpbWyxBGd4cQ 4Qk7YJA7 BeNL50co2LRQTBOLxg2qz9NDHsCD9xKDYH6hNDcVwTw4YTl4ZVuDaOyqAiBmMEqilQuxqs4yfsmXLyBW8gmDC5/HN+1UpLtTB7wbABlQpmIX4c6mmFhzjCkBF1H65s23iqqlSsVmxEbAhypDpJWxJWOz5MelibZeA0um85DA5HHao2NaZ5Jm+ZND1W7MzbkHNgzj0AFGzaHPKxpgBr18GSeuwMykqvsHyEaThUF4o25QzRLFB5bvFfKCJLRv20QV3gkde7QkuoqDezOc9WIcCUvnJ+5e41FSFG4Jy6/Hr0eavxVTT9j7OevbYN+EDkJT6JkqY/qSak6cUEp6j5RAzgh0z1kjVYKJgjL5gb3W4LspNzO6dXdzGhoDoqiKHSt1fLxkgmXg0XnO66zrQlRXeLmaSbsOos31JWXxiCL62PbJzFR5xWaUR/frADxHKB0SH8kWpZgFCkLjAgx8Y6dUtnsA/z1dutI9kT27Yn8kXgrHdtsmNYkyMG8Ogid38WtwUZ4F1QVKKHXSDWaCTKTK56r/5jSCKvizfaTsrHyaAY6PTWlOjerlsFJJYgB1FfeZ4ZwVffiP1eTVOYxw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 08:06:33PM -0800, Ira Weiny wrote: > The kernel pages used by shm_get_kernel_pages() are allocated using > GFP_KERNEL through the following call stack: > > trusted_instantiate() > trusted_payload_alloc() -> GFP_KERNEL > > tee_shm_register_kernel_buf() > register_shm_helper() > shm_get_kernel_pages() > > Where is one of: > > trusted_key_unseal() > trusted_key_get_random() > trusted_key_seal() > > Remove the vmalloc page support from shm_get_kernel_pages(). Replace > with a warn on once. > > Cc: Al Viro > Cc: "Fabio M. De Francesco" > Cc: Christoph Hellwig > Cc: Linus Torvalds > Reviewed-by: Jens Wiklander > Signed-off-by: Ira Weiny > --- > drivers/tee/tee_shm.c | 36 ++++++++++++------------------------ > 1 file changed, 12 insertions(+), 24 deletions(-) Added to https://git.linaro.org/people/jens.wiklander/linux-tee.git/log/?h=get_kernel_pages-for-v6.4 Thanks, Jens > > diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c > index 27295bda3e0b..527a6eabc03e 100644 > --- a/drivers/tee/tee_shm.c > +++ b/drivers/tee/tee_shm.c > @@ -24,37 +24,25 @@ static void shm_put_kernel_pages(struct page **pages, size_t page_count) > static int shm_get_kernel_pages(unsigned long start, size_t page_count, > struct page **pages) > { > + struct kvec *kiov; > size_t n; > int rc; > > - if (is_vmalloc_addr((void *)start)) { > - struct page *page; > - > - for (n = 0; n < page_count; n++) { > - page = vmalloc_to_page((void *)(start + PAGE_SIZE * n)); > - if (!page) > - return -ENOMEM; > - > - get_page(page); > - pages[n] = page; > - } > - rc = page_count; > - } else { > - struct kvec *kiov; > - > - kiov = kcalloc(page_count, sizeof(*kiov), GFP_KERNEL); > - if (!kiov) > - return -ENOMEM; > + if (WARN_ON_ONCE(is_vmalloc_addr((void *)start))) > + return -EINVAL; > > - for (n = 0; n < page_count; n++) { > - kiov[n].iov_base = (void *)(start + n * PAGE_SIZE); > - kiov[n].iov_len = PAGE_SIZE; > - } > + kiov = kcalloc(page_count, sizeof(*kiov), GFP_KERNEL); > + if (!kiov) > + return -ENOMEM; > > - rc = get_kernel_pages(kiov, page_count, 0, pages); > - kfree(kiov); > + for (n = 0; n < page_count; n++) { > + kiov[n].iov_base = (void *)(start + n * PAGE_SIZE); > + kiov[n].iov_len = PAGE_SIZE; > } > > + rc = get_kernel_pages(kiov, page_count, 0, pages); > + kfree(kiov); > + > return rc; > } > > > -- > 2.39.1