From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C64FC636D4 for ; Mon, 13 Feb 2023 15:54:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB8CE6B0073; Mon, 13 Feb 2023 10:54:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D69326B0075; Mon, 13 Feb 2023 10:54:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C57F76B0078; Mon, 13 Feb 2023 10:54:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B626B6B0073 for ; Mon, 13 Feb 2023 10:54:16 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 83FA61204C5 for ; Mon, 13 Feb 2023 15:54:16 +0000 (UTC) X-FDA: 80462715312.22.AAE5862 Received: from fudo.makrotopia.org (fudo.makrotopia.org [185.142.180.71]) by imf01.hostedemail.com (Postfix) with ESMTP id E7FCA40007 for ; Mon, 13 Feb 2023 15:54:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of daniel@makrotopia.org designates 185.142.180.71 as permitted sender) smtp.mailfrom=daniel@makrotopia.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676303655; a=rsa-sha256; cv=none; b=U5+1Es3MBeRX5GAklLVnx5mUwF2cMohK8XfliGYNIC/G1Ylf5prrSqJXhDHFvGfisrOB66 ca8156IbcF7f/jVhb4x2I0nhjZ+3y33+cYjK52O/gmJcaknUMS9I0N8zKsA1Q3pjL9LkrB t9kLTzx11jEy+2RoW4/EyuawiviKEX4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of daniel@makrotopia.org designates 185.142.180.71 as permitted sender) smtp.mailfrom=daniel@makrotopia.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676303655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=QBG5x1R26hySoj3zjs2WWWYHi8c2St5utpwhDC4q/ow=; b=rE4BhL3ANza49RGoTNmhggnmp0ckTiTnMD28Ip/3raSSvHjxw2oTyva0EQwtVb++0/ITCZ Sg5ATlaFRx6Xh909GikiSklyXJPIK09I+69w9vGH3qZwk1ec4o7YRIetLMjYfcEFjpXLKu XQALBeHu3ILhIMAqyj160vxYzbxiIAo= Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pRb9e-0003qT-2v; Mon, 13 Feb 2023 16:54:11 +0100 Date: Mon, 13 Feb 2023 15:54:04 +0000 From: Daniel Golle To: linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Howells , Jens Axboe , Christoph Hellwig , Al Viro , David Hildenbrand , John Hubbard Subject: regression in next-20230213: "splice: Do splice read from a buffered file without using ITER_PIPE" Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: E7FCA40007 X-Rspamd-Server: rspam01 X-Stat-Signature: 39knesgqgxrp34c3wpafcxmcha354my4 X-HE-Tag: 1676303654-586237 X-HE-Meta: U2FsdGVkX1+6sDi30/g6S/piH3FODNcmE6xuXuU51lH0jrCD0fE5TBII67vsRo3v3m4/eyIDt940iguD6GqpNm+QpOiJhGPvP2q0qeG/uYeO3/lU2MLzS0JzK99PVsbsxT5bSdbTHYawqBPnwD7+SC7zdz4xaS+C52b1dmpbEHNOMauQMa7sP72iINL5DCIocppSzjg15BoP0FAdovsRg8CR5bf9URpy2kLJEzh7XIwPiZIFUgRbTG9RIPN5KGrLEUm3G+/O9kv3bt4P9x3VaAFN4n68QF4LY0xJ5Zum6wU1d/1+6nSR4sgLM2iKSkXckG86WJabwpt+gX69Jp7BlC27eyRIyGnetNXgrEF1xltax2VhC2MDDUA/PbGE0vBvE3Xtnxrp00ip8TZyYRvMok0d/iYCHblw6lQq09HluoB8wONZ37xpG3zpiCgCSIsgeB5bMKbyRa0qiNReSbaHjoS38SrKFEJmSv7v1Sm0H5wQgrlh2XmqYgFQh8zWEhIgYI3nIukoaAuDa3GXbVnRBkWxgQS180c6dMf8pmQyX1iVhgSLCCKqMpUFE6oloz3uxhgVLkcZ5bWb+5RF9kxBlW8+7v5xOgTecz+4PBBiim2HN9HfOuDFzgzC9Ng0jgZ9JL++gG4oRAgOYkmLzOHlczXr9tED5dTHaLgp+0ZCJbFeoJwuUOamUuSIYkO3QbA1M5HfZTqLeYrnEJdT4bZMF8MDf4CPkNOmIdbCHSajh0WL47VrVrfm83olgjWnKYVV8snMGXCFvCO5Neu+O9cVvskSEkNDRbgTkDU8FN4pe3Y6YrrVeVFW9C2MtEOWnd0tPkcJNzQKiOtWmdqqxDoqhsBMpGjTn2gxMtn2fbz1qYXaV1fDpuoVngU7/vrBIKiPo4qyYbSwwaxHyexumLyyijD2I6ooUnWLuull4ig+/zPf1XozfyS+vIriZ3cm+WtixJL0Y+2YjGG33k8Mjyd yEqWkFCg nQN4OA5HdaWDqrdEcVFXB3zaXTf5367QC75sfN+D0sCwJefUH8lP7Wy+njI5PnueXHUCaktJWNzUGhufY/ndg9BV7WT/eglO2ZqUP0UgZxgOpUhRcG1nAl1I1N7XL0c1rugd59kN7CkiP3nRC8hQBd6UzMEoy/rHLSPHKU6WtaBJ6tkOxFPToabQ9xVYbzmnQiWND2sn4cDEMMTf9c39ChsZrJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi! I'm Currently trying linux-next daily on various MediaTek ARM64 SoCs. As of next-20230213 I'm now facing this bug: [ 30.119220] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 30.128134] Mem abort info: [ 30.130932] ESR = 0x0000000086000006 [ 30.134682] EC = 0x21: IABT (current EL), IL = 32 bits [ 30.140009] SET = 0, FnV = 0 [ 30.143067] EA = 0, S1PTW = 0 [ 30.146210] FSC = 0x06: level 2 translation fault [ 30.151151] user pgtable: 4k pages, 39-bit VAs, pgdp=0000000048cbf000 [ 30.157603] [0000000000000000] pgd=0800000049d82003, p4d=0800000049d82003, pud=0800000049d82003, pmd=0000000000000000 [ 30.168412] Internal error: Oops: 0000000086000006 [#1] SMP [ 30.173972] Modules linked in: nft_fib_inet nf_flow_table_inet nft_reject_ipv6 nft_reject_ipv4 nft_reject_inet nft_reject_bridge nft_reject nft_redir nft_quota nft_numgen nft_nat nft_meta_bridge nft_masq nft_log nft_limit nft_hash nfs [ 30.174180] usb_storage leds_gpio xhci_plat_hcd xhci_pci xhci_mtk_hcd xhci_hcd vfat fat usbcore usb_common [ 30.273791] CPU: 2 PID: 1232 Comm: cat Tainted: G O 6.2.0-rc7-next-20230213+ #0 [ 30.282469] Hardware name: Bananapi BPI-R3 (DT) [ 30.286985] pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 30.293929] pc : 0x0 [ 30.296108] lr : filemap_read_folio+0x40/0x214 [ 30.300547] sp : ffffffc00a28b9a0 [ 30.303848] x29: ffffffc00a28b9a0 x28: ffffff80079ce7c0 x27: 000000000000000f [ 30.310970] x26: ffffff80072f5500 x25: 0000000000000010 x24: fffffffe01f8dc40 [ 30.318091] x23: 0000000000000000 x22: ffffffc00a28bb80 x21: ffffff80072f5500 [ 30.325212] x20: 0000000000000000 x19: fffffffe01f8dc40 x18: 0000000000000000 [ 30.332333] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 [ 30.339454] x14: 0000000000000000 x13: ffffff807fb9b570 x12: 0000000000000001 [ 30.346575] x11: 0000000000005242 x10: ffffffc0090c5d68 x9 : ffffffc076cb9000 [ 30.353697] x8 : 0000000086a580b0 x7 : 0000000000000050 x6 : 000000000000141c [ 30.360819] x5 : 0000000007ffffff x4 : 0000000000000000 x3 : 0000000000000001 [ 30.367939] x2 : 0000000000000000 x1 : fffffffe01f8dc40 x0 : ffffff80072f5500 [ 30.375061] Call trace: [ 30.377496] 0x0 [ 30.379325] filemap_get_pages+0x254/0x604 [ 30.383409] generic_file_buffered_splice_read.constprop.0+0xc4/0x2dc [ 30.389836] generic_file_splice_read+0x38/0x2a8 [ 30.394440] do_splice_to+0x90/0xdc [ 30.397916] splice_file_to_pipe+0xd4/0xdc [ 30.402000] do_sendfile+0x114/0x38c [ 30.405565] __arm64_sys_sendfile64+0x138/0x17c [ 30.410083] invoke_syscall.constprop.0+0x4c/0xdc [ 30.414775] do_el0_svc+0x50/0xe8 [ 30.418078] el0_svc+0x34/0x84 [ 30.421126] el0t_64_sync_handler+0xec/0x118 [ 30.425384] el0t_64_sync+0x14c/0x150 [ 30.429041] Code: ???????? ???????? ???????? ???????? (????????) [ 30.435119] ---[ end trace 0000000000000000 ]--- I've traced it down to commit d9722a47571104f7fa1eeb5ec59044d3607c6070 ("splice: Do splice read from a buffered file without using ITER_PIPE") and reverting this commit and commit 82cf0207bed44feb0b3b8b17a4c351fdde34a97b ("iov_iter: Kill ITER_PIPE") fixes the issue. I have no time to look into this any deeper, but I'm ready to test fixes you may suggest. Best regards Daniel