From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE23BC64EC7 for ; Mon, 13 Feb 2023 14:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E633A6B0071; Mon, 13 Feb 2023 09:44:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1322280001; Mon, 13 Feb 2023 09:44:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDAEE6B0075; Mon, 13 Feb 2023 09:44:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BE8E46B0071 for ; Mon, 13 Feb 2023 09:44:48 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6FC951208DB for ; Mon, 13 Feb 2023 14:44:48 +0000 (UTC) X-FDA: 80462540256.22.3652E57 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 957BE180003 for ; Mon, 13 Feb 2023 14:44:45 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=nUOjCA8P; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676299486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JSxK9rMVsZmKsqSOdmHwtno2awdrOzMA4imgfyeBPO4=; b=Vdu1GVnZ7y57PuKodzPcDVyxwZ+q6gvYd4p5rj1oAoNW8D81tW+kCaR0Q7vRgALiHhwNMx NomxBl0B0epELrQvsPqd69Ox+UOuX7r+Qow9uEvwXi3d4pU+TMlXEkUYp5oAxP98nP+wn3 vJmwq52W3ShZuCcYPV5dGxAug/6cMfc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=nUOjCA8P; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676299486; a=rsa-sha256; cv=none; b=FH1DYZQw8ESQ86nToVIbxA5jB070Ix0MQF8n07001XQ3whsUX3ozLjCjocKVOoWMJX5++m zSOYZdlQNUfEnzDIDrCmy/aKVMEu/oX9xg4L5K5aTt3BpigRpAZntSQl52bglXD9l00JxL Cj39pqKQ9QUZefGxE1VsUH980lSTtuw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JSxK9rMVsZmKsqSOdmHwtno2awdrOzMA4imgfyeBPO4=; b=nUOjCA8P8jLHCHicL2DJLV93MO 8Wv93GntU4fvktAa3LhaWZ5d+DuDwMb7JJuI5QrIQ8xcPOJPKT70DhqclKb1xPKuj0B3pvadse3RH JN+4yLNsFXphcGl3bGF/j5d/9KCu65fB3fKW8D0Ffyk0XeKoyZcP3xKxIXypJK5BJuir7Cvvk/BxW G6s70GmWbDdnXosddZtKLDzN+KErM1PNyM2jm/htodVA3BcfSnPvRaUAUuZDfraTYXnSmLPiFaRlm Eto2PfXFH0+lk3iwWzun1z0RXM4CFpmSXF1w3GtDAG9BWqs72eqq7C8ZNPOUlOwrsy+pFRwcWG2il e2mQQ4HQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRa47-00F1gX-DK; Mon, 13 Feb 2023 14:44:23 +0000 Date: Mon, 13 Feb 2023 06:44:23 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE Message-ID: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-4-dhowells@redhat.com> <1753989.1676283061@warthog.procyon.org.uk> <1830953.1676286937@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1830953.1676286937@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 957BE180003 X-Stat-Signature: 4f4i4rn4pe43u9t464irtdzeddci9rcx X-HE-Tag: 1676299485-452771 X-HE-Meta: U2FsdGVkX1/YRdpF64+U6S7OI3Dcg12QsTrETggnzA8KZWk4nr6rEijAYPezsVE5dZQvmBcTjhqkf29v+rIbkdEEEmqXrQPk9BJo0TVSXi6rlzQ5Tb5Xa3737bPTTlaz/sLjzB3B5UXhHa+8/a3553qiLFkebc/0SywcKwhRS5MOVE8wGq1yOHjs5vcbPjN0ozYAGhiiCYAykU4fUNS45FOxVQYqdIWMoZCVfN63XZfZGnO4OsZ+HFwAjfUSQZxKDJuQZQG6uNnLf7WkkMJkPIHKC9xIRqN6Di+eaD05pnaEgt50Rkd35ZCZ53SG1iOOMdovRJplLRLv54X6HZchpLZA9mgmz94JTB670o1mvEkWHh4tAAfhqSohN1ItpIb0Jdl9LtC3inkz4FI5nZth9QpgRPE61+nOJxPg1g8lNWLQ01bGi/j4Tuxqu6nJOrC1SgYA368l3Zu/A0DeV+H5j5XJTDVNSknk8iV0Rm/kLcqaPZHWATy6LZB66kA8Xoi4jz+n7D0FQeE92dclAGl/VAIXYXP83EbyzEXaZnQL1AzCAglo/KedFOKj7t39+k5CCGaSRfe8EfefQZ7CLHy/ICAdj0TT/jJq4Ucb2si5sYN0A2qZkaNPPh6IC/oC0py+SjxXPPkQ4AM8CWfmAoxP3pFJV2RzVWJzOatX8Xpc83YiOmjYV/URaVLst4MsuLTsOQPIkKua4zKKhDIB3rc8uKG0sC0C6Rg/TJBt4zknwLOUf2HB1k/4ypvoa7hP0odGKuQpOtbRoWzZ1R6SqosZ5WQZYBcf9FFKFLEz8sNfY+tF41nhDxhQ3sfneEp4YpMtEvET/jml6oQMplrW9KpWfnVY2AuVFxHDqZBcZEMFSroYqHfgdPeL7M67pby7w2z8I7dWNdMBNzFrS1kDkDuTLO9H3i9K5LLQK0yRbVUVS9Spr3yZ42FIIbW9gkvWwSOWBig6RbAu4JovR6g96Fh /Yor1gvm dgiGXlV9EJCaOq7GGftR0wVKLV5G+jnPotXL1B3X8hHmTq8AnWXi7uMn1Tjrp6GqKY43PQ/UwaziXGdqdxP4ull8nmjINGjsicZ4D6jpoA5sAcdEOlIwkhr3iUOAmx8s1q0dx3uNvhZUk9EGulOj7NKdgs9lp2dN74OPwkdB9YMSzaigtkN/Tm2vzWReDyhfR4xBBnBHCMaiM7aErUem5kVhcHxn9+zq7pnbCKpHEwV34c7aOG9006Hkd/x7MTY2nWne4/3QYETIs+FPUIZJOeR7fRzAAptJWiqwSTDUDYsIV5iK+ixzw78KAJW/My2QaWBETbdOkUT66KLMUzm/v9uaSpUfj9rdd65n6Rv3cy76PTPLU+XkNDtS75e1ZR3aPGqQurgvlQ+1lDmvY4kyWl0Y/0lzpqpSnNovJDAu+M64gXHRWhrjXY44zHSOu9rMcswvumi0oDRuloIQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 11:15:37AM +0000, David Howells wrote: > I'm not sure I want ki_flags setting from f_iocb_flags I should've said. I'm > not sure how the IOCB_* flags that I import from there will affect the > operation of the synchronous read splice. The same way as they did in the old ITER_PIPE based generic_file_splice_read that uses init_sync_kiocb? And if there's any questions about them we need to do a deep audit. > IOCB_NOWAIT, for example, or, for I'd expect a set IOCB_NOWAIT to make the function return -EAGAIN when it has to block. > that matter, IOCB_APPEND. IOCB_APPEND has no effect on reads of any kind.