From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76FE8C636D4 for ; Mon, 13 Feb 2023 13:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0688C6B007B; Mon, 13 Feb 2023 08:36:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F32566B007D; Mon, 13 Feb 2023 08:36:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAB976B007E; Mon, 13 Feb 2023 08:36:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CC69C6B007B for ; Mon, 13 Feb 2023 08:36:43 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 998F6AAD5E for ; Mon, 13 Feb 2023 13:36:43 +0000 (UTC) X-FDA: 80462368686.27.40D2EBD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id C39C220014 for ; Mon, 13 Feb 2023 13:36:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ACRFerY9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676295402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WBsHPFyQ/3u7/lh/7uLULXSnFfjfKpl/+ZQxS+UDoN8=; b=XKENz5IZTyuL8EcK0yX2JnjQZVnjtwLU3U6kikB2DvofekV5fYN7tdbjCNjvEChMTRox1a 8TEw0jHJcSgp7LzwzWbDOtBGQHhtyT81aE/RczKTYGnvK1UFaoq9UIXkcd0kdKDgvt/LQX 7LgNtVmDJmj+7Hw2aL/IsyQMTosp0Fs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ACRFerY9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676295402; a=rsa-sha256; cv=none; b=qaILprrGqwJdZLdDQ9M6/vh1WK1nZASMkwlZcqsfnGhVgdltLerjdN+0jF5K7o0kXv5IrZ IlSnqXzJ5Qn89iaYgCpt6J5KHFTEqfe8cexBsddOm65DBRORToI+ggFiy+h2b9pG61s6iL paowTutr1fKjdddQVXOrfQT5ZP4sdps= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8A6F41F37E; Mon, 13 Feb 2023 13:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676295400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WBsHPFyQ/3u7/lh/7uLULXSnFfjfKpl/+ZQxS+UDoN8=; b=ACRFerY9QTr65z3Df8Q5sEawTKjoV04EOvZc+1ThKd2y5Gh1wCZZeMHcPkLA5kuH+0GSm4 1bw19SNVRXLu8QM2qNVitO+V0dCusj4E6XNs9FABjLO7sJqaEDaI02e6239GbixcpWrLRY l3LNC5WFqGUnt+GT3sYThyEqgJn+NqA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6BB181391B; Mon, 13 Feb 2023 13:36:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QkxxF+g86mNQZQAAMHmgww (envelope-from ); Mon, 13 Feb 2023 13:36:40 +0000 Date: Mon, 13 Feb 2023 14:36:39 +0100 From: Michal Hocko To: Roman Gushchin Cc: Marcelo Tosatti , Leonardo =?iso-8859-1?Q?Br=E1s?= , Johannes Weiner , Shakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker Subject: Re: [PATCH v2 0/5] Introduce memcg_stock_pcp remote draining Message-ID: References: <9e61ab53e1419a144f774b95230b789244895424.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C39C220014 X-Stat-Signature: 7jom15wquh9qpw7etefceonpmyrpm7zp X-HE-Tag: 1676295401-464102 X-HE-Meta: U2FsdGVkX18S5CvCcdtqOkDy2nlU2b8270YgQvEwwxYV2SUZWIuFpuawYyFQhO/hSp0hwjZ5Yx5UOVfozCabUrjNRIbOzqfL1HayMsfg3glFwgoqWxr/yKgPAF7zw00N17PpULHEGscR9mJXAeqhrWd3kfCIk7gcS7y6YvS4vckkjLLDj90xhtZrzaqAOM4FesJUhx6t1u6Pv+EO89vZs0YWZM4/X4QI2p4kw6z8ZJuvVcDXxW09we80UbrQ9pj0ht53ntKj+ZXwHPjRaiM8zabfunVL//+SxqgxHfpy5+110Rynvlhz5j29Vnk1VelJTylxiLxwFqKJEqXMRV0bcRkt8Xz925q5Z3ofUDY0fIMMvWp+Q2nBF41779ltAqt1gcqPT4SRWEaaAavD9vQYfhVxH3CN7LjMlnmJoH+PdWfHNwx+vd9U0zIC/ummBmbcw9efW1eib22L1Qv+ofxdus3sUApv36Xph6IHNm2tqV7rkAbxDLEvV4O4cjSr+Z5Bixh1l6S9w0YplE6gYA4b3mcUUWnw8+h+wPPHatGZyVepkY4vbhgJFub7og3lf6qh0I6yE6vFjSdr/JuA841mHrgppo1B0FrJJfPp9PUXB7TBnFSr+AfUYlRji4qKStFllX0/LGYl+5cSZGpNXwOINRoztFULamBH4TzW8hDT2XAJibUzNFJUKJeY6ZQYpYs9KPr1FWc/tM2iohJbeoEEjQWfi1g+KgXMrNDNoKBK+v3sfZrN8RDVP1ujuEloYfYSaHoKsCDCR+I3bxxxNXh9gq2gPxtW/x9RendfKOcGemt1CiO8Csv3svZKlvoSXoC3i2D679KS1sjEWF4jBUhvnhc0Epcdv+1OLXt0lTU8BxxOnlFxSSi7Ha7I/rYLQV1C2U2aylkQ/nzF1QQjx2EopE9gt4j2L6HuaRnGj9lQB401y5JPIQnck5gT8sQciKauqR3nFtkITGD86UhuBIk 85F7ylIo jUnZDkkNjMRKtluE8t4LMU/Ui37CMmxeZ/CVAIK/huYO/sVR38AWeRwdLiQKBcuszWeHhxt/7Rz3ap92FYNpHXUGrxXuCnCfuPZWnFUf+HHSRPP2MHeOW6akvlcDWk7pomAX4oyms7gqeVVpycu4KQ+Q/yBnODsQ3EZMgw1pfH5Sd29vY/OCGEiUQEilePvcXX3x358wp2c1GJC6wfVznuL+/QbiH5FSde8+0kD44aRVg3RC3d48gqm3rn6JkLDLgrThrZit5vGUp74E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 03-02-23 11:25:16, Roman Gushchin wrote: > On Fri, Feb 03, 2023 at 04:21:09PM +0100, Michal Hocko wrote: > > OK, so this is a speculative patch. cpu_is_isolated doesn't exist yet. I > > have talked to Frederic off-list and he is working on an implementation. > > I will be offline next whole week (will be back Feb 13th) so I am > > sending this early but this patch cannot be merged without his one of > > course. > > > > I have tried to summarize the reasoning behind both approach should we > > ever need to revisit this approach. For now I strongly believe a simpler > > solution should be preferred. > > > > Roman, I have added your ack as you indicated but if you disagree with > > the reasoning please let me know. > > Great, thank you for preparing it up! Really nice summary. > My ack definitely applies. > > If you want, feel free to add a > "Suggested-by: Roman Gushchin " > tag to blame me later :) Sure, I have updated the changelog. I will repost after the patchset by Frederic[1] is merged. [1] http://lkml.kernel.org/r/20230203232409.163847-1-frederic@kernel.org -- Michal Hocko SUSE Labs