From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EBEC636CC for ; Mon, 13 Feb 2023 08:23:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D0376B0074; Mon, 13 Feb 2023 03:23:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45A2D6B0075; Mon, 13 Feb 2023 03:23:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FB126B0078; Mon, 13 Feb 2023 03:23:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 213F86B0074 for ; Mon, 13 Feb 2023 03:23:06 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D9CA640113 for ; Mon, 13 Feb 2023 08:23:05 +0000 (UTC) X-FDA: 80461578330.18.176CEF0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 2CEA01A000A for ; Mon, 13 Feb 2023 08:23:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dD2SJ9Ta; spf=none (imf19.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676276584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=gu6VnY15iu9YfN3ShspFDeEms3XZtHsE+KfdYhnuzCnijzq6i9TaORp0JfKN++xxkiJPXZ E2MeUM8/0Ch2SfvRKzh1wuJGIfGvJv476Z9KAQXZrgBB1H7/T+22aMgpjRHUrko2hlWWiS rVIrkSaZY5JDVeMKq/OMaqQxieA7T8Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dD2SJ9Ta; spf=none (imf19.hostedemail.com: domain of BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b43816e12a84725ed160+7113+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676276584; a=rsa-sha256; cv=none; b=GFVF4tQDPzMwGDMoNk7p3kp80oRQZZ5QsBBxoZtwTGsHAYDltbbpQgb9mj2HgDtp6ILrES KnuTaPsmwpDHB8gWqCOivS1m1yIqN28k/yj5QHo9Kk5/nrbPMTvfKr8ElLWE2rKVxNQ7YO Aq8XyI7kdNvb4O5l+GJ2xGFN69NvjL4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=dD2SJ9TaABf846C5N0UDrOlCQB EuNx8i3aV/Ksu97IIw7bi8WZFTytRD4ewC3EfnfKNH8OVNy53ESGr4nhGu/+/bvyuLDK3MfgCblTR ba+U3UavoaGfrbQF8hIWF53fBKd16wIFZSxhX+Xw2p9p/o7Wnl03SIsIfMHqwWfr8INlhTV6Mcbmx R7a+vaBHfUpox7wZzh/w7CGr8CuDeTSPPe/3W/QeFygMI1sW5/E0h2raHxrw9wxBW68fWrddWDJTg 0og7DsA9dZChrIHOyH3e2Ry3n+9sQ2vneHU3xJkxq+Nn5MCEmnZYTCXi+LlJhgr/A4pGND33owgAY OG+BULaw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRU6n-00DZix-IO; Mon, 13 Feb 2023 08:22:45 +0000 Date: Mon, 13 Feb 2023 00:22:45 -0800 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v13 02/12] mm: Pass info, not iter, into filemap_get_pages() and unstatic it Message-ID: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230209102954.528942-3-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2CEA01A000A X-Stat-Signature: gxwen54bie76hrjsgtq7dw9gikps9jhf X-HE-Tag: 1676276583-151980 X-HE-Meta: U2FsdGVkX18qx0W3oLCThRwDuPPyrcgC0SvkL/I0hd4J8lxQ2nuOXynWpQ1QOqVWcnxMxGECXDVzOoRLpnAwGAWHSjODHvYB8Hx8e0HwQ4SOHnu+qO2Xu52xq6UQPY2U5jWf5Xpx4tggfyu1tF+mD99mRvBmFJxazxcAvov7Z0dBKW9Nx9NC+kOMzGTcOa7yCyqVl6BOKlmZaVjSr9IE3XaCdnLyXeKAPF+WQQ7VYuSvSRzzHlLn9aYBwtqnrvMUGGfDs+rebANwTJEJi7fYGPZkFOakW27CZ9zKSX3pL2OlIXonjLBPpwkofFYwg/km3NEK7L4wIqC5VAQh4uZe7z2H7XtL/Xy4PGde+1kexf5E3XMUPNzQByQeXMpv6H7XisIbavljxuLPcqQlQdbF+VkWA3bhO1epnuFb1x6G6+lbaM3cXx1TuMwZRWbxGY8mECb79vUiADY+etdD4y+/Bak2jJwPyJGRBtjCu4FORTDr0i1JgX06a2De9KFxtvfIPOO7f7j2wVTrT2/ibrwe6EVz45jLSMJvxZaQWx6JXxaRskenjbleCjGEs8doJAmqYzqvG5JWBokURoT5y3ylO27c2rzO9TLhkf0VKGxo54EkQ+jrBrC0zItzxZMpSmgY+a6wBjGqR5O2irsv/OQDYJGak37Vy8J9ckcCePanuE/QpGQztmWPduPBXQIWO58n24xVU7sghjwb+ok9UhALqB6cB2x/ONIRC7DmcI++JL0XhXrKO3LtQwvDxfMfbgsJtfFyPcBFQ3nCSYKJvmO9l53dJwsKCWO07hbyiqo8L8nKwh+400uBzHaHcqQ9e03x7j8St6JW4x+aVhbzDk2Q0bphjYzYNg0BZbaKskXuOlELxSLlmlqOGinJY0mjVESoh+7JUw132AuXuh4WO6ZxO2d8Zo+VlG01MtPdeVppaf0vOZmjRfVNYMOsSBAZtuehHacrfCdQzaH5AeZPGmO l1Q3Q4yE JK7AGWQG3d60VZvDNZjsWjg3CF/tOYvCO9U3bs8R2VEW0WdcM1PB+1mX85Qnfwdruakjj6+duj8exfAZg+ELTQTd5q+viR0g1N/+xLDdsfHJo+Az4HAlpqVd5A40bO0DZ300vR7LsGY+KdSajZTYvcKurB02W0n+fONhbfEF23tZs5Zhl4lRwEGhUcy2pFaZ9t0PFVmPXCoNU/kXBbap7q+N+G5fMm/i079jiJ9BwuADtYEQQXKSvYuZHAN/9Y29Q1muY11G1r8/6Kg3YDaKiII5Qz4ujx6caHa/B7YlQ0L81kc/8opLptzSPGscq/JwvT6UnXSI8H8Ip4+ksyEa+b9c+SNn2YXFXycasQOWWGcO2OjgycrRpsczBTq73GokrPXjmDuTY1dc/3z04SdoTRa1iKl4pQWfGPBPj0OYAcq509UZS1NFMzFa0WB5p7dNsyCa0MvygHhv0+m+vuG3Cx+FzQ+bSVyKBhLSkAfI70oM3Ilx30mnZjtzNHGOJSPbPqJrR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good: Reviewed-by: Christoph Hellwig