From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08D5C05027 for ; Sun, 12 Feb 2023 23:59:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA0F76B0073; Sun, 12 Feb 2023 18:59:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E50916B0074; Sun, 12 Feb 2023 18:59:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3F736B0075; Sun, 12 Feb 2023 18:59:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C153A6B0073 for ; Sun, 12 Feb 2023 18:59:28 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C1F81607C9 for ; Sun, 12 Feb 2023 23:59:28 +0000 (UTC) X-FDA: 80460309216.16.3A7BD02 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 6ED651C000F for ; Sun, 12 Feb 2023 23:59:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gvt73Cu0; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676246367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0LoPt0nhvvdTsFpNoT8Wq47nyEhSkAz3WMtQu6kQtW0=; b=T8KucLUkMZ2CMpO0ObeU8gKlAP5Mi6S8D0WlW4pdf/GAi+DzgTFxyrCbf6GSQrRmkH3Rqy i5O7JkLDyshZCzJ5Zsf34yhu7e327RflYGa4O5gdSsymZeL5MQ9dlqfHq4xQumD91UUd85 6e+KDIPBBNWT9PumKEDB3H9sZeJzp4g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gvt73Cu0; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676246367; a=rsa-sha256; cv=none; b=rk1v7ADjZUKbTFXlzjywCD7qsfOGBSGXw3mnjF357EahuC2MASD/T5FMNBDowqak5bt6dC 93DHBH3lYuEsV9gB4nT4XWohfdqWxpae8Yqv9TRb8w2Qw3Qep2GKU+1UDIJjFQnAAo+5H0 uFI/+CGxwMurCZGvFp40lJOvJcvPZ/k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0LoPt0nhvvdTsFpNoT8Wq47nyEhSkAz3WMtQu6kQtW0=; b=gvt73Cu0QvUxzxnFaXYgG7QhBk wa6erbb7dXSlqVs2qMVu/umJ+OnL0ZdywbaYNMaW0/Vy4OgIQ688SxGcs+qYf0zLnvJ4CChJO5LXA K0hw021mrwzRoIFa94/pZgBfpi2LBBhjVZ/AB/57DKJGtLjf4UfwwkZ4dWNNDQysMEaK/EGmD9hLm sbrgBM7YzVCNUJ1to7GX+7bNtMz51udYxCM6wordio3G2Nff4O+xml1Yiy4FpzOeMhIw1+CGz2fzC rnSZ0/O3IQCOuBstlxaPiywTVNreqIMI5ezcVbBMc0GsvBpyzNaMj2UTU9dKU30JJ9GgrsuWXzYlp tNIeHkFw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRMFe-005HPA-Ta; Sun, 12 Feb 2023 23:59:22 +0000 Date: Sun, 12 Feb 2023 23:59:22 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 4/7] mm: Remove ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO Message-ID: References: <20230211033948.891959-1-willy@infradead.org> <20230211033948.891959-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 7qirw6s19ufnczub5seza3b9adb9anta X-Rspam-User: X-Rspamd-Queue-Id: 6ED651C000F X-Rspamd-Server: rspam06 X-HE-Tag: 1676246366-149558 X-HE-Meta: U2FsdGVkX1+P2tZZeU2/MArLWjYn0Xga/vRql26Av+bF5LIW7ZlvrvHlyIy1BoKZVtQGjqBb4pdMm+Yx2ExfAY6Y9aFO4rc1y83jZthet9t7ubgH2SqKiKLylSz+5SRwwNqg2bY6brD0vOeYw3SuDjMlS6G+UNKmKL2GaUOUSogt+MUTEXvWjDuVCfp0Si3XfOMJ85knbM8tEAJ1z1jaf/YYnSKanQD/NX+4r8CdkyHdhUbdGDVR897qzCJYq3bryD2C6EdO4Laj0Qs1jblPIlBPhbQ23ZHkBB4eJqivKPL7zVUjKNcLNKaapWtOtDoNTYpCxcURwuBh2y39KvgiGu10zh1pflwk92XmsqiHkB7pgu3ZWn/m5rOVHA4XyDZszoA0pSIYd+UfZFJaIvQ+Byr/2m/gveB2CNNZUzX0BWRPD/dAowB2zYHVq6svq+APdLNSN9E6yZkPHnw6GmAJvlJpu5YdPYw5YwKMUdvoyuOU3EztCVER9GbUyKEKgYWobqaM2/oUORfvv/fOS9v0jdLU8koXsgHAH82XJxi4JIm5ZYfTxa0ifp335RYWcnuiq4fX9ycl0FBmSlEm5AfMexsmFC64ePLrDBFycadDk0mG2Oxxja92R1TSge73eQAKPmn8p04EZvu9ixeNe5PjVhhg5/SPct12YrEyUClo1cE0H9WuJIh6SCfR+w5XNY5LjnfSEpkRuYabU8YlSUavSMWwRoG3am7mQmacqHOxMucMmsY0f3JkEWZoNS4YDgfZS930HAnceo2K2FO+UWNWCDkAxKIH9FxauXJ6E74lzcZmh7eSk5N3Cqc6EaGoYsDWHLM4vGP3cCian9I7wE8fqAVEuxqZ7Bhz0rKt1ohYohorfmLFcUU183GJEdHkOQPypAJ7cVpZ6RiOIVx66kUfMK/C8S6j9vYnaTeSOQ54hnhVUKYPZWJUsl4Lr8btHpRzSxlF1D0m6ggnS3i0y9c iZnazNho wQJuNe0nYlUBwdzLPMeAtpN5BeaVEt/OOTXOI/cNhaz5MSZnGr3FJBc+NLyi9K9D+fATGtH2gc8gTl9bKRSPRmEv66DxLtf3uCPy1oUevHmvuYHUGXO6qrSXy/33FuqOmJ+U2KOJKSC4hQD0yOCxUFeThAB/J9Oc6NHkZ7bWe0mpIkbSdVm6QuuFNRv+6qLXPIbczfkoVDJCOAZJfZXIGkNtd7JEXkesruENIGXOjoGiyWcFHnm+kVNsTESg1ilNBTv4V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 12, 2023 at 05:51:18PM +0200, Mike Rapoport wrote: > On Sat, Feb 11, 2023 at 03:39:45AM +0000, Matthew Wilcox (Oracle) wrote: > > Current best practice is to reuse the name of the function as a define > > to indicate that the function is implemented by the architecture. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > include/linux/cacheflush.h | 4 ++-- > > mm/util.c | 2 +- > > I'd expect a change in arch/ that removes > ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO and adds #define flush_dcache_folio > > What am I missing? That not a single architecture got round to implementing flush_dcache_folio() yet ;-) $ git grep ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO arch (nothing)