From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8ABC636D3 for ; Sun, 12 Feb 2023 15:51:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 770416B0074; Sun, 12 Feb 2023 10:51:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 721D86B0075; Sun, 12 Feb 2023 10:51:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E8B36B0078; Sun, 12 Feb 2023 10:51:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4E0066B0074 for ; Sun, 12 Feb 2023 10:51:34 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1BE26AAEDC for ; Sun, 12 Feb 2023 15:51:34 +0000 (UTC) X-FDA: 80459079708.20.AB02CD8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 68D26A001C for ; Sun, 12 Feb 2023 15:51:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PbLMAROZ; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676217092; a=rsa-sha256; cv=none; b=u1RAVp1hqLlgzK8VNTOJ9niK8k8tOgq7LJFnOpVUEyz+/nKOw18KhdIMf/dKJ2HFA7uoom 92++cC3PpyrBMBS2liInssmqeY3iEXNjIbw8DV83rS3j1J2KSJChv2MhsBn4gPJRSN3b4N EWp7qxbz6S8NSAuC1CjBmByW+qL8RdE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PbLMAROZ; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676217092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypwQCNPmPwMowwptYwx85jnG9Yqc9tlF0vmK31cALWU=; b=pM+DhfATUTOAsbuxl6RTTxKb985WnmUAEDWZ8zuEW8UQjvyz/jss5LhmlmSS2EJqIn2O18 GcKH35/im5KDjk35XVAuhPWJ+cGLlgpNKIf8ADHGHEg3k8UXybWv5RIuxzegsvrF5RvvYj LVsu+x2l7HijrcwQJx19ihBGDf/HKvE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 428CA60CF2; Sun, 12 Feb 2023 15:51:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49E16C433D2; Sun, 12 Feb 2023 15:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676217090; bh=ETtghzt2GtCgdTJuGSePN/aSkjSfhuJOAPiOwP8SSS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PbLMAROZkaKtskdecmZ+f23GLJGXH3qXgd3JY5T6K66bpmahYh8/FzF0KOCnnJe5F MvmMb24tAMMskvogOhr4kTxpU+hL7as7QjdlF87+TdMwMoAja8iIg4jvhS4U19n4K8 Hi1G+rzyWqdvZuiTgVM5nMyGd4EEw7Wx31THm0qZUBQAsgc8tS08BdT0NvcF+PEHVI qzveL7zhPkqq1DXiQo6AkblREhwWje82wh0mtBJzGXzq3u93Im5jZoj7Ftt5T4XLz9 ++kr+tHAc/2QdsRUWvISnevd3+Vlfb9D7ke0tEEvUKO4Gc1Vjga6U1Mzy5dsEun+s2 7yyVaaTuamKOQ== Date: Sun, 12 Feb 2023 17:51:18 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 4/7] mm: Remove ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO Message-ID: References: <20230211033948.891959-1-willy@infradead.org> <20230211033948.891959-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230211033948.891959-5-willy@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: 68D26A001C X-Rspamd-Server: rspam01 X-Stat-Signature: xrx9yp96gswwmihyagyjn75u1scedhq5 X-HE-Tag: 1676217092-760544 X-HE-Meta: U2FsdGVkX1954XE40hatde/4Oqgb4KyYbatZ3ePqYWB0Jr9SsC4gh0xA+A39+R5cFqQ5peD93BXuMxotIKMPViiVDL5s/RX5etdhWhfERJdDPWQJIKc5JTMRlbmcXVxUpqxOh1axSxPUuQVGmcrjQLGsYbwT1pzwO2cQWdp4LDXdGYWTXFcqeriY8B8RzffwAFcnLULabj08KCRRTWSryWqfpjyugsmxD/AqgKMSWfZ/dNqRenwSQDcoDH7Gm0XHlByf+/ZpJCQdbCmXwhNed128A+0jfNzK/a3JEjCKwM/s6+H2Fllk5XYWWk3gRgKJPQyKFeVef0frCF6jDmOPxH8YbZdY5jgt7g89VBbOH8RI+qaOS68osBGhJPqy3hKoQbEytDFlC6CVitqu9YgP/fL4VBmSG6t2PRUj/hIn3zamIxLAxviT3S00cNA9lySbNVlv3BY1C2x0s0bK6v5VJATfy9NibJp2X+p2fD1k5nrHY2DU5tr+HehPDFzCZ1MPw9CsENCJ9fGYiBQDqWGUUlUOMie9XVemfh0Ush5PnVnUDkJAFjjoNdV25p3zO67yV0y7njwL9G8RSOi2MC090P3NOithTe8E9vlrVcQcLs7u/y+3NeymSt9xNQWsBRy5fDtXGQ+AgUVOvHoKNlfaZLSKD/O2Q9dWaX8btsYQfm2zlQP+cSn53F4Fj6Am437540nZcqv46YtxRDinYeBDJXNmtjFy+66zKf9uredIApDfo85wTM1+LD18c1/bzKiWqtuRDP58nbZGrXj/uduqyLXZ8MczK/CJSQlNFzzOt9K+Md+qjprHTu/9rvIfKELzfnu4ABRIBaYm3McbGCBrC57pPmjJ0SkmI/WL2ME6uuA1FxpkbIorrJ3tXASZbnEt2lcbaKBqN+JS2r3brozUWMkO+Ez+/5NM2paoI1cF/Tm2gPoELtEJloxhFJtOrg8kt1cLpC5UkukadgkBrl1 hVOp/9pU 6wb7xYUjyVQ01G5nosHIBDx+NnjZftPJWO5/dpNIL9SHeJHiX40qVJgFHx5VaiDn+xSgAM0ti88PenVJ3xU9tcpFQuELrogFw4iEJsgv3eTahcYZESUbPexM79yfOPmbnX7fllUiwpfejo7FrU17llz9kDkbDSdGT2WDfMOhYUFfm4HxynDWiEKqqnX3KAJTTgbdZ8b0hlFZX2XkiPzTvfzY41eeFCquY7vsQ/lY4k8Btj26n0ypVoNlXMgNR9KqAsHzHl42F7Sgq8qUEQhuNKF+87IE2xu/Sb6gFsAqJuXzkBu1ADhmwX0yAg8dxwnUwhp6EdRgQRNQWmLJtZa9Qzlf3mSVxU3AogWkDCf8tACk3ptiuYeAOUuDFGeRGGLFvWEDF2bIYbUZGKkEd+lKFocScERxFYQqkUKDc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 11, 2023 at 03:39:45AM +0000, Matthew Wilcox (Oracle) wrote: > Current best practice is to reuse the name of the function as a define > to indicate that the function is implemented by the architecture. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/cacheflush.h | 4 ++-- > mm/util.c | 2 +- I'd expect a change in arch/ that removes ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO and adds #define flush_dcache_folio What am I missing? > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/cacheflush.h b/include/linux/cacheflush.h > index a6189d21f2ba..82136f3fcf54 100644 > --- a/include/linux/cacheflush.h > +++ b/include/linux/cacheflush.h > @@ -7,14 +7,14 @@ > struct folio; > > #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE > -#ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO > +#ifndef flush_dcache_folio > void flush_dcache_folio(struct folio *folio); > #endif > #else > static inline void flush_dcache_folio(struct folio *folio) > { > } > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO 0 > +#define flush_dcache_folio flush_dcache_folio > #endif /* ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE */ > > #endif /* _LINUX_CACHEFLUSH_H */ > diff --git a/mm/util.c b/mm/util.c > index cec9327b27b4..39ea7af8171c 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -1124,7 +1124,7 @@ void page_offline_end(void) > } > EXPORT_SYMBOL(page_offline_end); > > -#ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO > +#ifndef flush_dcache_folio > void flush_dcache_folio(struct folio *folio) > { > long i, nr = folio_nr_pages(folio); > -- > 2.39.1 > > -- Sincerely yours, Mike.