From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8270C05027 for ; Fri, 10 Feb 2023 22:41:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 498836B0206; Fri, 10 Feb 2023 17:41:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 448B36B0208; Fri, 10 Feb 2023 17:41:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 338A56B0209; Fri, 10 Feb 2023 17:41:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 23B916B0206 for ; Fri, 10 Feb 2023 17:41:24 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E0C28807BB for ; Fri, 10 Feb 2023 22:41:23 +0000 (UTC) X-FDA: 80452854846.04.BEDBBA9 Received: from out-212.mta1.migadu.com (out-212.mta1.migadu.com [95.215.58.212]) by imf30.hostedemail.com (Postfix) with ESMTP id 068548001B for ; Fri, 10 Feb 2023 22:41:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VSbngdom; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.212 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676068881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lRNlMWPKMrHGMSAjAROsp0Ofo1v27P7a61y4CnHrCcU=; b=V0dd+ky1t7UYq291cLp4KgHV+IoRJ9mY2UmvK9LINSa4J3ft9jrx+1rgqg2fzObEgvJuLR w67XqE7JAAXEr2tXyGNHQx4kVLQtH6ROyiskGd8sY7dtUz+tUGdTH/BWkqbmt3tDb1EKz1 yi0BDCFxagpPF14PyOTHi4rZjMrTIiA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VSbngdom; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.212 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676068881; a=rsa-sha256; cv=none; b=1t6xSbNjaMzAv7dVtNd9TFco6qZPyqENB1c47thuQRSIRAqQtmFAAVzcQllYdGpVH0dT7m feb+YdV8XLZvgMtmo2kaec6LHkksMBXqxSGBrmVSxacnOgJMdsxBaDJg12xqngBjfU3Rg7 LHA6/vpIB6bELcekN18YKM9naA6i79M= Date: Fri, 10 Feb 2023 14:41:11 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1676068878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lRNlMWPKMrHGMSAjAROsp0Ofo1v27P7a61y4CnHrCcU=; b=VSbngdomBIa9l6bdRYKcCSWYvfOe/8rxdGevSy1qXi9jj8pn1oVxugjQyeoOL85fZE293S u7kccV6Pcyc1GFR49zN6LhRnm7tiSAzPJZntOZc2XZGPDOBr7uX4kvKj1cz2sTZftAghiJ IV8QJqENVhtLeWRqJvGSd7tAJFYefrI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yafang Shao Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Dennis Zhou , Tejun Heo , Christoph Lameter , Vasily Averin Subject: Re: [PATCH -mm] mm: percpu: fix incorrect size in pcpu_obj_full_size() Message-ID: References: <20230210154947.4460-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230210154947.4460-1-laoar.shao@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 068548001B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gxz8jszhsh4psdh6ay5kuptr36icy3au X-HE-Tag: 1676068880-660043 X-HE-Meta: U2FsdGVkX1+V6hmljqjIs1uZacn1ro95gFX2nmG1yQ0GDFs4IJmbOCm95MWsvYK8udqlS7ZgCK04DNFpOIiV3OyVE2EgOIx4usM60ifdBbLUT6WJmhID0r3Dx3BYkM7xuHEHtOQTRXrX5DC4UDyazMTWrMrAH3QJ7H6Z1ybB09rDA57hEC/JzoDIeHPp5Phx3qP5tKz69QI9qwSdFn2+eWHdKKfwFxS77s+eTvT35laOfymVYzFbTLA4dwcNrKAGVXQhqSO2bmjjOTDJFgeJ6cbk1xWSIHC7a3ZROUzXzJo3cpjHXfGirH8x4L5VGX/eVSYCaM0hkv+o3ANSOzzxMqUu8UItEsxJSWNo6xlHqZki9mdPS7vTx6dQp6jJ10j1HIyRjfmEeXPTwGOGDF8E1n9jW8Hxabs5+4gy+Lg7HK2xRkMmGT1eT+RTPuRdGJf/YPkuJjUfYkPZT+jEjhyPs90nlGjajP/v5IjixlwsOfrkI8/aP3OJQBoAcPHBix/XiOkmz2EfDk7xJE4go5m7onlLz7ke3rsbmtmhYfmxF6hf2Z3YPDnmu/qpyyDFPoio2duTwDv6/mrsCpKNcaaBlEPvMONxyAGoVx7FxV8tziwKiYxWIK7AincLKnp8wj/wIswFBnU6w+HegrjBeT2X57ZJ50RAr9mAdN324kfz2cETvCHZbg3yJPi2onSXjnQkVmQ15AEjc5jrIMnArgiyBb9r3DTgC1JVUPV6SSV0LQbZf2/NKEIhnR5Hs7ZYwfxOoax2NsfofI8fqGrbGU+8Q7xaL32AAWYJdQJFEbMcin9Sz+/HHZ6orUCMcTsrJU8QkdZaDV+KR5EDSMHofX1T1S+LjObWEqkgbvHN9lYTcnOiNRAU3+caA38TZ+ohrlCjGa9ZniSxEOX7qb9vtnTZz9/f9Ssym/VOOm48JDAWK4OhYoUIVjuWecPrDuSuy2KJNYMs9QUrjsM9Kv+7GOJ taR8hhA+ rNuUqp9IUYYxfkE1gZbI4HCmWwpls5tL+eLEPmx07MVJMTQb8aKtXuwoyZkAkzZm+KABKhgEvWPRRgxBCQxkZROsjagnmUHtQUwu92G9KM3vXGvxZ3ZeCbmOMRaY0eyuMoBDRzYmYQp0D1puyyvYkgj3bL5q8t2AuSI42UHMS9eFE8oBr00T6j7PLZAxc1ywu+TSQdifwEyV6rBDD9JhOILAMIML+UeBs0JZ15wC3lh23rEE7lAc8D50XV+pEsElbyis5/UNSITlXMSZUffs0cPUOeKxhwAOBQNXuhzsAEBrx9/25bgnVn+WD1GKPy9LW/ExL/Uu3v/ub0rMzqVUmO6kqV0/Y3+tG9ABEcYwRA8BJysrcvlliuFCs40bRD3VoEKqj8ATrQCTx6R2GE2ndKTAIslfF8tHGxIS4OoA7UI3huXbZIG9LrNU+AL4N8xWyTyo6Yrynsv99SnacqAWRUgOtUhPrqhRvIfEvKBDOyLfUihGUvUkaTKgZrjmlaJVEaKiuduL7ybDKkTA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 10, 2023 at 03:49:47PM +0000, Yafang Shao wrote: > The extra space which is used to store the obj_cgroup membership is only > valid when kmemcg is enabled. The kmemcg can be disabled via the kernel > parameter "cgroup.memory=nokmem" at runtime. > This helper is also used in non-memcg code, for example the tracepoint, > so we should fix it. > > It was found by code review when I was implementing bpf memory usage[1]. > No real issue happens in production environment. Probably not a stable material, but nice to have it fixed. Thanks! > > [1]. https://lwn.net/Articles/921991/ > > Signed-off-by: Yafang Shao > Cc: Dennis Zhou > Cc: Tejun Heo > Cc: Christoph Lameter > Cc: Roman Gushchin > Cc: Vasily Averin Reviewed-by: Roman Gushchin Thanks!