From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECDD2C05027 for ; Fri, 10 Feb 2023 05:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E47E6B00FF; Fri, 10 Feb 2023 00:53:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 394C66B0101; Fri, 10 Feb 2023 00:53:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2838B6B0102; Fri, 10 Feb 2023 00:53:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 195846B00FF for ; Fri, 10 Feb 2023 00:53:03 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E6A7B141344 for ; Fri, 10 Feb 2023 05:53:02 +0000 (UTC) X-FDA: 80450313804.25.7DFA663 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf11.hostedemail.com (Postfix) with ESMTP id 1A6F240007 for ; Fri, 10 Feb 2023 05:53:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KqlyxfWj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676008381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r8a69HEYkh1oQvGxe695mWtJAwhwUUM7wLLsEJAlx1U=; b=rdMCSdSu2qCgsV5fpbXzDRQwXaJ0cSDmedR+t69OpWDaZPQ94A1xfzvvRlZ0BkvwlcCj3l UpaGYljMdBKC+rm+LmwmoYHlCZ2O5psDhgnUU0WPGyhXgKQaH+cNwLXoiMjrJO//zp8jha jrd4+95IkGpVmfL2JNaHOV5pSxiDwW4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KqlyxfWj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676008381; a=rsa-sha256; cv=none; b=bkizzJs71EA66/J2hsk88YKAP6haUrhkkdT3slqxMEme+DcmJSRYIQfcAfcImTXsiXseAD KJY5C0MiJqMx7o3AIM3JFSpkbkmS5gsZIafDnVbi/fPNNOf2FApfGBgdywZM0t+qvRcEcf kKz1TnQOYGbd18vDJPJCqyMCSWYEal0= Received: by mail-pl1-f174.google.com with SMTP id o8so3060846pls.11 for ; Thu, 09 Feb 2023 21:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r8a69HEYkh1oQvGxe695mWtJAwhwUUM7wLLsEJAlx1U=; b=KqlyxfWjqGDVE/MXDWllO7DsPw2/IY8BO/Ij3Rws+Rrz/ZHtbS2fMRNelKoJ7lfZkg VRxI9OauzRrZShnlI9dHI1QOd7+lXwYrKMUS5zqbzRDz315mr0x7jA2yEF56XLpa4vyg H7qLD+hgx5kRmwPZtjeMuPDUCXASeGeLbrUwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r8a69HEYkh1oQvGxe695mWtJAwhwUUM7wLLsEJAlx1U=; b=IWX3+4liTA6r6pMdcocG1uNE6/sEWz//MVfIo4L/xhTIu0QgVjyw3zqmJIQnzD1ZoE IhzCak8vm+MDOzyiSJSFLqWZKLigwz8jWcglNAbwFxrHbacFFSL/IMRHAXv1X4WQNWyU DVOBOtzfXOtlh1HIJ19Y8KUTPVXfsz4WU3EBYqpFfKmLu4rFSUj40XzUC9teDBrwb/h3 tXrk8uVPipluhLfqPg2zR29LGjx54RQHMqIzzB3SVUl4TDvuYEm3sLIph3a0YCbUExLN M/Tgg9mvo+FHUNkg961r9ECd6azcGPqtzH+cWkR9h+9yO3M+VC5qDfJfRNysVXBw8YvD 6tPQ== X-Gm-Message-State: AO0yUKWQZhscnzyTnrYYVx3LDPlSvpctIyWhgwu9wsI95+cWv2ha5XOD +9YPHKuWmdfhDw80jYF90xbwXQ== X-Google-Smtp-Source: AK7set/Nnbh0tPoL9KSBfOCad7/dCn2+vZN4cSn5tXxNkRawo3thm8lpj1DJfijTa2b+CcSzOxvatQ== X-Received: by 2002:a05:6a20:3ca0:b0:c1:344c:668f with SMTP id b32-20020a056a203ca000b000c1344c668fmr16020692pzj.12.1676008379916; Thu, 09 Feb 2023 21:52:59 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id g8-20020aa78188000000b0056be1581126sm2474167pfi.143.2023.02.09.21.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 21:52:59 -0800 (PST) Date: Fri, 10 Feb 2023 14:52:55 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230206092559.2722946-1-senozhatsky@chromium.org> <20230206092559.2722946-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1A6F240007 X-Stat-Signature: dxzr35qrd3ifzq1hhses1escskhwpuf3 X-HE-Tag: 1676008380-895663 X-HE-Meta: U2FsdGVkX19SOSZPkNt9fp7TH2dQQFmngcYx4z8WEWKqu6b2NxGMtAMlL2IHcux0uXjoeEFrbunqc6ObS5waqm3JOGwz9vwnBThcfdv182Kq8OhXNKqrir05vIpSUkZr7YOEjvxi1pDt2FLHaEdDdQdA5+lofkNhm5X1XaNOba6aT1vh5dPvQ1v4U7lCDLio1NjE5SeMOQIqM8x4PKO+r+JUP8lWuCmVOhIXNvRwrxY2aqbDva10T14+hs5wouHbOQcKnNc4jhHk1+HWkqAz/R07SKGzm+EzMx3TDDQEtBNA9PjnGdR6jPWKLA33CuG1Gwc3XuyBL7WP7kFY36Eptoq7hz5aB5qfrJUiA0d9HwXyEkhP95O6bmsRJU0zwgaAa9Qy11cWNaWFcAD5WAx3OKbOuKeytIATFbAhNrcemj0l2qs1HtXS+UsknK069VB3YzeY78zCrXqZH8NZkbLxNqZgvypIlnRIhU0FLKnfBvMNaj7jt9QONAHEK3lW60JiR9J07VeGUTnTJFpcnmiY7GB6wCUbRpVUD4FZ5qHpsWgkLYQy+kNlFvkf+YtgDI6mmjaMHa/Gh6plafCcMGZW8Rc5Vyh2L+w5DapKNcAhMmVYZBv7fEyz+mgZH7RWilFNuAujx0MNRN/WqvQQcpYGvMMzGCcCbaSZSxj5WlV/K6+lPPBCleKvXIlNBcrS/nKHkeYeXBnYf6PPG+98MzCp59O8Flz6fNxnjE8e3n1U6xRMmdwaa3JJZYP/ksJlPg0G5CK4VrmPHTR4GuWpIAL/9+XnZkP/BWhwl6Ub8eBYUOxJvOdOgEJ+/kdkkF40t0O6EmVq8XHiuyEMLU/Vzd+xrsRTWLDkCNikWZ3AYbonfPd1f7oZezs3eUxWlF7lIWGgosEQdB43gTuY5DZf+CwYqvA5Qcez/5db307T3hH22mOv4abEjWhrpJqf1+oAs8s0EyP/XbmA8CYoNLTZe6y 8LDFPB3b Un4baV8B/ylOIEn6H+hrm2KkU7l/92EuO3NlA6bnF3e1RsAIpJ8niZcGMF06YkVw1dBzqA7zp5Pdf74GXLWyWMrtKcB2AQZIKWLN2F7d5CP0fZQeHzdgvkutzG1ZFHNcTsWxr5aXynSCTG7VTMPWqSrMOGipWl1SBuw/nuYnYkfSWRLlJMbwHJAriCxmJqjVJVFBbADF529B/p5g5uPM9lHVm0d/zA8AunKGXtSoqMm7XR5CWudzbO/lW/JK4vEdpdLjJ95d8Gjk98PPh3Edfj0HX4zsnPXFspuO4SknZtnco14D6iXnkqIpMTSv98KMp8W7HI+RMH5BvZhkfosKoThrFwIJrdqsJgGcZWQ/iSlXg/QeJ25emi+P9KQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.112786, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/09 21:15), Yosry Ahmed wrote: > > We need to be able to do zs_stat_get(class, CLASS_USAGE_70) or > > zs_stat_get(class, CLASS_USAGE_10) in zs_stats_size_show() to > > show class's fullness stats. > > If we use #define FULLNESS_GROUPS 10 for example, we can break down > struct zs_size_stat from a single array to two arrays, one of the for > fullness groups and the other one for the rest of the stats (e.g. > OBJ_USED). We can have different helpers to update each, the former > taking in a fullness value (0 to FULLNESS_GROUPS-1), and the latter an > enum. WDYT? Wouldn't this be more code to review, maintain though? I mean, what do we gain with this - fewer values in enum?