From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9ABC636CD for ; Fri, 10 Feb 2023 05:47:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFB5C6B00FD; Fri, 10 Feb 2023 00:47:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAB806B00FF; Fri, 10 Feb 2023 00:47:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4CCE6B0100; Fri, 10 Feb 2023 00:47:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B30906B00FD for ; Fri, 10 Feb 2023 00:47:48 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6492E1213EA for ; Fri, 10 Feb 2023 05:47:48 +0000 (UTC) X-FDA: 80450300616.23.E1D975F Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf14.hostedemail.com (Postfix) with ESMTP id 90608100002 for ; Fri, 10 Feb 2023 05:47:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HEZLiVHM; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676008066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8AOWh5FIT9l+ytkQEtsn/0BsGE5ItnlbSB8SdkHKfew=; b=uDfbq7/iQxImPGXbu3AXME90TX5GRJDP8NaYGYWeWTUeT0xx6GoN+r9Ml+AfW2zNd5EG7w f5ytXMeihjyXZOQHHHoMkfBW2fMUOnWHYhU10ChS36q+sEBiqDyu72iV9Rz/zod/GpvsfG KSVLkZUXOcBWrgXoOvD7k6X0svYOee0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HEZLiVHM; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676008066; a=rsa-sha256; cv=none; b=wbUiSYepAPOVZrpJ15vnQ7rpiXgnWeRp4Zv3B2UqmeWrQvFIoC/I0kh75a1VW9aEnQFYhU WuSOxmy8xzp+hig/MIQB2oeHQcYRzrHuZ7+JgJY4WEPmqhWMiz5sNGK8NwCucqj/BJAJ/S Oq48WYdfgInbHLK3RdAM+SnI+LuvDQs= Received: by mail-pj1-f48.google.com with SMTP id f15-20020a17090ac28f00b00230a32f0c9eso4512393pjt.4 for ; Thu, 09 Feb 2023 21:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8AOWh5FIT9l+ytkQEtsn/0BsGE5ItnlbSB8SdkHKfew=; b=HEZLiVHM21ej+uZAeh9u3n6lcfIjjxfzBaiacOvUbXd9poXIv4rOXhyGQ7ckucUDPD 2oUYgMQrBQgL8IUOgWiGIi5iFQLndPomzhyCop7/cGcAmX85i65EAQN/gzcoU35YLmm6 rJz4q11QfO9fsac2EROUUtVRaWtKht8BnCByM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8AOWh5FIT9l+ytkQEtsn/0BsGE5ItnlbSB8SdkHKfew=; b=eqFJeUj5Op0AQejgDc0XsNDYy8B/Ro92A7Et/kQrM3nRg15j35YQpjCirvNrH2EK1P be+JybP8kzZdZGYh1hQT8uvHYnoaaTMDPjr8cWy/Aq1WtW5DVRxwYh5+1jrcroKFehhC TNc8GAaxfAljZpfcsvYTdOgHcLTgtN5Hp2wG7pHdXl8e8EDQQVud/JA3erZnKCXBpJ1o RqRdYUvr9jvNJY2KORWZhA7pCSKZCU+l1/AtY7qvHioRhALTfp6IqxbWTm9Le94fAilb 9GvRoU2ew86PYqjPPE79f8qPS2eObKvv38Z4XvHxbPpkVvBAjsRCybRmBgQ1taPd1INK 7WfQ== X-Gm-Message-State: AO0yUKXf2BaymITxwkqAgjg0/QeAkos0Y/DXcttLkLbKq50slH65YUh+ bOGJfYKtwdGCGEcklAVSSviiYw== X-Google-Smtp-Source: AK7set/QW7HoJeqcF6Mo9eFz7CrxaMTf6JVRoJWLEPu0Mf1tAc7uZYnwwdWflmo7mKLAmuAgpXL5Fw== X-Received: by 2002:a17:902:dac9:b0:199:4934:9d31 with SMTP id q9-20020a170902dac900b0019949349d31mr9658586plx.20.1676008065432; Thu, 09 Feb 2023 21:47:45 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id v8-20020a17090331c800b00199023c688esm2491029ple.26.2023.02.09.21.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 21:47:44 -0800 (PST) Date: Fri, 10 Feb 2023 14:47:41 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230206092559.2722946-1-senozhatsky@chromium.org> <20230206092559.2722946-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 90608100002 X-Stat-Signature: 8gwr56e55epbwojh4ybo5mfk9e7qaubb X-Rspam-User: X-HE-Tag: 1676008066-904606 X-HE-Meta: U2FsdGVkX1/pRtjR1B7uKdYi4NmKg8bmm8SuJ4yenHlLpg4BISECsckSbhOgmDo2LuEXz4dLvbxjYOVEEaZfIrwgZohmORmtvq6ShvCsBQL16OH5uIwH+El8ZHoWu4AZlgW7Hb406OXTQEoX13UgGbKiTOnJ4rdZy56qywr2XN/e0W5v2nnlsveFl1YtFA2oyrQ5ytqs35dTmt0JplDdkpcu5ufxjhO6azCFw2YNAz1mUQbZqwvg0qAdlZyGXS85Z9Q5p383I+SWnFuZVfIIOhqRDRZiMgiRYiCT6zoO/OtG9y4ZGkMm2boC5NL6WSkJeZtXUhE6fP0JFNqDJpUKovr+RxH+Rk9hyLvmgI7yyoXOJW+wmiNsfxEWssaWTRVe1dAvBUlLcEk1HRg2x1uABWgGNzAaN/qLvN82o5068Hfadn2kjE2W3bxzRdf2S/cWmq449lhf9WZOmP68GhJWJMIunWRkTm3rKIkwvzVnckd+lG9GPZRS1W0pmn6Ua6mYxQ2LvaWc2l55iPGer5zeR8n7/sTu+r/iX1wQvApL15Z99ArBUHYhuwZtNv1vvn8uCQ9BhXBRoeSsdfHuHafT0XgZEh7s5u3AP5aTMkpcHBPxaRTXE9M0o/EtMYtKMkV6MyGpA+PrfwCqDziYr+kFN2qwGacYjXA55qi8nDdrIHY94xWj/5M8G8XDg+uBaWMAraLjZBfUohwIAn6JaneNMG44yC5GDPRiJlVzmGUWH9RCNeS6QDXkKbANxraB3EFaqoNRogwZRXxYcEpNqHlQRM7wgBYbaYRRpRrTqQBiiqvFSSguiMbyXRjsorLdTXxjhoVfCMzD37NwRHTpLHmarQElADQceuEb5HT+L6Kvr6X6Vs/+c6q0QChFLWcVwHu59F9BTnBJGsE3oQnpTg2HVhg9U8eZOAG4Xo5eP+e+Pg3TqLsSTiDg3WMEdVAGaY8FT7B9EfCsxTaxcKBRsRX LrprOZ6p Inuy4t3l7uJkLFfes/+x/Yh+eq2p0I81MEHhlPyjWMAwUNhJvPkRylMjaS13k3tdxjeKSlvbxX9wigBMJ1PLe7y5FiUJoYuyj5jdkCsOCHJJ9+9tB8J8CpjOhaM/thshb2HLjSeIAtU0UEIjqeBnHD0vbGeWmkaiuAllZVZKAV8n94mSNoE+bshR6JROHyLAKU7YpBRGm/m3Zh8u60gUWjxUS592W3LiEEZwkQunVUyWguvXHkEFggRYmvz7bG2Uk0xcM+/8mlY/06fKAlqlTcxmp7K23cFt6b8FBxnCfjax0BVfC1Cwo0SS7Mm1o5h/pPQ+SASDwCsnyZYkT4ogFwi+wbmtuluGbqLOSnIGmLWzZehw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006937, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/09 21:15), Yosry Ahmed wrote: > > > > I can get rid of static const arrays and pass "begin / end" group IDs to > > > > functions that iterate fullness lists and pick the first head page, but > > > > I think that enum values will stay. > > > > > > Do they have to stay for a technical reason or just to make reviews simpler? > > > > We need to be able to do zs_stat_get(class, CLASS_USAGE_70) or > > zs_stat_get(class, CLASS_USAGE_10) in zs_stats_size_show() to > > show class's fullness stats. > > If we use #define FULLNESS_GROUPS 10 for example, we can break down > struct zs_size_stat from a single array to two arrays, one of the for > fullness groups and the other one for the rest of the stats (e.g. > OBJ_USED). We can have different helpers to update each, the former > taking in a fullness value (0 to FULLNESS_GROUPS-1), and the latter an > enum. WDYT? You don't like them enums ;) Yeah, this probably can work. I'll take a look for v2.