From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEE9C636CD for ; Fri, 10 Feb 2023 04:30:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3875C280002; Thu, 9 Feb 2023 23:30:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 337816B00E6; Thu, 9 Feb 2023 23:30:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D897280002; Thu, 9 Feb 2023 23:30:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0B3936B00E5 for ; Thu, 9 Feb 2023 23:30:07 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D35F6412FF for ; Fri, 10 Feb 2023 04:30:06 +0000 (UTC) X-FDA: 80450104812.09.4780524 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf20.hostedemail.com (Postfix) with ESMTP id F406C1C0008 for ; Fri, 10 Feb 2023 04:30:04 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aAAiWdGn; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676003405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1+orT4ztclZFNeCn2/cy+EXNwVVJ1UrZTaDdZ6P0C/o=; b=zXZ1XrqA7fUkZ7msEyxLVCKudEfiP6tzgS4ZZczpbH7JgMJunPDhOB1bXmNBTuSD/LeRkh ig/4Iz1Yjp9hCVuMRh+g44X2zH/3QIDvRvP5sgEh8QHcQ2vs+Z0xB8takTxLBz8WLouGTw GZwLFfFgrD04JGH6dbb990v5NYz8Veo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aAAiWdGn; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676003405; a=rsa-sha256; cv=none; b=fenyLjvas+OHvk3x17hMmNAbFQPcqHQpIqtrzt+QiQz9cMkyWU7aOGmsOJbG1QXs+Oc/Fp LVyjQxbcFgCS8eF9ddgT+j6gb1otPO4FZiPY7ymITZ4MDH+xOFyUvdHztOQSgbwc24pWkW BALdU3BQaUZ566TD1gyFDmMMdiOGkDc= Received: by mail-pj1-f43.google.com with SMTP id y11so384821pjc.0 for ; Thu, 09 Feb 2023 20:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1+orT4ztclZFNeCn2/cy+EXNwVVJ1UrZTaDdZ6P0C/o=; b=aAAiWdGnMxnDRNbU5mdVTMZfAj2VmYwtwi/2Mq+6pJrMbYq+beEtgHtSQZoWFp5AtN MG9B3T4ELnrnKOkWlbY3MDklUfjouY525ejhFWqzYIZKJNmZGHrPp3VL7OVBFLQF6E9w 9o7hU++lFUoiPp82yExpHfDSW3tbhbNPdiuXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1+orT4ztclZFNeCn2/cy+EXNwVVJ1UrZTaDdZ6P0C/o=; b=NCJBJBxcc+H8WTSPiFVU+uKNOwV0l3Xf7a2g1elEHXZufj+g4I1Z3dbMdeshkfBUIm DJjk9FWo91kydSmB8Vwc8iTPyq4ABcbo/HmHetMQ8xiVBmHvJP+N9iI72rt0qfZ3GNCb 5nX9bpLS0TzkYI6pJwvqm9qt+YlWoxW+ulVsFjRRB0uk8txMb4wf4NjhN559nBCIQHiz qbk7gQs6Cb3Wf6PDpROSbjo29fvFZY576jEejWE/fGTbXmzI+v/7tnqMd6iPOXYjD6e1 JP24D6E3JIxyouzFCNUO/vuBhmJMZLo5lpUCALmIAIbagBnee9fwe7uqDdrxt8ZWhpSC imWQ== X-Gm-Message-State: AO0yUKX2L49kRwLZUZ4IYgu6BKXYZhrCjdAcjdSskB9BCh/+bP0NxBat uY7hXlK2OJSRQTXRlDODsnmoHA== X-Google-Smtp-Source: AK7set8Cp6nq/nt1N09xKj07/QV1E6l7rUVOI6hkrCyDB0iP/iQ4q0BS7XhK1tEgEVwAbRzYTU4y+Q== X-Received: by 2002:a17:902:d0d2:b0:19a:703d:c1cb with SMTP id n18-20020a170902d0d200b0019a703dc1cbmr1314390pln.11.1676003403650; Thu, 09 Feb 2023 20:30:03 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id s18-20020a170902a51200b00199136ded1dsm2336072plq.112.2023.02.09.20.30.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 20:30:03 -0800 (PST) Date: Fri, 10 Feb 2023 13:29:59 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230206092559.2722946-1-senozhatsky@chromium.org> <20230206092559.2722946-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: wb1ewnqu14ckm9esk7y6yrht6g4cpjhf X-Rspam-User: X-Rspamd-Queue-Id: F406C1C0008 X-Rspamd-Server: rspam06 X-HE-Tag: 1676003404-811294 X-HE-Meta: U2FsdGVkX18cAcuInKV/PWjId3BvxbncRtW0uh6a0KoA/l2rFPqIUL+R4+2U2aLw6ka4UX6rGTSrvkCPoVaD46ih4ob4qJ4IzRaBs77d7YeQNm2AQ0AqcCNU1Sz/wPGWBJ/MDIW/wSHchqgQkEejrSyeqi6uVwGe4OKbWRSeUHVnqs5frB5M5cxQtOFcIXS83Zux6b25Uu5ssNMhspJeOfD/vjsTqJS/6E4851o61Iwyi981dhmxkW+ge8wwJoGqf+yt00NxCycsGMADzRx9hbNubNLLBB+asLK6xGFoNSNjYMgZ89btwGo7oN+2qk4jE7OvMwm/ku2V5WzKMzp7QiheCTx6Sfebg0kPpG2BjcTHRwG22dsU79iqdh6oDy6Vc3UcFTeSapRwYCZKpxRECFhmqeSES78gQq1gK2i+p9yIJ1sN64zl4HptWOAosvWLp7BXfRU3JIIEWuySQirrLh8dIjNgYPcXcR+6DNXiDZd7q6wL4R1u2H1QYbPvCrXl41G9ZyUUSVObC3oUf0gn0fo8HhxAlOKcAFRE0Np4YB3dI5IPBsZBqifvGCanywEapkQD4gXkAlR+f0egxtL1K9hi4aQOJuJta/8SndNe9iSKGPaUMP0HJ1K57VRXUY9q2xu0hPCQjutVOBZ0KY+XjyBSTKglZyKgIOxV1wWpPq5p7OrO19CxVcP57Fc6D9xidEJmvbaeCoCyx6Ty1Eoi4hCyZwoJiU1HIcQNXqfCxvSdBHE0KZ4XGF1v1crpEd4Yf4Ual/DXW+dTQNbpSqoycst6aZrtcXpi8oYgsnkfivg6HaiUMiZtyhHeEZ4CSQsO1di6Goj8hIIzgdY9rP8b4FuhXlTeK6p51CdS8qPSFojETcU5mhpCdmonvfREBJzqcvlpBjQNK2Ru35f2hk9sCpnKGIyVaZB+WMH2m4BvCuTOj4xuhVuX2K/rZ0jsbjf7Vq8gX5HuLEoW21YJLil BkJuw2hV 716p6oNeCm1MdQIzLyFkcbbG/o94UWT62gFGrtcMb3yDiZnsWmJACOt5zD9eUai65nW0pPm7+gGHhVcZgZEYqK7xVoDJciSQ2WktLLUu7kiIwE/buMrKG3mvbd4TI05spjBVDQOm9FfGqt55Gcv//zIpbZVKArR0II6mRUmv3D9d4H6uQRbhmdzUza2MyeVWD9W23/h+y0xbaA/S9X+mMq4SZVPYWZCmsXMbNu3Rm3yyDkvhTD1Io1OM4lyp/QBr26ZTCrMFQbuonjoQlsYCIRrI+fGil3OvOouUuztbJ9V02d0ih7OubyWyl66q/BRhrMWVwnGI+LvdQu9yet7GbKSd9uZe0S9phVN0ZQFIPEgohgE0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.020698, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/09 20:25), Yosry Ahmed wrote: > > On (23/02/07 10:47), Sergey Senozhatsky wrote: [..] > > Forgot to mention, I was also thinking about extending zsmalloc stats > > file and providing values for each fullness group per class, as opposed > > to current ALMOST_EMPTY and ALMOST_FULL stats, which don't tell much. > > Makes sense. > > > > > I can get rid of static const arrays and pass "begin / end" group IDs to > > functions that iterate fullness lists and pick the first head page, but > > I think that enum values will stay. > > Do they have to stay for a technical reason or just to make reviews simpler? We need to be able to do zs_stat_get(class, CLASS_USAGE_70) or zs_stat_get(class, CLASS_USAGE_10) in zs_stats_size_show() to show class's fullness stats.