From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB02C636CD for ; Fri, 10 Feb 2023 04:24:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49E256B00DE; Thu, 9 Feb 2023 23:24:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44D566B00DF; Thu, 9 Feb 2023 23:24:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33BE96B00E0; Thu, 9 Feb 2023 23:24:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 22ED86B00DE for ; Thu, 9 Feb 2023 23:24:11 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 56EDF81268 for ; Fri, 10 Feb 2023 04:24:10 +0000 (UTC) X-FDA: 80450089860.03.844015C Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 7230B40004 for ; Fri, 10 Feb 2023 04:24:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jAsN1BhI; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676003048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ROzvlU3xKIlsDrIvQBCFILPBUqpYkd1d+ibfENwn1RM=; b=4wi/u/g5dpvjZVaOV8V167vS4sNlxvs+JQ5Jsex8uGEgopJcxOak16kvQZFPkL6uJvWxoV q+77LpGbW5g8FSd2H2NpwdQ1BZN0xaEghXTRgn13Jzv1RgyOmADohoVhv1wfFyATBDxfSw hm/Kk6KRfkp8FZdAg8CVr2gcl3SqGsU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jAsN1BhI; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676003048; a=rsa-sha256; cv=none; b=xxZ8fuyCMR925NzS3x94UTfEZXJmUeoaQGlhbgvyrSazSkNbcOBaQehh0o42AT1KIwOfTh texExzx0wZqf7NUgInpM3F0qWer6a2zpD/nXkhTzrwmTyPDYs8jx3/twdmmVJKLfHSx104 kanz/FDXYktHWdhZT/TpMaoC5ExM0kc= Received: by mail-pg1-f172.google.com with SMTP id 141so2989914pgc.0 for ; Thu, 09 Feb 2023 20:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ROzvlU3xKIlsDrIvQBCFILPBUqpYkd1d+ibfENwn1RM=; b=jAsN1BhIAS2GZVQlEo4rba9kRWM6lUnYMsR0FGTj+nJufqqKQc5oEGXbiuTRZSbZ4p PmsoS57Fjw1PXy7jJvgdxEr3qzFm+gsioE6aj0PWqh40DTVkiMMiuOKR/Z0mPsJCeLop qgZ8PbKIe/xISKDP3YIf594PH18WaLsuEf7pA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ROzvlU3xKIlsDrIvQBCFILPBUqpYkd1d+ibfENwn1RM=; b=Pw3NEzw3qOLcsjNhY0PJqKkJwXrUgWYhZ5KIrKSPXQYkoxs7hNiIwuxAClw/v7pccd 2VoItwL0y54J503yWo9XQZ3XXc2m8roRgho7oZLjNLW48z1zWx9EGWBcRctM1qZrxfxX fpHuJ/2/qStfIOkLBvar2tLyX2IvlX92J6yiQRzTsb8wd3QsfbyYrYsitNLKF8iHRiPk 4Ic3rnCV5oVitMtIB0HR/5DvdZaLSvJ9WV3+7/Y0KfhZUOeaokqS5A6wydwAqhZw+lQG k8HoB489efkFQz3u1q0hkWkD9K68UXjhEzrh12oT1VB3ql9UW3fD+Ay8DCXNAJCi3BqR EWKg== X-Gm-Message-State: AO0yUKXgfxCFbxAEZxPgd2/RdvsM+G8/v459Haqw6AUaDUN/hqVwTKF1 8Y9aNDFmyjyelQaAQlEGu9pb8Q== X-Google-Smtp-Source: AK7set+mfzWx3mxCfqbVfdwwFUpePlSYefplh4FXnZ5ATccmMriRtYim0RuXuYksfloxNhK80PKjfQ== X-Received: by 2002:a05:6a00:1d0a:b0:5a8:473e:2fdc with SMTP id a10-20020a056a001d0a00b005a8473e2fdcmr5579704pfx.12.1676003047015; Thu, 09 Feb 2023 20:24:07 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id h11-20020aa786cb000000b005941bb94491sm2250946pfo.4.2023.02.09.20.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 20:24:06 -0800 (PST) Date: Fri, 10 Feb 2023 13:24:02 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: References: <20230206092559.2722946-1-senozhatsky@chromium.org> <20230206092559.2722946-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7230B40004 X-Stat-Signature: pyd7exb4arou3kfbzobbo4dr5z96nwmn X-HE-Tag: 1676003048-203534 X-HE-Meta: U2FsdGVkX18G9bUvtEIjMlVjVG+MMTKWVwZnfsYGlxjExa8vm5w2g7ESXBJYxq4Tonb0zMV+kc8BKCbugTdFdNj5kRRE2OwVOu5F25XCpa8J94dTz9x9imev3rYCgZPNm0PbqEjEo9MgcK3K8ufZ9QY5ctDUUKkKzklx8wGffpp8sgnw6QHjOwlLOL/2Vvz2lgkH3IjSvqrHJ/4GKd8D8Sds8qRSsLBZsAgVvIJ5k+WfPVTo7PtWbJXXVHx+r+pYlY8+pt/EQSN213BnK3fZmmjuY7sSGf2lCj7PsI+CkzMz+i/4NJ6MQR5zaahLUCBI2xcan9SvDd+dMGPPBGBPl7iyjQf2JAqQjEAd8Md5+uRFy/crzXzV+1GhL9kfYxVUaJsG1fkvKF/PW+1W6j0WkjiB0f5lpvOf4LqVtEuBoUHJTZgj0A9jEGzMeQogY0u9VGxYWm5tNfiNaW3RNNAKMLYW3rUKdcSPzofpOFIO1rvbLFBi4Va+Xs4fBWAA+6+sBQqSdabn7gBWjVJrtXh81Qs11s5QUNHJO+WKCYIgZIFCyVlIKiKgRJqE+xOdZ8ZS9/4cW+49mVmS7kem/n0EFfhX0LtgVgqmTElTsJZ4h4g/ipxsMvkYnUo9V3XX8qH47IGv9m+nogOeozRLszeXINB7EpYud+XQtnOl+GtIF2I65WCI954vTuhyWAf0wC3SWoackS3jrSI93jSje2SWj4MbAwIKus35Xct1lD8jHaijdW0GwrfmzO20cGj/v5rZ+yoGxLhgyFLlVx7dd5Um/3UPYF70Dktfqp3FdHpfkHf7iwSyaoK7wgp828qz2J+e57Hfb+aZubbCC/5BFNjCraROIrkJENc3ytjKYS6wgd5Ij8wI95kTrUz0D53MWyXq8l1xFPw4UpgYTeSmp3rZb1Z6CcWtF2Q3flmc79fRVAY7+WuJf1dLeKes9kdy7O3VRSj85nnWDoDgRSGc8cU /snA0Wrd fODPzJBx1aiFwx/Qx22LezSXH2gwzHYe4+wqzq8jLKLRDzS3wZj+niyGiWRZ0qP5H0+dv17TdkyMTm5Ie27dIqi106uSy+0BrzQGIcfDQ66Gcx2zmHUsd2RzOdz0FMTNZSOfjEAGlL8xjRW0CeQsBakvwOrfzzWlBYG6O5jIoQAzA6tP/1i7mWT+MB46jl3lzfwGPPOJvQPIPx042XOL6YFIaotyesHksYraMrhALldzwvDCM0aCVrBY6f2dXid3osF/03+yqb4zdQ2UvzuuYLZIqWkXrIHlCoq98sbk7uTVXmrIYbBZUDOGGr49yiUMZvErdhMxYzcDwmC4AwKbCd1HQL5co0wcBDMjFXvN7mFTPqbXaTA+o/UeVxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004355, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/07 10:47), Sergey Senozhatsky wrote: > > > enum fullness_group { > > > - ZS_EMPTY, > > > - ZS_ALMOST_EMPTY, > > > - ZS_ALMOST_FULL, > > > - ZS_FULL, > > > + ZS_USAGE_0, > > > + ZS_USAGE_10, > > > + ZS_USAGE_20, > > > + ZS_USAGE_30, > > > + ZS_USAGE_40, > > > + ZS_USAGE_50, > > > + ZS_USAGE_60, > > > + ZS_USAGE_70, > > > + ZS_USAGE_80, > > > + ZS_USAGE_90, > > > + ZS_USAGE_99, > > > + ZS_USAGE_100, > > > NR_ZS_FULLNESS, > > > }; > > > > > > > Is there a reason why this can't be done with something like #define > > FULLNESS_GROUPS 10? We can make sure during build that (100 % > > FULLNESS_GROUPS == 0) to make our lives easier. I feel like the code > > will be much more concise and easier to navigate, instead of multiple > > enums and static arrays. > > I wanted to keep things the way they are to make reviews simpler. > We probably can do something more "disruptive" in a separate patch. Forgot to mention, I was also thinking about extending zsmalloc stats file and providing values for each fullness group per class, as opposed to current ALMOST_EMPTY and ALMOST_FULL stats, which don't tell much. I can get rid of static const arrays and pass "begin / end" group IDs to functions that iterate fullness lists and pick the first head page, but I think that enum values will stay.