From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546EFC636D3 for ; Thu, 9 Feb 2023 20:09:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B18D66B0082; Thu, 9 Feb 2023 15:09:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA1C56B0083; Thu, 9 Feb 2023 15:09:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91B596B0085; Thu, 9 Feb 2023 15:09:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7965A6B0082 for ; Thu, 9 Feb 2023 15:09:45 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3A80316102B for ; Thu, 9 Feb 2023 20:09:45 +0000 (UTC) X-FDA: 80448843930.07.3E5D027 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf23.hostedemail.com (Postfix) with ESMTP id BE944140008 for ; Thu, 9 Feb 2023 20:09:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ZS90CnmK; spf=pass (imf23.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675973382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGHbI4ra0FtneGPyfx5jeTG6NSLPIotF9rRhO6tyTiE=; b=49+6daWaSoaPNggQtiQhp8k4fNPbBRLZUry+1QwtBlSEMpODmIV5xeJJJXMnnFL2VuRZ77 O2bc7r3cq4W1ixL1lmkj1RWIO6nw8AAU4ARDrL+ZuQBpQihp3BmJ/Ij/EPk6SdZRVQmKHd Noxeya4/ofAAj8U92VYoQarGsIn0udo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ZS90CnmK; spf=pass (imf23.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675973382; a=rsa-sha256; cv=none; b=C2kEWFJD7g1Jy6vOTopNBGit1WXF81RTNA0viROOWDd3alKoefklloVV1uEcBvVNt9NVeR W6xEepV8Ighf/0wDhZUJlmvlm/NqhOnlcUDJxlhYoFty2mjxdUfIV5h17Fj7RsfDR1J1YU rdtliLzFhLpboQI9wXTazVwXuNZL9vA= Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 319K1lMe014350; Thu, 9 Feb 2023 20:09:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=XGHbI4ra0FtneGPyfx5jeTG6NSLPIotF9rRhO6tyTiE=; b=ZS90CnmKHcX2Szr2iyBq4vLBLxdSyovUrw65rrkcypmr3G8AfUE/iw2rCkxfMVuklwr8 x1RloEGV6ukvMY7h19dRqhwdOC6KkYKhl0ECGJhYIH1b/nTG0zOab+3KNxko47MxSqIf WELougxeGm2IDoMWQZRm7FdKbEn8156vW360HoUbkc5v+haxMHPFylW7Uh3dtDcwHypK GLD/Xa3khQvrXRmC5p3QaMw1Yrx0OqaZfkM0zMEAFRFlOkqGLNpMVAnIVxIDfpAjZqrh 8Jx4UrVItaT4Bu6VBbObJgL4MgcD/o4ndrJvpgfyFJ1UxULrhlFY7BDwwVTj8DEQGJcN Ew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nn7gr8c0j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 20:09:32 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 319K28xC016343; Thu, 9 Feb 2023 20:09:31 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nn7gr8bxw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 20:09:31 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 319CkNfE023807; Thu, 9 Feb 2023 20:04:28 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3nhf06xmub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 20:04:28 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 319K4Qke51380530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Feb 2023 20:04:26 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 283A420043; Thu, 9 Feb 2023 20:04:26 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2E0620040; Thu, 9 Feb 2023 20:04:25 +0000 (GMT) Received: from osiris (unknown [9.179.10.102]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 9 Feb 2023 20:04:25 +0000 (GMT) Date: Thu, 9 Feb 2023 21:04:24 +0100 From: Heiko Carstens To: Matthew Wilcox Cc: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Message-ID: References: <20230205231704.909536-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SN3n-Sj8UyAs9EywqmZbAifHCHDfdB2o X-Proofpoint-ORIG-GUID: UKCCI8etZ5fGapHAmtaqPfeeaV5GiOYm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-09_15,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1011 adultscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 mlxlogscore=364 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302090186 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BE944140008 X-Stat-Signature: f46xa6ddczxd7cx36ehfizqrw1ath51x X-Rspam-User: X-HE-Tag: 1675973381-988443 X-HE-Meta: U2FsdGVkX1+VzpZz/EdYUObknfYnXfibDYCXy4ov1VZFZSX2huAP85E6A5rrhF6TSHc7OYMt2P6yQAVCJIefYEg8P1ojIEGle4hO/1hJikvwKuLMX+l+AUP5aFLbniigSqvXXJkCPJ+nuyNoh+Mz5Pz70nOwOofydxa5+18oxcWreO8b8wedIMoI8JH8AylBo87O9U7Vn4agQvLvhHAglv5mrden4uI/fZ/63pwQTJI5HLHsZm9Ko8mxTvlWbL3LF/4uZQLnEtE8mWxIZJH2ORNiEU1TKqvbB/dcIlIqQ4zstMtMSm28L61IFNtfMeR1Wl1gtOsBYDcz+0we60c1mNOfZd4kjy+m/Hgm+L6xnyn6MCDP3MRztC+GfcmD1bWYH225gILY0uvzefklngGrgdkGDTj82Kiw4mzRkuBH3p6kDHM227ak3DKZ+++0j5svwdGKxt8NLuS8q3/LPHFguMEySMcAJCsTKLRdjrjAPcJbktC/qP284lYDKfTdAvc0ejJ+cRUp6pWBzEJ31yISA800y+9N7aThAUMy8tqyPg1WTjp3cZkYnMVpKP4a6KoZG7WLDSP/h+hT1bUZ2Yl7hCqCwwxNVxgnjOQASYQHBpPTXxls/CiLtLys9fPIy+oqy6Femy48FRX0IsY65+3DOqZa28Hljp2OwUohiJRqIF6dRNvZrtnVfGiQ7ztMIIdPVzpS2UEvwhnfy9v+NJgs1hb1PTnuxU3cxVQyk+CVMl+lQBy8P7GLLI2fdiAQvLv1jDgoULWyQY0hRCD+EnHBjN49OM/xTU62gryryFCMB3fmiMmAmgfE01z3johkBcLZB2B1YJrPO0wMaLxNSlg/CSnGkB74ge95AUDwswK6ugSnpgTlE2Ov6ZiHkx7rCqf/rcxxB7r2Kay1SMBv5jELWTW3zY3T2cKcW+DKBkaF0fyIvKLuDdu1+wdwpYLaomeOeXGTvardh6VQvHrgLGR M1wPPrEK KJjr/U2G2Qk/0BSjfuF9ECL8EZ3KhfcJ38FyNzUdhZCTm4zvFENCvT/MKpba+YIJTfDgTS54ymz54TEUv8lGs9jhD1jQuKGhsAyP12KxxVN2CFJmqxX/zuqghHA2njsbMkCxwKLzr491a31u2wkE2u0kDBJswTdq4JWhmIM9dl/EVTF2Q1CHlbOXFvbei5yFYNikY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 06, 2023 at 05:09:57AM +0000, Matthew Wilcox wrote: > On Sun, Feb 05, 2023 at 10:18:30PM -0500, Peter Xu wrote: > > On Mon, Feb 06, 2023 at 02:51:18AM +0000, Matthew Wilcox wrote: > > > That wasn't what I meant. I meant putting VM_FAULT_BADMAP and > > > VM_FAULT_SIGSEGV in mm_types.h. Not having "Here is a range of reserved > > > arch private ones". > > > > VM_FAULT_SIGSEGV is there already; I assume you meant adding them all > > directly into vm_fault_reason. > > > > Then I don't think it's a good idea.. > > > > Currently vm_fault_reason is a clear interface for handle_mm_fault() for > > not only arch pffault handlers but also soft faults like GUP. > > > > If handle_mm_fault() doesn't return VM_FAULT_BADMAP at all, I don't think > > we should have it as public API at all. When arch1 people reading the > > VM_FAULT_ documents, it shouldn't care about some fault reason that only > > happens with arch2. Gup shouldn't care about it either. > > > > Logically a new page fault handler should handle all the retval of > > vm_fault_reason afaiu. That shouldn't include e.g. VM_FAULT_BADMAP either. > > Hmm, right. Looking specifically at how s390 uses VM_FAULT_BADMAP, > it just seems to be a badly structured fault.c. Seems to me that > do_fault_error() should take an extra si_code argument, and > instead of returning VM_FAULT_BADACCESS / VM_FAULT_BADMAP from > various functions, those functions should call do_fault_error() > directly, passing it VM_FAULT_SIGSEGV and the appropriate si_code. > > But this is all on the s390 people to fix; I don't want to break their > arch by trying it myself. Yes, will take a look at it. For now I will apply Peter's patch in order to get rid of the collision.