From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10AEBC05027 for ; Thu, 9 Feb 2023 14:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F1696B0071; Thu, 9 Feb 2023 09:31:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A1366B0074; Thu, 9 Feb 2023 09:31:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 842836B0075; Thu, 9 Feb 2023 09:31:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 742006B0071 for ; Thu, 9 Feb 2023 09:31:25 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3C802120FBC for ; Thu, 9 Feb 2023 14:31:25 +0000 (UTC) X-FDA: 80447991330.12.13A9062 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 6FC7220012 for ; Thu, 9 Feb 2023 14:31:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VG5jFqXo; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675953081; a=rsa-sha256; cv=none; b=qyU+/4DxSzwD/ntrnnVn2yDqKtQNcCSkx+z56csgwaBatjgBBoLqPc0hwEuFCiFt0YnkjX KLyj/PFR8yjUluBOHrymIyKN3z9JJb2aW0vOYEZrm3lfrgPU0iXolbyP6GCsf9VD6W54xY EEEmWCGTALDjHGMWgrclBG8GzkGJzlc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VG5jFqXo; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675953081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3SDDobNw8IhsSeHChXAxs++SOI6CGdHlnbv8CLYWp4w=; b=i0Wb8YXfuMxyAVJXl5xdmhI3GmIZPGQj/m464LzSvNN/6GhKUReO5Ax8rVLWNk6roatk4V 2Lfh0nFYp1bg6jMibQN0XsxxmUSgi0m1dVwNWxSpgrAPHfhYGpkG1vsFK48zbVKXckoIbd w+7jhbyQGnFYLLDN0aQTJ9LJ2/lyEOI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6720A61A91; Thu, 9 Feb 2023 14:31:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAA0EC4339B; Thu, 9 Feb 2023 14:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675953080; bh=zAwLjTfHZkA4Un8Wr96bawLWi9udk66aSBO3uZqtYAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VG5jFqXowBO4k3HxzeJWpfut2l0emYLJiIhkuZRgIavsBSTDTP8w9UHu5bMOwz6az KDhpEkzdmx8AzjN6VDm3d79kkWwGfKZ3zv15VslgJvIfWn3BckIIPOx26HRHPWsb7+ JUSX7XenJnIUONq8rg7BC9rIb1aNamgywSg1Qtdtz4ZccT/Q+XGmD8xK8Rvo7PWZxM DZc+yN0yeqppujKqn3ectEj7YYmTNaWjfKoVbeZVsHfGgs9xz7l8BkQUfJC0oKeLG1 no+cx8P3SwCP4tVqMjsVHdGRKJyNTjEFUN5PvJ3xy81FNkix+uaId+dWBihVWuzVgt ZNhw/sUJ5xMDQ== Date: Thu, 9 Feb 2023 16:31:07 +0200 From: Mike Rapoport To: Matthew Wilcox Cc: Jonathan Corbet , Kuan-Ying Lee , Matthias Brugger , chinwen.chang@mediatek.com, andrew.yang@mediatek.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru Message-ID: References: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com> <87a61wvtcs.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 6FC7220012 X-Rspamd-Server: rspam01 X-Stat-Signature: fdqagutqy7ot65jg4s5pkctx1ftbcu53 X-HE-Tag: 1675953081-713433 X-HE-Meta: U2FsdGVkX18lA/CDByGEBn77ps/aRHc/tc0fTqaW34JBrzqXi7vxtts+IXNat5PpIsF6/V5cVhTKvcEa95+CjUewhJv2KtYb6pzGSba1ALQ8y4f+f4ES/q3Vf+ZmXm3Asby6deJnUzrf8Yqk8JlhWBVqDcUe1yRKv6oKhya3dMIBEP8P9oupDhPooC8CFzjixAXNIouFyN7R1QZNK9Gv0ha5B0DYg+x9zwC8UvJS7rCYV8Oldpm+mCOA9cYuVrCy8DEfIsRyrzC3eHRRGFVb4QSp9DV+nYawAr1NhmW22PirbJpsKR9s7AXhKxih+HvP9ogNfWAWJ7wQwmgI9mmoPu8icf61Ci0K9peKaT/YDamUB+Ks03doSbXX9yzTxsbvPx9hdTyAbDqdixpGWfaLLpaJyhvs8Nng7g8yPo/8L6qIYWZZempEUj0QmsBEhDLB+0BFjXwov5cMCg7zQUUhVY+24BUqo8U4HAvlUUr9/RaWP8qBBdj2N+gf1+FDRhgabq4CblKP+P+T3EhGAH/vOMB5ziabEufjnBAgkfnt2ZFgM0Ny9i/RM76Q4rGGp+kNP4ZLtJImoBE4lgacu3AwV7FkSBTMuzNhoU9HCXnCQ4js953Jv56RBqFFthwohqyhsxM+JaFxnsh7guJrqD7V6QvewIt6OEVvtSCBdX4JPT0WoWM3nQGB7hhQ5MNUSli/Afo9ZHEdfdfd+W0mAAHWsyYHBGFp8cuwUdMPKPKMG4YdRSF1zVK60vl0QU/aGvcBAlkY7RW9smvZs3y78XSfVsAq+X10t7P2aLPlgMdhuDCy3AaQJ7OewozK6bS8R4srENXumqV2E9I5ORL9viBtqCLPHg3LGbFXLHWJUdkd7uVep9hN4q7RV+ZZFZlqbUlC9WRt1j5fAqJMdcwP93xEU8L49AFcK7zp8rwtmQLS9X/GHTGye+CFaSe3i+xRSP/+Qj2oiwyWiJSQYNP5Jg0 XM6si1Un idxxh/yGkRYlmCyUt0neu9ISSbGnkmCU3Nt+7nsNE4QGPb+wwnP172Cu8QjtGSettcwFQzbQqW3bCfiy1lQHFDZjQHgqXzXHriJkEWakfhFtMpoPw0DQR3TbXrlHSQvM7OL3pv/hOH+rQ8L+5P/jwE9f37G7N1tuEYxHNvlkilHKDsuGqLF5kNKhqUrCsp2IXwZjuwgC7+DqA43jXjfKWrkauHfO+tNtXDYkA2AYDZy4ydf5zBPkYGZuRG0MrVn7jyooxisQlNo5ddHefoxplWclM4k2AO/QACfEuAUQzWMf+J2boNY7HwTbj/7D/q4WBZn+VQ1GvnPBR2MA3wMCYTYw1ZbY/IWgTlzsa5UX2dzNI/rs/HzIOs6SoLj1RG0hVKr6rYZCXAfc2fq32QCO/TCCY2WqFofPPVDL9ii0kjm+EOMzOchLwHbA5GwbJ0rHUYCePqdV4sH5QDvAOV1+yf9VK05/4ancTkeeJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 09, 2023 at 01:58:09PM +0000, Matthew Wilcox wrote: > On Thu, Feb 09, 2023 at 03:10:07PM +0200, Mike Rapoport wrote: > > On Thu, Feb 02, 2023 at 11:02:11AM -0700, Jonathan Corbet wrote: > > > Kuan-Ying Lee writes: > > > > > > > Since we introduce folio, replace isolate_lru_page() with > > > > folio_isolate_lru(). > > > > > > > > Signed-off-by: Kuan-Ying Lee > > > > --- > > > > Documentation/mm/page_migration.rst | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > This seems like a good patch to copy to linux-mm - done now. > > > > > > The patch perhaps is a closer match to what's in linux-next, but it > > > seems that, if we're going to update this document, we should reflect > > > the use folios throughout? > > > > Most of the current users of migrate_pages() still use isolate_lru_page() > > so I think that updating page_migration.rst to folios is premature. > > But when we do the update it also should include the translations. > > It's a slim majority -- 9 of isolate_lru_pages() and 7 of > folio_isolate_lru(). I don't think that changing the documentation is > premature; we should document the functions we want people to use. > I'd be surprised if isolate_lru_pages() still existed in six months. That's a bit of a problem when documentation describes how things are done rather than how to do them, but I don't have a strong feeling about updating the docs while we are still in the transition period or postponing it until e.g. isolate_lru_page() is gone. But in any case, this should be much more comprehensive update rather than replacing two occurrences out of three in a single file. -- Sincerely yours, Mike.