From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F4EC05027 for ; Thu, 9 Feb 2023 14:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3926B6B0071; Thu, 9 Feb 2023 09:18:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 342006B0072; Thu, 9 Feb 2023 09:18:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2092B6B0074; Thu, 9 Feb 2023 09:18:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 111356B0071 for ; Thu, 9 Feb 2023 09:18:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD7FE160F70 for ; Thu, 9 Feb 2023 14:18:32 +0000 (UTC) X-FDA: 80447958864.19.865CFF0 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf23.hostedemail.com (Postfix) with ESMTP id 9FECE140005 for ; Thu, 9 Feb 2023 14:18:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ptrgdRIU; spf=pass (imf23.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675952310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n6rfU3Snjl72LWDE6qX15Ocps4cU89fmRgYsFNMufWk=; b=OyV5ZqtZqufk7OgkTzIPuXCo72g4jlGGfYAH7duJ4tXd6jO4qsOkFcoDb5plMTDayVBaKA nFJB+lgfpx92b13Ub2iGyVGs1hJJShMhFT0zJCXkr/CzFGP6rBVwnRvKFLp9cxbAB/nZoe B6QzWta8JQPTMSRQSpMypG22YOUjH00= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ptrgdRIU; spf=pass (imf23.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675952310; a=rsa-sha256; cv=none; b=fSBvxRwUa9VLu4MRNvzzezdA0SYDrAmux+iGiLS11unlxps561vz4O+JA9szyeH2PG1F8L fUO+f+OGCd5zSCskHQcmmZ4++MygeNx0Ev/0WyeW7vOnmsvH2S666QGYcYbUE1uqazHG1v nUYjOB6iuwcYsAiSf4gXjc7Y1M5D7Ao= Received: by mail-wm1-f53.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso3999753wms.0 for ; Thu, 09 Feb 2023 06:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=n6rfU3Snjl72LWDE6qX15Ocps4cU89fmRgYsFNMufWk=; b=ptrgdRIUbWXZm/c9lvzocxPMYQ+eryxsewr3pbMPofs6WTJXzB1Ds06zzWNlpBFdfE y52VbKkz22dnSCkSuVB6Kqy3Bn0EYvx/voJ6fcGkXc58mN+umM38sBmb1NfC6eTgR5/g Qf4APaaY5Q4j3X5wFir1KJ4coiw/6UX1yJdqYkpE8FxOrw5mgdwYIa0ulh3uF+ZoVJ+5 ZQwXYAh9ubL1aXAeRfScDXJx+1YpSXNUVuWCwt2sfQeC6U5GThIdQyWV3OUK6IRbji9x ErxpRJynYb6LskLmbQBbz9a93hHFi7tmhPeCzwsN8HHYsmcdIEvrpMGPKtABOHieEgSX jkiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n6rfU3Snjl72LWDE6qX15Ocps4cU89fmRgYsFNMufWk=; b=2bM3C49+AlDviLfRxXqDj+56yYHO90Gs5wjJdR2RaLjCVC+edpNnG8HkMnA9NU/Z33 BMogi53udltuZx9sW8tyc0btwA2d8axKy3q+Qu/ncxY7JdlfkH01bA9ksbUZMhiRjsAy H1+hfWUgBpVNsbTJQ3VeEjtunfjF4cyq9FYloJwSDCc7jnAycTvwpZxETaDUdthxeGQa lW0vSGHaCZTB8wiz2Cfg0OblWR5eISXgGEZgSREK+310Bvy9BqrtEbkEuOKVNSn434Gj FWwkFGfU937CIS+6N3m0QYi3MNlPclSyxYA1xA2AoBjlQI5lNav71AqHTUevLGnwS0tj bWzg== X-Gm-Message-State: AO0yUKVC9n3CO+mhSJbcd3VPM31l6n+Z7kJIeyekl4NSfY7Q0l5kkUB/ 3lb1NpCUB0Aa1k/3F6SqvPY= X-Google-Smtp-Source: AK7set/oU2MQE6PRrUGZeem/G28nDvWH2jZGBGq/aX3yec9+KFq5SeSvdk3RbW/QsABFEFJLifd0VA== X-Received: by 2002:a05:600c:4d21:b0:3de:e447:8025 with SMTP id u33-20020a05600c4d2100b003dee4478025mr9943371wmp.21.1675952309295; Thu, 09 Feb 2023 06:18:29 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id o41-20020a05600c512900b003dc4aae4739sm5886452wms.27.2023.02.09.06.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 06:18:28 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 9 Feb 2023 15:18:26 +0100 To: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Subject: Re: [RFC 0/5] mm/bpf/perf: Store build id in file object Message-ID: References: <20230201135737.800527-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201135737.800527-1-jolsa@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9FECE140005 X-Stat-Signature: dg9d9941sqbb1rqhzcrtfhkeodm4sp88 X-Rspam-User: X-HE-Tag: 1675952310-313374 X-HE-Meta: U2FsdGVkX1/MWbIZDbl87JrFQTrF9jieKa8Q91vyGzHLL00LvJ6wzkn7QYPB3pxKYLMfiKB1CJsg4pzxY6ymP7disTCi51XLUBmB09KQc06tx/oba3xxljdEEhJMjAwZGW7g/60lYL+WoIR5cYJEAv4jTbvAohcYyLz8wPDgocJctGDT5xaxJZ6noDQsEaX7MHZXdVxgUeD+K6eoV3brOhFP1U/rQA5LRAlPqOkJfHSApMsFZ4eaQm9hdrCvSo9QCj4b+V/PD1EStg1aGzvbKq+hcl5JFW8RtOLSf3XbbLqgL6G6J/ccBZEzNLIysm7vq1bkzrDPuT5qWGSsew/FNaPMiXkLF4Pf5VJdpT5XXCINqHdFnVH4OeEpfy42Oobdhr7/7Ud8dvjttPaitqN7coI96ap1o33ZsXBGoOgqSEcxqJC6deSOlPOGD4Z8g7DDk8niuYIdf+0Fj/fxB66vlVZifExtISgNze0gg7EFFqZpB5lUkm6JZenlKQsFIWanzSUnT7Uu8sQRXhKx2QPwdhSu4rOU4icGR90fnN4a3B/qstmODS9fO9nIZRs6IaDomPsUj68JrHh3+bDx94HvBgHvZMNRWE0G+KroC5gMvlqLlWEKeK7HQenpcLfs8AmfxHFLfWiSmQl+t+IC46QJa67P5W4SKB/l4/hofRQUdgUotZ/u1JU7oG7Aseor8CbhYh0f8wk/9KKP9esv2arQrMnCVSE4bWUOzI/NnxB/xxUKZwFOCIORn8fCHh3Xn/X30vqmsq6qJfWDN1ZW5z7fdkQJCXvGlOa4RRcn4HoLo7tAsW4At725MD2ngiDdQlSi3e9itCez2/+/5q3/Maglxcq7FBfKeAjTOr/LFv51KlA9gHvyOXl7XxavTDK18gjFFmhxPdf1NoXaHZkgA4b43kvwdQ8XWs5lH0nXIp4ED8yYM/RJ5NKfWJFuG5Lg23zOe7qiJMgMkhjVCbcSWsI wrN27MQl Hypo8P7cv+/MMxGaVgeCSA3bT8iVBh7/lDv92/WO9ytneQYjlUtQx5/Blub9EdK+J3irXmsTnVqfoVWpgmm6847Vk+PypGd30dWvl0w4Zy/zuMmYURs3vhho21MVPcTPVQBLbPXe3MeUdOiP5Zl6ScyQpkj7nSDTu73j1MxYBkAxQuSMHe1E57B/EeIH47YdTYz/YLw7IpfQN1W+k3KnifYmU3QWUFBZtPGCcFQCZ/fK8lA2l+Azl3xfR/3Lmtqk7sbqO3ffYbNS3jL2WFSTvj1QwaKL9z8D05s5ft16qkMQhMxdFPz0D33tR3umhi3Gi83+XK4QAufZv69Mrd8z/Yi/qQs0sQi0VKwyg1U/7/WroM3HPmolpMuHdBGYmLFqhZtWf+vs7qqlQUoVtjmsn2eiORvH434eUFvxPeH5iW6hXMj9AeLSY7I+jZNiUHg7fCrtwhQrNwytnR8ObnE560Cb5SuxjnvZVbzE6/MMwYtiAjHP5DquJUUP+22bAa/vfptDOXtfGkMiBhYBatNaiiIR3XO6GbJHFyJMgmDtchMJ9NZT01VNYPUvsWT/rO6QpuY0fw7D/9HYwjKY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 02:57:32PM +0100, Jiri Olsa wrote: > hi, > we have a use cases for bpf programs to use binary file's build id. > > After some attempts to add helpers/kfuncs [1] [2] Andrii had an idea [3] > to store build id directly in the file object. That would solve our use > case and might be beneficial for other profiling/tracing use cases with > bpf programs. > > This RFC patchset adds new config CONFIG_FILE_BUILD_ID option, which adds > build id object pointer to the file object when enabled. The build id is > read/populated when the file is mmap-ed. > > I also added bpf and perf changes that would benefit from this. > > I'm not sure what's the policy on adding stuff to file object, so apologies > if that's out of line. I'm open to any feedback or suggestions if there's > better place or way to do this. hi, Matthew suggested on irc to consider inode for storing build id I tried that and it seems to have better stats wrt allocated build id objects, because inode is being shared among file objects I took /proc/slabinfo output after running bpf tests - build id stored in file: # name : tunables : slabdata build_id 668 775 160 25 1 : tunables 0 0 0 : slabdata 31 31 0 - build id stored in inode: # name : tunables : slabdata build_id 222 225 160 25 1 : tunables 0 0 0 : slabdata 9 9 0 I'm stranger to inode/fs/mm code so I'll spend some time checking on what I possibly broke in there before I send it, but I'd appreciate any early feedback ;-) the code is in here: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git inode_build_id I'll send another version with inode if there's no objection thanks, jirka > > thanks, > jirka > > > [1] https://lore.kernel.org/bpf/20221108222027.3409437-1-jolsa@kernel.org/ > [2] https://lore.kernel.org/bpf/20221128132915.141211-1-jolsa@kernel.org/ > [3] https://lore.kernel.org/bpf/CAEf4BzaZCUoxN_X2ALXwQeFTCwtL17R4P_B_-hUCcidfyO2xyQ@mail.gmail.com/ > --- > Jiri Olsa (5): > mm: Store build id in file object > bpf: Use file object build id in stackmap > perf: Use file object build id in perf_event_mmap_event > selftests/bpf: Add file_build_id test > selftests/bpf: Add iter_task_vma_buildid test > > fs/file_table.c | 3 +++ > include/linux/buildid.h | 17 +++++++++++++++++ > include/linux/fs.h | 3 +++ > kernel/bpf/stackmap.c | 8 ++++++++ > kernel/events/core.c | 43 +++++++++++++++++++++++++++++++++++++++---- > lib/buildid.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > mm/Kconfig | 7 +++++++ > mm/mmap.c | 15 +++++++++++++++ > tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tools/testing/selftests/bpf/prog_tests/file_build_id.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > tools/testing/selftests/bpf/progs/file_build_id.c | 34 ++++++++++++++++++++++++++++++++++ > tools/testing/selftests/bpf/trace_helpers.c | 35 +++++++++++++++++++++++++++++++++++ > tools/testing/selftests/bpf/trace_helpers.h | 1 + > 14 files changed, 413 insertions(+), 4 deletions(-) > create mode 100644 tools/testing/selftests/bpf/prog_tests/file_build_id.c > create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c > create mode 100644 tools/testing/selftests/bpf/progs/file_build_id.c