From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9D2C636D6 for ; Thu, 9 Feb 2023 13:19:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B64D6B0071; Thu, 9 Feb 2023 08:19:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 766706B0072; Thu, 9 Feb 2023 08:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 655A36B0074; Thu, 9 Feb 2023 08:19:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 576166B0071 for ; Thu, 9 Feb 2023 08:19:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1E0341A086B for ; Thu, 9 Feb 2023 13:19:17 +0000 (UTC) X-FDA: 80447809554.07.4C9ACE6 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 365BEC0007 for ; Thu, 9 Feb 2023 13:19:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VYsTBOFO; spf=pass (imf10.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675948755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s4Q71AiGjsfLKoBxQOWiUkZxB1lpoWpjh8S6/VViVGM=; b=JQQZYJhSFMM9E9hB9ADyOP4TxQQDV577/tXHT7EZGPNcuVEwwvQO9r4YxzGqX+oFC9a1N6 duX7qOIMtZ84p5BmHQHsEpOWGGfrhNIa7Ph0fe8HaH4X3drVZIWyl8iqPvJblFqkNW30v0 erebYYiU5naIGFzFLj1+NSMzbE8pBts= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VYsTBOFO; spf=pass (imf10.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675948755; a=rsa-sha256; cv=none; b=zXfqq2m5CyA91poQQw2pvmwz+A3+xnI7BRNFSXv1jZ9kPA7W/7wOfH2djcjkgBxss5cNF9 RKgVzinYUHI2ftfKs6WC9lSPBrKm0KrVLb/c5jRJnkz+9+kQ9iUQ9Uf68wgFU0UiNs4QUB 4Lp5TuaEdwmSakJybIEjIYbXfNovRls= Received: by mail-wm1-f46.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso1488821wms.4 for ; Thu, 09 Feb 2023 05:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=s4Q71AiGjsfLKoBxQOWiUkZxB1lpoWpjh8S6/VViVGM=; b=VYsTBOFOg7+qEy3LpjhJFQJ5IlOmZRSSFEFfejUhzvUmjmKz42pecTD9YrGtL5QvCy TFPh/kBqfJu5JHN+mpn1FuUxWtQClRcy/fYXNnur8eCOQ040VCMzfy1zOFWfSPtVI63M KAMZnVlmoOVF2aDtSeIb5vODf16+JY/+uA4dRIjRJqq+er5m69Za6ejhENuF0/esIa4P sYv0fMjtpqFcZY54ic+tyXnGV3MXZS0yQ0NCDnJHxbLZWGYyUXd9HL36Wjumo+xZHq/l v/QVmqEn6U36oY2vQt+SRceIa9T82S07raIaEn3k3ytOVpsnDExGC5LrxiHngiR6AOjE pk8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s4Q71AiGjsfLKoBxQOWiUkZxB1lpoWpjh8S6/VViVGM=; b=t38yldvu49bBsCDUIQCu6dKhajFpV8VTeHBdMuTSosswY9zD3NTboKrLMpC4FbI/zF PuiEnJbtw+jKnqGuqveklxt9FdPEgDfQp2uAdh/Tjo/Fs4DuuugL5h2q3JSA+1iXV5Pg jyhc9kfT9x5CwfgQ02TJmatULRWQy5pidsnH/eFR9RYbBrGKUJ/9GR/LLWhLsRQ0NKj2 7rriIo0z+Qa12gGn7JNIFZBVQMNiX5BB5ngemvOLLE5uZ3Ewk6HVVerXgAwUV57/jCcN s1GOAnc9oBh8zVwx3QQ53zCXK0NXcWaHQ/tdZJfe02T0mPZpaM0LnR1SB0V4W0Rv/lJ9 VCBw== X-Gm-Message-State: AO0yUKWPEPDKkrmyRnnwT0gJ+hsI5awLV9EzbZAhx3MBAwlhIEAEM9Sm 5b6HoJ91kGsXQKfFlWrkUxg= X-Google-Smtp-Source: AK7set8kUwYAxNHUD6tovIM8ZnOWsU0CeR/O9TTfthpdMDuZQbPWx2cIT0b0QPoUc5OSV30H7ZOElg== X-Received: by 2002:a05:600c:990:b0:3dc:5abb:2f50 with SMTP id w16-20020a05600c099000b003dc5abb2f50mr9550565wmp.19.1675948753640; Thu, 09 Feb 2023 05:19:13 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id a28-20020a5d457c000000b002bdda9856b5sm1244007wrc.50.2023.02.09.05.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 05:19:13 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 9 Feb 2023 14:19:05 +0100 To: Hao Luo Cc: Alexei Starovoitov , Andrii Nakryiko , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Subject: Re: [PATCH RFC 2/5] bpf: Use file object build id in stackmap Message-ID: References: <20230201135737.800527-1-jolsa@kernel.org> <20230201135737.800527-3-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 365BEC0007 X-Rspam-User: X-Stat-Signature: m76x7wnsbx5i3mhwny3erx1u747jrcyn X-HE-Tag: 1675948754-9340 X-HE-Meta: U2FsdGVkX19W+4ffWuRWRzgJKVI+FmRmSwCrKYDY0oAVzHzdaea7CdoIR6/nyREM4OqptdbX8jBpoVAmYI4VOUXKXvTMfLRXkDUbF81WCqDagOvWRZ+teSl8wFWPvXnFr7Fl0J1Bq7O5APLS+7Sh57ouXFzGdKR7EzLaqfOzxX2RUdPA4G5Q3PN3WjXfJMAuqqdyF6yIO0P43nMWX7tH5WhQ7uIfXJ3C8uy48zd4AP6jpBAePJIdDCgS0qkbDax8rchkC8QOPKnGTYsWxlvq/wS/H6eSXPjFGLK8CJPrTAXaTHqOxzKhOlV5VpVpt+3eiB8u55QMpZbtGuX1vINrB/FGEhPQBNwEHCM9baTcfUZSjHL8o5o6MVQup2HPTmMZ/YAa7qlJ93/8FaHQl6UIJ049eEWENkYlEPmnjvUvbo+46LXzKB1Q10x4g++ADqJYA2TSPkiaHaQ74m/BHmc4LtUT4UKm6FqYxA9UnxKPB6fBBjXiqchGoWOTtwhbuT0593zuMujl4gZ9TVFUifTztjJQ0mIYyiuDthfV38BZf5HqO4MSA1Co2jGdREvhRhzUDZ0IC5o/eH/PZrcz9H0NW1lxlIpNXvZzqtle6ChprkBYCWZB9WMpgAtJRpfY/6jA3OWuMRfWzINrqK4MzyjY0dLdMl3ltEq58px7yZbJIjo0z9eaeITLzy50F7uNSBLZk37ahxSAGy8EBHyDBRa25O6DrUyFqn1685ygdRMgh7nm+sDGNUdct02w19lig9co6dz/1DK9ClEvpo1f6hnUAEpLeHfU5S1tv1ogwJFqkIfKD6jAvulUQX1tPtX6+wsKD7c6NvnzJVkrgLOZHnvkpfYeNg+EiFjFYf8EJ0jRvTufoAURi/hoewCHK7iky7DwIStjR6ke8UCPhFKrCQLpZBKo5gOvptFcywjsLPotZzZ9dErJuaux4famWXwL7lRA5xPvVHFUloL817T5Uzg hcyQVkB9 sbO7K+ztQwZVkS01jGlbNRhcrSSPPeHG5Jzzb1420CHG6xy4s7Mow+WO5ZgfRclgVg1TRAeZCkxioxBnSABdvVeYhnsDmNXrjS4TbKkHPYhRw/RF6IPOeK705kJaIseHZarGHagygNZoOBKfgxAVh6QvWubF2dYGaFH1eau0+DEqN7+dsd3ZKQtHWVRVmALkNT1aK0eEsHmqwbf2eWvgbBkbNnbxyO2mKQmc8pZ1YGs55YOiX9IznISM3s5MHiNqYbeX1ETRHjBzgU7NnLs6N731AoLeQGJUsb9CUpgMuq5CMhB/Udv8Wvr8e3RPYkOx03KirvsHKe2d5NYakwQU21hwAPWERmtZgNvcK0R7GE8HnWY28BWUfEf45S31MygaSqSwoUOPR8iNkbGoSon7RsyRwz7zrsuBTTNAAiTX2yHmZxTEgnsR/4VOJGOcXSpz0gs5ZVWJC05Ay748kcQLlLJD0Yc8ggzT6IMJNrS5+jPc+g7I0uFXGkT9yvsnGoRPmp3E5+NDDZii6PCAEw9fo1R1p1AKdBa9dTvLPU9KrLViiJIYRxUIY7p+/Kg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 08, 2023 at 11:23:13PM -0800, Hao Luo wrote: > On Wed, Feb 1, 2023 at 5:58 AM Jiri Olsa wrote: > > > > Use build id from file object in stackmap if it's available. > > > > Signed-off-by: Jiri Olsa > > --- > > Can we insert the lookup from vma->vm_file in build_id_parse() rather > than its callers? that might simplify also the perf code.. we might need to rename it though.. maybe build_id_read(vma,...), I'll check thanks, jirka > > > kernel/bpf/stackmap.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c > > index aecea7451b61..944cb260a42c 100644 > > --- a/kernel/bpf/stackmap.c > > +++ b/kernel/bpf/stackmap.c > > @@ -156,7 +156,15 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs, > > goto build_id_valid; > > } > > vma = find_vma(current->mm, ips[i]); > > +#ifdef CONFIG_FILE_BUILD_ID > > + if (vma && vma->vm_file && vma->vm_file->f_bid) { > > + memcpy(id_offs[i].build_id, > > + vma->vm_file->f_bid->data, > > + vma->vm_file->f_bid->sz); > > + } else { > > +#else > > if (!vma || build_id_parse(vma, id_offs[i].build_id, NULL)) { > > +#endif > > /* per entry fall back to ips */ > > id_offs[i].status = BPF_STACK_BUILD_ID_IP; > > id_offs[i].ip = ips[i]; > > -- > > 2.39.1 > >