From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96B7C05027 for ; Thu, 9 Feb 2023 13:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12D8F6B0071; Thu, 9 Feb 2023 08:10:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DD706B0072; Thu, 9 Feb 2023 08:10:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0E3F6B0074; Thu, 9 Feb 2023 08:10:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E4B7E6B0071 for ; Thu, 9 Feb 2023 08:10:25 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B91C9C0EB9 for ; Thu, 9 Feb 2023 13:10:25 +0000 (UTC) X-FDA: 80447787210.15.6313F8A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id E0150180016 for ; Thu, 9 Feb 2023 13:10:23 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IbxJAcxI; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675948224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LawwaK/yAKjY5g+XV6BBxg8MJwf55RJqkRT68lynIdw=; b=HQ/i4Z2RuL3kvJdAcifTLBvsO5Gjh3EbBpcsrfFPt7TZEWF5tZSlZitvAeSmA+YclP+RCn HLA8RFy38qKJo5yABcodkPdCcWr2MAUKIH4sz4uMnnWqu83qp+yRVJpqoYwE72gF/BPSYp vqYlajvxz53XdLZnYY0JvoO7BXNQT28= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IbxJAcxI; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675948224; a=rsa-sha256; cv=none; b=q/TrNvaLxmeF+zP1xyGVVDp+JQBYeFsqyFUXoB2XdKglankiN+6CaYzTqMU7xr3bvS7I0b 7pmBJS24j9aOkz5zCHrNnJyR2ET04Dgn3j+a669UeTFdEkAgwmvb5RyjDp3bQGvcsrw79L BsIW4v747TOMN5pEDNm9aCpdm9JL9i0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF89961A51; Thu, 9 Feb 2023 13:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACE6DC433D2; Thu, 9 Feb 2023 13:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675948222; bh=4SUmqquqGXJoK6fqr+/rMnpLfSjMEDdKWErLzFfQiqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbxJAcxIY5aZSy8WxcV0uALiZbcIvWCMEUPDCaMmQmTjiQVyI8lF/94iQfqQkdCZM PZdv9ca/F5KivfuWiigTuT1SG4/YCVTOKKrjerMnwjdv13ix9huD/Qek9w27t8GKxv /0flF45ld1/3Dwvmb59C8wusQ0kkPeVcdiTwazc73m56FwcDU+91btuUha2TNEBd17 sIBgdMUx69bJVjv8jLvPynF3Q0q+WWsdyDNFUw9M4nydY7VZwZ9zLcAjARLixKOl+k V9YQTg4QS7b+ll5deXaGt/mqSV2Tb1PLjcJkpxxw7BJ7Md1ZxYhttiprhhMKhtEUId DBKpdSpSELI1Q== Date: Thu, 9 Feb 2023 15:10:07 +0200 From: Mike Rapoport To: Jonathan Corbet Cc: Kuan-Ying Lee , Matthias Brugger , chinwen.chang@mediatek.com, andrew.yang@mediatek.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru Message-ID: References: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com> <87a61wvtcs.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a61wvtcs.fsf@meer.lwn.net> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E0150180016 X-Stat-Signature: jmkhhitjye9c7bpgkhwb77j3pxemy3d5 X-Rspam-User: X-HE-Tag: 1675948223-339754 X-HE-Meta: U2FsdGVkX19IJSgxlq/1oVLhg51FwprbAAwakF/kFhulh44mNnDe2vRKjMTq27Y477Sc0Y3jSH6GVj22qDimMlYBrq4nJFKho7hIid1TmT0Vv6gSjKuojo3o5iwVw65amFfs30fWwjEfpHwEWydv6/LDd1x9psy4SUZHxpiHNOKLHXjCIltjaM73miu0r5HB9LWcI0W+STeTlyWwHYfq1Pi1tgsFLQUkiaam0qQiBo5dCQkjO2nbB+pKYwTjHiYW8/Ag8+pyioGXHTNmjmkTKA12p4FFF7QtLjq2oaprN8OUh4SqhznlBxEk+1h7jxoVZe2sh83u67s7/bX3vcPwF2c7D4kV4rnUjPZYPQPfLxWhVH/Zn1RA+DZixmBvH9LJ3cVKxkA7/aIzkWK2dYsbwqIoFk+vyYTe/TxkvR2z/c75ExbHz29xnhYtJtkQpWN3BWIS46Ful47NKhYC4legLr8xj5C3UoT+ndXrN+3P80/wak/uySZ1C0Rgur/f/Qouqim79Gfo1Z0lXWUx1K6tyHt3hr4g6JfOMIrmvUCDhh1AaWY8xqUxmQ8nlbPHLVrs+mICpTzs0AP0rjHRUpGbm6nFiLLqn45ZqvbU/z2d4qqYZ7zJgb3dtbEVBgv68iSspNBVbeCNFmnXgSylQDkNFAV1uzOOFoL8wlvvUdJq8PAajlEuiQq6zRqeFJvAgKK1OoOe58evOjUngZaygKnJo4l+yD8dXy5mXmIFeiItsiE5url00VP5qJqwaahQGiZaBgPfKYxiACBHluQERuUED4aPuGCAr7O1yFI2L8kXKK1m4Z9bcK5MMnttvbFXCsNIbb8dvroXao6NL5i7x0uy/5eRsJ9CR+sBaIggeTXREThyN/M967h0scFT+0Y93cP1rxco694+hXv4p3BRBW7rrg7NEcfR9jXUIC1ZdAL/PagCDNPMuK1phV8rhTlcRdvBb5j2z1f79ciO1GEzyr7 XOLVQEvJ FAF1rnzaHxmzA/fzYeNVZw0L8iuTGWhoUkJCJ7FDx88uijoFa4JQWnlCVgL7tcrGgnvUKhUQ6oiHG3Ng4jbYiz28awtezoo5waBa713/aKENvXzwNELbg57UAEsN6wQZwlSXMAUE02uZgv8ihNdhhK3O73SU7xMYk2B+1SGY+8s1ic/ZhiP2Pf6pZojSweSbCiJnvWG23WAmhhfYsZkGg5nHgzFrypUbTaE5cknKD2Lb2km/AhMe6GwXTk9bBvVQI2ahHaZ7yS3/Hh3mZe7UCYYssfJIXeVRMdTui2gGb9wfzWkh7TjegyGS27xM2acocdQAx4ogTiO1Tb2U+BFdyzD+169DIvBtgeDcMdocAn2P1C2KgpiY9thAJs8IUZfNwd2Y2vSMpYgKmFR20xDh8Dxp5ROhe92e8c4WZISv/iDAcUTh+xUmxpflewYLc7sm7IAE/GsvYuOwovjGeb7Y4i4HDGv7sQbXEpY8hGHix9RpZ0aI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 11:02:11AM -0700, Jonathan Corbet wrote: > Kuan-Ying Lee writes: > > > Since we introduce folio, replace isolate_lru_page() with > > folio_isolate_lru(). > > > > Signed-off-by: Kuan-Ying Lee > > --- > > Documentation/mm/page_migration.rst | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > This seems like a good patch to copy to linux-mm - done now. > > The patch perhaps is a closer match to what's in linux-next, but it > seems that, if we're going to update this document, we should reflect > the use folios throughout? Most of the current users of migrate_pages() still use isolate_lru_page() so I think that updating page_migration.rst to folios is premature. But when we do the update it also should include the translations. > Thanks, > > jon > > > diff --git a/Documentation/mm/page_migration.rst b/Documentation/mm/page_migration.rst > > index 11493bad7112..1f8cc175d770 100644 > > --- a/Documentation/mm/page_migration.rst > > +++ b/Documentation/mm/page_migration.rst > > @@ -69,8 +69,8 @@ In kernel use of migrate_pages() > > > > Lists of pages to be migrated are generated by scanning over > > pages and moving them into lists. This is done by > > - calling isolate_lru_page(). > > - Calling isolate_lru_page() increases the references to the page > > + calling folio_isolate_lru(). > > + Calling folio_isolate_lru() increases the references to the page > > so that it cannot vanish while the page migration occurs. > > It also prevents the swapper or other scans from encountering > > the page. > > @@ -89,7 +89,7 @@ How migrate_pages() works > > > > migrate_pages() does several passes over its list of pages. A page is moved > > if all references to a page are removable at the time. The page has > > -already been removed from the LRU via isolate_lru_page() and the refcount > > +already been removed from the LRU via folio_isolate_lru() and the refcount > > is increased so that the page cannot be freed while page migration occurs. > > > > Steps: > > -- > > 2.18.0 > -- Sincerely yours, Mike.