From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2123C05027 for ; Thu, 9 Feb 2023 14:04:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 104826B0071; Thu, 9 Feb 2023 09:04:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08DFA6B0072; Thu, 9 Feb 2023 09:04:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E70546B0074; Thu, 9 Feb 2023 09:04:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D130C6B0071 for ; Thu, 9 Feb 2023 09:04:19 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 97E2540F9D for ; Thu, 9 Feb 2023 14:04:19 +0000 (UTC) X-FDA: 80447923038.26.001A10A Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf07.hostedemail.com (Postfix) with ESMTP id 50DF540021 for ; Thu, 9 Feb 2023 14:04:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iZJRZxrJ; spf=pass (imf07.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675951457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/PUxryEd4dhrO7bv0OIAXlQqcpfOYRHX35DELWBAPHE=; b=uc+cdSsGcp1Pcz183Q1FkxdFvnTaYfmnABf+4CSKEmgLfcpAyg2w/9X1RNEQKFPw0uPGOk 66UZkn6T7aBrIkHMxcum6LIXJPUTg6W6dopttCmG5CyhRwS13EfNwRkgfvsoyRb776dsc/ ElTbrGZcCKq4FMFmyV51fn91jOOE5LQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iZJRZxrJ; spf=pass (imf07.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675951457; a=rsa-sha256; cv=none; b=aGkRTBI802EIAkJI05DakAV2lHm3N69ZipP7B+iqFYE61ELKaAq56UHvmJ7VobPQu8x22Y evD6fGeKqsyIG/H2sDWPchw43xApSmtUOXa3w8l0Mcu3Zz0g2T23CvMyF5+em63SGV08mo j5WF/QWb4D20RlTTi1n4Vq56qW3kAE4= Received: by mail-wm1-f51.google.com with SMTP id u10so1497211wmj.3 for ; Thu, 09 Feb 2023 06:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=/PUxryEd4dhrO7bv0OIAXlQqcpfOYRHX35DELWBAPHE=; b=iZJRZxrJefggzAC+FvHDTR5gLHr2uHOtDx8X2MdTdeIgzrzDG6+ByN0Vf4uv9rbdJa 0MDoPsaegm6+PTbsCeRrIagMBvqPuzr2uZgBUl5tcxm8ne9n8LsmVBYHokjdCxILpZxg lqpWDghfBS1ywAJqFT7yJs3O/js1VCARGvfb7N76nxzSNSLWejE0lU+9nvtZs9HwdpBO d1lnFgGgMUdH+V+IxsKZnRkgPWhYRON4NyfgJEElTfQP3AOo0Gruo8GPcnQtKou34Kb6 cT46EXKlM1V7w/af/QS5WDqFwniA7H85MWFGufBNMoBZzK45yyPtv4FWFgwZQZXUTKK3 sRkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/PUxryEd4dhrO7bv0OIAXlQqcpfOYRHX35DELWBAPHE=; b=7qyAzhVuwRbjQEZ022B/ia9BTZU6SKCN31YBmhpsCt0F0Bodhubg9fJA1b/P6SmDq5 ZC7cKk72TRL8DF9kpJi4KEkJ38NlIbUYsN3+A5YBZmx/KGkaTaEmuyDddy/oGvQDPmzr SI5IL5JPqrBzt5BrhGNHNIJwvNR9wp1+N7lsuWm8HyimE95ry8IxzrpRc0CCJtSlaNtY o43voq66/9fja2Q+58g2OtmnvJICfRChywjkhxGYAH4X/wcxUegFeq5fkKQbPHxREXsE Y51yTJsEOMFWJkH6EhQ8UEzduprl9LS1w/f5AMlI0EUt0C1JBbeO/getmWAY5Fd5PnZM 3Fyg== X-Gm-Message-State: AO0yUKXyMW6DfzK5jI0hVrSq0lbs+pACIuCTZSWEFNFESzzDzHnHr6fO Wz32S8yktER5hz+XhGzRKCw= X-Google-Smtp-Source: AK7set+dQJhhuPXnb9xc8cpZgho9rV47XxrGh3m7mcorhUF5e31qI+vipv6EPg0wYlRKPwf3t1OkIg== X-Received: by 2002:a05:600c:3d0e:b0:3df:efdd:9dc7 with SMTP id bh14-20020a05600c3d0e00b003dfefdd9dc7mr6197494wmb.10.1675951455884; Thu, 09 Feb 2023 06:04:15 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id u6-20020adfed46000000b002bf95500254sm1378133wro.64.2023.02.09.06.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 06:04:15 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 9 Feb 2023 15:04:12 +0100 To: Andrii Nakryiko Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Subject: Re: [PATCH RFC 5/5] selftests/bpf: Add iter_task_vma_buildid test Message-ID: References: <20230201135737.800527-1-jolsa@kernel.org> <20230201135737.800527-6-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 50DF540021 X-Stat-Signature: 71qtygwx7f6yr7ou4su99wmoi1ifwzpp X-HE-Tag: 1675951457-847112 X-HE-Meta: U2FsdGVkX1/6M261PTJePqk/LcXrX4zFHPYcSE30yvnqNQQaNTYNKzCKYzynKQqQ2NuK+pxzMC1QR10tEY9JXlBFvVGEUmEfiQFybIsyYBRWWFHWKD3SJ8F603LiIltKRLu9ff2n8H0B583m1cxT2JApJJ9SnGU9O6DBjUmkhprjy4hr7l8s37lx0Jowsv+vniYQ5lvbEkdvdd878pErYHoyrx2QGzRs7dO4nDpwDo0FRQIPXf/7kT5/or2QLT+ugOviXAdjVVdlbi+NaSKe1hzVelHvemCyvMNck02QINR8GpMbKeJZStZUgE2RlusnQ1Y9f4eQnyFJhUKBPxsHOnZ13XGTCco1fiziuq0A5rHHfTvBAXFFlYKIDo+POfzE5tYhUP/zZO3xknRMspUqfqsRgL20YbV5UgheFP/m9ciIr5u7VcCigj4YK64t1hKCwolNoDgWp3BlOHY+Z1fri5zGLP86crIV79cQZ/PpPG+IBu0XJ7awkqNsMJsU8a+xK9T1cv4qv6AjArttkeQSiZbocFnTm1AKeVhoxhaTw4xJXyIz0Wwaz0zDIplyW/GhkY33rlqcUNAkk5g9OlbFHtq0GXyJBHuY0JFD64axNcAiZGWaH9InJt+zC72sp9TRZ+D1GzK+P0wdjMA7Dxu+4Cm8mjzLzl9Rilln/4cUHW4NL0h7gmSh9XDKdjvQtB6QG6SABsQosxn9nD9s4UK0DNlYw+rZjX2v+XIry9I3mYv9Yb+c5KrvQlYnYD1HTzEhOf4YlKOhaIjGqi8NjdErbaI5lKUCpMKDU62fu9j8JMbhxAyilHSac+kHvQNeV0VaKoMYu4F1BQzzShdEesVAL8GarJK7YrqxWKeTYDxHhU09ghzsNpHcqG5AXK0aTWP+z1R5MciPfMl+TmmSy1SPFajBjeTOGs6Qhwig+QlcCpu4Cod7QFw38HSdroXzfS8OmthTbvg+pvjJdZbQDLN LRt92/sH DqvFs22a32n/M0fa0W8ztiFXxSLQVeQ5D5aFJHy/DnOryjfPX7685PmkA8A+N+5yH1rds6SNE/2ZjkZ5BO0PmqNCXsTfy5DLjyw4bRYrzHYnNNy9f+WW6NRBx5130yA6EmjaCajCWKAbKs427Z8mGkqJrnOiglKSPitgbzMpzPcs/3gWRK1+x1CsCKegFIWNsFC3Fn6Xb5Tq76KrRH+gfkXFtSdvvW+as0773NVLSAFbqTPUUZh9+BezxdrYKErAAZr2jICVboElNTAbo+M56uzPKMM9xO8SuZUHT45ZMxs/BGTVMKhmrAgYKTRB/2/Myh4vGHhbwSeYPCt92a9PlWySN6F5bhg5pjCSGa0Cb+dY9EQN2YZkvMRXtJZrsIgcMOd0x2I51j/2u90NqqrCzRN2NB086z9qFp3qitDrza50uL/23j8bNl4IQ7bHfrqiNFhxNcxVhVkxQDDeoGYGej+RDXw7MqUnz4EwA8MZBv3TanHR1ml+Y2dQw6nwrFhnjirG9F5T6lsd1BLcc9BJJLfuaD/uivxXRX2R85dAczE83u+4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 08, 2023 at 04:01:42PM -0800, Andrii Nakryiko wrote: SNIP > > +static void test_task_vma_buildid(void) > > +{ > > + int err, iter_fd = -1, proc_maps_fd = -1; > > + struct bpf_iter_task_vma_buildid *skel; > > + char key[D_PATH_BUF_SIZE], *prev_key; > > + char bpf_build_id[BUILDID_STR_SIZE]; > > + int len, files_fd, i, cnt = 0; > > + struct build_id val; > > + char *build_id; > > + char c; > > + > > + skel = bpf_iter_task_vma_buildid__open(); > > + if (!ASSERT_OK_PTR(skel, "bpf_iter_task_vma_buildid__open")) > > + return; > > + > > + err = bpf_iter_task_vma_buildid__load(skel); > > + if (!ASSERT_OK(err, "bpf_iter_task_vma_buildid__load")) > > + goto out; > > minor: you can do __open_and_load() in one step right, I copied that from another test, but removed all the setup in between, so we can actually call just __open_and_load SNIP > > + memset(bpf_build_id, 0x0, sizeof(bpf_build_id)); > > + for (i = 0; i < val.sz; i++) { > > + sprintf(bpf_build_id + i*2, "%02x", > > + (unsigned char) val.data[i]); > > + } > > + > > + if (!ASSERT_OK(read_buildid(key, &build_id), "read_buildid")) > > + break; > > + > > + printf("BUILDID %s %s %s\n", bpf_build_id, build_id, key); > > debugging leftover or intentional? > > > + ASSERT_OK(strncmp(bpf_build_id, build_id, strlen(bpf_build_id)), "buildid_cmp"); > > + > > + free(build_id); > > + prev_key = key; > > + cnt++; > > + } > > + > > + printf("checked %d files\n", cnt); > > ditto both intentional, first one can go out I guess, but the number of checked files seemed interesting to me ;-) SNIP > > diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c b/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c > > new file mode 100644 > > index 000000000000..25e2179ae5f4 > > --- /dev/null > > +++ b/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c > > @@ -0,0 +1,49 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include "bpf_iter.h" > > +#include > > +#include > > + > > +char _license[] SEC("license") = "GPL"; > > + > > +#define VM_EXEC 0x00000004 > > +#define D_PATH_BUF_SIZE 1024 > > + > > +struct { > > + __uint(type, BPF_MAP_TYPE_HASH); > > + __uint(max_entries, 10000); > > + __type(key, char[D_PATH_BUF_SIZE]); > > + __type(value, struct build_id); > > +} files SEC(".maps"); > > + > > +static char tmp_key[D_PATH_BUF_SIZE]; > > +static struct build_id tmp_data; > > + > > +SEC("iter/task_vma") int proc_maps(struct bpf_iter__task_vma *ctx) > > nit: let's keep SEC() on separate line from function itself ok > > > +{ > > + struct vm_area_struct *vma = ctx->vma; > > + struct seq_file *seq = ctx->meta->seq; > > + struct task_struct *task = ctx->task; > > + unsigned long file_key; > > + struct file *file; > > + > > + if (task == (void *)0 || vma == (void *)0) > > + return 0; > > + > > + if (!(vma->vm_flags & VM_EXEC)) > > + return 0; > > + > > + file = vma->vm_file; > > + if (!file) > > + return 0; > > + > > + memset(tmp_key, 0x0, D_PATH_BUF_SIZE); > > __builtin_memset() to not rely on compiler optimization? > > > + bpf_d_path(&file->f_path, (char *) &tmp_key, D_PATH_BUF_SIZE); > > + > > + if (bpf_map_lookup_elem(&files, &tmp_key)) > > + return 0; > > + > > + memcpy(&tmp_data, file->f_bid, sizeof(*file->f_bid)); > > same about __builtin_memcpy() ah ok, did not know that, will check.. curious what could go wrong by using not '__builtin_...' version? thanks, jirka