From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2E6C05027 for ; Thu, 9 Feb 2023 13:58:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D64756B0071; Thu, 9 Feb 2023 08:58:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D15526B0072; Thu, 9 Feb 2023 08:58:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03CC6B0074; Thu, 9 Feb 2023 08:58:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AF2E06B0071 for ; Thu, 9 Feb 2023 08:58:28 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7DA0616085F for ; Thu, 9 Feb 2023 13:58:28 +0000 (UTC) X-FDA: 80447908296.19.FE9A29B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id A177BC000C for ; Thu, 9 Feb 2023 13:58:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JZUXBWPb; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675951105; a=rsa-sha256; cv=none; b=5SeGH1QkuyFTqbmpcr66LUeWHOk7IlJUyFUg7+N3K+TpuztpBM68SlF43q5VhlrKs4hXnA RAvuzlwsyC3hwhN+mTcYsuD9laXai0Ha8SazZTsYhPS0ImrE0qFqbBMLtMp0OVj962LA3Q V6o3K9g0jnsGQe2ehaGLjuG/Yty4s8I= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JZUXBWPb; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675951105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SgJMYSTcwLM1ixgRLAPd5jJAf8M0pVTq8SAJXoBvwMk=; b=KmS8y6ycfovO8xUA6WItsfQUBl9/fxxRslEEjI6Dqvq555xEIIO612J0CxktEXE0+zP1H2 c54q5D2RsPkTcdAiclNB0ETGwTETs1jyuNSInKN6scePz12/qG1AvJs9WyoJb0okC+d8Hn 76Bi4hHzjArUtgaoMDKi7cEgI/0n24k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SgJMYSTcwLM1ixgRLAPd5jJAf8M0pVTq8SAJXoBvwMk=; b=JZUXBWPbQ00z8TXTU+ZxSGwxJ3 nn++ZtwCXNQ7i5ca8YILza2oM3JOdiT9EIubWY3IbWuZiJKxSvGFHSH0jViD0/QWLn+QEqWUxrXRQ VYbos8eOlrsacOr3eWvZAhUCLDzUYehlDtcJCm2cyN3ExIX5Qy6fEhWXbWJeoW0Yp5D0VYRvSkGLd /OdhUc4UVAtX/1g1bTk7M1Z7OIswzjACzDGIYdAcXysS/22aha7l/bvAjN2mlOHVHf4tTNPAqsaCC p2af01D5ggKiN1y2EvmvqZeIoWpIN7XLISiwKiBqPT0TLBrgzhEmRayHsoE5Xeah58INu+DB9MPDZ jAvvtrnw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ7RB-002F9j-E0; Thu, 09 Feb 2023 13:58:09 +0000 Date: Thu, 9 Feb 2023 13:58:09 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: Jonathan Corbet , Kuan-Ying Lee , Matthias Brugger , chinwen.chang@mediatek.com, andrew.yang@mediatek.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru Message-ID: References: <20230131062853.28449-1-Kuan-Ying.Lee@mediatek.com> <87a61wvtcs.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: A177BC000C X-Rspamd-Server: rspam01 X-Stat-Signature: ypn8my1phzuxdm8cq9w1ntssfs6nqocp X-HE-Tag: 1675951105-670022 X-HE-Meta: U2FsdGVkX18jfggNmCPqdzysSZvBeEwl2ItJKE7+lFaaio+zlWgAzxxKhbji5mir/FBA0AkDnz9icV3qBTCMCJzAF6BzDEeEJCxL4kLfuHMfelJSOy+nwgWg/G1FZMPrAsxllSZ6F7Lw0uZDAm/n+Zp8IeXVxFIgK1e7WHYlw0czh+60qpQ2EF1yQdlgN+u83OpQ42zTPq9VUVhAlc21Y2w117PvMmMEJkml6FJJmY0i07P1VcueN2LDm1EJwCDEzkemDXsSkabwfdOAHXf4BFVif3s3XNMhuxZ8aLzywg1UbJ/jQoSfFZEKKw1PaZD/UOOy6zn2ap6cXX/Ke4Mv/yeRztszF8Hgeb3GIVhoQME2xRgkS5mHTpUOZ5DXdC/MGwl0Xk2E1sG02mP3ykw/obXcnb7gh6CFzbBhhfkDTCa6vWYVvt956iACwE6MqZEt5570i5T97L20KdIaMzeAJG0tS/UZYIYFUB7QLhSr/xGAOBLm4s17vJ5UpVNXBN2S+N0hGVwloQ6ZdR8WddaZPqS1P8Z1MjsrPdFGqdGl1xhzezRemOrjmsHVDzo4sTOHpKzrZm0+ftD9XvhYTPo2ZkmicvaHJorVkmZNAnVcDth+Ff0pTp6tfEBQqlQn7ZquLfC5xKe3txn0tsYUVHQpozrBt5xEqhnMkF3G4UEY0tq2eh/9k/vhL3GADJOObHRTF1RnMFO+a1F9TgyIK8v+DmMRs1tJTR5YVIjrIzMm9nmaKhRi5Z+hp/btCUl3d4/t9UhM7BkTGWJ6gv5gg6mCSX7hRb+/llsiccrcFaugjyWkslh7d0ljpikzGfJ9UOrhkUjbIo344Gpp6ORd1EEMXaBod629TZVzdHu/ycMQoa+t95D8QLVu5Pu7Y61PJZQ6Oxc/FBAq9UK5l7p9U36S/iY00EqXyGbXbCg5LC4GVJM8AUWAt1FC+uPl1UQW9I+ai5pEjl3cwHNXvWE/aoI 9lMTJruM eaGv/2c6n5bYiKslDvZffdQRYtF0GyCC8IGFnYD2NxPWCdR4kC75h0+loCR7Kzhd9U2jKDKbZUcZtCQnFkn+ptP46n8dY5oLEuGMmuvr+K9pcNAH4iPwcuuXdvDFpEuTCYDJHwPXUAKedEHiQFPPm/56rrk6SosR+hmBl3Rz3frLkdqdFVl6ussaGI1njZaw1ht20AKeAovL+k8Fr7/HX0LaYy2H7kDSyGd4Ff5xBDaQS/QjYqL/xWyYxPPi6aoq3NpO3HKyw7xhbIiXfPM/kXTE5c+aoV6dulU5lPu73zoMpg6xBGxprJArv3PGtxq1tM8LXJvmkQZFmkhk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 09, 2023 at 03:10:07PM +0200, Mike Rapoport wrote: > On Thu, Feb 02, 2023 at 11:02:11AM -0700, Jonathan Corbet wrote: > > Kuan-Ying Lee writes: > > > > > Since we introduce folio, replace isolate_lru_page() with > > > folio_isolate_lru(). > > > > > > Signed-off-by: Kuan-Ying Lee > > > --- > > > Documentation/mm/page_migration.rst | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > This seems like a good patch to copy to linux-mm - done now. > > > > The patch perhaps is a closer match to what's in linux-next, but it > > seems that, if we're going to update this document, we should reflect > > the use folios throughout? > > Most of the current users of migrate_pages() still use isolate_lru_page() > so I think that updating page_migration.rst to folios is premature. > But when we do the update it also should include the translations. It's a slim majority -- 9 of isolate_lru_pages() and 7 of folio_isolate_lru(). I don't think that changing the documentation is premature; we should document the functions we want people to use. I'd be surprised if isolate_lru_pages() still existed in six months.