From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2016BC636D3 for ; Thu, 9 Feb 2023 05:59:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFA4D6B0072; Thu, 9 Feb 2023 00:59:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAA466B0074; Thu, 9 Feb 2023 00:59:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9737F6B0075; Thu, 9 Feb 2023 00:59:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 892026B0072 for ; Thu, 9 Feb 2023 00:59:35 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 684171C63BF for ; Thu, 9 Feb 2023 05:59:35 +0000 (UTC) X-FDA: 80446701510.16.F72FD9B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 976714000D for ; Thu, 9 Feb 2023 05:59:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OculTekP; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675922373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=etkSJGPEKv1rXfDaZ7FyhS9c9LAFUhNpv/0TtRwYfgc=; b=RlDr/KjjTmSBSt4a7Fd7d1RsBQiajbEVFHYdb/jFWJQuUwTDjMeqvUyCr7VpdZEf1mBWht SU9hCZKzlPTtEhvUZPi97aeaRC+y2oso+/aUXR8UOSL6iJQOrZQREpBMBmZgQhnpsspW5I QdzB7SbBPLrfn6DPgD5zxTyq42LD2SI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OculTekP; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675922373; a=rsa-sha256; cv=none; b=lWcWY5VlVerO8wPtK5MMYEdpoERYhO03znh0sHI0PHmovVRZ+z7OA99dVCVWLVxPPCosuL tS35AJWog9kFOlWA0c2lwrp1wfJ7kD9L9bhsNNZjT1juNxRdhnOGMYnUWTdbrlIQYBYhqh e2Usxi+Iqj8Ay8FE5JKVEeI3Vi/24PU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D9DE61870; Thu, 9 Feb 2023 05:59:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A2B4C433EF; Thu, 9 Feb 2023 05:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675922371; bh=C3PzIyt2T/NB+g/Zf8/N5OjMn3X2HNTvVkA2m4KLgY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OculTekPRb8o5jkmwqmVaE7Zf0U8O5GJqyWmZdkRlXkuUXIpjxhrSe3iP5QWlV8os Ev1tH6HbFCUgpiwy5vwBb7n5CK6GQy+fP7f0LA3nCbWXVSnCRLXyBKBFLNOGGoyuo4 Bggg6XiTjJ2pqaFGhALv3rmCqzV1b7jiBJzi1PSYQBI/U32qn0q88X4AZ8r8Rv6d0X Jk9rnpFVv9r+Qvo35TwRjEtjYPT4uuZrdc3GGmS4KVHBGfbcIT11Np/htuueEShFIq X/CZ6D4s0tIyWXXPBFIcdwl9OW29FmtmkYk7q7jRr5Wn5gtzAEK+gqoT9LKwAYS+DH ES3IJfxyBjMYw== Date: Thu, 9 Feb 2023 07:59:17 +0200 From: Mike Rapoport To: "Isaac J. Manjarres" Cc: Rob Herring , Frank Rowand , "Russell King (Oracle)" , "Kirill A. Shutemov" , Nick Kossifidis , Catalin Marinas , Andrew Morton , Saravana Kannan , linux-mm@kvack.org, kernel-team@android.com, "Rafael J. Wysocki" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 1/1] of: reserved_mem: Have kmemleak ignore dynamically allocated reserved mem Message-ID: References: <20230208232001.2052777-1-isaacmanjarres@google.com> <20230208232001.2052777-2-isaacmanjarres@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230208232001.2052777-2-isaacmanjarres@google.com> X-Stat-Signature: ocenpbcedg6zm46w91ta6jqbreq7xgjc X-Rspam-User: X-Rspamd-Queue-Id: 976714000D X-Rspamd-Server: rspam06 X-HE-Tag: 1675922373-638036 X-HE-Meta: U2FsdGVkX1/kSvOVu2Wy5AuPA6EggL7+ijAQ47Utvk/E5+niGWuyR0P9riATV5wasTVKyLHdd4XXvj1l578KDPb8jtCOpmqHCg6u730CcBvazlFbmmLVS1Cfdv7bYOHpxj271a8BVyDrYXA0NruanNA41xY/IiQH+mkq6myIGyqoVyQXKvzwiR6U5xlA8dJfqhl1qNS0vJW7l2o/3SxXnoh6xQef2DLMlhRBOyiipXCUlFyNGq9xuYmdPx+J7xZB/BTh1PA4NBa+nP34M/7UlrYJ/OmBWi3BuPk31H1EnUiJ9VQPhIZWU1QySHWQQHglg7loB2cdLYI5AomTkwaHhTKXCHk9pXy9ZPr9FdJQggiZpVcD4p1ZTXP34H+38McEp8xgEqGi8QPpTqrLU4NmxcUyhE3Op3btrxQ3uam8+2n2odr+f6Ni31zxv7yMzqVfyeICYngEduxa47YnbSiOZ92JYNvmetlW5EsuFLhOmpgTZJZ2jk7G+MpB2ZaZzrgkQp4Kl4kQkbuFv/Pekv739NtCtovo+dt7HKOFqGYAfSm0QaFOd9s9aF7xFgxRbtNlQnBdnde1WFSoovS3T7UjJH3ujdpm2h+zNq8A6YTorJ/X0+s6myAqSAdu8mGFDUaqkgVsuxnfnatsCy8lpRnxTjjsG/oYulQjBzMu/wzuRY7NJ0hajVmgqtrh2DD0sW12WL6XyCmQrXJUH9gYwTOhMF/GAluUtigFrdCVbfUHLweejFWzvPl2wYV8ExvjB6tqcIpIz5qeiLQGuT8LQm7jTb+u0J2pXKUvbnkiYaZa98mf5ZZWlOaFhOOIjhie+q8Lfq2gWyF7YujMAPPatalH0hInFxPcniAvyDdMBrSZ1vGiaxYA2ifgKteCgvje0K0+H7SXZjCf2+KuPd13KzzbdaNeqWIchCNY+5gjuAD+/Aog9XeBQ+D8em7WBLj+M07jx5kzal++8IYvulQAK0Y Jcgpg6ss yO/6rk0qnNOZdJ7UYd59LWVAkkFrGGDe8kxvefRWYTilQruukRfEkqO1OlbAQYJW3z9ilWUhU/XxC1nhOi7SQr1IR89L592vWpcf8dcCoSM5i4/ba2tuvcchHThtl616BU9w/bS+nEqMUqtE6m9iRg4tEF/UGEaOYLTmcDcL688/VKEdTh4nJd4NfE4lga6PboQkZWHln7jnX8IHs+vdOxTvOk7d6RCDY5mxiNJidsDG9up0z/vU2qSH4+VB3NjXSsJllRZUeP1uQ5F3c5v/jxWVfbtxPm+K69m6h8EA7rJp6NZa4rpxAarnKfYbThOjfmqi8WNiBawsOix4nDd4ZVPAKBZPz/+3q6QkQF6KjaooYMkWx/otns9IiaeNpVua0MwXtzrWXYctaiuGm9HRWaruoqzITmwhB/m/E+Uj/JQGeeqMb9sGr+FezDTggTMfgSepHUVAVx/kzq1NZIeN9awzE23psMWk1vFQWlpajG8hKQ1zC0Mmm6O6NAvcK+DDBcbNiLUoLlGipWPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 08, 2023 at 03:20:00PM -0800, Isaac J. Manjarres wrote: > Currently, kmemleak ignores dynamically allocated reserved memory > regions that don't have a kernel mapping. However, regions that do > retain a kernel mapping (e.g. CMA regions) do get scanned by kmemleak. > > This is not ideal for two reasons: > > 1. kmemleak works by scanning memory regions for pointers to > allocated objects to determine if those objects have been leaked > or not. However, reserved memory regions can be used between drivers > and peripherals for DMA transfers, and thus, would not contain pointers > to allocated objects, making it unnecessary for kmemleak to scan > these reserved memory regions. > > 2. When CONFIG_DEBUG_PAGEALLOC is enabled, along with kmemleak, the > CMA reserved memory regions are unmapped from the kernel's address > space when they are freed to buddy at boot. These CMA reserved regions > are still tracked by kmemleak, however, and when kmemleak attempts to > scan them, a crash will happen, as accessing the CMA region will result > in a page-fault, since the regions are unmapped. > > Thus, use kmemleak_ignore_phys() for all dynamically allocated reserved > memory regions, instead of those that do not have a kernel mapping > associated with them. > > Cc: # 5.15+ > Fixes: a7259df76702 ("memblock: make memblock_find_in_range method private") > Signed-off-by: Isaac J. Manjarres Acked-by: Mike Rapoport (IBM) > --- > drivers/of/of_reserved_mem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 65f3b02a0e4e..f90975e00446 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -48,9 +48,10 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size, > err = memblock_mark_nomap(base, size); > if (err) > memblock_phys_free(base, size); > - kmemleak_ignore_phys(base); > } > > + kmemleak_ignore_phys(base); > + > return err; > } > > -- > 2.39.1.581.gbfd45094c4-goog > -- Sincerely yours, Mike.