From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BB9C636D3 for ; Wed, 8 Feb 2023 21:56:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C690E6B0071; Wed, 8 Feb 2023 16:56:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF2476B0072; Wed, 8 Feb 2023 16:56:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6BCE6B0074; Wed, 8 Feb 2023 16:56:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 917406B0071 for ; Wed, 8 Feb 2023 16:56:04 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5FA0A1A0E8F for ; Wed, 8 Feb 2023 21:56:04 +0000 (UTC) X-FDA: 80445483048.22.0C71582 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 94AB51C0007 for ; Wed, 8 Feb 2023 21:56:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=X3Q+qaLo; spf=pass (imf20.hostedemail.com: domain of jstultz@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=jstultz@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675893361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WrzQdBMb984GoLwSermZKSUJHb2Pj08MtfAszXlgQ/k=; b=EkGJnCudNEiAz0AXRIlbfB/D6QQYJGBheX3Uq16DyeEjhTE0us+S3uClAHxg5rlC05lslo gmmK0hZmbzeWSsp9yGl4TV8EDM3m99prKJiIwKHpQziU1LO1WjAKZX+X7D9GbztVkLPhYy stErs3HHyApusQpoHO5mVR9Ntnc6yT4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=X3Q+qaLo; spf=pass (imf20.hostedemail.com: domain of jstultz@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=jstultz@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675893361; a=rsa-sha256; cv=none; b=RqaG7a5m3yAI9txaNhdakqWHhXZRdM1plLKC9SqxSYdQ6fihtNwhqNTW5Yhu3iaEjrowGX pa/EWZReN/Zkx81Vxr9W/tfCCHoS6yLvvxy3aK02ijehm5IjI2H1lNpzGz4Vh2N0pulZFx zaMnoKUZpmAtJwmolQxVrGDeSXQ/TPc= Received: by mail-pj1-f44.google.com with SMTP id ge7-20020a17090b0e0700b002312568942cso1722982pjb.3 for ; Wed, 08 Feb 2023 13:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WrzQdBMb984GoLwSermZKSUJHb2Pj08MtfAszXlgQ/k=; b=X3Q+qaLof/eu0DFR89m7gQn/6gT+BTyfg6uW5GUTN9076Tc/H7WEg3Rn9nCbIYk9to sFk8ItAXccaAM10ROnONd4cmr4F88/N/PKhJCEuuN9EngNYzN+wCkhiXHHzrGbjsOj5c Fg/zSiwQZc1Cmg5B1mowGhhJdKsrlLIIiw04r+NUiQpcTf70tDIcsvZo1+IibxXFTIoO KITAEPIX3cfaqDGsEv9ZT1g8yQ0DzXX01fusCwzAB58px3qFyBiOcYoSAo4QBTjxdgE9 Yd6KmjOmsP61c2aSSvYd/3vLMvRKxtMs2KdH2Z3v/xZQWAiBS5fNRul6faGsMl5rMtTY /WHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WrzQdBMb984GoLwSermZKSUJHb2Pj08MtfAszXlgQ/k=; b=2Yk/6VR0c5tntqYkVaHiOowuPuJIBIaNjaVJIa67BLJXYOYBN5MyO3AvpvmATbE227 zGnu4TpX3BqEdOW/foXXywHHBpIHwRJRtz4Zr8Ko8dAv606FKp3tYFroJfmSetZIbsC4 InaOhdBBIrv5BwIdtNMY+5sdoCE/XMqyanGjPHo+Na2XxVxNYCdUiDIdQMYDFLaA9K4q /u9/NUsAUWUOFvzvBTLf1HDHVTCDsYchIg59P/3xCPEIHMfok9e/z5uUzU5IWkHdrS7l m7Ic+5eQfSwjWfMUsVZzjwG6zAKyP5gs3S/wE7IfG1na+wDDPIw1jKzwHclp0tWdq8ND 0kWg== X-Gm-Message-State: AO0yUKWy2P1JlPTmWOfEg8mD6/NzunZzBQJmsGwx5luDDInicXklq2Nc 72Z3u2raqBLAsm3789OlYtOoKbA1QK4a86jfc945 X-Google-Smtp-Source: AK7set94ohGg+ZPN8FmhK2vwun0FMjWaJ4yRKKML6EHTABq5z5LP5TMYNz3fYPfypqrE+agTNEfmnw== X-Received: by 2002:a17:902:a604:b0:198:d5cc:44a8 with SMTP id u4-20020a170902a60400b00198d5cc44a8mr352677plq.19.1675893360186; Wed, 08 Feb 2023 13:56:00 -0800 (PST) Received: from google.com (238.76.127.34.bc.googleusercontent.com. [34.127.76.238]) by smtp.gmail.com with ESMTPSA id 25-20020aa79119000000b0058d8f23af26sm3938910pfh.157.2023.02.08.13.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 13:55:59 -0800 (PST) Date: Wed, 8 Feb 2023 21:55:50 +0000 From: John Stultz To: Yafang Shao Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Andrii Nakryiko , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Kajetan Puchalski , Lukasz Luba , Qais Yousef , Daniele Di Proietto Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN Message-ID: References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211120112738.45980-8-laoar.shao@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 94AB51C0007 X-Stat-Signature: gw18dcyyq4nsqyedoxqsam7rrjdb11pn X-HE-Tag: 1675893361-978330 X-HE-Meta: U2FsdGVkX1/AiSwM98OP5xT1pPCATeNrWtlnwZAx9gE2hkl8AM8lQCd9MvFvQM7qII6FOTF54RctfEQzc9GVotWtInJVB94hgRRecgHJsWrjPqs6irIrn5oUF8bei07zsY+u0CgiQ00FI9j6ylAIf1Xwm25+26bb/kZbsNme8Erv6raU8As3B6/Oy/7THSaNZFUPhUgtZkw2Ufi+GVL5JWNjjgJsHnoncf0whcSCVVUTIAHAr0ShWxnfrY495n28htjPt5S7UkbRy6MDrJmGlwfbykPRkFJmaBCWU+/dFKeVNXKtKDZVhIKjQmaSddmQhhuu1/qoWfQ/uyHX9hiReB/wgplRpj7kEV1T6zNtwvA9w5yqVp6n0c/eK6CjG2DdY+KX6YtGGwEtk0hAO1ap4xF5X0UMm87HSiiP3Wm5hyp9GsmDr7LMUvoZGvMn6HfocpBM2cAUg+rYxt8yYGTrgAofkDED7QuwugQKfjRkSuIjNgfglAvdtqpJTPIkSRRCN6fkBfU39HNBLIrWbvPpxpvA5gErQSeRJMashKsY36tG02sCUdiJALnAUek7wRmOvQo+/osG18rNEi5T+1tTRTvgXX07nzPcO7lOfoMQr4mZrFd/29LbmXwFmTTV6rIyR63xCoy/Qp5QYC0neLe13oBTKWH7Hrw38P1Hfn2fXykD4t0slfR9JMhhlu+/70upMHp6A71MPFrWQ8ZB8vsxIr8nOpLSDANV0WRXlnf+kWcUqvWlyw+ZXbhpi+StMk6GUmddfRuB9KtiJ0ogqIkmXzjr+DIcGUJRWJ+VLdoEIRaciueJvhMa93yJzIjx2gsmoUTf46r0U/btS/Wq5NHRQjkX48PazdcCL1erEzRnnnN3PtT0fVJyy2it8gXgen8l0tzV4oG7Rg5QBKqekQoB9lWjKkgCDgxLX/6zJIr8HqNmd2zQixl3vXEC1D1ZjXytqLXhUnFEJT4Akob7QaJ TT+N6473 qLPs86KQSLjn6rskYBJd7cGNccx4xdsDe1PpCcTYY3ttgzZeAdwJ0p/7x6sy8opQeMVdfEup6AQStuRSpbaU7ZCkA6N2FsLTkNHKJwi/uNPbeDWMu8dcwdiQfBebXbTUAwJNBk2Kv6C2gy4w+vvgYXqdRriP+UtSnwg3bh9IMWR+Y55YHSOyOFnKI/Z3Z7SfUbm12vlbSdFu1kewmZWyc/CMo+hK9zxUMHcMGZHKDuJxihAZscwWAY/VrWQhwWOih9aIl+0hLzXeZ+2l6Q6At0KHiT2QKrf0owM0trS46+6oUAfzAi6ykJv7FsVbJeVVDRafV9jy5A4yltiJigEAhbofca77XXAMiVlRa3rcirTBZsdQsyHyXE7UkXc+lkLSTQ+h4YgTrKgThg5gtV/oi3NQLiR5K3ESjIrt2tmVFKM5zldSIa68XUUW9VfwPA9QAoWuId1g0YyC9uoOQMLJ+BRMF4Xpf5/AWr3QMooJA8bkAW2o/m2DQ4zuHnijz7/3EM1hQ1IUc+1VOvGTS4ZwRORlr3mfowE4cu0G01EMn+SPEV9CDQ68CCpIblxxtE1SdLQkDZySSBc6CR519fX39i9ysQ6c+15JXsrXmRTfD8kKvtaHypcfluyRN8d+26X/Sofd2JHQZjg3aftlvmhQIdaxhgc4RMYT/zxLdY4XFkDh2Zad45xlrbD49LEXsHcBgpH1RSEspMp8GnWD87K4bd9iWU1R8KcjcS7FAjxWxzU9tdqzZitunsI04UGTSGSeiaHCd+3I0Rq3eRdhBD20K5/VunEP68QDiBF8TDqcjCYN35LbnMzl7PxbU0f+VrCfWqzwqdKj7z8tmGi8x2KVeJs8FQ/qTOct/pFD7YAlFx2zGCXXFEeEwsaCX5FlJhRo498pYViAc3FdTCyRybor4hSSc05fqjfuP1XyJEpI4fMk8f6sI8Ei1eEuw0iJw3rePRCkdsYoWEqNO/VeLqs3m9Z4G3vyd 8em+sRvq NdYrlUz78WRksV48wUoxWSwaOdlnmXl6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 20, 2021 at 11:27:38AM +0000, Yafang Shao wrote: > As the sched:sched_switch tracepoint args are derived from the kernel, > we'd better make it same with the kernel. So the macro TASK_COMM_LEN is > converted to type enum, then all the BPF programs can get it through BTF. > > The BPF program which wants to use TASK_COMM_LEN should include the header > vmlinux.h. Regarding the test_stacktrace_map and test_tracepoint, as the > type defined in linux/bpf.h are also defined in vmlinux.h, so we don't > need to include linux/bpf.h again. > > Signed-off-by: Yafang Shao > Acked-by: Andrii Nakryiko > Acked-by: David Hildenbrand > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- > include/linux/sched.h | 9 +++++++-- > tools/testing/selftests/bpf/progs/test_stacktrace_map.c | 6 +++--- > tools/testing/selftests/bpf/progs/test_tracepoint.c | 6 +++--- > 3 files changed, 13 insertions(+), 8 deletions(-) Hey all, I know this is a little late, but I recently got a report that this change was causiing older versions of perfetto to stop working. Apparently newer versions of perfetto has worked around this via the following changes: https://android.googlesource.com/platform/external/perfetto/+/c717c93131b1b6e3705a11092a70ac47c78b731d%5E%21/ https://android.googlesource.com/platform/external/perfetto/+/160a504ad5c91a227e55f84d3e5d3fe22af7c2bb%5E%21/ But for older versions of perfetto, reverting upstream commit 3087c61ed2c4 ("tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN") is necessary to get it back to working. I haven't dug very far into the details, and obviously this doesn't break with the updated perfetto, but from a high level this does seem to be a breaking-userland regression. So I wanted to reach out to see if there was more context for this breakage? I don't want to raise a unnecessary stink if this was an unfortuante but forced situation. thanks -john