From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C697EC636D3 for ; Wed, 8 Feb 2023 18:10:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45F256B0074; Wed, 8 Feb 2023 13:10:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F916B0075; Wed, 8 Feb 2023 13:10:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7366B0078; Wed, 8 Feb 2023 13:10:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 185526B0074 for ; Wed, 8 Feb 2023 13:10:40 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5E2AC1340 for ; Wed, 8 Feb 2023 18:10:39 +0000 (UTC) X-FDA: 80444914998.25.AD7D160 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 0F38F14001D for ; Wed, 8 Feb 2023 18:10:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JMPfVqhJ; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675879837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ckI3WTqph30NpxWFPDE4cvDOQBvbkyW3uZldKIaVSY=; b=giHxyvhT3JvGqliUTXASFj6BGmv5HBiRsID3A9X14rlc8tA8s8kvdpRnUN6V7yVFT4ubnw yauaE6j9HKMHZ4NZnWF5GJa4fqWK0r8TvzT0tBAIJkpqLOzNbRbY3rcddQBWqtA03RbwIE 9YCP+Za/bF9mcC7Z96pZTPD0q6QoAe4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JMPfVqhJ; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675879837; a=rsa-sha256; cv=none; b=IzTb6RyFJj6Yen1LcWBiDVSLe8x8+LD3KI+6QPjrOTSSepO5EGZwJ4gaA4JiRTmTONRfkm 5Ricyj00+H1U3Pb8x3zdHfoJiZGG7iEwfpbdMZcWW0cfuc7LetOqzqfdD2sZ8i29thoHQJ uSEEwWNJObyx8BOSpgjZTpMBuVSzmY8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6ckI3WTqph30NpxWFPDE4cvDOQBvbkyW3uZldKIaVSY=; b=JMPfVqhJbVn/kncnVS1BMxmG6J 7sJHcR2ZcAolixI6M2MPAPnXWiuciSLsUMPrQleNPoAP5IvNhrdaZQfFVV8ePo6qqEP75miGAirfZ vk/ymwQJTYe7EUO26Xli+xTMEZLhLbJ8+6rsxLiBn93PmLcqbg+TMe16aAx815GFkG5NruFfsbTFN HWDKlIv91/hNuJXwL812aDfO1jQ3bIhdcrC4v8UMyi7ggxcqOoN5kk71Ft3U5xl1gdlCgy9vmWKxn Pq+bl2/gZjdJ0ZtW8pDASUNLM+nn1LBJp22WegAbq3DTWtgR6z2nKEbC+Fp0VY5fCiZ/7X9HdMVBk H69h1HXg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPotn-001RIT-AH; Wed, 08 Feb 2023 18:10:27 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 228CB300129; Wed, 8 Feb 2023 19:10:27 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 128FE20F05D4E; Wed, 8 Feb 2023 19:10:27 +0100 (CET) Date: Wed, 8 Feb 2023 19:10:26 +0100 From: Peter Zijlstra To: Arnd Bergmann Cc: Josh Poimboeuf , Andrey Ryabinin , Andrew Morton , kasan-dev@googlegroups.com, Marco Elver , Dmitry Vyukov , Alexander Potapenko , Vincenzo Frascino , Andrey Konovalov , Arnd Bergmann , Kuan-Ying Lee , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] kasan: mark addr_has_metadata __always_inline Message-ID: References: <20230208164011.2287122-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230208164011.2287122-1-arnd@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: yeuk1d7t5fw9xb7tha93e8uw1agpg9nb X-Rspamd-Queue-Id: 0F38F14001D X-HE-Tag: 1675879836-429318 X-HE-Meta: U2FsdGVkX1+CpSiqe1zCn9treAKzax9PL4HU610LmtH2VavyKSA9r5x6f4Usf/xgLcIAmhwYTkVtWZfiDN2Z6z3MCWaZzdqyo/0RpPc2V1aAmBdLRUOweD8LG5mtBanU/uIghe54nCWcgwzkr8pbfy4U8mvDGBmV7Jp1SJ46F6S8y35Zp2ua9oDd1DkiGgWxrQFX0chJDKMnTBlPPjPxD8FxhH9pofl4T1uVxRRczrWQbcMqvjtEZUU2X8h/qVmcMc+29b2KR66OtQloeM+b5UkFvYbfHyXpWqHmiDZuo/cEQ8tZHjLa0oyYtXHG+jkmk3Dy3Hvm5+8x2TUZFDyG6vob77h7+cJggw1P09LNfRE2KS/Zl3tPqwuuta+O14FbancvMOdPPy9dTbnR/4x4BcKd2WZfvXbYR690ziYt/Kt6P1LuED0pkKAywLdvJS7jMmtW/PG/A6fooYHCLGJVZuZ9ABXIqKUfcd8fQ/VdjovrufPGC69/PK0jwUlshw8WY0dZh+qzbGgNA2PdZpCliE3OQcshgNEyUcY0THpwQYVwcp7jdjsl3+wVz1Qyi8RMOdCLsqL01qb6HpOPnSFKSq2f9+WfWN3qWTZsyO4Lyicl9LwVX41ZU8SO1i/Sivf+Kcd+FyeUQWI/HKLI8yCVqKgcPnXh95H3azNABRNrCoru7yS7aZpCDUbSrtU+N8BcOVHDqlbKB+9Dggr49S4p0d18UDex5OmPHy/17A6iB/hFQqKxj08hn14OHgpohzg+VvlIxCOhvNLGQ14B47RBbFlxLbAUN3qYLV8BmRo67TAdhoBv4Gr03zE2idPsECXKNtMbtSjNDno/FZGMGCSCHzWnjwsOoWg5Jg42ssLA2AQWHhwTJ9Ndec+0ZxdPQPBs5PwSyxHJL4f9t7eKWuNR84m1stv0DN2st7ysMtnaEhFqkecjHbequ+jXQDN6x+8MHT4DSZYCTNU9bPRtoSJ hYnsnVgR OETE3yVa9fdfNgaAj5Gmdv+EifGhlEeAKtHPk8hKT7HKON9gx2xzvdivVsimIX1hHyvKw4AgMspdWDVcWGSFdVo25FfECkCNgQPVDhWUmVqJay0q89NtbLP8KGH9kgLQ/Y1KBroxCBlflnel4WsEG7ROzWkk44kkSr8Esrze+OBQdfcKsU/BmeTDrS4KUXFDjSWOk+sorKdyXPL8b8ypOC6IQv8wK1sKIEvPytFdO1sO4hkURtqhEWM53HuNmU9r5P2hNFtAqUlhYBNh0kXmD/rxcqrquorWPK7p19Sc0eBG/Q4SltOTBhgCxHdeVvpbTOpVXQUxR4Nbmt1U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 08, 2023 at 05:39:55PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When the compiler decides not to inline this function, objdump > complains about incorrect UACCESS state: > > mm/kasan/generic.o: warning: objtool: __asan_load2+0x11: call to addr_has_metadata() with UACCESS enabled > > Signed-off-by: Arnd Bergmann Acked-by: Peter Zijlstra (Intel) > --- > mm/kasan/kasan.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 3231314e071f..9377b0789edc 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -297,7 +297,7 @@ static inline const void *kasan_shadow_to_mem(const void *shadow_addr) > << KASAN_SHADOW_SCALE_SHIFT); > } > > -static inline bool addr_has_metadata(const void *addr) > +static __always_inline bool addr_has_metadata(const void *addr) > { > return (kasan_reset_tag(addr) >= > kasan_shadow_to_mem((void *)KASAN_SHADOW_START)); > @@ -316,7 +316,7 @@ bool kasan_check_range(unsigned long addr, size_t size, bool write, > > #else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > -static inline bool addr_has_metadata(const void *addr) > +static __always_inline bool addr_has_metadata(const void *addr) > { > return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); > } > -- > 2.39.1 >