From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBBFC05027 for ; Wed, 8 Feb 2023 19:25:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07D2B6B0074; Wed, 8 Feb 2023 14:25:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02E0A6B0075; Wed, 8 Feb 2023 14:25:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E38106B0078; Wed, 8 Feb 2023 14:25:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D73326B0074 for ; Wed, 8 Feb 2023 14:25:21 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B359DC03D2 for ; Wed, 8 Feb 2023 19:25:21 +0000 (UTC) X-FDA: 80445103242.02.DBB7F5F Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf19.hostedemail.com (Postfix) with ESMTP id B09BA1A0017 for ; Wed, 8 Feb 2023 19:25:19 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=V22eJSdB; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675884319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFlrkeEXgNWehBcAx33U4rHt/JekvgpyEDTdyrAYRpU=; b=7W4rm47rtRtyZIN6zCMc0Y+4GB5UNKW5/h54BkC1DwqVYTeYOIDZkmXi4d7bIapUzBuEld H1qW/1ukjVzIcenwZNx7COK4a/IM4wqqTKtrRdITay21rIGgKM9pu5v2hPvBN4eqGZ4IKs QI4a/QeOeggp/L62mNwN+yeyxYgqW9Y= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=V22eJSdB; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675884319; a=rsa-sha256; cv=none; b=qarK1VIjXBy4dndambfEJ9ppU16nBUWtCv9eHU/VGsrEIc5ZYRjJjTASx/9UGeuZi0xip5 f4ND7nQs4FMlb6T7NFDHPUb3hARK+keMACk8gsyfXr/lZLqTTQvVmvsLtesEgtBgmr8mfX VTr/Ye7AVkRT7G8N70xnXy8QcAQuuOA= Received: by mail-qt1-f170.google.com with SMTP id w3so22130659qts.7 for ; Wed, 08 Feb 2023 11:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NFlrkeEXgNWehBcAx33U4rHt/JekvgpyEDTdyrAYRpU=; b=V22eJSdBMDmC4TCgyxOGFJrfM6rr9USfSzc03bCGt+fb1AGhUkoO4mPupY7BkmUPcW 9PLRYSREg9TZGrUb4untXaC0WGKlnYuiybeZG6+AEES7ANGcxhPrpvJFhYFt14ySsacP zWZXSIDMuEuhKm492fjso5d4Crwy/54yXB4gdinpsDa9rrMoQL+vq94D3qXNLu1kbFqw VZx/SG/pw5nT9PyCitWVS+8RXy1V9zlSbsPMp0/njff5Qd+Cx+5MGVA/bbKr8JtgDcNH pjKTU/v0/+ZBzy5BZgvnetEVi41tw+lVU8tureVuK6l0DWCCnwmIZeWqP8euzinHhQcq kQEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NFlrkeEXgNWehBcAx33U4rHt/JekvgpyEDTdyrAYRpU=; b=XppUfDQTQ0MqdChF74trszGn+M+WX1kVRO8Vz3WnlSAR4uXpyap93K80xdLm6mWzx7 L+cOMXGCpIYSoKRFxmqPvJiisTLzDIpRPq+OApnwlaWN2vutgxAzxu8muBenj+FIL4Zh vO+7uLAy/LyzGw3kDBIEDLiw+pzPv9EdiC1IJkTGaY/v5iACGcGB77/I6K38YaJ3Vrvl 6IVJRhXPnmQZH3AzYoqfXej0NKrtW95le2jZMVBZghakXIMsjvPvlv8p6ZQeIYql1j0e 9fzlI3skS2o4pK8JOre3H70ZRUlnuHnNvqKsFsW1BLySYLS4UOOG6PbF4hGxKLunSBv9 xu4w== X-Gm-Message-State: AO0yUKW1DBwbIdWhNXfNfelWqR8WDpmy0IUwsOq5sbGTRxfyglzidXQ3 nZfNb19oO7yz8irGRp1gjl1SWA== X-Google-Smtp-Source: AK7set8XcNRm6tPbkByIqalkedbpySv8bjESt4jGk2jFPI2Hkasx9aKHrLecauBSzgUTWeuoxFut2A== X-Received: by 2002:ac8:7d4a:0:b0:3b4:a6af:a2f2 with SMTP id h10-20020ac87d4a000000b003b4a6afa2f2mr14968503qtb.34.1675884318724; Wed, 08 Feb 2023 11:25:18 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id k6-20020ac80206000000b003b9bd163403sm7091871qtg.4.2023.02.08.11.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 11:25:18 -0800 (PST) Date: Wed, 8 Feb 2023 14:25:17 -0500 From: Johannes Weiner To: Yafang Shao Cc: tj@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH bpf-next 2/5] bpf: use bpf_map_kvcalloc in bpf_local_storage Message-ID: References: <20230205065805.19598-1-laoar.shao@gmail.com> <20230205065805.19598-3-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230205065805.19598-3-laoar.shao@gmail.com> X-Rspamd-Queue-Id: B09BA1A0017 X-Stat-Signature: z9biys3z8aujdijqkzhueenq9dmpozux X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675884319-568696 X-HE-Meta: U2FsdGVkX1/EtgVJ/lVQudYdGwBIIwHqclyDlj1fZ1zVTye0hAaInfOUhJo+hQEX82bbP6iOPcf6iJTAtUBz2+KTF7vNvrb90fMihbl5mCtWmWYN29peU6afh7K1TE96bIIzuTbNQGuxHYJuekCqFvKc05c1nhyTWizUayd5SdffC+C6t+AX5h7bEC9ylMzT97x6eJLLIv0qyXCr+CJxEl/vu/PCQv5tiTx+LBGuld1UfNsmI6H5V5f4B1Xu8ZMfBqzwDxcEzcM9L3y7vWDVUSb32ODzsjg4QiO8WCfQXz0IPKFjsyF5fkh33ghK+5ulsoVRtpc8BvIThiQiAtlPaetvhRRudOnGckznPzcBUHVEEsv08DEXtoNGIMk/CRs59PVPapeKqUXmHi9FB3uOfO8dAoZSbFY0ctsHvhcnyKkUnCaKhps2JoBk3FOrjaaRe600lj28NHPNXmac3Xkdkec1NF/N9EIB8zo/FwQ8q3ATH+NOH4whb0a4bVOTXuEPK8zTFLWzmFCZCcYYpV5FD1dVrOmqyRSC2ALR3E3BDJXhMeFSntwPcgQCZPaEHolAzSIFnzjbEmnILCw17WCpeeE6ibnF/AiAL7+IGN12HJUzKHYNIZx2TVPrWtvmFjuMmCq4wftqaQXOhY39TI0n5iluxmRQZEHPKXGW6E4uzHw7LTqR54GRdzorWYoR8j7K+xeWqKJ+FavoqvONlSwWUcSHaAef0hmie2YTyxl8AwE1c8KuGt9Ub+x+1X4tFdBC7UHw1lcNcR9gJr47oPdJnn40etj4weihTV7CM94MD4rQ6ivf/GYIO4gbRAZvt8a1eVGsJdXQIqJc5F7cLzzZmKjq9tPF5PGzRZMWMGDbK385VPAs+nWQuGZtekA0YPjGu2z6vYHs4x9i6vivcDnl0SU+rU1JU6wvCI3jS8tJuwlmgvAYoxWbu4COQSJVl/wLV/TtU3Gw5SXLt8oOibO AHIcXLUb t2TqU7lQmgiKZbHE2HnTJYNHG/1MD6tbHeaHbRLrrMUzc0frhAw0IV/e1yrLl7+4Nh/x8u7UAC/R9diitSbEQ6WjusvdRnZomnpNFDqnazuPcX7t7Yw/OdQ0qq+FwtD/DxNQUAtITbqqxsesygb4hRwPSwh9J4eTLKAT2aJxaxFBkbxoNwXK0RoDMMxK6WiT19UH/fc4Oth3n4jeU5tjOwlLbMVHNcX3j0mtdLbN7IIlj9YdwFliW31cEuoDwexwmuSBKuviHVo8aPlsQXMzTruVlfZOIqoNdUjOJItNeHCcf1/YxXHJhfLnNXK2mELkuvsOnV2RS/2fdkqkNVbxbYBf80DeVXI5k2IkZW9sfCChLuBXuGSgwbLUZQPec3dCjNxEscyAsSQLeBIGP6bkQCFTyNNr26xpC0yEMIjWpBxMCTyJo48sCqK2L2dozi5rwC9mW10sNzwYdXu10NN5wAGkXRmt7sTCTSaGjxTdFCs9BF9aQ4CU4qwzDMN7bf7rw4bFX/cIj9hXujo09ntQZ2GeK3iXdjNGT95JePXo6Qo2bnkgSGlP3b2jX2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 05, 2023 at 06:58:02AM +0000, Yafang Shao wrote: > Introduce new helper bpf_map_kvcalloc() for this memory allocation. Then > bpf_local_storage will be the same with other map's creation. > > Signed-off-by: Yafang Shao This looks good to me, but it could be helpful to explain the user-visible part of the bug somewhat, i.e. who is being charged right now for the allocation if it's not the map owner.