From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC22AC05027 for ; Wed, 8 Feb 2023 13:45:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 464CE6B0071; Wed, 8 Feb 2023 08:45:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 414096B0072; Wed, 8 Feb 2023 08:45:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B5286B0073; Wed, 8 Feb 2023 08:45:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1CDA96B0071 for ; Wed, 8 Feb 2023 08:45:08 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D051B8070A for ; Wed, 8 Feb 2023 13:45:07 +0000 (UTC) X-FDA: 80444245854.13.24C5910 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf17.hostedemail.com (Postfix) with ESMTP id 0F96240009 for ; Wed, 8 Feb 2023 13:45:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qOV7ysnA; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675863906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=alfJUZBV+BrVmvoYfSmGRjxyktkbme4Dc/pX5IUBNAo=; b=lddmuI9aF/MKKYOKLVBAVyvmqhu9ki1Ooy8EN/Ui+lguk1Ofi4bmwIUB7pP0l461rj+wu6 h9ziF9/cmfKWHGu6JHE1krqW19d1SPDgWaC/gqO8DICpxq+Q6cob0CcxCo3yPp/n+H0Gww LiQhcLOIDY2yAG3tPLsz6ch6KubjDNc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qOV7ysnA; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675863906; a=rsa-sha256; cv=none; b=7leU43odLDQNGq2XSC/1ycs3+dFC9m+YFY/2o1QTCAxcTBwEyRisYMwBkBI2ebKBZqdDVK QCaYruSiRRSHgofpkK24124/Fm4iJSQfOlGZq6yFiktRcIQF97V557KdPoUzM6dA21zgYQ ISBSdHZR4VcNdY+NppZJ7Jm5h75tatM= Received: by mail-pj1-f45.google.com with SMTP id bx22so15511888pjb.3 for ; Wed, 08 Feb 2023 05:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=alfJUZBV+BrVmvoYfSmGRjxyktkbme4Dc/pX5IUBNAo=; b=qOV7ysnAAE47VMzfW+KW7uRQ3waC/E8XmADC10hm4irUlpgyQ7W9iYPxZ4ELgAqlhT LjIlmiu2gGIqass/jeVRMyvjNwUEv+WV5tdMSo2zQLMRN2vxuod8wxnC6nkM3y/R+I+h K8aFy5z+AEHJZW5D7ypP7nruC1fDjCbfW2Ce/nkXTsnVFsJ86n5MCU4QSDWSSK+YQC1V eR7xjDBpbTf+S+YnpbqpO3YFtt4f2FioYXoa7qazR595af1e5Vo1MyyVHSzK9M+3XQCB tZ+YpRzE0Ktq/8lxY6zE8zSXlnjcecUsfEcPZIpiBBxPwscyLA9a8qvnWbtq6WFjvcKS imlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=alfJUZBV+BrVmvoYfSmGRjxyktkbme4Dc/pX5IUBNAo=; b=Uq37XaOk6QrNe2dQhT5QtCU8XN6be60U8C93+Jq/AleM8Pvec809Hilb2SSAfDig64 5xpafAwcGHZ9h1FAV94FjghyRlSu488aH30YA+2SkuY4eLjIccxW0OOr3fsyeW/XlTa6 USE/xXB0Rezd7d2ODxGyr0izmswUkBD9E6vj2V7CutOCHWP6o2cQ5lOIM5ChHiobpi9A sCAiGxtB2505Oy4qqZuVTWysK5Z3cp5d1mgm9t+E8+4hoeOMPUyf1KVxyuOFLtxp6HQB s56YnAS0jLYQtTq9wNj83APBcUYJhdowfplaBws8KM/PI/gd5fIc/bOHDQBnF081pp5I NIXQ== X-Gm-Message-State: AO0yUKXzCgOZ97XdtVn6IMUiTrjUucYSPCAJju8RbwHotgggjsTx6iGt PH4Wo+4z/XM9Oyg9zDd9xKQ= X-Google-Smtp-Source: AK7set+sPEOSedwTYT2y4bNUQKcEXNgoZqhXS89DjZ61bh7BdhGz84e05koI5bATzWm0v/BjRJNztQ== X-Received: by 2002:a17:903:120b:b0:194:58c7:ab79 with SMTP id l11-20020a170903120b00b0019458c7ab79mr9146382plh.63.1675863904496; Wed, 08 Feb 2023 05:45:04 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id jc10-20020a17090325ca00b00199190b00efsm6056928plb.97.2023.02.08.05.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 05:45:02 -0800 (PST) Date: Wed, 8 Feb 2023 13:44:49 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Peter Zijlstra Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 09/10] arch: Remove cmpxchg_double Message-ID: References: <20230202145030.223740842@infradead.org> <20230202152655.746130134@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202152655.746130134@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xb6k357uuqsnhc3rsq8f6zqzjxwrg5cr X-Rspamd-Queue-Id: 0F96240009 X-HE-Tag: 1675863905-956208 X-HE-Meta: U2FsdGVkX1+M98VZ5UOlDrSu0gnWzVAiId8bBUioOuAXtbu4NrIvmrV7e40qqt6eqZrFGZ2kRvt5EzSxOrL9Ti/J8h8a+JeSEUzp+blq+nN7RMUem1UCiNvE5HxRDfAv6MOrJB+VZmdjJogAzU54G+PK6lLZs4lql93bG67Z9jXKKO/UdJLqlsujIuac0zwrbELMVeXdvkgJegnVOvZLzzBSXVdFJ4kGU/c3GzSR1aeV6LMb74kpKFC44pcz1pzolFt19cHhlENMfAJGcAlvdbLfakItGTK92hCroIO+fl8BK76uQX9m2sWn0xc/OChYUnsePcIR1lWw6uIXo17YQex8hWtTtVMSI1oQHPCVpdvYNyH9aCAvUL2kTCZ235TN1gYuVd4sLOu0xQ4Fjaa33nb0g40GFxzFPuREi9biMX9QeRywtsvt+xoyrwkOmU6DXbt5pm9GeKd+VC08sU9IFiefAeg2ls3STO+49HYZqoSqw+yrZv+9kcdPibx8g3pKEUCiHLLXuqWEbQjXQu4xpyZYpI6eIWifTiI6rZm30d/S3eDMhBYaoIARrWuGzxi3HWV4kmYdc6+WguvLieo9rrPt88S/Y0hYLO3AvtRxm0jF6RdgEPuGjCPWDXNMMT+zXw0pH5HSHTwrkvsGWwg55Tg4tGvnBtenqbFLhSGlYw3IE9GbrkRASplkQ8J50bnrjdZ2BVsO0hDUi7NpvFoxTFwteOBcVmtpJs9Ll9DUibbFput0hJocQd2PMmF4akacz053rMKZRdu7c0EgULjeSvYbSxg4+Zuo0tPR+uBGG5rMmj4S75IZh1j9/bTSpKVZ5GORdnSQlFpM7prNKqslbIx6oso5SJDo+goPb89HD/X57oTiReRzaHSW8knTccmUPTbfx/GhToj0MMQ91PrU5PWp2DOJtOWOCoZO+4mPlFjQH0CI3AI1ggTZJNsxUw/uOq/RGEMn/fYtS44pRUK DcqPMGle Wx4wehH1VndNC0AGBE324ZmAIP7VjWos7fcVX4nD14Z6KYiDU6ugW4Jak12HCB3jqOXEXFKoJsLZTzISnDrPep95CVU+CG7ilREQjo/cJo5DZtY6FY0Avq4Bwbc2JUniiVAvcnEZAscuMkr2TkuPhSDLxKQNhsIJUrBuKWkrEtB8g9sjstnH+BCErRzx0aqQAbupt3tQLXInYlGwpEmKySVaB6IBeCwmGke4E+P/6TYxuyBJHF2j1FZy2yQtJbDb7QhMFAr4/CI6/oYvUhRW/Tm/iTlnFz4F37FAjfqi6A52KHe646Cx3yhig81Ifte5MjldJ8kVWDmRW5OcXeHtgGM5yhoQL14AuwWa00AZgsGLwbZMwIXCHpPkTkFrcaJaVfvA84r/YHxdyVcMhToYlirF+Lk1fqooXgkvj5eHMYJT8Z18zOWvvjIOOMMfTSJVMegLZXRV2qaXkSi4/1Aj5wgHwv2sNZq7F7SSvYNGpHn9X5js6LNm/MhIPsjTiFxNbYmDZ9DPla6tMnWChWtXCBYuKzryRlH1n7vAS/wL03gvTKzkKyZKPzKL1316//MV7wa7VkZAY0cwUc/ABDaemFxCf1USUfyLkCVc2oz1VqmRMe3WTGVDqH4o1QpLHEu8y5dxLMClfdVczr00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 03:50:39PM +0100, Peter Zijlstra wrote: > No moar users, remove the monster. > > Signed-off-by: Peter Zijlstra (Intel) > --- > Documentation/core-api/this_cpu_ops.rst | 2 - > arch/arm64/include/asm/atomic_ll_sc.h | 33 ---------------- > arch/arm64/include/asm/atomic_lse.h | 36 ------------------ > arch/arm64/include/asm/cmpxchg.h | 46 ----------------------- > arch/arm64/include/asm/percpu.h | 10 ----- > arch/s390/include/asm/cmpxchg.h | 34 ----------------- > arch/s390/include/asm/percpu.h | 18 --------- > arch/x86/include/asm/cmpxchg.h | 25 ------------ > arch/x86/include/asm/cmpxchg_32.h | 1 > arch/x86/include/asm/cmpxchg_64.h | 1 > arch/x86/include/asm/percpu.h | 41 -------------------- > include/asm-generic/percpu.h | 58 ----------------------------- > include/linux/atomic/atomic-instrumented.h | 17 -------- > include/linux/percpu-defs.h | 38 ------------------- > scripts/atomic/gen-atomic-instrumented.sh | 17 ++------ > 15 files changed, 6 insertions(+), 371 deletions(-) > > --- a/arch/x86/include/asm/cmpxchg.h > +++ b/arch/x86/include/asm/cmpxchg.h > --- a/arch/x86/include/asm/percpu.h > +++ b/arch/x86/include/asm/percpu.h > @@ -385,30 +368,6 @@ do { \ > #define this_cpu_add_return_8(pcp, val) percpu_add_return_op(8, volatile, pcp, val) > #define this_cpu_xchg_8(pcp, nval) percpu_xchg_op(8, volatile, pcp, nval) > #define this_cpu_cmpxchg_8(pcp, oval, nval) percpu_cmpxchg_op(8, volatile, pcp, oval, nval) > - > -/* > - * Pretty complex macro to generate cmpxchg16 instruction. The instruction > - * is not supported on early AMD64 processors so we must be able to emulate > - * it in software. The address used in the cmpxchg16 instruction must be > - * aligned to a 16 byte boundary. > - */ > -#define percpu_cmpxchg16b_double(pcp1, pcp2, o1, o2, n1, n2) \ > -({ \ > - bool __ret; \ > - typeof(pcp1) __o1 = (o1), __n1 = (n1); \ > - typeof(pcp2) __o2 = (o2), __n2 = (n2); \ > - alternative_io("leaq %P1,%%rsi\n\tcall this_cpu_cmpxchg16b_emu\n\t", \ I guess now arch/x86/lib/cmpxchg*b_emu.S could be dropped too? > - "cmpxchg16b " __percpu_arg(1) "\n\tsetz %0\n\t", \ > - X86_FEATURE_CX16, \ > - ASM_OUTPUT2("=a" (__ret), "+m" (pcp1), \ > - "+m" (pcp2), "+d" (__o2)), \ > - "b" (__n1), "c" (__n2), "a" (__o1) : "rsi"); \ > - __ret; \ > -}) > - > -#define raw_cpu_cmpxchg_double_8 percpu_cmpxchg16b_double > -#define this_cpu_cmpxchg_double_8 percpu_cmpxchg16b_double > - > #endif