From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6673AC636CC for ; Wed, 8 Feb 2023 01:47:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E8256B0071; Tue, 7 Feb 2023 20:47:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 996986B0072; Tue, 7 Feb 2023 20:47:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85DC36B0073; Tue, 7 Feb 2023 20:47:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 75DA86B0071 for ; Tue, 7 Feb 2023 20:47:04 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50217AAFF8 for ; Wed, 8 Feb 2023 01:47:04 +0000 (UTC) X-FDA: 80442436368.26.212B609 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf30.hostedemail.com (Postfix) with ESMTP id 7BF668001C for ; Wed, 8 Feb 2023 01:47:02 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=T3Rnvod+; spf=pass (imf30.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675820822; a=rsa-sha256; cv=none; b=AcuznDCJQD7ShbSvRrHyJk5FioS3vcwbhdsKtsE+QI0SOtOafHQnZ2hpyiPCxbDNnN5+jA En5D76dqrKm7HCzTW2uQPprRBW96VOUROOvRn5/FLbdy4nsQDseRSd2/pkXy+Gkrd1CObe CcTE5O9BX1OQ7JQpkFRmXlkUAH8QG3c= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=T3Rnvod+; spf=pass (imf30.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675820822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KjZgcroriwsEugk9weWmwBjNRJc6RS0hv55s25nO4rI=; b=RFHdwGDxrQVrdm7EUME7LicOq4wuSkFHcVzkR9MHWBYf30Rf3vcP/O3zV62eEO8NnhUqGI YJgITmEH7M55lF0uC4JOkZxO2ap2q9ISYf190uyvisqIXEPoX3/3//HKfBcz2GU8b7v3zi W+908W+/HtE+Ymv2bh7+MfLYfgoy3F8= Received: by mail-pl1-f182.google.com with SMTP id be8so17648792plb.7 for ; Tue, 07 Feb 2023 17:47:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KjZgcroriwsEugk9weWmwBjNRJc6RS0hv55s25nO4rI=; b=T3Rnvod+sGjsj4Tp/F4rNsfDkPXTVmQKBueGwJ6rbffiNG3ks34G1SvONwjbbpKSLx K+aMl/olK6iozVZB51N7ov4qxoGCUcZBbDcc1w7U8kKQLGvoStlIamTHhU3Y3tMVXsQ2 dwJV0Ik729AAGrh3WdwN1AMG+YeI6rvaleYvbndhh1/CGcVapI9TA7J8GqdJ+71qYHNv IN9Y5weECLfx5f0egpHIdWT3WSoDownqAQoNz1uTzumQKUU7zFyxshcwHYxy1z7YKEd5 Trx94brejc8JavIrW8fWP36rkAMfgMsI0utsNzWJSsd0mzipVcsuKJSCJxgFNlUbpAXr DElw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KjZgcroriwsEugk9weWmwBjNRJc6RS0hv55s25nO4rI=; b=pczmqf8PKeFGnrHX7yJRvEVsiw+k/ucI5xiqvCOlOnOaTvwW821/OlqZ37IeBLnN84 eQJ9anG+JD2DrIFNobWO5XU3FqE5SWBYZXUl0lWUsteYh6e4juH8H/08tCjKV+2FstML USxAR+IqCDrpdRoDzHY1jqbkVEyLaPGo+fEoLSU4nE6nYLEHckJn/KlDuWhoK19tf6mL TuphMrwVf3jZg5YhEAlmkO5n2G0qAorHLB9xJeHpw6gHz7cHADdRRebp59Zk2JhZZn90 DmJPTJd19NdYALibTlfiV5OuwhWQQCkvCNybhPgnL/cmRGWP+bTwQujD0wiP+JQ3XgpA 7Xuw== X-Gm-Message-State: AO0yUKXyNNJ3wpdxqiQbJKvAHOGbezs7+SPFNE8dkdl9ke/9jSQI4Sfv oO2ilMDSNc1BX+To3j8NHGM= X-Google-Smtp-Source: AK7set+Rx8bwFJXZPUypnmLEaScqNCFoHUGKQdnDDCzWzsSJ8ehu9pZaOgXwJDEoM4zRSDGCA3KG3A== X-Received: by 2002:a17:90b:1652:b0:22c:46a1:67ca with SMTP id il18-20020a17090b165200b0022c46a167camr6033526pjb.37.1675820821100; Tue, 07 Feb 2023 17:47:01 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id q12-20020a17090a2dcc00b00230a50e6eadsm198397pjm.24.2023.02.07.17.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 17:46:58 -0800 (PST) Date: Wed, 8 Feb 2023 01:46:46 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 1/1] mm: introduce vm_flags_reset_once to replace WRITE_ONCE vm_flags updates Message-ID: References: <20230201000116.1333160-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201000116.1333160-1-surenb@google.com> X-Rspam-User: X-Rspamd-Queue-Id: 7BF668001C X-Rspamd-Server: rspam01 X-Stat-Signature: qtmyctyjge1h7756ynw6jhhc4zdfpyb5 X-HE-Tag: 1675820822-340235 X-HE-Meta: U2FsdGVkX19jJGmZbIRLpv/t8C9Ib8fW+Nqy62oD97PKRLu0NaywpNH2Vsi4zfHtKiT1WxyA+vuOcUmQmSZz2RBWYOO3sSvLOxgbMgcxfQSuuAZNnsWt9To+jBjGhrfpTp/nFBLQ8FsL62oY1UV1oXx4s9jVrKyOqS3UP0LhLIRP3l50pZgF1EjKN2OjixAGSVdELFzozJ57fbXLHdghFISLZDMCEi8SS3Pg1MKYH1IY9uQV2Qn/D5JX3watcvy1dFuNNO2fZRXx5YoEXW5Rvswe0hwV0GkeLooJhDOvKfxQo73MqSCKms3xyHkRrvAASh/ARfCCno17pCeNJAiIiuD/tTt1dqUkcGah79twlu2rHYIzKYeDR3cizzcOMOSYs4xKSmz5dG9et1Onee/G83o+rf/LLwJuQjl3Pqp0nJK60k9X9PH3FS1f4Sfa+CDE49IJoW/YWthk27hFoAoUM2MJEjzGcw2Y8zP+nsEZknD/P6OUaxaguIJeulv2QenEnxX+fZu0zSrbuKMaxVePHgP0l90pe5xBueYopsPp8Nfc/jKiHUxXd1nBEU32M3k40mdIqjD+gu/juGuTy62OydEsk+babIkDgW7Va4AWGYohDxL4voK5oLWXzSAsPC7N/6Ik00CNVazcP8nVQXGezrqVwdrBfLb4m0Ks/20/OGz59ZXiayLXY8AZr2vGmcEFqrB/rrDKVvEnk+MaehOoAqFFA7oZ68e/bs2sqvhUfBAKztiB0OtfzLyGfg85qdE/4Tph7FGOyHpBtMpOHycUyAXedPHuf6TyBAgFAFzQa8JZJCHeBs+eisHMQ4i/19yDNcAu+FivnRHQFVNzw85xfU0b8cFEj4hJpida+Gvxlfam5BXSj0AR6uAvDKV9GpoEEoK86g80BcgMYAMj4QbcnC5s0zikL79rVKU0w+MGYuyt2BgDQaYt2F97huCs2KPzkMerLs6B4G13R6m4f3K 24o2ntRH Ur6UQRTxlGITaf0vNuh0Ttv1/xwx/3DJZPE5m4t3gB0MoXX/ivetGMajgnC60QO11f+6s3xYtFKALNl0XcIBaNgh44Mte6Nbc96Tvyzl7if1k+9020yCtJBZShbEqMvJbv3aAJiQc8CvfzfyVf2/C5xayrJXrCUUsDO51ikMJjR8G+fd8X6sA9xleR+yCAOXMjdN3C3l4EmqsLJnHa7s5IaKUABvCfClz4VlOAX7QtsjLFcdeW6c6gNDJgDcCMI21lEHX3iUvDggj3ZBX/RULbG98Rg8s1NoEJdc/tuqp8YXz3WbOm5BzsQVrXBzE/zhXHSGfixQuF6nldPrQ1k6elpTusfh12BdmQAzjfGlmW+zPerpbeVDoFF32SNBAyk7mviuuZqz5o6rljynSes7bYTNfMT5DAFP6l78iFytVcwCEA2qLHLHbyc7tpBXXZLUAPNaqM5CzfOWzWCreBUKl47o43A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 04:01:16PM -0800, Suren Baghdasaryan wrote: > Provide vm_flags_reset_once() and replace the vm_flags updates which used > WRITE_ONCE() to prevent compiler optimizations. > > Fixes: 0cce31a0aa0e ("mm: replace vma->vm_flags direct modifications with modifier calls") > Reported-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Signed-off-by: Suren Baghdasaryan > --- > Notes: > - The patch applies cleanly over mm-unstable > - The SHA in Fixes: line is from mm-unstable, so is... unstable > > include/linux/mm.h | 7 +++++++ > mm/mlock.c | 4 ++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 5bf0ad48faaa..23ce04f6e91e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -648,6 +648,13 @@ static inline void vm_flags_reset(struct vm_area_struct *vma, > vm_flags_init(vma, flags); > } > > +static inline void vm_flags_reset_once(struct vm_area_struct *vma, > + vm_flags_t flags) > +{ > + mmap_assert_write_locked(vma->vm_mm); > + WRITE_ONCE(ACCESS_PRIVATE(vma, __vm_flags), flags); > +} > + > static inline void vm_flags_set(struct vm_area_struct *vma, > vm_flags_t flags) > { > diff --git a/mm/mlock.c b/mm/mlock.c > index ed49459e343e..617469fce96d 100644 > --- a/mm/mlock.c > +++ b/mm/mlock.c > @@ -380,7 +380,7 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma, > */ > if (newflags & VM_LOCKED) > newflags |= VM_IO; > - vm_flags_reset(vma, newflags); > + vm_flags_reset_once(vma, newflags); > > lru_add_drain(); > walk_page_range(vma->vm_mm, start, end, &mlock_walk_ops, NULL); > @@ -388,7 +388,7 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma, > > if (newflags & VM_IO) { > newflags &= ~VM_IO; > - vm_flags_reset(vma, newflags); > + vm_flags_reset_once(vma, newflags); > } > } Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > -- > 2.39.1.456.gfc5497dd1b-goog >