From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14966C636D6 for ; Tue, 7 Feb 2023 16:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 720E96B010B; Tue, 7 Feb 2023 11:52:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D0D06B010C; Tue, 7 Feb 2023 11:52:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 598E06B010D; Tue, 7 Feb 2023 11:52:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 499B16B010B for ; Tue, 7 Feb 2023 11:52:48 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1CD31A5139 for ; Tue, 7 Feb 2023 16:52:48 +0000 (UTC) X-FDA: 80441090016.10.23CBCB5 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf17.hostedemail.com (Postfix) with ESMTP id B820E4001B for ; Tue, 7 Feb 2023 16:52:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=pYf4Wm2y; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675788764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=90LXWSidw5JtQbA5QjDdZbPVfE/311Yqzr/kJ+sttOM=; b=gQmG8Jc7pkStDQEsXFRQOOO6IHu+8aGpEUUx86f7hGDu6hLKSpIiIhJNnjn8cm1Y81tiay vlGrkDAs3/HoHjfzRB5irjFJEGECpvZua95u5UJ2XPOelzRP+2Y77WzNju/TdT9H2J+LL2 JGUVvaoId6OgtNfrwpvRNy7O52tRMtk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=pYf4Wm2y; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675788764; a=rsa-sha256; cv=none; b=O99N1ripydcb3uUEikuronLjwPyphjRmBXBQsKaAVM3Qgt4CzCxUFOQ8MuFYbWipDckFVi NOG4rEfvdYgv6dRxhKNjZLNMarawYwIt2jYgHwfKa0SEqmCmsYnTS8Z1jtQOH1ZWAXtG5T 8fjMzMwpVwIG+adoo+a7v9Tswk6VAfY= Received: by mail-qt1-f177.google.com with SMTP id z5so17406720qtn.8 for ; Tue, 07 Feb 2023 08:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=90LXWSidw5JtQbA5QjDdZbPVfE/311Yqzr/kJ+sttOM=; b=pYf4Wm2yX5Db/EesL6WWX79wefRSPeDXmP+JdbgruotStM4aTAg2EEmqAmFcafVsOQ qVZWuUrBQcBVM89VJJ7Lg4bX/OLfvPC1JnVU38e0oEClpG1YyWHd0+1D5TuFyOmu9tci 7MwIi4JbzEUI59mW7MaUZ/BNcb7O8lzbaqyOkMte4VWLeUgGN2267ypBgPNhYD5pWixE 7FMX6ON/ZNDrK1hq08B5q/9FdOFoJ38kat9YP6xjerL7XjmkjB4pkTIVGToAAidXO5G/ MQeEU/d9tJ/c2Ix5Z2oWzN6/Eq3r3KwCryG0x4+v8QGkNaxF/8oRrWFBcMl3Dd67WCf4 AwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=90LXWSidw5JtQbA5QjDdZbPVfE/311Yqzr/kJ+sttOM=; b=bLcLh0767xiLe8pJ2aCVQz+b5L9n139cXRRCRez+w4joW2hAxpjg7SqGqfKeO3pnW0 92FBxggZrsonk4uvDmyuA6y4IcD5u9Sc1bmVEsuUyh1n4l02EWpgmGuwEWsU5xwVIQvG Ogpl1wOfbCx9UjKDT8fd05BWLnGZ1/Bq98Ndrb4dspRFveY/kMSfvLjNJg+IqtjBNxz/ 8Nby9nwrCsgeeR+siKQIMIiZhlwhxv2dR+yxkSG2o3uWbA2qsQXHJgtrqfRCvgryvnCC TJH1tnm5G9axh5MWdAnDQK0tSiGVOhP58Ielx53mLvfesJDV0mPGLl+W5f06r7Qsq++W DRuA== X-Gm-Message-State: AO0yUKVBFZTg/GrgNAit+wuEJMbh0g9bgSi7mT7p6Fy3z/T6MencXbLV x4MHUr4uSMUtdQGr9Ve4jFk5SQ== X-Google-Smtp-Source: AK7set/uMLJlKX7oaJVhg/E1eUJJiYug4Xd2CDFycpOG8k49bTxnQu/j0dxXX9P9xRATm5qsym0V1A== X-Received: by 2002:a05:622a:54c:b0:3b8:68fa:afc6 with SMTP id m12-20020a05622a054c00b003b868faafc6mr7290880qtx.29.1675788763797; Tue, 07 Feb 2023 08:52:43 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id f10-20020ac840ca000000b003b84b92052asm9621428qtm.57.2023.02.07.08.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:52:43 -0800 (PST) Date: Tue, 7 Feb 2023 11:52:42 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Yang Shi , Michal Hocko , Shakeel Butt , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner Subject: Re: [RFC PATCH] mm: memcontrol: don't account swap failures not due to cgroup limits Message-ID: References: <20230202155626.1829121-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B820E4001B X-Stat-Signature: dqnsy3m6wy485t5dg1iddb6e8nxakpdi X-HE-Tag: 1675788764-139563 X-HE-Meta: U2FsdGVkX1/ANZzUgfns130ZVgOTnn5EKMiDox3c7utOp/T/cLCyRfbl3FC3dj7Kn50XUAQJ3gAQx/D0PF8xESLFOcRz7N72HkDdDiQ63aQvKHx30LmpRos/8nIfqCNGM9KW9qt+S2ferYrEQA6MGtxp6yS4EwQKHGo2kkBFORrHv58cc4Aafv10eF5t7efLaw3VMI3vvRZ8na8e+kuvg9C8HxrLayI4O/q0qZyj6dKJjGwGk1Tu7xy31iEjNIE/aGSA9qlHRPQi3KBa5XzM/Gq18vrAafVLxNCC2w4DQhWElcrCCed1409cv5rFydQ4pBs3UstTzv8/WxmrRvCar8qhCsOqiFx/Q2u3WlPT8MWHu+RUx9WpYNh8GByzkQiqkmlrlO3+dP6NYxSD7gLX1I1AAnTJvht+wZy0JPTsFUas6BC+OOl2yeJ5xDkkKfMpjY4iPmNCzL4DChnILOTRXfyCnXXLkVA6Kc8VHfrRKMMQ8di4uHBtdX6PukEa3VS/5eK+uBhyi0Itk6Jw8yB/z43UIf3tkeF/peOQ2h9N57ScO4CHPJjTG5VT1Glkunl3FvSRlA31ed9VJm3wXsM7uqNR66tV6ACd+5mEVsOWzFTCmDixQ/lNXl0hUEFat2U4tI4ILXmHHHyQNE9p6fulmtq5Ewk2qQ3SfGErhR2PFi1/ifXXtwPiT1SaoLuv1Qs/O0pmnstdbq1DXnqvy4exT7ieSYk31dGcDx1vJhj+0hrDnr6lJg3lEaYPQtHRxxJD3FhcNiNAXys8aDqLxc8wU7GhtwC6Lj3AmVExv9K2jQ7YQuxkQ6YsckOGacTW6g7GpIL1aQ7dxwWwmMMiVKiONy0nn57gzbi7/76GtUDa0XkYwk8o/dLJBcpwgHNQt7l4yt2/bmVVFkiNL8SjKDrIpx+MQeUL6qwdB5RWH2LqXbsPeesYTlib9onssz2UXhPdahbHma33Oa1aBL/CSPx JMFGBPWV 09sP4gHseDmbQvuKduEDGMhjP7ZE1qAPmYBUOBk2BIb8TYodU7Hp2KPx7u5OrzmPT/NJOCIknB8OFoCbaMUN2qfW1gw00+sUtuJGt8sb3OgYby9syI4fC0vnqJgEVqOOLITH6Wq0/ucBnLoPfM2AOd1FHV0ps6Vv/Qnpp1/W24VSQ6WVpmjy1CGutLTNoTyDMMWZ2jch7hN9QVVEnpvkdJS0p8sxibG238902S8TpoohaxXqHPzoVps8NQSUI/Br79Fpp/KS6lSIi2ZwkRSoG+iciO1VlbRVBOvUZvCns0yrq0V5vl+o5lP+YEEO5wytI/lk02T9W3MWGK2nzndBYVguFU+WveueEaCWYkGXqMH/8Bi9KHA4an+zFZYloLpQlvRVjco0oO9e1gwQSd34uxu+2yPOTW8QTbTRv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 11:19:32AM -0800, Roman Gushchin wrote: > On Fri, Feb 03, 2023 at 11:07:30AM -0800, Yang Shi wrote: > > On Fri, Feb 3, 2023 at 11:00 AM Roman Gushchin wrote: > > > > > > On Thu, Feb 02, 2023 at 10:56:26AM -0500, Johannes Weiner wrote: > > > > Christian reports the following situation in a cgroup that doesn't > > > > have memory.swap.max configured: > > > > > > > > $ cat memory.swap.events > > > > high 0 > > > > max 0 > > > > fail 6218 > > > > > > > > Upon closer examination, this is an ARM64 machine that doesn't support > > > > swapping out THPs. > > > > > > Do we expect it to be added any time soon or it's caused by some system > > > limitations? > > > > AFAIK, it has been supported since 6.0. See commit d0637c505f8a1 > > Great, thank you for the link! > Then it looks like we have even fewer reasons to change the interface. Yes, ARM supports it now. But the point wasn't necessarily to fix this because of ARM. THP swap can fall back due to plenty of other reasons, for example fragmentation. It always falls back on swapfiles since they don't have the cluster allocator that bdevs have. The broader point was that we show failures in the cgroup event counter that have nothing to do with the cgroup's configuration.