From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
Shakeel Butt <shakeelb@google.com>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: Re: [RFC PATCH] mm: memcontrol: don't account swap failures not due to cgroup limits
Date: Tue, 7 Feb 2023 11:52:42 -0500 [thread overview]
Message-ID: <Y+KB2lcAH3vhw0Xj@cmpxchg.org> (raw)
In-Reply-To: <Y91eRKKutWBZwmSG@P9FQF9L96D.corp.robot.car>
On Fri, Feb 03, 2023 at 11:19:32AM -0800, Roman Gushchin wrote:
> On Fri, Feb 03, 2023 at 11:07:30AM -0800, Yang Shi wrote:
> > On Fri, Feb 3, 2023 at 11:00 AM Roman Gushchin <roman.gushchin@linux.dev> wrote:
> > >
> > > On Thu, Feb 02, 2023 at 10:56:26AM -0500, Johannes Weiner wrote:
> > > > Christian reports the following situation in a cgroup that doesn't
> > > > have memory.swap.max configured:
> > > >
> > > > $ cat memory.swap.events
> > > > high 0
> > > > max 0
> > > > fail 6218
> > > >
> > > > Upon closer examination, this is an ARM64 machine that doesn't support
> > > > swapping out THPs.
> > >
> > > Do we expect it to be added any time soon or it's caused by some system
> > > limitations?
> >
> > AFAIK, it has been supported since 6.0. See commit d0637c505f8a1
>
> Great, thank you for the link!
> Then it looks like we have even fewer reasons to change the interface.
Yes, ARM supports it now. But the point wasn't necessarily to fix this
because of ARM. THP swap can fall back due to plenty of other reasons,
for example fragmentation. It always falls back on swapfiles since
they don't have the cluster allocator that bdevs have.
The broader point was that we show failures in the cgroup event
counter that have nothing to do with the cgroup's configuration.
prev parent reply other threads:[~2023-02-07 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 15:56 Johannes Weiner
2023-02-02 18:27 ` Shakeel Butt
2023-02-02 18:30 ` Yosry Ahmed
2023-02-06 16:18 ` Michal Koutný
2023-02-07 16:54 ` Johannes Weiner
2023-02-07 19:09 ` Johannes Weiner
2023-02-07 19:21 ` Yosry Ahmed
2023-02-07 22:14 ` Roman Gushchin
2023-02-03 19:00 ` Roman Gushchin
2023-02-03 19:07 ` Yang Shi
2023-02-03 19:19 ` Roman Gushchin
2023-02-07 16:52 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+KB2lcAH3vhw0Xj@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox