From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F5BC636CC for ; Tue, 7 Feb 2023 11:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69FB66B00B2; Tue, 7 Feb 2023 06:09:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 627DF6B00B3; Tue, 7 Feb 2023 06:09:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C8796B00B4; Tue, 7 Feb 2023 06:09:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3843D6B00B2 for ; Tue, 7 Feb 2023 06:09:12 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CF540A0992 for ; Tue, 7 Feb 2023 11:09:11 +0000 (UTC) X-FDA: 80440224102.13.A40DDE4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 230A01C001C for ; Tue, 7 Feb 2023 11:09:08 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fs4G9i1i; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675768149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1VckuL9TubkTbxE4edCRGlhbctC56ZS3adv+u7VwL7Y=; b=dRVdmcJZfRXwmD2BvpAlG/Icrfa71FdlbyIQrUWqxkQFrdsXpZVkbP4panzCV2dwtmLHnx B3eKBQHuj8I26ahEEXH7h0IzLFlzvfWOQWnUefpkBIXA3uN3t4pIzZv4FNJOw1QweBQOPW 4rqdpcIRY7M/ATlrg7jhTQ7OOON4wY4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fs4G9i1i; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675768149; a=rsa-sha256; cv=none; b=nxIAJNPWGtEaBxECm7aZ8U/+kxvieHogYEG2Vza95EE8ysK8uHtCLTGmtKELdKPwNVOGX4 MEBu5VxdxBQOcUUtC6AqGaDZaf0DcdHfKJfQE3F/HbppiTz1021or3yZqVMLgP2Yr626oN BQ+H9ebWH5u5S+y8Z0QwCLkz9x1MMSA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87E55B815FB; Tue, 7 Feb 2023 11:09:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2695C433D2; Tue, 7 Feb 2023 11:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675768146; bh=mvrKzmSVoOCwU53QtQIouMJvK9TPygmAN88fteUFBPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fs4G9i1i81rN0OYBH+EGKBpThz7iyeTa8jodg2hwsHaQo7kNO9FbvlCW9ah07VFpR 6qb6V5yKTYaTUWhqT8EI1uppyRCwHTcUmDBiVYVid713r/+ekzt6Ul16wzd9I/5dkk RLOD3e42ghPRwi25pSKkpMvYWGkRX0il4+6Xgm60ow+zJGISagQdUgnaM3jtf1b+VT atYlPtQwyz1Soxs3FeQ8NtCow4CYdeBjjDhWzRicLEGJEmt5uAET8kAWezODq0XzWA n+RHiH/nEktfRHzAbJaf3EnmBb3xOj7tt8YGN/ZLmY3oPiag88XChvOI+0ssTBKosM F/uD1iu65305g== Date: Tue, 7 Feb 2023 13:08:54 +0200 From: Mike Rapoport To: Aaron Thompson Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "mm: Always release pages to the buddy allocator in memblock_free_late()." Message-ID: References: <20230207082151.1303-1-dev@aaront.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230207082151.1303-1-dev@aaront.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 230A01C001C X-Rspam-User: X-Stat-Signature: 9gz7geofwhcmbwhaay8ffcreh3m6aayz X-HE-Tag: 1675768148-710738 X-HE-Meta: U2FsdGVkX1+MqhzvQnYyil3w7rzlwXAs7+4BT5GbNmlZ6hzRHK+mPCtC7b1mQ5+Y7IeEm4jK5cwuLPAtnRMsznmOupbLp/1fxCVY8CwLhuZvaI/ezeamHsz8LlICxaUpvQHRJoJEgukSgxiOQxB46AQNFVf20qLzULyHTfcBYBCKa6/WNf5fB9B5eFBcpPux3wSXEbSCwsIAy2/bpJKImSv/SEZj7TGcH4/UCvgIxjFYILVfY9EuEOgq19tb0TV8KyQ9diYfKDqgfYJ1ywIxFXEn/ECmgvrPqb5AXv6hanOf3c2+a8lVtj+K5hwkzVX/20eKjJFYf4OX3oozPShDjT4S3Oe3ObQ6A6Qe3dXlIuIPf2Nkh1wuHjwKPJCr59xHiYvnrLxdG5aQBhGGDfjWqzkkFl0BfzLw1II+3vMpabuAtSDAk93R1dWm5Q7tlO8vQ7fXR1Ue538Dn01d3CEKWB9N5hvorn/BnX8ugxl1qDyQ8PqLCLWFcPAcQiDifS7EmvBkUrvMJcye8vsLkiCnDuBviTREZxOHoVZNIUZnVcT0VLseuDW56J0zOpCfZrned6ImozwEZHArc6b9nOO0k9LsfCA1r+e1CGimAfzt+SylKq8NYfdmNw2b9TEMDbg7hgjUrk5YZNHsX2pKI7Mda54bfIITmZ7awsNB0HBu8vbqVWiVowuy43cwM0VQCq+HM4M+BDRmRVOoEXYT0Zqqai9ZFoTpvkL/k1/y/Uckgp+eeYojZ+cyT88XV24Sp88qsGS5WoFXr5qXlLraR/DsOo3D4vgFszaKDfwsNDz417FEY5uYMD9k61nDwFFlcMRycRS08Urj63axD7qnfWabopA+0CHmZ0lvIR4GrVHH7oOW4jPIILtaUybf3eftXnhqgNlMIaVZQDWzcGeOCX+NLh7uWsQTGEMFMaUprn9lWaczc10/Q6v+pSYznUtFkjsBViOiuthDA8K1ZWOMnMw gC5F4NE+ vl+QxGDe2ZTKCEM83UQUE79LH0uspfzUjcY/g+7DIbysngw1iangu8OhqCIXwASP+5mKHNAwH+yFvKpr1KWDWr6rkCeVGWfaFvTd53FuDLwkD6aJyrsFUkhv4E8pmmuXcqjDExtjcdFwOQ1afAgPl6y1MoKlAOkFQmPn7QKlwKQksqb89tcdCpzfSVm6XmjfToBBQG/Y5zgWGfng8VRD+BpKExivQmfw8ZAkN0+HV3UO+H9+jh+ewFF/Pd/nVmGUZN046JAaHEWEJCWFu9AuzWIGG1ot21/QXPaJ/FHYB+qeLnK+N0PSGJMdJ3VefVjH6lhEjldNq1QggDFEsHqvbMF13UvTO8mvn483+PWb3YWpRHHyEaprc66Szrso19K/V7p2MasaYUBRxOLI6tA58Zh09kZAqcXHSlvRo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 07, 2023 at 08:21:51AM +0000, Aaron Thompson wrote: > This reverts commit 115d9d77bb0f9152c60b6e8646369fa7f6167593. > > The pages being freed by memblock_free_late() have already been > initialized, but if they are in the deferred init range, > __free_one_page() might access nearby uninitialized pages when trying to > coalesce buddies. This can, for example, trigger this BUG: > > BUG: unable to handle page fault for address: ffffe964c02580c8 > RIP: 0010:__list_del_entry_valid+0x3f/0x70 > > __free_one_page+0x139/0x410 > __free_pages_ok+0x21d/0x450 > memblock_free_late+0x8c/0xb9 > efi_free_boot_services+0x16b/0x25c > efi_enter_virtual_mode+0x403/0x446 > start_kernel+0x678/0x714 > secondary_startup_64_no_verify+0xd2/0xdb > > > A proper fix will be more involved so revert this change for the time > being. > > Fixes: 115d9d77bb0f ("mm: Always release pages to the buddy allocator in memblock_free_late().") > Signed-off-by: Aaron Thompson > --- > mm/memblock.c | 8 +------- > tools/testing/memblock/internal.h | 4 ---- > 2 files changed, 1 insertion(+), 11 deletions(-) Applied, thanks! > diff --git a/mm/memblock.c b/mm/memblock.c > index 685e30e6d27c..d036c7861310 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1640,13 +1640,7 @@ void __init memblock_free_late(phys_addr_t base, phys_addr_t size) > end = PFN_DOWN(base + size); > > for (; cursor < end; cursor++) { > - /* > - * Reserved pages are always initialized by the end of > - * memblock_free_all() (by memmap_init() and, if deferred > - * initialization is enabled, memmap_init_reserved_pages()), so > - * these pages can be released directly to the buddy allocator. > - */ > - __free_pages_core(pfn_to_page(cursor), 0); > + memblock_free_pages(pfn_to_page(cursor), cursor, 0); > totalram_pages_inc(); > } > } > diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h > index 85973e55489e..fdb7f5db7308 100644 > --- a/tools/testing/memblock/internal.h > +++ b/tools/testing/memblock/internal.h > @@ -15,10 +15,6 @@ bool mirrored_kernelcore = false; > > struct page {}; > > -void __free_pages_core(struct page *page, unsigned int order) > -{ > -} > - > void memblock_free_pages(struct page *page, unsigned long pfn, > unsigned int order) > { > -- > 2.30.2 > > -- Sincerely yours, Mike.