From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCF75C61DA4 for ; Mon, 6 Feb 2023 23:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 605D96B0074; Mon, 6 Feb 2023 18:47:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B5746B0075; Mon, 6 Feb 2023 18:47:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42F8E6B0078; Mon, 6 Feb 2023 18:47:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 33BC06B0074 for ; Mon, 6 Feb 2023 18:47:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F013C40B88 for ; Mon, 6 Feb 2023 23:46:59 +0000 (UTC) X-FDA: 80438504958.02.E514E23 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2088.outbound.protection.outlook.com [40.107.243.88]) by imf06.hostedemail.com (Postfix) with ESMTP id 41D9218000F for ; Mon, 6 Feb 2023 23:46:57 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=KCbwOmOi; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf06.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.88 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675727217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m1cZH6QBg5u5gqtW8D09Qp+a2NDpwHgDwVehMwMZZWs=; b=5LbXAEX/PKJ0xJsrTge27XJuL7lNyIjWlZQR7tKcG6AviKU6dkqOiZF0MC0w30/0HHfGDy A0oo9JTsJ1NyFtYxXNuEmwjA/LBzl3KJKCet6XfPmz/ssbcDDLP8N1d1NQOTWtLwRHQZ5s KR4OiRymx+90quWZ816e7lOy00PjOuY= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=KCbwOmOi; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf06.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.88 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675727217; a=rsa-sha256; cv=pass; b=qxuE/S4j7ERbhWUB2I+5AQk2fTviBIunyTKF9BB+iangaNlfZC3MAoKldofAgOGZ/Gr6gV 6n4IP8FreL/RjsdXatbkaZ76tL8e6s9P64rbPoz1PsXEWEJ/wJqWDaIN++uHlW53j3G5AM 2qUI70UfCDiUGERZJORaGFUtfKO+eNk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5D9IxavRHi1iapoKg9bR3JJBfCpMwk8uUQVP8wxTp8tztvC8MEzjVrhtD+JEfQNTFnVCxhF5p5E0pkv6S+tTRGyDjFqL5TrTtZMYX6cJK/gqgPxTIRNQNz+yVCB+Kr56GjEUWpiKNVtRzZzbifs22XARSEs7/1CqVpvdvbNlPsxj5C+oIPvyjvLai8SrUQIy4kaqSdYpfv3uld0Eh5o7n6h9w+KrmyprnQ9lGqAcCUf+eIpHsf0cI7STEEW7huVG82yk96hxEbFBkA2i//XGpE4kvaxPTdxrANaniQ6t7fS04SVMIKvoUhoTZbbP4GGp6rtmapYcvImzx0FX1l7Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m1cZH6QBg5u5gqtW8D09Qp+a2NDpwHgDwVehMwMZZWs=; b=DHMFmEi1J2S3o4nyOXkaz7uzRvs5trpzgbWXdFC4iS3pwTaK75PzTTH1K9C641C5DpWI3Cc/qf+VRNjVUVBC15dUXWO7MJrqyXSifVEkHBINq72QDpKCfYDzd42x4vbY4ytnDEDsDVm7XHM6riT4A7ccjJaBNvtXPEHRpBPkpcrehILOQ7nLQExZV2BUNwPGIrxtzpDV3aSAymdLzAS3nBc6vtFX6FxybXH4H6Yma/29DcxHPfpvtvrpRv3Q3KsNfdfwyJ6AjigHO4ogsQ6Lpe2cPo2O9mh3maUPsnhY8WnfMnrMB3ovJ9eHWgcmMPn9S3dFEiCprHAhXvcXokjFug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m1cZH6QBg5u5gqtW8D09Qp+a2NDpwHgDwVehMwMZZWs=; b=KCbwOmOiFjl/9wQRAWVjsTA3qUtrPlAIO9z/PRsXX/emkvyt5kmQlo9V1WNwnFF8t1fUCK51bTwjXk7GjdFG9qey70jrRP86xJrhLPrrBFg3DYQ5SFQw5iKkW1NlsRPMYSp7uUVVl8Gw4Nua0IlTdFuCpH5qb1fJsw2GZat0SKU256UbX2NHT1aJXu2UvBV0sMpVrQZP3vWp4K783WklxQOJl/KLCSVHpFUlxG0cdRBuBvk2YZLjqir+OITiGCMDB8PC8Dy1QKP08g/qdPndQmAi5Vu1Q0LgrmyLAcVFfwylaqIQocP0KsHiVuYvMpHi4sGNnk5bbyjLHziyzIkp0g== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by MN0PR12MB6270.namprd12.prod.outlook.com (2603:10b6:208:3c2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 23:46:55 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee%4]) with mapi id 15.20.6064.031; Mon, 6 Feb 2023 23:46:55 +0000 Date: Mon, 6 Feb 2023 19:46:53 -0400 From: Jason Gunthorpe To: Alistair Popple , Andrew Morton , David Hildenbrand , David Howells , Christoph Hellwig , John Hubbard , linux-mm@kvack.org, "Mike Rapoport (IBM)" Subject: Re: [PATCH v2 00/13] Simplify the external interface for GUP Message-ID: References: <0-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> X-ClientProxiedBy: MN2PR07CA0026.namprd07.prod.outlook.com (2603:10b6:208:1a0::36) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|MN0PR12MB6270:EE_ X-MS-Office365-Filtering-Correlation-Id: 18fbf73e-1c41-445e-3721-08db089c6d98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mJCwfTkrme7UMLo7QCzMrY9erDNPB0W2s9MoSj6CmGWmlNAlJFV7aU8bLc7H39KEWGskPsenbUs2z8D+AWQcKgWU0hbe7nW5V66T+EvUxhCQClzwSrJEQCSI38lvVwrXwVH2nrjHOcZwbVxDjF079+nMH/ym6OngGVNNbpikdA4dEtA+NYGXHH2rWAS83JKFdIrpmJbGbQCBvkwpyDh0+f4pqahC1YYyHQjiwFDgT7yCPwsiAmktUFTeWJMXtNI6YBJ88dG/BgMk/Y7ILypKHAr76UQU23k0uUxkKmf77IafSnairVQRB62WQV8iCHZ3qFV9tr3fj1Ur6OUSwPf/BEwSuy5xbOPwHXHoZkAfqWF1pSCnPtDzDBvr11iA0tD0S2oTBeU5RGpVxZz6G0gUH56axnFWkpBMDzMz9Uk9Oe9mZrYloH6yKIpd8tP5a2lUCj5KbPoBEOe/650OpNPSZIZEHLTFbZsA2BSmYWBEM9Wm7F3k5c+bDmh3abrUagVmeEb4xK9M0JTI0IPwcU7McJYdFMoNQvyWdnWtBvBxXtR8QEjEi9lakHnaBfrE7zufpqSve/9JU3vCnmVFEiprCvmfbKfiZQ7gBnmMOehQvfgyn+jRVsS4Rql2+n4cdFHL1iA3aBkR7w7NIjymA3YP3ZJBQjK0pdI8TTRR6q744DTQxjiCpksxCkwrQ9By6BZk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199018)(86362001)(38100700002)(36756003)(66476007)(8936002)(8676002)(66556008)(41300700001)(316002)(66946007)(110136005)(5660300002)(4744005)(83380400001)(2616005)(478600001)(6486002)(2906002)(186003)(6506007)(6512007)(26005)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Tt/G1gtiVPS1tlSeCcZH8wb0duYlW9xCkgh+AEAgd8ZDDuhOl4jbPP85uux8?= =?us-ascii?Q?peqNgRA9saVdoeqQJ7D1v9ZobSrKLgXFaehFevhLeM+2SA5/3jZjebPdWrws?= =?us-ascii?Q?lMqOoyUWWhSzN5CFPCieTikXldtsc+3gWgEEbQ+QNwvxcrAaMMtMo4E5r5YU?= =?us-ascii?Q?c7ITPW3fgKQrMYAlkRaNJ187/VIGafRmtwlY5DTEdBIgFksEYX6bomx83RNs?= =?us-ascii?Q?vodI5hf2RXK0uj7OzyTwBWX8SrLU+q5QJ6KiRx8AXumqXaqZKxjp2JSuZx9K?= =?us-ascii?Q?/0nXmYdfvyb2U6IQnFmgKu1i+JNXgQvsl2Q7PsakgJToXPlNylQyQA4NNqLx?= =?us-ascii?Q?jUIGhWn4aOmrT9ICaPOOfKXbqKIa6X4EIcl43hCVGWrKgQMIbGzn+FBAMgeA?= =?us-ascii?Q?BKS/P5x3mDIBrKcIfk76Otzjyz/HoEOQ5TniqgA7tnldALctxK22o6XtHJMc?= =?us-ascii?Q?cTfYMbierYLC9wbx5QfK5t50JOtZgfRboxkVw2Dq0KGWpJlrOE7ne8qF0upY?= =?us-ascii?Q?URf2Ot1/XmLkfP1Zdx1KvYYEyrhAq/0quKjgmkCKjkxSmlg1usI8WPeQY1H9?= =?us-ascii?Q?qiZJvxZGrt8yShFRrpYt+O35rl+DQC1A0AY4rtpoLEeoK+wJA8shxGWZH/iy?= =?us-ascii?Q?JK/iVsbvOg++w/MZwVU8s5gocS2VmCTi6n+eu1xSnrSwnShvKzWQQtZI9wWR?= =?us-ascii?Q?a4jcDNdgEy7YQBzoVRN2xpUOFrBkKsJptxUHPIYKcBc5l/FxrvB+GwJ4WG7y?= =?us-ascii?Q?fgEKGVTJ/W19EuJAr1tTjgRqL8VK7RD374ULE/wKBHNkYECWQkI6j92zOqV2?= =?us-ascii?Q?QjwoBVVl44J588VkLRLxZOWZFobFhzmcupEtQ8I6wUKN8lJIZ+5GyyOp1mI7?= =?us-ascii?Q?O5ua4IqNWncCv2oPaHYuMzrRoZ+WPf0SVT6blWzEt0SyIdBS2BdXd12aMN8d?= =?us-ascii?Q?JgFADGXZktzzwX/yQkH3INilbBtpR7/CaamNwJFjvQGkMvQAc5ocku1w78sS?= =?us-ascii?Q?BVhXwuxAnVs4tJku5r7JjEOW95iNMPpuDADPSvYEBu47B0F3TM653xVSjr3H?= =?us-ascii?Q?usxIQyRB5ld5kLB2DkoDFp1QzygDvOyzVo/c0bNZe6IGgeNB1WxCILWtLWkr?= =?us-ascii?Q?gWvcXYJpdLevLi3TI/+uxzPIExawnPCQA7GFd0s8Dmff66f7bINaiKMuam0x?= =?us-ascii?Q?N2vCn13Vq7cGoHTZ9truYwRfMigCmCpft76nqerDICrjrgpvJna/MTbUJffe?= =?us-ascii?Q?y0u3bhhNNqJ2FzCFp8YJfXlI9ILJzWxIU6qV3QiMwzP0SefHeSrIS6ot1IQT?= =?us-ascii?Q?CpIuj+ehGkjaztbK2zIkJD+Av28phMvO9oKcWyblNF2xT/IwkCUvIjMLAyB5?= =?us-ascii?Q?Gk4x7HiMhp/noIY7hwR2jtNYSNqInCSp7QXjVDKGxLZD5UKqawD4VkDXzOvO?= =?us-ascii?Q?E55lNyW0sUfGLgQWkL82HJzSDt6AxqSEL6T9AyIu3v01CwOsSj2mHm4Sqd9S?= =?us-ascii?Q?hN3F8oy5WXkgr8s6xJVZHbn0lc8xzatuyoscz0SbGZrrV4uiZZasib1OaQVv?= =?us-ascii?Q?mrHi7o2JJfb3faeekFbYJ76KYeDjwQ2FXNCDTbIk?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18fbf73e-1c41-445e-3721-08db089c6d98 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 23:46:55.1544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ITBr/fP1O5a5NBVFVa/xzbcc1bFiVrD55SWnZ67r8KiQkHOUN7Hb1aSo5XwhZFoo X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6270 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: oio4eibafgk1jpps5wzrfqh84cnr7th9 X-Rspamd-Queue-Id: 41D9218000F X-HE-Tag: 1675727217-584288 X-HE-Meta: U2FsdGVkX1/4L1k82l19rfdQmorfek5+PkYNF7I1Q77Df0PlcL6QFwk5Gcj2tOygFaC3PP9YnXbnZOAC7bdVas7j2DTSJCRxbrTxGxh+3+7uOnFR0GGCl86L/SKINyM3LZLLdAZVXfrmfbT4ECwIstVnFAWvbXPFeqXL4vFhbok2vE4oKiyRHcfPGsowj4Yu87WLieERVECd/4GAamH4VTevG12a0n7ieLVhG6JmP7tuMG84NT9S4rgT04kyWyhTe9T83WFF7xXFzkGTxapSMF4HFBk8fwGoI/SJZW76suz/G82p88/xuTL/vFtoE9FOjPw9/tjE0bMYdgXWdGmQ6RSIdoM8HsmAy52uTrRCOeyZg2oczd22mLctH+DRBMt1Y2ZgZ1WxKlc1X/IodTYo7qezNBOHwvgWmmH/phLPdk0O8ozVSVOwixbYalcPuinEwmolLBEzMX/C42A/Fm7O0S4JngBkE+epaUm+ZnYpgA4W+alxHElTqH2Hskz1Qq+25YCl1Ud58pAWrByUz0bzyt3C1D0J0Gh81i3BxGmyOTQf9t4KL4CrBlXpHFoa4ZaQInMQypPKLYpMemc9gdcNyJ4ywEMuvbU2HMyT/ioW+GuWnlewiu8+RMpSYEGEkhijWEjHxhy8qXesICMolnNVu8DJLajrxDqrANAjrh5NaRBeBnsIN5dKaYmTmsTvu3aenC7J+ukfdfXQGMypFIaOfWAXg1Ly+rc2tzsVD10ef8MuW2DyYUSb7egj2jdHx27sRKwF0rnsHFgD9Sup/6ALIgv0CuqieaUbfpLEGc4hKX6MdQy7Js19MeVqBktC2aFuxp1ZRKHwXMudFtdjZ61BlrQvqowNL92wM/JtPvtk8XYjXmXFXDkGRoaWPg+PH/xtC1IYsHZFAgAIhb899rVYl8bdxvGX8uXE74/Rnq3/NYRbndYQLDDE89ldRskuDtLXnWWof2ElQrgCzLotkFQ DiIbJdV3 ZMmIzlscM8St8TGyjckTG7IXEHG17EchrxSG+ORSEKk4JAroUdFS48JJ7U7rodwtzHHrc09agOu12B59ourkQs6v/eeiuL9RqEuzX0DNXApi3YKKyjb+trM2MNFt6oQAtuT34Fx2DDiF124JvNmQbKCKZchuQUTlPmNRVjPpuxY+ANzww75CkPohhebh5t+e5SeY8kac5e3fAyM3ifC4fdfSRw/O5luX1xQo+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 04:34:21PM -0400, Jason Gunthorpe wrote: > It is quite a maze of EXPORTED symbols leading up to the three actual > worker functions of GUP. Simplify this by reorganizing some of the code so > the EXPORTED symbols directly call the correct internal function with > validated and consistent arguments. > > Consolidate all the assertions into one place at the top of the call > chains. > > Remove some dead code. > > Move more things into the mm/internal.h header Hi Andrew, It has been about two weeks and I don't have a reason to respin it, so please consider for this cycle. Thanks, Jason