From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C548BC636D3 for ; Mon, 6 Feb 2023 16:50:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B6056B0073; Mon, 6 Feb 2023 11:50:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 53EDF6B0074; Mon, 6 Feb 2023 11:50:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E0356B0075; Mon, 6 Feb 2023 11:50:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B12A6B0073 for ; Mon, 6 Feb 2023 11:50:41 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E9F99808DA for ; Mon, 6 Feb 2023 16:50:40 +0000 (UTC) X-FDA: 80437455840.17.A116228 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 52751100011 for ; Mon, 6 Feb 2023 16:50:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o9x0fmAt; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675702239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QsnjtXqlYd9jM4hWcpY2ITNKQ2+0AQz322KtsJvzG9o=; b=3QUvOjuLhqT/LQu9lz9v6HYutGWCYosm8Jiv5tzAzhykUB/dKyD1J+RCqfAB7CqQuGysqd KYnlQbVqIxE4bcNNlrdIu6NOpyJkoA5aqBxsAnUWZQ1V6o/hzM6lml1d8m2g0+859Yz267 FbPeCUcrD6i8B69DZiUzhRUtieC6IOc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o9x0fmAt; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675702239; a=rsa-sha256; cv=none; b=X5zfP238daMnrJn4u69CAYvDeXz2e06BtrUI7PYoVXWrC6v0cQuhWfH3NQTH0Z2+M4LfGD mcJH+CFm1oYqGDmj/4ssHFpG4sFgnAKcstA2i1Gw3+MjK2F92FjW8RfiKVH2rduCLWAaJ/ E3hZo2tga37EWxIBNeNjZOyVLV43E1s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QsnjtXqlYd9jM4hWcpY2ITNKQ2+0AQz322KtsJvzG9o=; b=o9x0fmAtsRZJTApoTBbxandpw+ mSnoT7hNRnfXVJvfPI141H9f982jGDMSTNI24qrfCfks8vyc0ue3ES1YhvTFhgIQ7jGapWtwXuCNu MqNNORgw4D7IXVbXwGrMZYH0Nrkb3r0aS7oiz6XKOJhYPh/LN+ThJuEAbn6yPu3QJH4R64H1Irva+ sBh2e/VoimTCucaRAdS2roVnY3shiTvTEUHRQUdJVIdOnCm4CfBn0UpUw6FuYALDVjlTGLKJosoDg b+Hovq80Kgd6ohI4SNy0JsJKuJfx3uUfCPTuOGrb3WrFywaNhPZ5xukyblt1OdT5lbGJ6iXgbrPRy vJNd8vUA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP4hQ-00GvF9-7O; Mon, 06 Feb 2023 16:50:36 +0000 Date: Mon, 6 Feb 2023 16:50:36 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH 2/2] rmap: remove parameter 'compound' from foeio_add_file_rmap_range() Message-ID: References: <20230206153049.770556-1-fengwei.yin@intel.com> <20230206153049.770556-3-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230206153049.770556-3-fengwei.yin@intel.com> X-Stat-Signature: 83qiyra69tzaworxmthi8hntxo8ar7i7 X-Rspam-User: X-Rspamd-Queue-Id: 52751100011 X-Rspamd-Server: rspam06 X-HE-Tag: 1675702239-613449 X-HE-Meta: U2FsdGVkX18yi62qKAXooCHVnQksOhT7DlBmzLUy+m11l+SaCceIfPk7QMcAGcvrrtDX+y7/yNmWgGRXNYhmXJWUXSW2QK9v4b5JOSqkUSU8SNi92QUHkijN61ceJ8HIjnFXQcz2dEc+Bwc1lC/3tW63uYkN89B8BOa1QX1L9DcC9Bfk5GdGOF4FarwMR8knvBo2A7R9mifWS/jbkvtoydi9iyWgSdcI6ZnCjcNlT/17nJ6TbQqVB7Uts426oJIL4Cq8/oIfDKaf+sjB6DsGvT0cvwZSX14NYaKzRhmX9+e+jfnTGeeMLL0rc4JZiLT1E2fWzNLDQsWgw9yqAk/0xSpBAUXVvLX6QuWlI82o6tH98QhCgBw8G6OLabEVq0SGAm1lGdGzS2Bp2sC824ADz3TbDk1O8tWDkSAMvM3GePkRlpghZdueOk9HieuDBqwsJdW4jJxpR+x3Ai0vWc9BFNgMrK3hAhK/STx9uCvwFFc6T+I7wFt+u4iXb0OPa+rBGsMK0xCQSxLtVYgPTlPZy95/Dz7MBYV5Xe+DsWl3l8gV8x+V5M3O/hEECp/oBbJK9TjDMwybIBwjPLO7o6z35DuBr+PUVbLIq9ZaybeyVjwcHjFJR6bxn+PXeEcOA/qI4MOymQ4eZfVOrj2stXa08+2ZwS4dUasGCG9L6JblLuI0Miecjv3o6vZQjI+My2KI6ly41nbBJDioCCIQ7cIy2IFbaMGGCTKIycoofk5EQIcaR+6LVhhLZ4Z6Fq47v0sbmpYAnMwhiE8cA2gAxWJMIBqz7j75ZXcvJ6kAERJ5LbphJ4/boeXDuwX5O8GOJfxVdxI0lM3Ddo+WCtsDyLL7SdWl1nfRF8VlBrvMlI4ExkiLLsrlXJ34MTLuCY7tXfMicQpw3ux2jwmOEU+NHErQYnQzYfvXkCo/51JItBlcY2QJ/h+agT2Gb4YtXMAmJ22Z6h5z1W3dEAeKWA023zJ 24FT/Bbl QiEkAEgodV46gaEUNealwwipUIQvK+laeZ/Ckt3XwQiPba0v26+v18ErscP5k+z3QZFgoFrCziM6H8yA0HRRFaiyVbcx32zOp9DqJ0UyVYapvBGvoTosOWmk2UtNzpzWv7MgqV02oSy3Syt1MO3+mm2XfLA5++t87CCm6TSSwsOIB+avzYnQF3ICPmqC2Of4TnrBCa8rcX02/5cc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 06, 2023 at 11:30:49PM +0800, Yin Fengwei wrote: > Remove parameter 'compound' from folio_add_file_rmap_range(). > > The parameter nr_pages is checked whether same as folio page > numbers to know whether it's entire folio operation. We can't do this yet. Even if a folio is large enough to be PMD mapped, it may have been mapped askew (or its PMD mapping may have been split). We still need the caller to tell us whether it's been mapped with a PMD or with PTEs.