linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Yin Fengwei <fengwei.yin@intel.com>
Cc: linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com,
	ying.huang@intel.com
Subject: Re: [RFC PATCH 2/2] rmap: remove parameter 'compound' from foeio_add_file_rmap_range()
Date: Mon, 6 Feb 2023 16:50:36 +0000	[thread overview]
Message-ID: <Y+Ev3GQGDchr2UqI@casper.infradead.org> (raw)
In-Reply-To: <20230206153049.770556-3-fengwei.yin@intel.com>

On Mon, Feb 06, 2023 at 11:30:49PM +0800, Yin Fengwei wrote:
> Remove parameter 'compound' from folio_add_file_rmap_range().
> 
> The parameter nr_pages is checked whether same as folio page
> numbers to know whether it's entire folio operation.

We can't do this yet.  Even if a folio is large enough to be PMD mapped,
it may have been mapped askew (or its PMD mapping may have been split).
We still need the caller to tell us whether it's been mapped with
a PMD or with PTEs.



  reply	other threads:[~2023-02-06 16:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 15:30 [RFC PATCH 0/2] remove parameter 'compound' of add_file_rmap Yin Fengwei
2023-02-06 15:30 ` [RFC PATCH 1/2] rmap: Add function to handle entire folio rmap removing Yin Fengwei
2023-02-06 15:30 ` [RFC PATCH 2/2] rmap: remove parameter 'compound' from foeio_add_file_rmap_range() Yin Fengwei
2023-02-06 16:50   ` Matthew Wilcox [this message]
2023-02-07  2:44     ` Yin, Fengwei
2023-02-07  5:03       ` Matthew Wilcox
2023-02-07  5:35         ` Yin, Fengwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+Ev3GQGDchr2UqI@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=dave.hansen@intel.com \
    --cc=fengwei.yin@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=tim.c.chen@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox