From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72541C05027 for ; Mon, 6 Feb 2023 14:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECA696B0072; Mon, 6 Feb 2023 09:44:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E79636B0073; Mon, 6 Feb 2023 09:44:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D40D06B0078; Mon, 6 Feb 2023 09:44:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C5EE96B0072 for ; Mon, 6 Feb 2023 09:44:21 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92613A81D1 for ; Mon, 6 Feb 2023 14:44:21 +0000 (UTC) X-FDA: 80437137522.20.622B8BC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id D981520021 for ; Mon, 6 Feb 2023 14:44:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HTCOu9n3; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675694659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W1ucORgppWdZndNRnxWL4kOEmsFMRb5rhcTqqNHE0Pg=; b=xXnFMLdJXJiNuyqErmIjneJVfCmEo4Kanv3+UlDanQ8jxceVmBSAeKXW0MJEsOj8QwlWCc cSxgLz4gSw3oTaQWT/lW/U7qAH1Q/+fq0iqN8lKjEwRgihc05IcZ/wajTRk8f3WAESsg5X R7JGTyRGUm4JOMdl4akzb40f6xkklEs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HTCOu9n3; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675694659; a=rsa-sha256; cv=none; b=ozblda9+eyaubioABwN+4tNN4Q4b3maaRwCvik0nJRaMBSwzFmjgEW0otZXRzQ/53GOvx5 t83YL+PNsQmEUH+TTHHrqWjWbyyuk4pSN8zjkWvFcBGC1vc7qo4yFYitaGcAtwZyHUe935 g9f/YBQ95/3gmJ1s9BG/+tpOZ52urgw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W1ucORgppWdZndNRnxWL4kOEmsFMRb5rhcTqqNHE0Pg=; b=HTCOu9n3A8gw1aOGYU1eO436T/ oO2RgDznJG6wvwsAXUi9X1do4OX2qY5g6TIYlCiYGdX/i8URhcg08XKXGk9IJHWmyQV+sAU4YIIic WpHB8nSrmyIqwmoLQNSodpwYAVZubZm6TUK/qDWFnm7o1fj0nL8lO+VmBIx2kXXOYzgi4i/nIXF4L /JSABay58/6xLeAFC7i25VvbK2O4TxRoDMPgj3gFHe5xuoMSpr0KKK6r6sppoqJ3cdLnqdWojjKAM qh/CUpKBeia8AepLVlVKVHndLjp4hRWERcGPgwndgVd0fgGopxqF4YSCoId0VgXhClopj3UBkRSvm hLQT8Zvg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP2j8-00GpkB-8T; Mon, 06 Feb 2023 14:44:14 +0000 Date: Mon, 6 Feb 2023 14:44:14 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v4 3/4] mm: add do_set_pte_range() Message-ID: References: <20230206140639.538867-1-fengwei.yin@intel.com> <20230206140639.538867-4-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230206140639.538867-4-fengwei.yin@intel.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: afokynis8s5jbg1hgfsgygihz881ms5b X-Rspamd-Queue-Id: D981520021 X-HE-Tag: 1675694658-175139 X-HE-Meta: U2FsdGVkX1+yPyRqVb3bfPJXZ+7IxLxglTqHlh+rNPdN2+kHIGyILtM8hmH6wdVOlNK80RzXEcnM3ypQIGHhb4S97R1tpJIagObDmqcXPazFbIz8vJoKa0zPCNoT1Q/y5hpcZ5iDEIZjAkMp5rqPU2bO3ayM+8K5gvuhm8azFLTxCYI5ZBE/BG2CF1aWz86lHFZicia1WVEzWLfNcmmH+hUe8oE2haVjTscvSSwxR8j+ylsSJjRipZSBpo6USjXTWehZ1XIWVO2r49P7j6TmWwuRaun8pYCHamgWnbWS+L82NDR+82YpfhZ1guk8YtGGfX0g4QMCbaiQkGnkUI1DglBCjUmVKI3xD6niPyoHhWfPtCpsH5sPYGKh8+KA6B2EjLmkT8EpL1/tfa42WK6H1K77zilZQ3N7KaKigBNvJKO1WON7v8u90P0jJi6EKuMAp4B0ejvhX9AV/sAYwFB3NxVg7kNu7gmiwJN6Lf3TMqntFg6SLUpyODcxuqMYxSAZTb3ybANeGsYv7MHE/C9szMUGXfclXlc29FALjwxExWDnOaR8g1LqCWbmwiyaDQAg8vF/y8/fE7cVXqQttYCSKENdvH2eyiFJ5d0ZDyTyFiZ2yGNW67YwpfA0j5jHamy8Zjiah/+vvl3rleZ4kj38OJvO79IRO1g18BSkiXSI5dBdlI4GenlaoERX+u15XrXvOZSlxYhROYQ6chqk8MThZLgYw57RC/m3tXePEiaEdx7bZBmIzf1vFVl6eOuCcoGJLkPneYKGXXFv31Tz/cSTtJcG103asK+76rnzUA/W9vIwFIpRACGsRT3ZRAOmUkp7sPBbhn+sIfuVmpqkVBUTafp1rHK0sqR6wAHzB1zjPe+QsBkDHX9USaVpwda/SZlN7cBkFo2kxb5bP4JCXkT4sGyKXLc8t+JDjRo/Y8GkAKD+9xkHjMigXARw907PQ4xri1T0MXNrQ36UpqYBjYm d394g42l rYYpJU+ygPtEufhmd+SZCHhs5b0bqSU9Ogzq47rLhsC8ofC9zM9z62yU39x7SES44wjN4k/l50XZH9kSFGhN2vHHqQOhewQIwoC5XJ7EOmbDZMLP+p0jnogLxveVeFivSgQZvBIpRg1wlXCcWpBjD9t3IwCZ63NrCHrsK/qQcVwhtyO5ml4LhcXm++0Ec9TG+w4TzJ4YuQoASVlA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 06, 2023 at 10:06:38PM +0800, Yin Fengwei wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index d6f8f41514cc..93192f04b276 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1162,6 +1162,9 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) > > vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page); > void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr); > +void do_set_pte_range(struct vm_fault *vmf, struct folio *folio, > + unsigned long addr, pte_t *pte, > + unsigned long start, unsigned int nr); There are only two callers of do_set_pte(), and they're both in mm. I don't think we should retain do_set_pte() as a wrapper, but rather change both callers to call 'set_pte_range()'. The 'do' doesn't add any value, so let's drop that word. > + if (!cow) { > + folio_add_file_rmap_range(folio, start, nr, vma, false); > + add_mm_counter(vma->vm_mm, mm_counter_file(page), nr); > + } else { > + /* > + * rmap code is not ready to handle COW with anonymous > + * large folio yet. Capture and warn if large folio > + * is given. > + */ > + VM_WARN_ON_FOLIO(folio_test_large(folio), folio); > + } The handling of cow pages is still very clunky. folio_add_new_anon_rmap() handles anonymous large folios just fine. I think David was looking at current code, not the code in mm-next. > + set_pte_at(vma->vm_mm, addr, pte, entry); > + > + /* no need to invalidate: a not-present page won't be cached */ > + update_mmu_cache(vma, addr, pte); > + } while (pte++, page++, addr += PAGE_SIZE, --nr > 0); There's no need to speed-run this. Let's do it properly and get the arch interface right. This code isn't going to hit linux-next for four more weeks, which is plenty of time.