From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E21C636CC for ; Mon, 6 Feb 2023 03:18:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA5A6B0072; Sun, 5 Feb 2023 22:18:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 333726B0073; Sun, 5 Feb 2023 22:18:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AD5B6B0074; Sun, 5 Feb 2023 22:18:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 06FB06B0072 for ; Sun, 5 Feb 2023 22:18:37 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C0CD9120A43 for ; Mon, 6 Feb 2023 03:18:36 +0000 (UTC) X-FDA: 80435409432.28.8DEADD6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id BABD410000D for ; Mon, 6 Feb 2023 03:18:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fsVeQD5H; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675653514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HUnXR7sTsl7YLdib1oIsNCKOxnTEFsrq4tcNXVLT5m4=; b=gu2BEnhKnSo7kORSScQkKP8/+uTXLbs7ZhNxYJS/5pSAYK8smrogkzVy6/s/15LssUf/0I Kw2nbYhduys+xPYdlN3xmp4w6dASxH02HZF3YRRcof+nEdMr/0WtmGEW6ncLNoygIUzcCR MALTOqqCOOys0JQ9g3+8O7a5w9UfhU0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fsVeQD5H; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675653514; a=rsa-sha256; cv=none; b=uIAAfePNSVFIHah3crlqW15l0WP2qz4zuQtF9YzpVaWdiBCvQZFIEbrGHPeKJHkwtvrgah /h/SEcJoMh7EPuLCHLm9+cLFK6luQpk/vBnf9ST8k+EbgnJChs3VleAEaEaYZV3bHTrqxK 86aJTVRXklFF/P8NsCzQP81XfE0heWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675653514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HUnXR7sTsl7YLdib1oIsNCKOxnTEFsrq4tcNXVLT5m4=; b=fsVeQD5HhgDtw0OANPTWFjLM19HiDP6eXKL4vunRkM50YKlk4Se603vfacpQQ/TmPolqDf 7liXh6ZDSiv6H/oDyY4s0xCTT6PrstSHqG/qN6xdbz7b0lQkFSyVI5h84jEuEVwf3Nqj5n jI9eDDsJmexHI+CzZbbQxwCCqDW6UjQ= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-50-VewyYIByNMiESSylsjlMjg-1; Sun, 05 Feb 2023 22:18:32 -0500 X-MC-Unique: VewyYIByNMiESSylsjlMjg-1 Received: by mail-qt1-f200.google.com with SMTP id f22-20020a05622a1a1600b003b8674f2302so5763511qtb.7 for ; Sun, 05 Feb 2023 19:18:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HUnXR7sTsl7YLdib1oIsNCKOxnTEFsrq4tcNXVLT5m4=; b=ORGHZu/9C/0k3tSC2vlBUtB+WSTlfVo25GyU0Dv4cusa5KsiN7cco4y3qGgJcqUWlu a+R0pynlYOlJoLzGWDGU3CiEaU81DO7UE4QdIGqadwXEZ7ugREGLM7X33UbboeIPP29P EndIlyNHmsna/dX6sExOEo53yW1JmsJJfApZCbMfXehoMbzwnqgbJIpXi74Ylk4wS+3Y k/2zAz0GAvxJXt69kr1KBCVa9xkQhPEbsP+KjlOw5k3l4dmIlTP1yDnuCzMQ53tD3dxJ iWN5Wyaik3aWm9dK13YyF62jV6Ar027bjEl/9D16qlO2Mpq4k/v1J70YT0Z2nKfPjWio 1VQQ== X-Gm-Message-State: AO0yUKVIvT9iOYvyaFetTz5jQdgF82CUI2gbYA1VnPhxLrEUGecGEGwp /T1AMsfzIsMnVgYyuni4FucfWxBOBrJyHhXecRy6fSzMfNvag12UZRTPadNleEXaOdAc8eEvcJu fQra2uWh6tio= X-Received: by 2002:a05:622a:17c4:b0:3b8:5199:f841 with SMTP id u4-20020a05622a17c400b003b85199f841mr33929532qtk.0.1675653512191; Sun, 05 Feb 2023 19:18:32 -0800 (PST) X-Google-Smtp-Source: AK7set/cpAGW2ESxNhYZ0jEVuvvuRs8ZuhdHof+3DnmWont85g1bLMGsUjVwGkO9KhDgbxDFzB1GTQ== X-Received: by 2002:a05:622a:17c4:b0:3b8:5199:f841 with SMTP id u4-20020a05622a17c400b003b85199f841mr33929514qtk.0.1675653511960; Sun, 05 Feb 2023 19:18:31 -0800 (PST) Received: from xz-m1.local (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id b6-20020a379906000000b007186c9e167esm6574425qke.52.2023.02.05.19.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 19:18:31 -0800 (PST) Date: Sun, 5 Feb 2023 22:18:30 -0500 From: Peter Xu To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Message-ID: References: <20230205231704.909536-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: d7qrw1zc4xazgjo3tqarmft7wu6f35pn X-Rspamd-Queue-Id: BABD410000D X-HE-Tag: 1675653514-592745 X-HE-Meta: U2FsdGVkX1+nyYKcdZUZ0VjVNwbXpavwr11X10Y36vEBXwNLdb8jddjeslsrLNp+PlIdj/hGgo8WK27OpmUzFunnQfqEm3s2n9zmD4NITLDqzx/DpQmNARveQr2eSwkv61vA1CIEzFX+gX1VIP4x99GNeOUjsIGNFsK7kD+u+jrailfLVUTWUuhkdPP90vI+F5H7Gx65uCWh37rwFTZpulDxDqmojV5yvg3rzhl8W2OOGgXmALiaTVs5PfsZORix/Lnc3Aj5yAi9JRq7PkXqDfPu2/1/puwIIEjZXDSJuk9unzV9gwNBgc5vpwWfszzurosKZ06xWPq7TW35FURXeUHahCQWgqOThIJm3yK7CL3jwlTWxLV0n5yni40dDVeyvRXLssvoTLevpPnA6sIV0pBiJNr18ts97kRR/oY1E/X/NBCu2X4x8FdaNFVo3eY1u2XgQjVbU+Ec1HzKZOKgAuGHKIt673MRUtPBJlgvVMJuDPI0Xt8gER0/iNfDgmfS1yPv2Rz5dfD6/wKx1Obdyi+Cyns3LQB9SihYC9zXEPbM4xAgnB+cZwZ0gDPGTe/bZBFWpJSi2vL1U9CUC61zZDcIX2TT34qs7MO1UD/kOk/jJ/O3VW6f8b3KBasG0ua4i8tK7uS9l4W7ebQ/0Biy0/kuXVz3Td9QAuOtDO6bcLjpDmtd0cE7V1vYBVifI/oNPw07veGDV3Nd1YRzLHjrJWExN9/N01PXkbZZx448C3jshkU3SE6ml6U5hFFcAPyxZY38qpzVkDwCYXrr5/JiHeK35YLhuHTrfXAdiMymHRktphsiL/QzwExwBQkd/qTHNMq1LGM358/miSZbmFl/rrRn2q0rRurZHCVOQszyZy8ngRyR5qU6uMYqz+WfCxSsR4MRj9F9h5VAu3woZ6TkRtnJogz/hR/j8SqCai2eAijLrg1/wQWO+dRE3BZl86xFWYStIqVDgcVNqiSsJ9i GO13N6B6 1LkQgWUsMhCi/IolFv7DUL/JTr5O496UmVp39S4z9jxWwvYaFFYv2LRkCvLjXNmmSpOJgdJK+HI9bv5Lxibag0P97gUKUN0uYg/pv3WD+mujxQ4TCxE0j9D3S+U/o7Jx1tIW/dLd1nGTBIjEkNmnUfOR835p/li45zC/KUTCiV/qqDzkjUGdtS56JROOsGLh0C4tGaHNvOdSjcSijkw6+cFC19xuCu0Oe6vUK5mp/csO/vrjSpJ/gINrkrUo5U8DJ6O9dUVRn8yCRBwexeoADvRlOk6oPskfvcfF2z+Wtr+ASY5Se+bTv81fCvumAEVCGk8DLll/QEfL20wOfbrTF+RxwpxpU1DPeCp+aJd/toj+ImLmPOIG/vj0SYYOyf4pDyDOl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 06, 2023 at 02:51:18AM +0000, Matthew Wilcox wrote: > That wasn't what I meant. I meant putting VM_FAULT_BADMAP and > VM_FAULT_SIGSEGV in mm_types.h. Not having "Here is a range of reserved > arch private ones". VM_FAULT_SIGSEGV is there already; I assume you meant adding them all directly into vm_fault_reason. Then I don't think it's a good idea.. Currently vm_fault_reason is a clear interface for handle_mm_fault() for not only arch pffault handlers but also soft faults like GUP. If handle_mm_fault() doesn't return VM_FAULT_BADMAP at all, I don't think we should have it as public API at all. When arch1 people reading the VM_FAULT_ documents, it shouldn't care about some fault reason that only happens with arch2. Gup shouldn't care about it either. Logically a new page fault handler should handle all the retval of vm_fault_reason afaiu. That shouldn't include e.g. VM_FAULT_BADMAP either. Thanks, -- Peter Xu