From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F85EC636CD for ; Sun, 5 Feb 2023 22:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BF266B0072; Sun, 5 Feb 2023 17:14:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96F696B0073; Sun, 5 Feb 2023 17:14:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E9096B0074; Sun, 5 Feb 2023 17:14:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6AC596B0072 for ; Sun, 5 Feb 2023 17:14:25 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11978C05C0 for ; Sun, 5 Feb 2023 22:14:25 +0000 (UTC) X-FDA: 80434642890.25.8F8D72B Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf08.hostedemail.com (Postfix) with ESMTP id 43EB816000A for ; Sun, 5 Feb 2023 22:14:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=niOBgCzk; spf=pass (imf08.hostedemail.com: domain of xiyou.wangcong@gmail.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=xiyou.wangcong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675635263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YRwBessYltnVl27VyWC15atdLwY8Z7C93TnQdOZlZQw=; b=IwRWKUi69SzVnPNuT1/+lkPvMcCT/5aOoTN0n7CHZ/yMNJ12E2H2FX++MTPR1TChxo8qyk Xk2lLzIu6NeD934djJpP7uMPme1+0E99+2Dygr+uJPsz50ddYhglP96yhBZto7/huPlpXN 3mOaQWxPiwGODP/eQIJp6dA/27UR49M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=niOBgCzk; spf=pass (imf08.hostedemail.com: domain of xiyou.wangcong@gmail.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=xiyou.wangcong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675635263; a=rsa-sha256; cv=none; b=yY3Aam98Z8kCkak3eHCgui+1pC5kgHH/9/KV68nKvClr93csGI+C0Oza5xoMKO6DIOxWgL eqszvw8pQbcAUcjQfbVbpc0ahXcvbYYevH9JKQbC+8+dxfOaDiyluhnKdtj8NmqIq/tF50 f71soC3jt4anR7TBRidw5687JRo1soI= Received: by mail-qt1-f181.google.com with SMTP id w3so11063400qts.7 for ; Sun, 05 Feb 2023 14:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YRwBessYltnVl27VyWC15atdLwY8Z7C93TnQdOZlZQw=; b=niOBgCzknPFZRDNIEiLf+vWUNwLMBkPhwxsQVSRlM8YqLvXTmAvIh6txQ8YHUuxi04 EoxA5l4jOR/G4v9I35cAN1lbQ2L5cLELDZTfEUdyl8xtpjYAz4YCr7GvgnP54d2F3OXr X8zSB0i0IlJ6+IcUYgYYHw9W86whUkBIrYUnEp6u9XA8P6cvwJmYi5px49H1NKcqQ5vS ZwaUcMIGtbHh+9rnscvR0OjI8VQNfcn+H0giyfoim2Gotz3HOH9TXD789WjfBJet5YXD yXVmZQfp4aaCNuOvpUGeD5XJNJN1XrY3oGvAhlmfWKM9h+cmBoYFUG8vtfYC2QRieUbg nCbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YRwBessYltnVl27VyWC15atdLwY8Z7C93TnQdOZlZQw=; b=v1V7wZDPJEC7kWwhFGlFxJQSOJuRN0vx3MNs7Tr4udyvPbeI4oHWed7QStSKUdYULp wzW4tte+mTcgZ0KwDRUXPI0A26LfbX94hrY+3xoGbZZMv902L454eMf752ZKbNp7zHSI sE3VvOeps2OzyXHHoH+YbjV4GGcYdaiQ63YorJzWJRiVs767sTnAjRhfcN28qZthzSd7 Gkv9O/6EXPeEV0EJjFkMXS5qacpte6HMEUPKIGlTS83GLqjf+580VkXT0h+NV4jy2981 S0bvBf1vR9uXfUnNSGfwv5SOsslrCUuphIujFjlE5VUd3hzTk17u0Wy7ao+uK/C24MQ/ u+8A== X-Gm-Message-State: AO0yUKVXXgrOXel2sZu0ukqoE0k6qgyK0Z7faIAVhf3M0mskHdQJJr1o cGG7nzf7OnCPRAG6tYnkDEQ= X-Google-Smtp-Source: AK7set+kz4HpH3tFLp7lAmDe31VhB6UBIyJIhtaaej/n4SYoYLCUCr7qx6G3Ez/hSMcydh+woNDD4A== X-Received: by 2002:ac8:7f11:0:b0:3b9:c08f:219c with SMTP id f17-20020ac87f11000000b003b9c08f219cmr28331246qtk.29.1675635262393; Sun, 05 Feb 2023 14:14:22 -0800 (PST) Received: from localhost ([2600:1700:65a0:ab60:88e1:3b3a:d596:a5ab]) by smtp.gmail.com with ESMTPSA id h62-20020a37b741000000b007283b33bfbesm6167874qkf.121.2023.02.05.14.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 14:14:21 -0800 (PST) Date: Sun, 5 Feb 2023 14:14:20 -0800 From: Cong Wang To: Yafang Shao Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, tj@kernel.org, dennis@kernel.org, cl@linux.com, akpm@linux-foundation.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, vbabka@suse.cz, urezki@gmail.com, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next 7/7] bpf: hashtab memory usage Message-ID: References: <20230202014158.19616-1-laoar.shao@gmail.com> <20230202014158.19616-8-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202014158.19616-8-laoar.shao@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 43EB816000A X-Rspam-User: X-Stat-Signature: mne1py9qxa8ef5b4c6b8hwju9zui9pu1 X-HE-Tag: 1675635263-107636 X-HE-Meta: U2FsdGVkX1+OaoFEMdHcm38Ok5OOkQK2jzJ6cYy/lKPm3vvbhfabEehU7cuiCLDkwDlv520ifwM60pe11lVjc7EhdXzhhnwQKsdps40/SUPY9vL4OrLvpSG8lERWSyEzAIRCaM1qlb0l/K+R1c0204PhKXd9zuXMQol2iHIstYJe4MVOxsPnrZQKwUCFC5idLA2dNpEmV2sgWfYwpuDlQf7GzET5rLZxu4LE1MWgAvzXkDHEJW5ByMIwbLHXKrJhGGRdQi8DMFolP0iLfhEXusFHBt4fR6gcMuvt6JhNSs6rB+mEPsYqUtH+qt4iVR8rhMTyHgGnbJ5lQMNFwuOZTppQexEGXcbczkyWZZ/O5PIkQT5imGChQI9orJDnhKTuJVGtzrVsVP2IGmmz9KXN+5R3FUUr7PiUXY9KX2EOPwLrmps1FkVTc1s0ctZ60TlvG9D4K1znRr6vATIiHD4ZENLpWJeKIxJtJ4mcfZhKGOCal9RZoO+cyfj8VLu+kqmElbGTF14R+TkjhOMd2lVFvCS1toN85TSnwzVneSivHJ3EoLnlEWTMUB4eyhu1F5creOYOjUjLQQWOLN6csb2cmeIbPbUjNiaWKccdp14SeAQsGIV9MTrDkBmZ14jlC/SN6PMBmCes/aDE6yUyKOn6SF+Yl17SV1bb9x5EBV7er7w6hevUSU5tFAWgURp7uBkWiN24PJcJIZtjCBukxWCvt6tBL/gBE4hFG5Bx6jbvHM/YY4KcQsTYwnbCun9BN/z/41FZ6oiZFhL8BiFLyFPJHDnRRzyzTJEeBMyRYW8W1JXIeqTEg3TAIBpS+77+y5zUyq6oN/8yRtZ7SVZbFCunSUdbjr1oCN2H2LtdLCfM3Vxx0liP3t5jeiGSNRGkwfIv/TAZ1V3Jokvu42JfERlaxcO/Au2bJPI3R+YJ29JpEu7aLHbt7//vKgA7ZuRTpmm4lBAUigtR4zSl1KCcPmu dQcHUcr7 3nJuOtMMdGzgtMzKg8SivOO9G0xQQwQw96OJEaHaolcykakk11T/16qlE8hmctUeTEKp+9U4LFUqHcwXKDhHZjHPcHHfkb7PaHRS4YKgZJ37PgOuShEGSpiJAg5K7YFB9QXLBA+Wv7V5kHmxjQKRMHUg9bqXbqHPmOo0b3lHbxuxZHGe3WdpCq066Ekd9IQjBoTCN1+kTN6tjXwaS1M9h5TyfkD9rkLkVo0T7Ahp+RCCZf1cT8RUYebG1NDPo8XPIxQ8Qw42YR6Vs7QeqFgLjAaCCzwSXdP+yj0V06oFK2VAJ3I218eWTXQtAhbmCpZF+cthB3j6HxxW1+4CYbrtlnJ1OIkXUlfxOX8B4eOXNrkX+15qGtmDBmcHQbheUCIZkRs1Owhd9AjqMyxejXA1NCFeEV7fsXn91cgnOCtPyExuSUpVXvhShFBE9/uioi1JpAivxrotd6ROOtvdct42LIewIz7+i/R5RGdR/+BoynxAB7rO3ogV62XwpS1dIaT65ePDq5tNPdVIPRAc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 01:41:58AM +0000, Yafang Shao wrote: > Get htab memory usage from the htab pointers we have allocated. Some > small pointers are ignored as their size are quite small compared with > the total size. > > The result as follows, > - before this change > 1: hash name count_map flags 0x0 <<<< prealloc > key 16B value 24B max_entries 1048576 memlock 41943040B > 2: hash name count_map flags 0x1 <<<< non prealloc, fully set > key 16B value 24B max_entries 1048576 memlock 41943040B > 3: hash name count_map flags 0x1 <<<< non prealloc, non set > key 16B value 24B max_entries 1048576 memlock 41943040B > > The memlock is always a fixed number whatever it is preallocated or > not, and whatever the allocated elements number is. > > - after this change > 1: hash name count_map flags 0x0 <<<< prealloc > key 16B value 24B max_entries 1048576 memlock 109064464B > 2: hash name count_map flags 0x1 <<<< non prealloc, fully set > key 16B value 24B max_entries 1048576 memlock 117464320B > 3: hash name count_map flags 0x1 <<<< non prealloc, non set > key 16B value 24B max_entries 1048576 memlock 16797952B > > The memlock now is hashtab actually allocated. > > At worst, the difference can be 10x, for example, > - before this change > 4: hash name count_map flags 0x0 > key 4B value 4B max_entries 1048576 memlock 8388608B > > - after this change > 4: hash name count_map flags 0x0 > key 4B value 4B max_entries 1048576 memlock 83898640B > > Signed-off-by: Yafang Shao > --- > kernel/bpf/hashtab.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++- What about other maps like regular array map? Thanks.