From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED8AC05027 for ; Fri, 17 Feb 2023 12:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 486956B0072; Fri, 17 Feb 2023 07:11:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4367C6B0073; Fri, 17 Feb 2023 07:11:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7106B0074; Fri, 17 Feb 2023 07:11:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 19E9E6B0072 for ; Fri, 17 Feb 2023 07:11:16 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DE9AB12029A for ; Fri, 17 Feb 2023 12:11:15 +0000 (UTC) X-FDA: 80476668510.30.7BBEFE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id F27EE160009 for ; Fri, 17 Feb 2023 12:11:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="P/H8PRGz"; spf=pass (imf08.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676635873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MYiaBSjEl56ySuDVwZK8XF9Z2JRTm2SiNTi4k9/d4dY=; b=z6Wd0EFaBysq7HsQDBUg8rTwdRfCbs3gbhLRT6Eh361RpUvSS7yImE5qSMijG7/Q0yylbB 2QDBeWudGbkl7GuAYLu9rVpfJJqWPTEoitmPZMuFtvumm1Vb1AkykHSFtqDJVrkH5kqoG2 uVA3ZD1katIcfMlrIz7h6P0xD9i/V30= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="P/H8PRGz"; spf=pass (imf08.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676635873; a=rsa-sha256; cv=none; b=UnoeIBgvPUOHL7+3Wv1cyeKO1vFT+l5tmN6hVfOx0+DBFmqXtQHIiwsMjeA4QfVS920SSx O7ssUusl7ltQPVsL2DJBcTGjPYSpTjKEGPGaoAzfVdKjTXxQE2lYeZrHW7VMAHfC9o1eho i7kV+mADw0t4HAq1OFSad17cRIUoAo4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676635872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MYiaBSjEl56ySuDVwZK8XF9Z2JRTm2SiNTi4k9/d4dY=; b=P/H8PRGzVf4B3j2opdwnfasGb+ot0an5UbY2nZkiX1Bn4Zr6I3ujCLZtqN3wAZrHVTPYM+ gcUou0fUD6Epg+rVJOhUFreUfSAwH7XZLWHOam/HI8+TLD7/z81tgFIU45IvI1F2bCbPST 95CperTVCBqKR+jeRpDq2xbBkQmr+TA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-5OWtxEMRM3qXVeLMOZTBhQ-1; Fri, 17 Feb 2023 07:11:07 -0500 X-MC-Unique: 5OWtxEMRM3qXVeLMOZTBhQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 523733C0E46D; Fri, 17 Feb 2023 12:11:06 +0000 (UTC) Received: from localhost (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95D432026D4B; Fri, 17 Feb 2023 12:11:04 +0000 (UTC) Date: Fri, 17 Feb 2023 20:11:00 +0800 From: Baoquan He To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Christophe Leroy , Christoph Hellwig , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , David Laight , Stafford Horne , Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v4 01/16] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-2-bhe@redhat.com> <056cc71f-7fb9-4d38-a442-a05de6f7d437@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Queue-Id: F27EE160009 X-Stat-Signature: xgh9q3bjbst4bkziucj6dc4jbt7mgajt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676635872-888244 X-HE-Meta: U2FsdGVkX18cujBMMrWL5BuYknMvWAS4v9yrX9HQOV5k2yPeGAoLMYrf2ybUEvhlCITiZL1EGUxFLLUMyNcbBfdu89AtGURh1mFTuyOjNqMidYAY2i5NzXvr5cGxWgezNQQ8FFEx2wAcQJfMom38P5YW3Q2AppsMj8zlCUW9Zc3APdSDGjToWZkh+HvCXAjg/fPTxnQQ44u5ETEZx2g7dBqLmuZH23lKA9B5h1kRgn1awmE+uURMS6Xp1yT2HmtWuI7ZsTfx7KXDkB83gr8Yyflgw9EWvCWIt0KSik3wYann0mtzDg1KUdtAgR6/QKKhijXyAVF8SRZxqeYp6LQ/Btu2JPHswdKSbnUztmJ/kpX7S56rdC8HxmsPB2jvlk7UJUzYII+G/qrXzzuyo3mlUEfpoEbS1pqrAkHOqdHDJNK5gGFOeUuiMBMmcZrUt56oltct9iFanVeb0WIMutlR9xIO3XKO4M4NZ/3CtDiPRe/wcaI9uNECN6kWwwTaUSI8BdXJNhR21ktM+g3iO8qQ+D8iGKKGoxBXO3dH/bH+lFOyWdT/JaVsM9rC/a6/wecL7WAwDg4Hm60CY+SlmjvT0Wd1go/ii6Wrp1JZ17aXZBL50ow5aoYJ9L107n71m5NBB+Z1ydtEqf9RxcoZilYO+JCFLD8+bYP1NZB/LeeWzntt+yf5dPpfN3LI/+rXFTcSimVmGEwDrYI2g6AMBiMRRc3rY9PnIYJavy48HIV6CgrODJj4XH+nvYMWrpGF80FVUem9thcrAG4WCtWxeE7oxTNlDOx+iBrmf2q/HBX1d5d2J6tf72xs2Pprv5Sir+KlgcKSSkY48JvLWjpzzeDMXlmz2S34VesepihJsmu1/BDgKF3SvZwH70amKqDySacOlIh80uZUmJVHQts0FrG6V1XP+O33LNx9tg7bI3jA3epqeV9ZFohAtbnfkl6rjE72QQZhj9mbdqeAq+wiDwF u1n6FNny 5hsslY5yfG4oRwpzyyHeQ5LdKBxzs89t2n1g6H9pPghZ5JvVrMd0d+AY75uysj/Aq33yGyHDivzeimv5IFb0WPMFpCdyBfoV8OnGDzoCDFjr1GGfJNTK3BA9dEGtKsf3JBpgaPA8Dpuls92KXCWOcrFgPz1o+/e4+I82x9eXbP54TWKzTNE8aUGyKurR96+O/LKlukt4lmqgf2t+aUNN5MEy6gmB3OBYcCjtB9RtaicWTS1O09mC118tSP/ryhy94FvJoDoLYIGfCRz3afWzLU/XNPR9x9u9tzsZOQjVqxAW+HT5CxwpKpdK4eIp7IJtRgGnsG/SqMX2AKxPDtn3/mZd/XJqnmdKrdT9qsxeLZ3NYyFYRpp5NsqPmDpmC+09cVFi+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/16/23 at 03:51pm, Arnd Bergmann wrote: > On Thu, Feb 16, 2023, at 15:47, Baoquan He wrote: > > On 02/16/23 at 01:53pm, Arnd Bergmann wrote: > >> On Thu, Feb 16, 2023, at 13:34, Baoquan He wrote: > >> I see that there are only two callers of {devm_,}ioremap_uc() left in the > >> tree, so maybe we can even take that final step and remove it from > >> the interface. Maybe we can revisit [1] as part of this series. > > > > I see now. Christoph Hellwig ever mentioned in v2 reviewing, I > > didn't get why. Thanks for the details. > > https://lore.kernel.org/all/YwHX98KBEnZw9t6e@infradead.org/T/#u > > > > I am not sure if it's OK to do the change in this patchset, maybe > > another patch? > > Yes, a separate patch would be ideal. If you do the same change in > more than one architecture (other than ia64 and x86), you can combine > those into one patch. I am making a patch to achieve this. There's trouble in mips since it hasn't had in , and adding that will cuase build error. I will post the patch for reviewing.