From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4FEC636CC for ; Thu, 16 Feb 2023 20:26:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C6386B0073; Thu, 16 Feb 2023 15:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54F116B0074; Thu, 16 Feb 2023 15:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9B46B0075; Thu, 16 Feb 2023 15:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 26A456B0073 for ; Thu, 16 Feb 2023 15:26:35 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 03890160153 for ; Thu, 16 Feb 2023 20:26:34 +0000 (UTC) X-FDA: 80474287950.27.FF35860 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A35FD40016 for ; Thu, 16 Feb 2023 20:26:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=chJfNxZ+; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676579193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1oecOc+hiRofVEjCM7aQ0Wlwl5gfnG62Egd7W9YjTsU=; b=Nccl7lx/qdMIdWIKgvEEGRP9pnygHVNFnL7rmHFSzq1Jc2RWfbbfiyLzv66OcrqMvpk/pd wCvy6HJui50Jd6pLEFt/XVe8RVFsW+iYgrhz6CCSyqkwrCGR2uPs1FTX8BppHGMBiKaE5p xz0OWJIKK8qIbJmSSaxdfw7I1Sqe7gg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=chJfNxZ+; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676579193; a=rsa-sha256; cv=none; b=GlOUs1YqOhqGpUOvVn8sJ3gCB8fo1sq//J3YRuF2O6YlRssClMpxcoXuy4tSf9AHRmYww5 ECAvxdWn/uhQRVmVKMz5QNIpR72YAY3NtN8j5vqkRNBYnvf996HQ2BSMNxy3Y/D5PKV36z 5CIJztiPTCLC5e3DN5ZvRzXqzIUw0Es= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676579192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1oecOc+hiRofVEjCM7aQ0Wlwl5gfnG62Egd7W9YjTsU=; b=chJfNxZ+68Tlk1/yaHduFb6f0fps48yHTz3gURgcIO0QDAZTcLtanI2f9bMba9Lm3DgFFi UT57l6FXVxT6+q9gphkBB/iLj4EQW1aPq0AG7+InvCvAl+8p3qT+e3Rv3FMh5NsTF2cY5N 9CLb0f5RGzzDmkcl+wwEoSUNQRuEmZc= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-626-TaAK9j3TNc-qfeLAh8lRNw-1; Thu, 16 Feb 2023 15:26:30 -0500 X-MC-Unique: TaAK9j3TNc-qfeLAh8lRNw-1 Received: by mail-qk1-f199.google.com with SMTP id a6-20020a05620a102600b00729952b4c73so1891821qkk.6 for ; Thu, 16 Feb 2023 12:26:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676579190; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1oecOc+hiRofVEjCM7aQ0Wlwl5gfnG62Egd7W9YjTsU=; b=DeyQXzGlio34epkQLhA2Tf51I6sSZKVCbKGf/QlaGxkZjuqKAJRrAMXztbvKwDnzEw LwwnsjEyS3Sn+bzCccaMXVlJ38y02hovwFZuRUBnHSdIoNhoZNeM/6OjnBcZV6ApMmJP D9WoUqagOafrYMzq9BKlK5lDsYIvqVsALnF4Y/RPVcmbOkNGlxvTbtnBp4Srg46x5x9A 6HCpmRpEIBwDSZiVhnjsax5psDbqrPTkwGTSiJDIMRqelbljMeVxkT9vXJKiTFTLNYOe V4E+ESjjVzVFO16olau75nJgHyqtMqteI+7+zlLEnnyBrOB+4npurh35WcoS4+VT5KLE yF4Q== X-Gm-Message-State: AO0yUKUOfxDVWxNyrnj80XK+JWbWLq/YauSZt8HTQhIhsHAE7F/8ns+p TuVSaUnLKMLejMEXSI505vZMjxeoXPb41LAOstA/c/3B2pJNY0Et5rv2ykiGl2U98rjN4N16saG cmOLC9TSf1nc= X-Received: by 2002:a05:622a:19aa:b0:39c:da22:47b8 with SMTP id u42-20020a05622a19aa00b0039cda2247b8mr13465408qtc.1.1676579189936; Thu, 16 Feb 2023 12:26:29 -0800 (PST) X-Google-Smtp-Source: AK7set/Xjpm1YuVpFOgB7Vc7SzNUNmso7z9n0j2QOFUD0tMjJXptDDPTST7C89smgOnvOS8E8ZLz6w== X-Received: by 2002:a05:622a:19aa:b0:39c:da22:47b8 with SMTP id u42-20020a05622a19aa00b0039cda2247b8mr13465386qtc.1.1676579189605; Thu, 16 Feb 2023 12:26:29 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id f30-20020ac8015e000000b003bd0e7ff466sm1003888qtg.7.2023.02.16.12.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 12:26:28 -0800 (PST) Date: Thu, 16 Feb 2023 15:26:27 -0500 From: Peter Xu To: Muhammad Usama Anjum Cc: David Hildenbrand , Andrew Morton , kernel@collabora.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] mm/userfaultfd: add VM_WARN_ONCE() Message-ID: References: <20230216091656.2045471-1-usama.anjum@collabora.com> <20230216091656.2045471-2-usama.anjum@collabora.com> <4d29a9ec-027d-06b9-8543-87d386e58c94@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A35FD40016 X-Stat-Signature: pz3dayb7hiwofkkomoycj1y1gwpfzrkh X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676579192-965461 X-HE-Meta: U2FsdGVkX1+Hgo0SAk6jZq3jSJlyVEibLmLJlyOWuFnStrEYYRU2otKf2lCU88z4bVkKkwQqIqACPcyJNGcZGNLsrVPK6zf2A9Hcp/CHW1jrNsLIwRPjHLoCHKPktpognBWdJrFu9f12D+nq/ZaReODHNkNVS0VtKgw5ylY8MYB2qmFzKiL3CHaYB9eGirY49+hf1R0+YGDEBqoMKBzHCXlKhRpkHp82pabLuxT+xlIIJ6TOMu3qh+5qkltUTTNFTUaCTcBB6lq0gUxaij1RtTJ215ZfNZ7uYaauHKORtKoIq7Rkp+B4tyFnDH/zvTTLoSxHo5uZtUKLsIBi7fofSUx3N0jWIDoQQ2bGl5NN/zfC60StVW5HBC65au1L5bpeChC4rEmmkUYbo1YJzLyL70IRLO+FD7yHSAno/nW9hj2vonHjIVH676cXvgOgzub8Jd+lzrOp9qeT8jDdrU8I9VFm/+zvENEg9HA8cK2IgrZrbBzv3aOWX6bsCFq38HEVblVea7DzVb1RQpVBBxTYdnff4dcoHDkLg7yOAZ8PhMIx2pOASEJybAPf0tAsLfDC/dD9AIfa2P/ODbJ/gWm3VIVgU8rMlOPiRYAcF/ZOk2c54yfDIBfCKC+ZncWwEbfa4fgriIu3TOycHMTE+PK2F03OQkXdPsWQzvKp9cmcHBXFHCr5Ud0jtGHkmKRDqqoadRuymB3nsnEkI+H+ZUXUx/QVOWZgrsZCqHp9G/ujpPjipmM6CZH64ioHMPNdPBGuhlZ3Q/ztiGhGnlsoK+BHNX+6UW09lWuolZO77TCSIE7dm6Hov2NxThXa0IT97vkAG9aLUHSEdqlSBmC2g/gqRKAdPAll1iWpX6u1TRz5kM4dDXlFwaY3b0KWzoUHoyzru/JlyvbITm7Vz31/bhZqo9PEHBDHVFkAlj7CTwfFfekS0DUkERH6xQ/sknnBMUvh30QKX0yVVXDb4SIT7PZ aWfkgsyZ Ve6QbcgBtSYIuWbC7CJP5xtKdHDOOWDqcuYYbC8RHj94b3j3pHXSK/hFlOmDlymipBYpoT0ZfzwNgRY4jHVgAm5XbBWL8FQ3PDmdsSV5IJ6p82tZLHbGsdSwcdbE8EfzfSVtMVej+xD72M4vc0ApM52NQZsUCsRgl/dklX6OsxBv1pUIZRXQG5+vUYbbXZ4USZPECuSj/Wo1hCQ4XPdDTYqBgLO2WjZ/4jKII96d5hoctakwZVsTEIjyYJzJctkpvixuctQcOmGgMLDKS0MnGqgD9+6vuW83xwePlDbcXM0HFPMI3LS6UR9xvjPCXjZBBVmTuQwNacPlwiuRoDcd2l+fLgl10fnZv1NIwSKIQLvHzDAihlDTrQQ3POxbDpB9N1ZywNJvO3bvFfMNgcPV9utiX+3yDVn8oFGh5ZjsHjKma1OYockmapbLZxLgy4apa8GzpRfgshQoeLYicuKVlgJlFtlzyWjFO/HMaQ9ove9Isgq8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 16, 2023 at 02:48:51PM +0500, Muhammad Usama Anjum wrote: > On 2/16/23 2:24 PM, David Hildenbrand wrote: > > On 16.02.23 10:16, Muhammad Usama Anjum wrote: > >> Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse. > >> > >> Signed-off-by: Muhammad Usama Anjum > >> --- > >>   mm/userfaultfd.c | 2 ++ > >>   1 file changed, 2 insertions(+) > >> > >> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > >> index 77c5839e591c..d89ed44d2668 100644 > >> --- a/mm/userfaultfd.c > >> +++ b/mm/userfaultfd.c > >> @@ -717,6 +717,8 @@ long uffd_wp_range(struct mm_struct *dst_mm, struct > >> vm_area_struct *dst_vma, > >>       struct mmu_gather tlb; > >>       long ret; > >>   +    VM_WARN_ONCE(start < dst_vma->vm_start || start + len > > >> dst_vma->vm_end, > >> +             "The address range exceeds VMA boundary.\n"); > > > > VM_WARN_ON_ONCE is sufficient (sorry for spelling out the wrong variant > > earlier). > Will do in the next version. Thanks. Shall we just squash the two patches? -- Peter Xu