From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00302C636CC for ; Thu, 16 Feb 2023 19:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7587F6B0071; Thu, 16 Feb 2023 14:18:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 708836B0072; Thu, 16 Feb 2023 14:18:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A9916B0073; Thu, 16 Feb 2023 14:18:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 482756B0071 for ; Thu, 16 Feb 2023 14:18:48 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 215111C5AE9 for ; Thu, 16 Feb 2023 19:18:48 +0000 (UTC) X-FDA: 80474117136.20.96846CC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id DDE2D1C000F for ; Thu, 16 Feb 2023 19:18:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gnn+mw4f; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676575126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vq/8D3nKqtw1WIOPbD3NZdoxax4+1C1opON75SAH+KA=; b=Np6lVzPu0+d8MusY/MEKLUFQ6dgllIGW9Sf/POjKxfahA9rUoLLtPREgCrNEqha78qk5SH I+Uzeyt5hTE9BhWUtB3eqWTLbqKefuyhkTeh14m0tcXdQJNCvlIWG0WQXeNKhQ0s1LVoG2 2jFDiGyG2i5SmjMf2jhuUGptklLKsJk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gnn+mw4f; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676575126; a=rsa-sha256; cv=none; b=c1w2HzEo/U+TK2WvkSQDNwwZuUEKa33lQxSlfHlDViz3CwSlE7mAI6sfI0CkgmfZe1a3Sg 3P52qAqXYkbjyDi9Wh9UPLnPFPx2Z7nReukMy4BfPdj2ufSs3l69cG6Z34Z0OuriVJP7H9 Y3eGGCCNJxpimRRd9H8jiseAh1iEtro= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676575125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vq/8D3nKqtw1WIOPbD3NZdoxax4+1C1opON75SAH+KA=; b=gnn+mw4fAVZP34XSIwtPEMYOMav5ZfFIMkgj6H/cwxDsH3hMbNLAnkCcsYOpC5moQ+C8HB dguudob2Dt9msIDhxl9a1fh+vNqabMj7AZPedmnqPUUeFbWgIUBRAnRjA8YypCFhJdVQ4H AU0Zr21XS86d02yV2BTFYqThqxwCvg0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-342-MKQlBiOhPfqR3gGEWhQFHg-1; Thu, 16 Feb 2023 14:18:44 -0500 X-MC-Unique: MKQlBiOhPfqR3gGEWhQFHg-1 Received: by mail-qk1-f200.google.com with SMTP id ay10-20020a05620a178a00b0072db6346c39so1796136qkb.16 for ; Thu, 16 Feb 2023 11:18:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676575123; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vq/8D3nKqtw1WIOPbD3NZdoxax4+1C1opON75SAH+KA=; b=hsWrLlfoepB4wQ5Fc6FXbN5DNuI4hi2ezZJykVyP5sJzqXuiq46Hbbivy5mfHtEBn5 ISjgmnpm+QmPgefWNueMp/TCYRWKIAIAjBWXd0bLddupMmfpREgvmIIvJk49v70kPPqn EZsKH69Fu9SmB0l4h6Su4pdsHe7iYYY3zeHAFp0mvVZT6k7vuwpJ9GrBlHRoKaVtjcHF q61gi/wDRB2rKRZjZ8gsYRpSw/LHJlZHUoqLsGORuRuZ9GlB6mJ9+b+SHcZOFWnVAPPj CqisDQxzbzeqefhv+62G64fSo16PU6yigVQSineHQlgRSOhWeqyu0wRyh3xyLQRRJo5J NwqA== X-Gm-Message-State: AO0yUKWV0Zcg64HPibejkGm3SY1J+lSx2xDzyuJPrBN4fBzgROj7S2lJ r3KKhZ1+HtF0qeTmjIxfYrtKuIPb8Ip2lDnRXnu/rppSufqrfwPo++kxKaLnlopy2licjow+PL2 BGdnTiDySjaA= X-Received: by 2002:a05:622a:1c1:b0:3b8:4951:57bb with SMTP id t1-20020a05622a01c100b003b8495157bbmr13365169qtw.5.1676575123585; Thu, 16 Feb 2023 11:18:43 -0800 (PST) X-Google-Smtp-Source: AK7set94r9QdJOHGjbfUETh7ovLgpkDfMBET1BqCT/UpQvalJnj5Q431hrj7SLkgGPpOCMlAFoI5Jw== X-Received: by 2002:a05:622a:1c1:b0:3b8:4951:57bb with SMTP id t1-20020a05622a01c100b003b8495157bbmr13365134qtw.5.1676575123243; Thu, 16 Feb 2023 11:18:43 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id m9-20020a05622a054900b003a530a32f67sm360565qtx.65.2023.02.16.11.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 11:18:42 -0800 (PST) Date: Thu, 16 Feb 2023 14:18:41 -0500 From: Peter Xu To: Linux regressions mailing list Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Nick Bowler Subject: Re: [PATCH] mm/migrate: Fix wrongly apply write bit after mkdirty on sparc64 Message-ID: References: <20230216153059.256739-1-peterx@redhat.com> <611c1202-1978-8886-eec3-929933ee75cd@leemhuis.info> MIME-Version: 1.0 In-Reply-To: <611c1202-1978-8886-eec3-929933ee75cd@leemhuis.info> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DDE2D1C000F X-Stat-Signature: iahkqc54a74hqou5ujk7cryqa6kkuibq X-HE-Tag: 1676575125-290635 X-HE-Meta: U2FsdGVkX18ltcSSLJ3jSwq1Vpanpbue2JWg9lXWrmKWmzh0n/mY8ZDqasZqj+fh8GmMttdp33j6HA78o8MJQkxsnT67vmQvu7Pk7tOuULzsSIDu/l/GUI9DYbXdz7r1FspaihqLu/M8o55ddRv3Msz/hrovmL7jTLiDxcSpvPiVY+TCgwZ0WmbhBY5UyjtQwc5X5+7WniEmBl1dXGk7q1hnCWF+ODTuKpoPGUxlddMDW1eRqcjJZaLMdWXtMRJsOsXLBXrcuQDnXjUkmjpdtcgLFvLnaWJMb9S49jtcCnwbdu0MNp7K52ZBQkWcYj9Tn4fMZjvsbSLNCqxdZQjcJDcqbyHhZJHFbNLhvxhv0Y3a03s9iV3QRIgCq5/G0fmiacS9/mv5gI+GGHt3mpOHduxRO/8x+21jv2D5vs6xuRIJyCL0yLkU5CbUtLbTyHAhuQPI5mCyxh7Afy+xq5U0Y/FCxlb7o+/xRbO3RdDUurk2OwcY10mpnSlKXRK02VXd7+MBFmKRwbDw/ioKxQx+eRCBkww6Ces1v7tpCiQjeljAq1ZUs/X/piKLSNNp7NED0B7OcgmVudEbUUtC3/B/Q7UnhdhpOUvAvgNZ6BOY5TMVa1SCeQvY7kwjofx34xakuIVOtOhqpAK2iJ6gxK69BbBHmCal3T4JnNtEV6VvwmEK/AuPhTRe6o0iTo7UItRk7Hw02oFAWCY11pumEL37bVVf7dRjY8/IAivUedaeyqliL7t2xlvBxfsmcWiD+LCpSOEJ33S4UsIBWhYuGxXN/tYz5x+26dkwko/cdeCf8wCKWc5mfjspdYE2zWscl2A0AvRR4DZ8Wr8jrYky439Pa5vnyBBhgu2n9zfFhGlcngcFBC3PM7X/1KYFKYcnOCflIVFQGDizn+dtYUrifSkW90+2NxfQXAgiv5Ca6eu/kIV8RjLs7p+PB/FjQiLbBOY2V8xbSv6L5ak6qcdiw25 Bwq7Qllm TEzDeK4Q+mAgQmWL/+GrN57+yAr2eqsik0hTP/Wds3+70P6KwtCYK3iVTuFVcGAoymkChsXS9OEoQcyURav0gJJEwCmoC1m5J8wJS/D27V0O3UASZLCaK1HMXjsMcPHmCe1cH/sOt+d/8zCHgY+B3EfEo6CcAFw3e5dFi45rTxSS8lS9R5TfhksjurnPelT8c/vOnw+wJhmIUOrE+gg9A1UGQ2FsmnfmXsEQOSAmz1Om9nlHVzDt4eoi1e5tpzgIxcoIOhMCgj4LxqTDdZl3sJlQCRMC97pIoB6IppQilggvNLGv78SUz3SlzGzL2+0edtOWDAQIxFmoEDh/nm5LTeaAjko+x3YKJ6DwcD1hw+vGBZTcjRzJprr5AVuiMPuNr7W83e+l+NXQ3w55vBbku2ZngX4vCx/hy8ZHcnOdhuDm2mGGctNPtOKqPy1x2sbAm3/6oCVDqEEu7RzMB9qaX7Fa+rvpQN7Fd1A9SgwuVfTIZen0EAB48sz2NwExq/yAZliTjQqN08NSTPprtuwv9ioe0+EQk6CQQwYb4jCzRBjPrfulGkpFMt73WnHW876dgXY3B7OaSW0ddEcGxX88MpuP49HrWVQKFisVMBaq6RV+D0tgOte+2gJbXMaO6N1RGjV+CeN6vmcjdUwci7LIBJfq+k32d7Em5j5wIL6u6VGfrd3LmU/aBba5vtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 16, 2023 at 05:59:16PM +0100, Linux regression tracking (Thorsten Leemhuis) wrote: > On 16.02.23 16:30, Peter Xu wrote: > > Nick Bowler reported another sparc64 breakage after the young/dirty > > persistent work for page migration (per "Link:" below). That's after a > > similar report [2]. > > Thx for handling this. > > > [...] > > > > Note: this is based on mm-unstable, because the breakage was since 6.1 and > > we're at a very late stage of 6.2 (-rc8), so I assume for this specific > > case we should target this at 6.3. > > > > [1] https://lore.kernel.org/all/20221021160603.GA23307@u164.east.ru/ > > [2] https://lore.kernel.org/all/20221212130213.136267-1-david@redhat.com/ > > > > Cc: regressions@leemhuis.info > > Not that it matters much, but feel free to use this instead: > > CC: regressions@lists.linux.dev > > Then things don't depend on me (in case I ever get help with my cat > herding job). And it also make it even more obvious that this patch > fixes a regression to anyone who handles it downstream. Sure. > > > Fixes: 2e3468778dbe ("mm: remember young/dirty bit for page migrations") > > That's a commit from 6.1, hence this should likely have: > > Cc: stable@vger.kernel.org # 6.1.y > > [no, a fixes tag alone does not suffice, see docs] Oops, I just forgot that. We definitely need to cc:stable. I'll make sure it's there if there's a new version, or I hope Andrew could help to attach otherwise. Thanks, -- Peter Xu