From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68093C636CC for ; Thu, 16 Feb 2023 15:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14816B0071; Thu, 16 Feb 2023 10:02:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C4E46B0072; Thu, 16 Feb 2023 10:02:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88D6D6B007B; Thu, 16 Feb 2023 10:02:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7B8016B0071 for ; Thu, 16 Feb 2023 10:02:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 420A0C019B for ; Thu, 16 Feb 2023 15:02:28 +0000 (UTC) X-FDA: 80473471176.09.AF0331C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 058F68007F for ; Thu, 16 Feb 2023 15:02:25 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNuoj+o4; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676559746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pa9Fy5Ubq9jmjLtkh5hpgt9BGts1NKer0SZauUxszzs=; b=G5q37rpibFnATBa+pOGoTcVXZftkWMVVxxaUU01yEFW0ZqSlBdgB9tnvTeMO/BQs5gR+LZ xekYcnelOYs5TbQGcNXKgJSI7fQkX4vA0IS6p4VVSktUdE67isU+eEnPjacJxWaZnh0SZH 6P6BCfUvKGxBHdN4W/FOpn85/WRAXlY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNuoj+o4; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676559746; a=rsa-sha256; cv=none; b=d2W/3kj5Ap+Sb0UBSsv7lmbfi0kMVNLBsL8jNxRlc2k8yIPVqvj04ZC7AOysrHbbhzQmGj cdguRCgC4X5vqYmWP0Hl2qF0MJQ07SLR/AMNiHSEOb/MClRCfGNJpv/PJUngTQ6aNgzeqQ CyjW6Z7BUOE3JF7aWHSu1xcYBpWThxc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676559745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pa9Fy5Ubq9jmjLtkh5hpgt9BGts1NKer0SZauUxszzs=; b=MNuoj+o4XpuuN6g0uI9jXglGdMW9ULlhIFSG9pHtsIzsTwgTln6lYURlWX/1Yf3JXpsOY4 NmgNBCSFz4X+6IheU4z8R/TgU0DWzJV/zIKb6VEuZb0N/xC5yYeDk+76GpNLWI2CnnGnC/ rDawwtvkF0jK9apBITKwPvYUcE20rEI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-2YzRB7XnMcGoT6pRyxinQg-1; Thu, 16 Feb 2023 10:02:17 -0500 X-MC-Unique: 2YzRB7XnMcGoT6pRyxinQg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 43635857A88; Thu, 16 Feb 2023 15:02:14 +0000 (UTC) Received: from localhost (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 746FD1121314; Thu, 16 Feb 2023 15:02:13 +0000 (UTC) Date: Thu, 16 Feb 2023 23:02:09 +0800 From: Baoquan He To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, arnd@arndb.de, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-13-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Stat-Signature: h6suir89x7f5r4tozdap6adqnm4ey4sp X-Rspam-User: X-Rspamd-Queue-Id: 058F68007F X-Rspamd-Server: rspam06 X-HE-Tag: 1676559745-13155 X-HE-Meta: U2FsdGVkX1/ofsKCzPZjl1vIu+WGIWZtTTw2CBizMjMt0IQJCVHp0Xj0gfNJMtEOccX0vryw7lG5+PwoxtaJcsKwMsH9GnvNAbPPZyuwD5suC+cLdvxi12kqQz/t/JO+uDN7wkxjeeouGsMoizefl99pFcjRYzhT+OQVN1R4pgnoav/uLolBY8dHG4ZfIu0JO49fOhv7f74wIbADM1nE3ItO9t4H3bzzBYFPSMCK92u/KpXoIQWfnbfiXN2hYaZmj2KOYHCHhOl7KiBFIiqPewNL7pxpS/6y6QRcYC3CvOf5dlDkd3fopCx2lTNPzliqGgvOUwnowXB1yaLTVpLorSQFIs2Dhypa6ZrsF2ZWAFLHoJOwG5vGidma1FQdVYfV95xVIStgKS7/7x10OW58DprJxzPzzAPQ+RAUCfdAzqxmXgJqAmLIUcEMHj/eHF2kqGDpMzhuYY7bBh7TshUEN+UzLn28bbJjOOBXDqPxZ+zASQswt+ArqL0yT90eMwxgtnTWvwZRDGOxrTSvf0qcaGycuqfqHNGcXk4mB/p6o95OF2OA9dEjQlxOWg04+SFPa3s+JV9Fv1B37iyp30ezXXxQoZbhTX6sD9OpZwk8Seww+RgdA3nUOD1Mk7nXwN15iTxMAObTLDxm2QloJN5fdzMqwMgXkan83bxYmeF0S+2z43azVYHalgHAVPQaqyRsHX1+XlQXCJAaRs7lHotxyBqUJlJ0E6nUwZL/qx+BauJaXQOeNk9R15Kzvk/+Tj0gwCOSSEqO8WSlkn7+UGumP7URoLwbdNLolgWX423BhjCpA+snFfxDSebj+VSr+yc1+mLlAAhbieOoNp1ymYMIRddqGEdQQkY6S2PCsMl7siSVRm53sQgallSz3H0fQLAE4+cJPOfrxCW6ZpTA5KQtsmWt8WQxJ7Bnuk/sFBWVzNe39tv6A72IhbpwOpYicRDHAROhncjlyvsvCOLB+Ck Tiz27DIO KfeB1thEhaH2UrmRXYBmXFr1WcFkptlylfYBMxoY9V5j+hx0J23Ith+c+SVRXFbPQ2o+a3aObprm3h2xfaUArQ/zhs9YRB3lIh65khRhmPJG9PKIIw+7EiRiQdBu1IR7GGWaGZMwEtyyr6AaD63tk/F5N5u9H1688gMjFm672qBDh3XJ1C/xtOqdS4ei8oFI/VpqeD9t6FquTsvLsb7QLRoUWzu7ReMdM01XEzSwiV2NxbYtPaRsngmoyz8qe61saMBHZXDG4WQQ4W0E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/16/23 at 01:50pm, Matthew Wilcox wrote: > On Thu, Feb 16, 2023 at 08:34:15PM +0800, Baoquan He wrote: > > Meanwhile, add macro ARCH_HAS_IOREMAP_WC since the added ioremap_wc() > > will conflict with the one in include/asm-generic/iomap.h, then an > > compiling error is seen: > Thanks for reviewing. > Huh? ARCH_HAS_IOREMAP_WC comes up nowhere else in this patchset, and > the current definition of ioremap_wc() is guarded by an ifndef ioremap_wc Because another patch of powerpc has got ARCH_HAS_IOREMAP_WC in the existed code. > > > +#define ioremap_wc(addr, size) \ > > + ioremap_prot((addr), (size), _PAGE_IOREMAP) > > This should be enough all by itself. It's not if including asm-generic/iomap.h. The ARCH_HAS_IOREMAP_xx is to avoid redefinition there. include/asm-generic/iomap.h: ---- #ifndef ARCH_HAS_IOREMAP_WC #define ioremap_wc ioremap #endif >