From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AE6C636CC for ; Thu, 16 Feb 2023 14:47:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5647B280001; Thu, 16 Feb 2023 09:47:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 514AC6B007B; Thu, 16 Feb 2023 09:47:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DBFE280001; Thu, 16 Feb 2023 09:47:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A4AF6B0078 for ; Thu, 16 Feb 2023 09:47:40 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0391F1401EB for ; Thu, 16 Feb 2023 14:47:39 +0000 (UTC) X-FDA: 80473433880.13.901E5DD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id F2A941C0012 for ; Thu, 16 Feb 2023 14:47:37 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z5GhV3ds; spf=pass (imf20.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676558858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QFaX4cxZUJf+Ng89cRL/nlepV5PVhHHLPICLCsLRqZ4=; b=orA1Rntk7+3S2DTVsfcYUX20Fc4tH6hbh9TKwduinLA7SDwlTJDBL1pXdqtFY79WCwZIUK DAFuvpM6Ddz5a9OvIU655RQo2pWRm+fvayVwX4xxzTOmFkHMdpjwcfSYlqdA/Atb4DzRS1 pn0iaROPhgaaL6VXbV17Q3EuIeel9hE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z5GhV3ds; spf=pass (imf20.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676558858; a=rsa-sha256; cv=none; b=Gogrqo0Kc6CHsYa50d1ZvKwEeibET8aC2lACcne/D5qGoiNocYVvs4E33veKqzBLs1QZue VsPMUMDFw3mWsFi87mYxcRnv7dYujFRX8V4lwc+kiBpKuQoBPNdIolFeSWtSY1JBd+bPlq Dt6k6/wPFQXZgT7J7fStogLCq7iGhRU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676558857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QFaX4cxZUJf+Ng89cRL/nlepV5PVhHHLPICLCsLRqZ4=; b=Z5GhV3dsQbv6Od4Puaqc6GGqb8MEGwy0Ydhac0Hg9H218glkVU9yxM1Hz51jnq9bGVMg4K QHjXcF36VLH368rECh9Hn3GCTXnDO2VN7t1A9bowfiXaUc8uwsmqKR6RbTxEoNGgXAnO50 mhdJfj8P8BzxpOJYbAVmgAJw7rUtrQs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-_35hlDTcPQ-qNTe5ah1O_A-1; Thu, 16 Feb 2023 09:47:32 -0500 X-MC-Unique: _35hlDTcPQ-qNTe5ah1O_A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3135085CBEA; Thu, 16 Feb 2023 14:47:31 +0000 (UTC) Received: from localhost (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7534140EBF6; Thu, 16 Feb 2023 14:47:29 +0000 (UTC) Date: Thu, 16 Feb 2023 22:47:24 +0800 From: Baoquan He To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Christophe Leroy , Christoph Hellwig , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , David Laight , Stafford Horne , Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v4 01/16] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-2-bhe@redhat.com> <056cc71f-7fb9-4d38-a442-a05de6f7d437@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <056cc71f-7fb9-4d38-a442-a05de6f7d437@app.fastmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: w9oh9xmkcpo18nmnee1s8zc5d1qx1y8b X-Rspamd-Queue-Id: F2A941C0012 X-HE-Tag: 1676558857-700552 X-HE-Meta: U2FsdGVkX18tVX1UNsywDlvkyEesN17tD9OK5wP0K6x8nvMyXFYXq0VAJjYQn++1SxtaMSEh7oAx4LAB0X728SzRfN0aQUdaXKVOrhjYrBCXCsWDwW6nHya9tiZNj8/xyW+OhP5lpsToqFJvTOKk4JoKM8KPjTUgcGalmNa4F+qoiv3yRCPkTQlE1X/kkr0KNWFJbLSVEzk12D0KdRpKOFoUGvNTBkMOQa2tlQa9LKiHCeWh2ALz+NA+PiDKGZfJ0gtBEiyF2FbMqCYnJ7IIz3fYRtUfrqAA5i/buUqRMJn7VHdarm+tEZSvyFFKfjgvuY21caxLueXWdXGNImZdlkqtRppeFbjh8fvtnU0TKueNFEeEcsiQrEH4vqf0k/UOEa3sXJ1VximNShua87WMGimOjfm+h9flwHu9cessNh6T7Gc4BET4ahb5sJcX61ibieJSRgjna5dahCwXpGJtlDBkT2O3PfsQyrwY3OYrnJinR78p4Kbi32S/HOCSBExV7K0Ea8p/+HF+h1AIx/aAhv42sXRP5GxyOMvCQw0kZX0ol0ib8vbd6+GbgFbxqlprFY8AzYgYst01hHP+SJJrYAbuUTO+Bm5x1lsY4OOsjLk8XNq4USYjtMjiG2sFtdG3B0ieQgr9Pzz//9MvT9uWDb/pOvBEEhh//RaZkjzU2bnjq+urYfhmF2nkyHTs/YLAPl9DwdD4KbyE1hvue7g808BJvpG3w+0kkv0GAGHVOVjTOosn2jj6M9uuFTcwUKWqrtdg4877T+Jan0+GTiu1zbHH11mLTpSijgd9KVFrr1eGbPulPjfkV2WOqoCYRZXAOAeq+vf6/fnBcDsemRdFs5jo3AZ7jgmqm1LDyY8mbvmvKw5JrJeemFPqMj2lvngd+8+9nOepsAfqIPCMIgPIXO7qZVVtXL34V+25wtv26lkpJyHLSTjkMsoPEQkfL6t7YzDZ2hzxh1effwsgsY+ QRVy5bNI B3fspahcmYUGT6w7B+YvrVp0DmvdvSMJjKC/E6+Hv+qaHlolxtIt1K3uzQJSpzorYZvLXevsOD7rek7AvvxH5NvQfGsa64ymSJBCe3rPBHL5M29iDbqr1yVOoEKuZEUfIWnkBWhz4zdsOhNDizKNO5d8zJK+bd/Gny2hx2y/eNT6E4FS/5qSoUywt2GueIduxU/sUsBGPz7FaZR/4H8kXO1oGifuRguEW06tzEVwWxgTpl0NFw40gQQ7tHdV7y7R85KDzzDV8NBV+w28KEU777DtUyU8/oDgipFxrPpuLb1LzGu4lVfgsAiPgSK6ZzDm8psYuWHGc4ISciX9N0w0BoBgNgAn6PtinxTNy16SpNLusX/pQlmqunCKWReasGfo+cOac X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/16/23 at 01:53pm, Arnd Bergmann wrote: > On Thu, Feb 16, 2023, at 13:34, Baoquan He wrote: > > diff --git a/arch/hexagon/include/asm/io.h > > b/arch/hexagon/include/asm/io.h > > index 46a099de85b7..dcd9cbbf5934 100644 > > --- a/arch/hexagon/include/asm/io.h > > +++ b/arch/hexagon/include/asm/io.h > > @@ -170,8 +170,13 @@ static inline void writel(u32 data, volatile void > > __iomem *addr) > > #define writew_relaxed __raw_writew > > #define writel_relaxed __raw_writel > > > > -void __iomem *ioremap(unsigned long phys_addr, unsigned long size); > > -#define ioremap_uc(X, Y) ioremap((X), (Y)) > > +/* > > + * I/O memory mapping functions. > > + */ > > +#define _PAGE_IOREMAP (_PAGE_PRESENT | _PAGE_READ | _PAGE_WRITE | \ > > + (__HEXAGON_C_DEV << 6)) > > + Thanks for reviewing. > > +#define ioremap_uc(addr, size) ioremap((addr), (size)) > > I think we probably want to kill off ioremap_uc() here, and use > the generic version that just returns NULL. -#define ioremap_uc(X, Y) ioremap((X), (Y)) +#define ioremap_uc(addr, size) ioremap((addr), (size)) Here, in fact the ioremap_uc() definition is not related. I just improve the old definition passingly. And similar for other ioremap_uc() adaptation. > > I see that there are only two callers of {devm_,}ioremap_uc() left in the > tree, so maybe we can even take that final step and remove it from > the interface. Maybe we can revisit [1] as part of this series. I see now. Christoph Hellwig ever mentioned in v2 reviewing, I didn't get why. Thanks for the details. https://lore.kernel.org/all/YwHX98KBEnZw9t6e@infradead.org/T/#u I am not sure if it's OK to do the change in this patchset, maybe another patch? Thanks Baoquan