From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D71C636CC for ; Thu, 16 Feb 2023 04:26:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 933176B0073; Wed, 15 Feb 2023 23:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BBA56B0074; Wed, 15 Feb 2023 23:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75C466B0078; Wed, 15 Feb 2023 23:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 630B86B0073 for ; Wed, 15 Feb 2023 23:26:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 225151210CD for ; Thu, 16 Feb 2023 04:26:35 +0000 (UTC) X-FDA: 80471868750.10.D5F8268 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id B2D64C0002 for ; Thu, 16 Feb 2023 04:26:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="cO/RpxJ6"; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676521593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9IVaVEssNR1Z/xVlw2ViDA0u+idnnENfCzM0p7ONhTQ=; b=ynfwcw5Ql9o+Ym787uKfpNOiqCT6EePOmketGll1cPfJW2I8dGHWIyDNVtAfXBg5hmEP+m c9kDzsKyOO+bTt6WI/LPVp5bz5MyYL703EH5ZqsdpZHf6ig67lyzxSrrEs4ipRWnrBmosc NGvsKiPYsMcrc6J/hB8H6ucw1hj+SqU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="cO/RpxJ6"; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676521593; a=rsa-sha256; cv=none; b=Q05xwfExFuW2A3rH4sCb/W4i0OC62nI2IudVJfIFR6cqTVuyPAAiqp1vNjkdjXaRlAYmWZ Uf7QE/0Z9ftkagcxjSID7XuF3sAJVe3KqQx3etIfhNuOSfu0EX+e+s6LK/pXICmkdAsGv/ 81fVg3Xl430E7IbVOk27B57ZwOeu/X4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9IVaVEssNR1Z/xVlw2ViDA0u+idnnENfCzM0p7ONhTQ=; b=cO/RpxJ6MbGG9NDBInzvT+5LU9 pW/78jvZtKVH3JYvQOhmjchLBex7AungcS3M7cVyIkHjLR81MOoYZ5JGINoaLhCYD3Yft2U+UVaXa Yw/9HJmMQ2GkZq/QQEjHzXdlAs67RQDwf1qwE8iWVb9+WP86B3lRlQUVkyjv+Uz+vSj3eTssI7Xt4 i4N8n8bTDvzHTCgtg6iChWV/NHINr3PIL9FqIHAbyvfeJ6XQT+Yj1NYS35IG3jq/hknnq6OaJSuV2 IqEaNkHRXUzLcHrbjWE4VWtVP4FnQW47y2ZGvFZOWK8toz0Lvqm1/8AVhS/SlW0QyjR5sJSlHyaxD s8lidsKw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSVqn-0085Gc-9F; Thu, 16 Feb 2023 04:26:29 +0000 Date: Thu, 16 Feb 2023 04:26:29 +0000 From: Matthew Wilcox To: Michael Schmitz Cc: linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, Geert Uytterhoeven , linux-arch@vger.kernel.org Subject: Re: [PATCH 15/17] m68k: Implement the new page table range API Message-ID: References: <20230215000446.1655635-1-willy@infradead.org> <20230215200920.1849567-1-willy@infradead.org> <20230215200920.1849567-2-willy@infradead.org> <84c923f7-c60b-068d-bb06-48aea1412f53@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84c923f7-c60b-068d-bb06-48aea1412f53@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B2D64C0002 X-Rspam-User: X-Stat-Signature: n4kuecnz548k9so3awh3i76bpgpzmk4m X-HE-Tag: 1676521592-311580 X-HE-Meta: U2FsdGVkX19zKsiOv011q7RO+Sf391QqbR+ZcMuAyZr5dPJoITgggBYrIE2cZO3NtrkUxy6KWSAIJHKNoJVM1f0hAtb3VcE8htf7j9rDuE7zLnd3N9li4cUaGNKLtBaoWcMlDrekpOBNopqW4b5c9cp7iacQ6wuNYCAM6bzQtEYA6z0DCdLF2gvzW27LDmIRbkSkQMw/fc7KkUNIIn6AD61WykX4fzhy/KaaBgvB8EgW1bNh7Xnes5WHcAiebOpk41Vx3SzfmMdHPntxUOV9SS/QXVFysZ99Xu+Jd/yU4iY16qlqmijV71uhIUCADSonMlCYaVaADo4675OYV70hGXMDlnHvffhl9xVppu9mxVHqdRA6jCfxOzBnakJ6uOhzDWff5TbZnmt39nTwa0fGq3+mj/xkBe84X1wqcLPYK33kvdfFTCsgXZV36ZTSxOI1XpFd83ce+MPoe86nkWvBiR7E5OfjKYQuJOlY8q1kFZ6fLqx/JVCj3csbQ8tgfMwrGeuFOwQQlG7fBRPDxC6hVm9UIjRoVusXYSx9SK3FhskVDZ2DaUqBU9i/Uj5CoShB+C83cDn8iAd1hOyFvTK9MoxpEeOGPLWpv1ByMSS0DvmPAQGf7rLvGFry6uyqsR7uhIWpWxGpBTRmrwaTIofcSLN6YUK059KAzM9EwEIDtOGNtfATbdNiK5OyuJHSZoX74pi45GvGjrU40BF7JgTpiz1OKjpnHjoAZb29GElpz80pmXXuGPDFfdS/8KcOvO9phkPGGLzrYOTofMFkKokmgkwdDC5iRu16XjKfdTKhDIiqQ16mXaDcB5EzgDSZsMU9UDL6++OadG+APOmqo0OLLnQfsXy2Yw9HLpAogBciXf3Cd0zw7pkvpvIYv+UM6EAok4QVZPDXgVrYhHyGVOLTFzXZe2uMrUGppCPP35o0vQBkWJ4pMb+LM+mrWwmV6mMF0F2NX+aiFRiMQG2tZ/i LO1OH40W ucVyTNuB7RouBYMm5dnfWEYiHYbMf4J9dTvgK+QtISXliKuWjujNiYB4TJNCmm4DcZ2n3INfx1iP7AZgEVauOpnLLoSeHt5nLmkF1AzcKFPvgqlw3U/rGSTHM9d4SFSjulu6AA3PHhUxP/uzKz3an2em7CQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 16, 2023 at 01:59:44PM +1300, Michael Schmitz wrote: > Matthew, > > On 16/02/23 09:09, Matthew Wilcox (Oracle) wrote: > > Add set_ptes(), update_mmu_cache_range(), flush_icache_pages() and > > flush_dcache_folio(). I'm not entirely certain that the 040/060 case > > in __flush_pages_to_ram() is correct. > > I'm pretty sure you need to iterate to hit each of the pages - the code as > is will only push cache entries for the first page. > > Quoting the 040 UM: > > "Both instructions [cinv, cpush] allow operation on a single cache line, all > cache lines in a specific page, or an entire cache, and can select one or > both caches for the operation. For line and page operations, a physical > address in an address register specifies the memory address." I actually found that! What I didn't find was how to tell if this cpush insn is the one which is operating on a single cache line, a single page, or the entire cache. So I should do a loop around this asm and call it once for each page we're flushing?