From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA9EC6379F for ; Fri, 17 Feb 2023 16:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D989E6B0081; Fri, 17 Feb 2023 11:14:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6F576B0082; Fri, 17 Feb 2023 11:14:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C387B6B0083; Fri, 17 Feb 2023 11:14:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3EAA6B0081 for ; Fri, 17 Feb 2023 11:14:45 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 947B81401B3 for ; Fri, 17 Feb 2023 16:14:45 +0000 (UTC) X-FDA: 80477282130.16.A070ADC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id A79BD1A000B for ; Fri, 17 Feb 2023 16:14:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sGL6zNZA; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676650484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KnUFNJfeceytXekVEZZ2PBZbloO4tvSDT1W02Zgchxk=; b=x6CVhQxvG9jnafuYOEMM+ciFY8IjyMSYlQnaF9BYy7G+Bebd9QGSVW0B0f/QetMn5mCe7o fj8DQ9bMk2o56FBCdVOHQAMv5CH7pqopSyvVAmrCf9NjpQbFwMPSm75cf2FUuertn0L7ke tUx8u8MbRDWrd2VmARyGIuhspz/wJVM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sGL6zNZA; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676650484; a=rsa-sha256; cv=none; b=XYkukaSZZmJMgBw1fbUJBjHDdQKy4LubdmnvUqdY19bRhajWaToi/yZy4RRItGjCEGTnj4 bNvliWcWyD5GWbvRREav8HycziOBkO5b83BNajBTQKeHVzscZsHXU2WUBfLrj0Lg+Mxzc5 Exbv9OA90FqIecAJmSK0Ioulsm1ysa0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KnUFNJfeceytXekVEZZ2PBZbloO4tvSDT1W02Zgchxk=; b=sGL6zNZAPMTbxDBefMd6fe8/U4 zzDIyvHo90wFVvbrPONPZBoWqZ0GzWT/uRWXKepVKkZOiFLouYNH8bH+Nu99PS3ZzajtdQueVg0Z5 pj/1Xhq9d3xl6fUQdnHIx5HtawVKRKzcRV6pn7PNanOGObCpYv4DYoBreTu8V1Rkj0z1vIYHyrwEE 228Z7QatBHC7S1ho0GE/07cz/NsJ4tujgE2/ENftFosFupD6K0dFz3F0x7q+rUqUWcfhe1foBs4kK 1gG/qp5BTx5I7Ekzxe46w3MP8frb7NQsujh33+Dya8GbrOiaendnwk0MBSyv1jZZ4ukUW4maTbDL2 jTDtG0/w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT3NX-009Rkh-24; Fri, 17 Feb 2023 16:14:31 +0000 Date: Fri, 17 Feb 2023 16:14:31 +0000 From: Matthew Wilcox To: Shiyang Ruan Cc: linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, david@fromorbit.com, dan.j.williams@intel.com, hch@infradead.org, jane.chu@oracle.com, akpm@linux-foundation.org Subject: Re: [PATCH v10 2/3] fs: introduce super_drop_pagecache() Message-ID: References: <1676645312-13-1-git-send-email-ruansy.fnst@fujitsu.com> <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com> X-Stat-Signature: 6kbp9ktsbk1fqe7e9imdczmuhnef48un X-Rspam-User: X-Rspamd-Queue-Id: A79BD1A000B X-Rspamd-Server: rspam06 X-HE-Tag: 1676650483-994792 X-HE-Meta: U2FsdGVkX1+xrEIiAadRKBUgB1Risxe84TbdKYHRBsW1JDKU+OHxS8E6yQGhGEz/V1/0dOdNabCi73ieefO+svPSCjazSzDRDgclPHReCvMmCdKZPJUhFHTyJC44WMhsyjLV3qH9Yz0iEPlUVwN9ilS7VDxn6iOuCYH3NC8cciUYSjgIMhJV5aAcoVsD6bIiHZc0ltKgT/vvHS6p85k3VLSyuKNjYfJDP0gyr+k8TLXgfk11aKLyiaoFbA3qDXCsND7+6uDJJfRM0fc1OfByc/MXl2TMVGN8zg2km9myAcdWRtbpBBtbRHAVqdWsFo9zhQLBHhH0lle6jxSnprDcxRxM4fbvBfN1HbM9KPIiWjAWtJCp/uLOtQHgGrZkPLs3dmBC+xGObWBArlxO+kftMS4tl03TWcBoIUvC4yrQjnSxOr9+Zcj5PHTT74WBHNHJv2XDjYU/nVBcb8NXpCknmlTcTPQts5IfYAtjfucFdUMmqZqc9qZOP+KcdXOpLFvxRaoGM7+gc+NrhR0OQ7kH/816kcd5CuYTHQWrkQvi1cAOY5DR6LSIGeTsCby9UDBmD3J/ksATJ+XfIl0+Sael3ZRZBnkB9HYg/JrZdZ4ZCfoyHdpCiN1NqUreVfgCyVqiatm1HN9g79iYTMbOh/aGHjlw+iIsyI8jac82/U2nQPCZWK9Abw5UsbjQ/Ev2F9mPINlg4dQdfxm4EXiEj1aQqjrOt2I+3woNVjSJei+lfkOkoTHjhnEiInDDPqIC/SWx0b9EbEUbpEjHf9ziro1lHyy8QuAJDNU8QoX5YldaQbLPEi8CJY/sDUGPMc+kNiQ9HExJLF484Xlks+vwmB2P9Sy24Ulr7B+L3lUzBSAylnvouDu7wDVFvOjATeui5t8focvV19QwMe0PhHV/kSYz3FRuE+mpH37HADAkShFTusLq8XrblyBVDrsTg/nnXKL6zZjvj20H2s6vrqoEVxJ YzexrwWf 1CpfV3KOPN4NCyC+wM/+FuPV75wNUbaQ1QyrgH25PqXYEsxC0XLSDsU/aiiS5IeUQwVujhEvafRUu9++cg5G6RoQ6JmsPZyIwHB7fmvMw8wy4hKXrCEdrkehBgk9JT74YxxhKeENv7QD9idDibOu26n3y4cfru9EuGHgIeYQOtYTc3UACHC0vfOCseopAMsQpVVWFBD1RlLtQ9RQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 02:48:31PM +0000, Shiyang Ruan wrote: > - invalidate_mapping_pages(inode->i_mapping, 0, -1); > - iput(toput_inode); > - toput_inode = inode; > - > - cond_resched(); > - spin_lock(&sb->s_inode_list_lock); > - } > - spin_unlock(&sb->s_inode_list_lock); > - iput(toput_inode); > + super_drop_pagecache(sb, invalidate_inode_pages); I thought I explained last time that you can do this with invalidate_mapping_pages() / invalidate_inode_pages2_range() ? Then you don't need to introduce invalidate_inode_pages(). > +void super_drop_pagecache(struct super_block *sb, > + int (*invalidator)(struct address_space *)) void super_drop_pagecache(struct super_block *sb, int (*invalidate)(struct address_space *, pgoff_t, pgoff_t)) > + invalidator(inode->i_mapping); invalidate(inode->i_mapping, 0, -1) ... then all the changes to mm/truncate.c and filemap.h go away.