From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFDCC6379F for ; Fri, 17 Feb 2023 14:21:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 006C36B0072; Fri, 17 Feb 2023 09:21:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF94C6B0073; Fri, 17 Feb 2023 09:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC1076B0074; Fri, 17 Feb 2023 09:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA3D16B0072 for ; Fri, 17 Feb 2023 09:21:39 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A5AB440836 for ; Fri, 17 Feb 2023 14:21:39 +0000 (UTC) X-FDA: 80476997118.23.906EF82 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 8345540019 for ; Fri, 17 Feb 2023 14:21:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=has+5tL3; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676643697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MjVXynfbooLeK3lh/BnC3ySYEJ/T8LeumorHab9HlOY=; b=R2RL7Wru5ye1qirJZY/KJEGgP7fH5ASkIS7PS4cX0vcAk7ma138WnUXNCC1iLqTze8wlY/ bX0nMyh2xeuRHicBJOBs355ruaRGZcbwPsaE/EwO29aw2eVKogPxPJaxOKPIUKmVDE98o6 7Te4sv4xZXEguv7vQu+xCF1kILrXC3s= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=has+5tL3; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676643697; a=rsa-sha256; cv=none; b=g4j2sIW2RrTDjRgyRBkklDmLMMmcZcpaX2sYU3l4b3q0pqXJiPAahf/YGX2cKonoGjIlUS DJJ7X30dwkfR+9d+l0KetVPlw7jF6Z+p4EiLsnu6xOZBhO2JOC4c0lIRnVnN+VO5IiaBvo dbqjy7X7jOdCP8id5y0AqpD4P+m447M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676643696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MjVXynfbooLeK3lh/BnC3ySYEJ/T8LeumorHab9HlOY=; b=has+5tL3KfCTt/MgKM2Pb0YgIeR6i832hGWBDfe3kZ2T5VxAycqL3AwVTU0B4zHaa9h9LG 9uWxiMZOusc1NLmN2XNhKSHlgYYl6lY7JCMqIJAZI3E+NsnVSni745QLU5yvxdP7eXQ2U9 vkvypuYP7PPIKH0dSVdv5P0goKQVJ8c= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-672-RgGbByAVPBmBxs3XCk8YgA-1; Fri, 17 Feb 2023 09:21:30 -0500 X-MC-Unique: RgGbByAVPBmBxs3XCk8YgA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE4523801F58; Fri, 17 Feb 2023 14:21:29 +0000 (UTC) Received: from localhost (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAB3A492B01; Fri, 17 Feb 2023 14:21:27 +0000 (UTC) Date: Fri, 17 Feb 2023 22:21:23 +0800 From: Baoquan He To: Christophe Leroy Cc: Arnd Bergmann , Matthew Wilcox , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Christoph Hellwig , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , David Laight , Stafford Horne , "James E . J . Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-13-bhe@redhat.com> <107be2c9-021b-85f6-d32d-ddb9e75ce24f@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <107be2c9-021b-85f6-d32d-ddb9e75ce24f@csgroup.eu> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8345540019 X-Stat-Signature: 8sn4wwudgznjs9xjoucawemijuh78rqk X-Rspam-User: X-HE-Tag: 1676643697-33602 X-HE-Meta: U2FsdGVkX1+NjLCACECPudow4zJtrHPDjYP6d4s8wE96GAVd2auxvILc4fPlNHDu0WahECV5oPgTtVX924e/StTSyDaptpphgjz1JVb+HyeTl0Hc284wk8ZlOvHh92IDibPq6qjsIQAHpT+Eaw+r6Ab9hRQPPzV2uaZnled8NYp/ChT999lQ3wOj8Ba7WQBIEI3Pi1S2FfXrTnX8SOEHZhQNTDGTCbWwM1FWZnjnmUzx9jXw4aeFdNx+BtAmYPZLPwvGXc4ZwrYd19ESHuau8frMdA8tMW7TotqGs/87lx09e5dv+IpHA7gDrgIvQ93vbOlwTZdOzpHOltEhpImbi/fyISHbN+8ufy+vPRkyas8RdSdh5cN/TPrc2azjmlTQd0PSDm6QvMotI/7msJUWkSnrX8KrRbNHnDCBAYpuuFLO2eSJ26FQehKxFlJvX6+HkTAYbYydU97lspZFLVvp6gQx9oc3yj839LIik26qYNFe6gOc2IjHKacv6Qrz9aVVQSYzNHO5rlZ90duA9Nt0y5ONAL71eKLzmNiYS3z8kbfRef/mJrwL92WLsxGhOpnT6Du8dwbxOq8zHgc/BUFPzlNCBhONaiH65giNRj3RFBkWLGiLrSSNhmJYCdbcoAd/rsmHYYkMxU4OWtwUZ2cN5Zf8ooNSa3R7cN98oAwz/kqWYeWYkycP9pkovDwCNoYAFdKRMGw9jA//h7LwJfvBbla+2rR3A1B7uORFU2WZ4DBy/YAXyxLHPhjNdM6eOoiGxIIuwU3Jw4211Md12XXn72vG798CGOzIADe9+TKK+xrQlnL6PE1Cy+8SA3SRuGXHllI1K+sqqgPJZYxL6OxhPc32QGUm9htX/zXQp3+WJI/0OnMnxAnIJ2rw3gpd0HEXi5yOjr7kNipDg9CNOT5AnCRKzMrgmg/JNAY62Gl0XlNDv8V95KwmR6z4AUCFvMPVr70oTk61cnjAtkAiz5M KaEc79ww mqSt8ofaQH33BczrLMHJr3aSA0jHRudiSbdzaJkTwnHErm1xPuKOgHJoImb+Arjw9oz4Ui+xaWgkPX1Y4PCXXUnlBzKhjHXgw+GrCn/gEiYhZ/Y5PZifPVU5e7BS+O5OQjRRHYm9MugypvZuO6qwThvslEC8ZRYo21GQyGXkGqdWgamS0jHvT1WmtE4NaMP51hIOMILbUrGDPUfF3oBu3DhMnjw+wIGhzDjmXpk+1M73JTsZ+UzPGUmgKPYG4MmKo01nBbQLWz+Fths5VLzibPUIwZWVWOXZucJqr0xPQsRSafY2zbD3yfkqvIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/17/23 at 01:46pm, Christophe Leroy wrote: > > > Le 17/02/2023 à 14:31, Baoquan He a écrit : > > On 02/16/23 at 04:18pm, Arnd Bergmann wrote: > >> On Thu, Feb 16, 2023, at 16:02, Baoquan He wrote: > >>> On 02/16/23 at 01:50pm, Matthew Wilcox wrote: > >>> It's not if including asm-generic/iomap.h. The ARCH_HAS_IOREMAP_xx is to > >>> avoid redefinition there. > >>> > >>> include/asm-generic/iomap.h: > >>> ---- > >>> #ifndef ARCH_HAS_IOREMAP_WC > >>> #define ioremap_wc ioremap > >>> #endif > >> > >> I'd change that to the usual '#ifndef ioremap_wc' in that case. > > > > Not sure if I got you. Kill all ARCH_HAS_IOREMAP_xxx in kernel? If yes, > > sounds like a good idea. > > > > At least kill that one at the first place in your series, and then the > other ones in a follow-up series maybe. Then we can make a preparation patch to change that in iomap.h, then remove all ARCH_HAS_IOREMAP_WC definition in arch. I thought to let this patch as is, then get rid of all ARCH_HAS_IOREMAP_xxx in a follow-up series. While the former is also fine to me. Thanks, Christophe. diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h index 08237ae8b840..5fa1e9ca951c 100644 --- a/include/asm-generic/iomap.h +++ b/include/asm-generic/iomap.h @@ -93,7 +93,7 @@ extern void __iomem *ioport_map(unsigned long port, unsigned int nr); extern void ioport_unmap(void __iomem *); #endif -#ifndef ARCH_HAS_IOREMAP_WC +#ifndef ioremap_wc #define ioremap_wc ioremap #endif [~]$ git grep ARCH_HAS_IOREMAP_WC arch/loongarch/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC arch/mips/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC arch/powerpc/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC arch/x86/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC drivers/net/ethernet/sfc/io.h:#ifdef ARCH_HAS_IOREMAP_WC drivers/net/ethernet/sfc/siena/io.h:#ifdef ARCH_HAS_IOREMAP_WC include/asm-generic/iomap.h:#ifndef ARCH_HAS_IOREMAP_WC