From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93695C636D7 for ; Fri, 17 Feb 2023 19:45:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECD3C6B0071; Fri, 17 Feb 2023 14:45:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7CB36B0072; Fri, 17 Feb 2023 14:45:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44E76B0073; Fri, 17 Feb 2023 14:45:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C116A6B0071 for ; Fri, 17 Feb 2023 14:45:50 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 04FB8AACF8 for ; Fri, 17 Feb 2023 19:45:49 +0000 (UTC) X-FDA: 80477814060.06.696F4DC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 64CFA40019 for ; Fri, 17 Feb 2023 19:45:48 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ZdlZ/53k"; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676663148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HznwluzS0ZGoZBxqPywPydMAJ7rtE7A0nySFqvQCNKU=; b=coRh83YuPc5FzD0DTvhJn5yrpKPEStM/MtoVsmEmJbs2MH71rSbnqSCaSmkZhtT1O/9on9 YDJqfOoaTfc3Xrs2tLqdOV+GmFZNrgS++aoRYYvIexY62WcavOkBsEIIz5vTqd8JscDMVb xxc80t4HoLSKDJOZ7A4mKDt5Dy/+UKw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ZdlZ/53k"; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676663148; a=rsa-sha256; cv=none; b=lugsFjJwQp9SJ3FmiIvKqlgGoTdFGMCw7zxkMgfQNlgYxSZe5+v0SWn+z+1oot9/Om4AB5 fbtegTwqrVjbXNSGLR9YumffHs8tzPpfXyONcmLwrgUykSNlieNwjEKnArFaM+8MA4MNoR 4FilaZbiL1J7Yyce+Gz7qgukZCP907Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HznwluzS0ZGoZBxqPywPydMAJ7rtE7A0nySFqvQCNKU=; b=ZdlZ/53k/mtRuNZKjJ/V0nzM18 NQTuOZpFnJ1UXH8JSdVoqCOQuGuckB9rvIbuhwkxblJF8okMMFOe5fO3WQtWVGHG4W3e79OPKnUw9 26h8mXYKiump0wSLoHk8KXdAuEEfYfdBdREBp+us9n7Z2hmECRNeFVpWFIilk3vMRaxhuTJV4VZ9T lyXv7TuLS4kOjbKcS11XQxqX98tEli6YJxVDyIJXKtCr4TyZCPmoqfY8Cy52o+qA3fha9fF2csXwu uYYs0E1ZnYV5NnP2hf0BS+FhyAxwbVmh4Q90+i8SWHbfPPkovS3KuJi2m7fLbdfZQXf8JuGL1QyBo QXdQ88XA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT6fj-009a9i-Q7; Fri, 17 Feb 2023 19:45:31 +0000 Date: Fri, 17 Feb 2023 19:45:31 +0000 From: Matthew Wilcox To: Danilo Krummrich Cc: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH drm-next v2 03/16] maple_tree: split up MA_STATE() macro Message-ID: References: <20230217134422.14116-1-dakr@redhat.com> <20230217134422.14116-4-dakr@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230217134422.14116-4-dakr@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 64CFA40019 X-Rspam-User: X-Stat-Signature: qgc3mtx7ag19zp1uodfymc8mjhbqog7a X-HE-Tag: 1676663148-168219 X-HE-Meta: U2FsdGVkX18fVEAEXNFi7XTCrkjQbLVevOxK52PUdUK/QlzIHOWwD84hieGaJz43YstCGWFkdt37FZZ5u3bXVXbFNsGACaFSyVodzKh+iaGfPX4y0JwVM5n4nTSibV3iUdaqcFEqGzlAEbEKEX+Xue8b1OMHEj2j/nPG2IoE3qKRCYXZyyXSwPLWFVifGtwVY/PaPpW+h/pEklmwgKCplnuB98vM/NjBp9Juf//arcblFrJopVielfveK1qD9fTAdr2CB84wRInV/yzktmBN5tYqfo0KmqggzXskD8M/3N3Q+bGKNq+dL0rSY1kw9biYtz+jgrqWlc7nxrxcVa/I0Zev/CWmZPF3H2Qg9UcuBahTJDWSw/awoQ5/c7BIs2wTiSt9NCRx8l+jOyzxFCMhGihCPs3s6+0tPNsIxRxheEVtlAiny0hp2UqyabcFc2p/Ru3N0qeTdkhyaaCWYNJUc35/kyml3IP80dcBbdS/H7VDgr5abguiBQC51qX8uqlZAXa/cnYy9GJ9gLHFsaR+SHj5n5lSofSUPkFSjpZ4oyIH0qA+z5Fe9S+Ey1op/RJp6YNgWZHpWY4jMVRrsysivBAe3MBC5OxWsrvVlyZZ/X29k9BkwaMcAfXCbjMXNDs2cw1WIpmugxYCKHWnaASvVg3p7Ifcp8rERbaHr0Ubya4AMGY25iy0stUHwNbDJO7elE4y4fMFVdANEVbxnLfKOh28TVI9FTizkgU3YSByyfmGkyJmk5aOUihmNnkA/r9h/WYyEO3epOdpCYDvUQwaUez/rF/hgv5LCO1nKWz0WcFmO243VmOGfCB48ZiMCXXLu3zI01S9mpNf91UrvRqtoPRsfhFuELVDifzVfSPcJsmBCP2bOugP86jhJXfLbAzKUP3E4tAc9pIfTSxXRkeoIC87LsLHnxIJRBPNRETq+efgcw7DXqYzZedu/aMgZP1/dDEYykwvORD0rAe4vu7 Q18BnT4h UzxhclMkcp01N3SlThfl5yJVxljO1JXx3pY1479yI5xmsSY3vfkU6Jhwt+jxgY37ahgUAkk03D7Y4Kcra8JQnesi3PsKg6MABAmCeYtJJe8afUhpc2ZVSLoIQp7/lAL35HtUgxJMOE/mBxj+7Gd25IaYdykI/SGwnUR4xkcPux8d6ylR2X4h1BDIxtaez53ivzqiAxfBtGYSrkpY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 02:44:09PM +0100, Danilo Krummrich wrote: > \#define SAMPLE_ITER(name, __mgr) \ > struct sample_iter name = { \ > .mas = __MA_STATE(&(__mgr)->mt, 0, 0), This is usually called MA_STATE_INIT() > #define sample_iter_for_each_range(it__, start__, end__) \ > for ((it__).mas.index = start__, (it__).entry = mas_find(&(it__).mas, end__ - 1); \ > (it__).entry; (it__).entry = mas_find(&(it__).mas, end__ - 1)) This is a bad iterator design. It's usually best to do this: struct sample *sample; SAMPLE_ITERATOR(si, min); sample_iter_for_each(&si, sample, max) { frob(mgr, sample); } I don't mind splitting apart MA_STATE_INIT from MA_STATE, and if you do that, we can also use it in VMA_ITERATOR.