From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B6DC6FA8E for ; Sun, 26 Feb 2023 04:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A87C6B0072; Sat, 25 Feb 2023 23:34:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 658F56B0073; Sat, 25 Feb 2023 23:34:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5201B6B0074; Sat, 25 Feb 2023 23:34:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3EB7C6B0072 for ; Sat, 25 Feb 2023 23:34:47 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D013D402EF for ; Sun, 26 Feb 2023 04:34:46 +0000 (UTC) X-FDA: 80508177372.03.8314466 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id E6E47A000D for ; Sun, 26 Feb 2023 04:34:43 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q3st/CHL"; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677386084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X8M9E7W4vhhexRDdiY+AZtRYDqU5sVbi9HJ0Sf8DosE=; b=7po5fc8PgRclyBRqHoSfoTkb+RPqwcjlyqkl/B3ISyhrgfM2Fw+DzFzUqyWrxeJzhEqyUs cl89X30TvUxC/LySA91QQG32LcCsTkC/B6dUygGO6M6SJFIvTqSqLkue241Cw1Gps5PAg2 ua5WQpxz5p7gBHhxTpcPM9J7x9PaSig= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q3st/CHL"; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677386084; a=rsa-sha256; cv=none; b=RRHfPigCIpACDcG27SRBbHuJTlho5t67bSQP3rDUOlvC5tlbqS0wDhNNnJRv7SNcfZ01hV CWFNwUKSCMMFpCK7MHuKkGR4EhAkyEpo/U9OIUepch8ziVyg/5Z5CC626mh+FQq60+55Ep SaFPupu7tWQo943LTsUsrDDNkIcgMxo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X8M9E7W4vhhexRDdiY+AZtRYDqU5sVbi9HJ0Sf8DosE=; b=Q3st/CHLLYuQrE4naelSIeVH3O FziGceHthnLibdMkKQlbydBHm1+DtkqII2Bx4TUZgyguUF5K5p8rdFWcVigYGuBpV/zxjOyAxhT0a 0jG4I+jsj6Zg/Ie1jJLQj8whYkE4jDK7skZLWhqudKfjEgdU9TgBqCLiYgB3tDZU1VZvCCZwmyZA1 wurvmlgKd901321WpbsuXe7aFScJT632mUoohCg2JU0pHqMvkLcl6v9ljT78ug/xSZpDIqNjuFPRQ wTgxEzaUE5H3K6h/kUEL3oRuNNfZyoV8TjsOgpqPKk7iS2CLiltoi0J0R/yrDQ6iUYCy/e3nfT1iz 6dcthOWg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pW8kA-00GdoJ-Dv; Sun, 26 Feb 2023 04:34:38 +0000 Date: Sun, 26 Feb 2023 04:34:38 +0000 From: Matthew Wilcox To: linux-mm@kvack.org, Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [PATCH 13/7] loongson: Implement the new page table range API Message-ID: References: <20230211033948.891959-1-willy@infradead.org> <20230215000446.1655635-1-willy@infradead.org> <20230215000446.1655635-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230215000446.1655635-5-willy@infradead.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E6E47A000D X-Stat-Signature: zup6gzjz5c8aa8uid3y5wwifhxztoyqj X-Rspam-User: X-HE-Tag: 1677386083-598785 X-HE-Meta: U2FsdGVkX19juXfx0k6bJ48jk/OW+5C8tHJlxbAl3yW1Uqc+S4MZGeYHkrqlIUCVQLfuc8/x0M7YbRykrbOik/BPgO9HUchmorpXIfNie8I7xPwfO1MfxO3lMyRjDSDdajFPDJFRt27c4Lr1hbzn/FrLs07L0gwMkVrWOdGkj5Pphml9JmvHInqgbNMeeVSmycOJMROThELIVFPzrUmA/0khsBg3AhWs4MfdzUZ4NXqdCiDgiWItcDvdW1TjJiSCHil5746gN7eB/9cUe80wzftZlYgoctOywh4TUHUVXOsUDKuC+ehV/x0dj2DeE+bdOcly5os15o4dTtED6nSGyVWK+UDvWrWtLMJd4KEvRnMuOoEpKd8hon3jaZy4/x7MjowTP3861DZ06T/4bVwtq5bZubcLZxwH6IvMSLG/bA3HEJaNuMoAaQzm2CX/JSSVcQN8NeofMCMlqFB6nWqBgGgDvMlDGTDzG4uF2wMPTtHHz1vnWRDWOk276GqRxJEv4UniE8v3ZpQEmU3EKiL8UJbI7nCP0bKNyqxYQF5oEHKsv4txEjK0DeO8Bjs6ItIsyqxkaom8MUgtWxP5Kvnx0/iw+99XezCECzDEC/5MN1bFEMP5ptjOqgx1U0Jp/UdeU5Yy7Gj4PFyCNzUnrha3Q/0RlPu540SbBQLgDAv4YyT/Wyu+PEKF9YrHfdG+/Q9uMC2/wMqJeuWjGq68DqN+wo51eF6uk7su1D26OQxZr+STUJovFnCV97kn4f7Fq1mq6t1OUjK7GiF5W+rhqe0LpZp4SFOB8e3WoZJ0O6UNkeZ5KgyoDSkRaNddKfrqRXZs9hk78UsOTFzzZsf3yb8JjUSYMZFM8HLnXuJXCDlaDeiKenQkodJPLEGn8TJgCYtZb0rqs3zIE1f5orHnF9P3+CZr0PCjMV+N0rGgSSDEgeI2Af1ciXJnVVgp5yeudpr7zqINewsuNE3q96LVwli PSfBySKz oX+nxdwi1EOKGQ18uKyPkRqkLgFzgSB51q5VrVhQ7AFp6BWeFyc0X76Cfmp4MiRZY9A8m4h12ExDusXQfLajGPg0tXd/Tnu7u6jLP2Y35KUP0VaH7GfSlJdPCk/l3RLdYqEHZLLrCnoWL4UsePzHQ6RQpNpDTmkDNhcdx7rGLhq+YjJN07YnbLXvGyzQNrqBo/shR1xnGMMFCMumDkciobJRNXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 12:04:46AM +0000, Matthew Wilcox (Oracle) wrote: > Add set_ptes() and update_mmu_cache_range(). > > THIS PATCH IS INCOMPLETE. I DO NOT KNOW WHAT TO DO IN __update_tlb() Help? This is the only remaining architecture to fix; I have all the others converted now. > Signed-off-by: Matthew Wilcox (Oracle) > --- > arch/loongarch/include/asm/cacheflush.h | 2 ++ > arch/loongarch/include/asm/pgtable.h | 30 ++++++++++++++++--------- > arch/loongarch/mm/tlb.c | 4 +++- > 3 files changed, 25 insertions(+), 11 deletions(-) > > diff --git a/arch/loongarch/include/asm/cacheflush.h b/arch/loongarch/include/asm/cacheflush.h > index 0681788eb474..7907eb42bfbd 100644 > --- a/arch/loongarch/include/asm/cacheflush.h > +++ b/arch/loongarch/include/asm/cacheflush.h > @@ -47,8 +47,10 @@ void local_flush_icache_range(unsigned long start, unsigned long end); > #define flush_cache_vmap(start, end) do { } while (0) > #define flush_cache_vunmap(start, end) do { } while (0) > #define flush_icache_page(vma, page) do { } while (0) > +#define flush_icache_pages(vma, page) do { } while (0) > #define flush_icache_user_page(vma, page, addr, len) do { } while (0) > #define flush_dcache_page(page) do { } while (0) > +#define flush_dcache_folio(folio) do { } while (0) > #define flush_dcache_mmap_lock(mapping) do { } while (0) > #define flush_dcache_mmap_unlock(mapping) do { } while (0) > > diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h > index d28fb9dbec59..0f5fa7c40c52 100644 > --- a/arch/loongarch/include/asm/pgtable.h > +++ b/arch/loongarch/include/asm/pgtable.h > @@ -334,12 +334,20 @@ static inline void set_pte(pte_t *ptep, pte_t pteval) > } > } > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pteval) > -{ > - set_pte(ptep, pteval); > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > +{ > + for (;;) { > + set_pte(ptep, pte); > + if (--nr == 0) > + break; > + ptep++; > + pte_val(pte) += 1 << _PFN_SHIFT; > + } > } > > +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > + > static inline void pte_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > { > /* Preserve global status for the pair */ > @@ -442,14 +450,16 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) > (pgprot_val(newprot) & ~_PAGE_CHG_MASK)); > } > > -extern void __update_tlb(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep); > +extern void __update_tlb(struct vm_area_struct *vma, unsigned long address, > + pte_t *ptep, unsigned int nr); > > -static inline void update_mmu_cache(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +static inline void update_mmu_cache_range(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep, unsigned int nr) > { > - __update_tlb(vma, address, ptep); > + __update_tlb(vma, address, ptep, nr); > } > +#define update_mmu_cache(vma, addr, ptep) \ > + update_mmu_cache_range(vma, addr, ptep, 1) > > #define __HAVE_ARCH_UPDATE_MMU_TLB > #define update_mmu_tlb update_mmu_cache > @@ -457,7 +467,7 @@ static inline void update_mmu_cache(struct vm_area_struct *vma, > static inline void update_mmu_cache_pmd(struct vm_area_struct *vma, > unsigned long address, pmd_t *pmdp) > { > - __update_tlb(vma, address, (pte_t *)pmdp); > + __update_tlb(vma, address, (pte_t *)pmdp, 1); > } > > static inline unsigned long pmd_pfn(pmd_t pmd) > diff --git a/arch/loongarch/mm/tlb.c b/arch/loongarch/mm/tlb.c > index 8bad6b0cff59..ac0b19dbd1dc 100644 > --- a/arch/loongarch/mm/tlb.c > +++ b/arch/loongarch/mm/tlb.c > @@ -162,7 +162,8 @@ static void __update_hugetlb(struct vm_area_struct *vma, unsigned long address, > #endif > } > > -void __update_tlb(struct vm_area_struct *vma, unsigned long address, pte_t *ptep) > +void __update_tlb(struct vm_area_struct *vma, unsigned long address, > + pte_t *ptep, unsigned int nr) > { > int idx; > unsigned long flags; > @@ -187,6 +188,7 @@ void __update_tlb(struct vm_area_struct *vma, unsigned long address, pte_t *ptep > write_csr_entryhi(address); > tlb_probe(); > idx = read_csr_tlbidx(); > +// I have no idea what to do here > write_csr_pagesize(PS_DEFAULT_SIZE); > write_csr_entrylo0(pte_val(*ptep++)); > write_csr_entrylo1(pte_val(*ptep)); > -- > 2.39.1 >