From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01D8C64ED6 for ; Sun, 26 Feb 2023 03:55:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51A276B0074; Sat, 25 Feb 2023 22:55:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CA866B0075; Sat, 25 Feb 2023 22:55:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 392DA6B0078; Sat, 25 Feb 2023 22:55:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 28CC46B0074 for ; Sat, 25 Feb 2023 22:55:54 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 03362120788 for ; Sun, 26 Feb 2023 03:55:53 +0000 (UTC) X-FDA: 80508079428.08.75E837F Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf23.hostedemail.com (Postfix) with ESMTP id 13428140004 for ; Sun, 26 Feb 2023 03:55:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Pv5KaI39; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677383751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dzJ5eFmoxtJDE8tPzMLwMNaPrtRMEcmDAZJuAcY/77g=; b=D8fy+iiIONwuDxsEiItuSLFqDrZVp0Xi4I8MkTfIhtjpbteToJwgtOUcFm8NDOlculZqs5 bVWjO59cTMtQc1x5a9jhEQiPUUScbn32c9F7GMYaFo5rZ7mZPD6L1d+ZW1LRn6/EscM1Y3 Otm4ixOVCKwu+xtQYoIKEy/OoP2Ms7E= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Pv5KaI39; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677383751; a=rsa-sha256; cv=none; b=hkmSWCuyQiXrtJjSo7hF2fzvPjNPJkwb9tgBv5oDEohssw7wZ7t8WLluyvMl2+GqeWSAC5 y3ggZFEOV0a3utBl3kpfcvcccknRIbB8PZlZ597p40ZXWVpQNYcMrnpeOpR8XEB5nOpNNf 4A8uGhJrhkAgg7fWdhJ/Dbm5Fe2e0lM= Received: by mail-pg1-f173.google.com with SMTP id y19so1760562pgk.5 for ; Sat, 25 Feb 2023 19:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dzJ5eFmoxtJDE8tPzMLwMNaPrtRMEcmDAZJuAcY/77g=; b=Pv5KaI39juy5PXhIT03OoqI8IzbO/dDYFD9lOFGTKEl5aBriR6YmbmGQJ2lTA+unpK O0WsZSlN3C8gYwLTsBJJqI3A8NUWJoleop/y3kqWh7DnhECisPjav0debRu7GqB0S6z+ 4v3h/8kbu1ZauPgqbGfl7iA+Hi6vrKf2VLmHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dzJ5eFmoxtJDE8tPzMLwMNaPrtRMEcmDAZJuAcY/77g=; b=Q5y2vIAvusXmUNkZWUGZoHvjaNsQqQzxOOmuXHGD2UJCKju0xo/ABuaDRPfObIxQyw a/D1N9z4i/+i3GrSfQ4U79XEFjhjBH2II6aqQUDSPLQQ3/xZ+rH9M01isqsxlJm/589q OiAJfa6mlqzGvek992vETGy3qeqTpYG/GRJWyjKOBDtfdJqW80CFGaYs0XPesGQHR3E2 e5x1FHKWAT3g1fEeozLAz7keIQN4V047kGN2Ls1Wi4QsxCt9jhNTRc128J8XfMQ6kXLk n0Gq3pW1eHyT1BdN7A8MFHQg68OxpTm+m0EFjC+pUyMnhmeA6/z2dW9EshwipTBzbvwJ Vxnw== X-Gm-Message-State: AO0yUKVsJRw5etRnMYqIHUx232LJqWdsFuvKkmhApeZ43YKP1Hh/SkuP u9ypgfwPZKK9RckzBVceozvduw== X-Google-Smtp-Source: AK7set96M9hMFvr4Zfedh1Y0waCQoYAvu8zpLYD7Qp0VufRtDmfXDasMRKbLqfmtnCjN5ageeK3UdQ== X-Received: by 2002:aa7:9dce:0:b0:5e2:da34:4aaf with SMTP id g14-20020aa79dce000000b005e2da344aafmr6170883pfq.4.1677383749839; Sat, 25 Feb 2023 19:55:49 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id m26-20020a056a00165a00b005e099d7c30bsm1795612pfc.205.2023.02.25.19.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 19:55:49 -0800 (PST) Date: Sun, 26 Feb 2023 12:55:45 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 5/6] zsmalloc: extend compaction statistics Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-6-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 13428140004 X-Stat-Signature: hc4zduz66onj5dk6gz1cjnperxzdo16e X-Rspam-User: X-HE-Tag: 1677383750-274541 X-HE-Meta: U2FsdGVkX1970yCVc6HCIh3Q23fQPgLp6gfq4zVJZC8KF2+Cfq0cZW1qoBTkWXnwg6ix+l1xq6ciU5QGRR8m/rst/C1ZA3LJV8eRcQGjmEZAhRdXJJhrBNINUDauUObFOoeum9sTMX374Tc0Q+FAXUe5/7fVrtTAUB6Ln/HfxNloUgrqkMdweo6i1TyQNQNg/p7uznmybFsx5DORlCwy70oQzDocnnGKLK1sl8QHya8bCPrPyVyaE/0x2+CZ1AL6Sr4JYWbDMvNN+XAuRcDen06oaxNlMHJYrEekNU2ZSANlj500xG1Vqab7X5sVwbQ7xAmOMvYcVBab3WANvFuW3HyzXQ/cAACn5Cy2nE7g/L4Agp5Mm5HWX2znNW0mThNPzBJZlbvWI5A+x5z9CB1xpyRYMuv5imnqFcsoJlI/Ui4ovgVe43aHQ1oc3yQpO1O7sLYJtNo6piO0sCXa8XOn/V+l/QprMp7bYZBgrsjxqN0wqTg10++OwiU5sLJVadGlyKpEJfvYSTagjEcorK5F8leLc/539dd+8DCxsjT4A+vmtNwA6rZ9OZvLr7xLUpwlzsewwbhP5/USPgbzBHMwXqyk9txotw31XzFQC1UE23m7asCQxRZmdXovqck8cNbJVGZQPH03WCPJ1kEYuRU7LLuuWNB3pn2uUBCS8NbYhtT0rEvJ/xo/GROS4RdFLMij48MywnW4JnUu+65AJ1PicNaO+1LGqziEDUArd6WYmx/NlGsqpYSvfMD+1jmAsU+q2mP2muq0tgIvaRsjRE9t1FAdvIUvagYSAGV8q6hEfOOmH2COy8gBw4Xeak36zpcD7r0fnVl98IGmissz8d2NDmhOt53iC5Xx11vOsDd2Xn02PSzCuOp7eXIT2Z2Z3bx6TCML7edcPtRCxmN6CD7kzSDY4AmQ4K0obz6UH0ahJ9OD9cyVqQ6IBJzaCrmtzJ2OxIwvAPQnlSQtmY2qvyV 4F19/aQz B7q7Yfq5SDScjC9zUz418zYg8bN6IXIqwbSPXIgWzovGMJurpM71+rbMt4P8TjDrolGBjySD4qq3hEbnxfsOmNASz/35Oz9TLDwwI0uIv+cBN5qVaTxrsawpr0kncfd/CrkF38LBs36GGDzX4BQxdR4J3KxkgJ/YfebomF39SuEYm2XXfdtJF/mk2rWJqMhlYAPPgkMFKdrudjezIh+m9wMl7O32JZGAsVJpBepfd0K/jIGZMwDv+qLZ2njuRhYATmda7FkKmqEarVwRtb6lZabmXPuhCKpPjg7Q+b0AK9mIJA3KU/IuyqDVjcfgfAOCIwK7bqZTNkf8yzLw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005782, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/02/23 15:51), Minchan Kim wrote: > On Thu, Feb 23, 2023 at 12:04:50PM +0900, Sergey Senozhatsky wrote: > > Extend zsmalloc zs_pool_stats with a new member that > > holds the number of objects pool compaction moved > > between pool pages. > > I totally understand this new stat would be very useful for your > development but not sure it's really useful for workload tune or > monitoring. > > Unless we have strong usecase, I'd like to avoid new stat. The way I see is that it *can* give some interesting additional data to periodical compaction (the one is not triggeed by the shrinker): if the number of moves objects is relatively high but the number of comapcted (feeed) pages is relatively low then the system has fragmentation in small size classes (that tend to have many objects per zspage but not too many pages per zspage) and in this case the interval between periodical compactions probably can be increased. What do you think?